[jira] [Commented] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-28 Thread liupengcheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166394#comment-17166394 ] liupengcheng commented on CALCITE-4143: --- [~Aron.tao] >See line 6, we only use job#name as a

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread liupengcheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166343#comment-17166343 ] liupengcheng commented on CALCITE-3272: --- [~amaliujia] Thanks for reply, good idea for the EMIT

[jira] [Commented] (CALCITE-3780) SESSION Table-valued Function

2020-07-28 Thread Viliam Durina (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166285#comment-17166285 ] Viliam Durina commented on CALCITE-3780: Just a note, in the PTF standard the descriptor can

[jira] [Commented] (CALCITE-4128) Remove dependency of File adapter on Demo CSV adapter

2020-07-28 Thread Michael Mior (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166484#comment-17166484 ] Michael Mior commented on CALCITE-4128: --- LGTM, and I know a related discussion came up elsewhere,

[jira] [Commented] (CALCITE-2569) UDFs that are table functions must implement SqlTableFunction and have CURSOR as their return type

2020-07-28 Thread Michael Mior (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166476#comment-17166476 ] Michael Mior commented on CALCITE-2569: --- [~julianhyde] I think the ANY/IGNORE distinction is

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166673#comment-17166673 ] Julian Hyde commented on CALCITE-3272: -- Let's not use {{CURRENT_TIMESTAMP}} for these purposes.

[jira] [Commented] (CALCITE-4128) Remove dependency of File adapter on Demo CSV adapter

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166675#comment-17166675 ] Julian Hyde commented on CALCITE-4128: -- [~mmior], That is a reasonable thing to do. Breaking

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166580#comment-17166580 ] Rui Wang commented on CALCITE-3272: --- [~danny0405][~liupengcheng] I got some prototyping but recently

[jira] [Commented] (CALCITE-2569) UDFs that are table functions must implement SqlTableFunction and have CURSOR as their return type

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166634#comment-17166634 ] Julian Hyde commented on CALCITE-2569: -- [~mmior], Yes ANY vs IGNORE is a little confusing. ANY is

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166677#comment-17166677 ] Rui Wang commented on CALCITE-3272: --- >I don't think it makes sense to have expressions int the EMIT

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166713#comment-17166713 ] Rui Wang commented on CALCITE-3272: --- Ack. Created: https://issues.apache.org/jira/browse/CALCITE-4146

[jira] [Commented] (CALCITE-4146) Implement EMIT AFTER WATERMARK

2020-07-28 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166712#comment-17166712 ] Rui Wang commented on CALCITE-4146: --- cc [~julianhyde] [~danny0405] [~liupengcheng] > Implement EMIT

[jira] [Created] (CALCITE-4146) Implement EMIT AFTER WATERMARK

2020-07-28 Thread Rui Wang (Jira)
Rui Wang created CALCITE-4146: - Summary: Implement EMIT AFTER WATERMARK Key: CALCITE-4146 URL: https://issues.apache.org/jira/browse/CALCITE-4146 Project: Calcite Issue Type: Sub-task

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166676#comment-17166676 ] Rui Wang commented on CALCITE-3272: --- Sorry for the confusion I made. I intended to say use a new

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166702#comment-17166702 ] Julian Hyde commented on CALCITE-3272: -- bq. [The expression] is something applied on arrived data.

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166707#comment-17166707 ] Julian Hyde commented on CALCITE-3272: -- [~amaliujia], Can you create a JIRA case "Implement EMIT"

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166708#comment-17166708 ] Rui Wang commented on CALCITE-3272: --- Totally agreed. We can have something working first by starting

[jira] [Resolved] (CALCITE-4137) Checkstyle should ensure that every class has a Javadoc comment

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-4137. -- Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-4080) Allow character literals as column aliases, if SqlConformance.allowCharLiteralAlias()

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-4080. -- Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-4079) Dialect constants in SqlDialect can cause class initialization deadlock

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-4079. -- Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3923) Refactor how planner rules are parameterized

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-3923. -- Resolution: Fixed Fixed in

[jira] [Comment Edited] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-28 Thread zhangchenghui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166832#comment-17166832 ] zhangchenghui edited comment on CALCITE-4144 at 7/29/20, 5:48 AM: --

[jira] [Commented] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-28 Thread zhangchenghui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166799#comment-17166799 ] zhangchenghui commented on CALCITE-4144: [~zabetak] I currently tend to transform FooCompiler

[jira] [Comment Edited] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-28 Thread zhangchenghui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166799#comment-17166799 ] zhangchenghui edited comment on CALCITE-4144 at 7/29/20, 5:47 AM: --

[jira] [Assigned] (CALCITE-4081) Round-tripping a DECIMAL literal through Planner -> RelToSqlConverter -> Planner throws validation error

2020-07-28 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-4081: Assignee: Chunwei Lei > Round-tripping a DECIMAL literal through Planner ->

[jira] [Commented] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-28 Thread zhangchenghui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166797#comment-17166797 ] zhangchenghui commented on CALCITE-4144: [~zabetak][~julianhyde] yes,i using the

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166836#comment-17166836 ] Danny Chen commented on CALCITE-3272: - bq. The only uncertainty right now is how to model

[jira] [Resolved] (CALCITE-2160) Spatial grid index, to accelerate polygon-to-polygon spatial joins

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2160. -- Fix Version/s: 1.25.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-2569) UDFs that are table functions must implement SqlTableFunction and have CURSOR as their return type

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2569. -- Fix Version/s: 1.25.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-4134) Interval expressions

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-4134. -- Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-4128) Remove dependency of File adapter on Demo CSV adapter

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-4128. -- Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-28 Thread zhangchenghui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166832#comment-17166832 ] zhangchenghui commented on CALCITE-4144: [~zabetak] In other words, when I am querying, I have

[jira] [Resolved] (CALCITE-4145) Exception when query from UDF field with structured type

2020-07-28 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen resolved CALCITE-4145. - Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-4139) Prevent NPE in ListTransientTable

2020-07-28 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166654#comment-17166654 ] Ruben Q L commented on CALCITE-4139: Ok, thanks [~julianhyde], I will keep that in mind for future

[jira] [Commented] (CALCITE-3780) SESSION Table-valued Function

2020-07-28 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166573#comment-17166573 ] Rui Wang commented on CALCITE-3780: --- Ah that's a good point on the position of optional arguments.

[jira] [Commented] (CALCITE-4139) Prevent NPE in ListTransientTable

2020-07-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166616#comment-17166616 ] Julian Hyde commented on CALCITE-4139: -- Fix looks good. For others viewing your change in future,

[jira] [Commented] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-28 Thread zhangchenghui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166241#comment-17166241 ] zhangchenghui commented on CALCITE-4144: [~zabetak] thanks for your reply! My idea is almost

[jira] [Created] (CALCITE-4145) Exception when query from UDF field with structured type

2020-07-28 Thread Danny Chen (Jira)
Danny Chen created CALCITE-4145: --- Summary: Exception when query from UDF field with structured type Key: CALCITE-4145 URL: https://issues.apache.org/jira/browse/CALCITE-4145 Project: Calcite

[jira] [Commented] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-28 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166255#comment-17166255 ] Stamatis Zampetakis commented on CALCITE-4144: -- Julian was asking if you are using the

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166257#comment-17166257 ] Danny Chen commented on CALCITE-3272: - [~amaliujia], what about the plan of the emit strategy

[jira] [Commented] (CALCITE-3780) SESSION Table-valued Function

2020-07-28 Thread liupengcheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166192#comment-17166192 ] liupengcheng commented on CALCITE-3780: --- +1 for make the keyCol optional, just like PTF, I think

[jira] [Resolved] (CALCITE-4139) Prevent NPE in ListTransientTable

2020-07-28 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L resolved CALCITE-4139. Resolution: Fixed Fixed via

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread liupengcheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166201#comment-17166201 ] liupengcheng commented on CALCITE-3272: --- Hi, [~amaliujia], I'am a little confused with the

[jira] [Commented] (CALCITE-3780) SESSION Table-valued Function

2020-07-28 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166215#comment-17166215 ] Rui Wang commented on CALCITE-3780: --- I know that applying session on the entire dataset without a key

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166218#comment-17166218 ] Rui Wang commented on CALCITE-3272: --- [~liupengcheng] that should be controlled by emit (or trigger)

[jira] [Commented] (CALCITE-3272) TUMBLE Table-valued Function

2020-07-28 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166220#comment-17166220 ] Rui Wang commented on CALCITE-3272: --- I used to send out this email to discuss this idea:

[jira] [Commented] (CALCITE-4144) Reduce code generation and class loading overhead when getScalar in JaninoRexCompiler.

2020-07-28 Thread zhangchenghui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166222#comment-17166222 ] zhangchenghui commented on CALCITE-4144: [~julianhyde] thanks for your reply! I used jmeter to

[jira] [Comment Edited] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-28 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166235#comment-17166235 ] Jiatao Tao edited comment on CALCITE-4143 at 7/28/20, 7:55 AM: --- Hi

[jira] [Comment Edited] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-28 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166235#comment-17166235 ] Jiatao Tao edited comment on CALCITE-4143 at 7/28/20, 7:54 AM: --- Hi

[jira] [Commented] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-28 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166235#comment-17166235 ] Jiatao Tao commented on CALCITE-4143: - Hi [~julianhyde] [~liupengcheng] A case I met like

[jira] [Comment Edited] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-28 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166235#comment-17166235 ] Jiatao Tao edited comment on CALCITE-4143 at 7/28/20, 7:57 AM: --- Hi

[jira] [Commented] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-28 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166240#comment-17166240 ] Jiatao Tao commented on CALCITE-4143: - [~julianhyde] I know RelFieldTrimmer, but it only used

[jira] [Comment Edited] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-28 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166240#comment-17166240 ] Jiatao Tao edited comment on CALCITE-4143 at 7/28/20, 8:03 AM: ---

[jira] [Comment Edited] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-28 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166240#comment-17166240 ] Jiatao Tao edited comment on CALCITE-4143 at 7/28/20, 8:03 AM: ---

[jira] [Comment Edited] (CALCITE-4143) Trim fields after XXProjectTransposeRule

2020-07-28 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166240#comment-17166240 ] Jiatao Tao edited comment on CALCITE-4143 at 7/28/20, 8:02 AM: ---

[jira] [Commented] (CALCITE-3780) SESSION Table-valued Function

2020-07-28 Thread duli (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166179#comment-17166179 ] duli commented on CALCITE-3780: --- If we use window table function with group by clause, and we merge

[jira] [Assigned] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-28 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-4118: Assignee: Chunwei Lei > RexSimplify might remove CAST from RexNode incorrectly >