[jira] [Assigned] (CALCITE-3089) Deprecate EquiJoin

2019-05-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3089: --- Assignee: Danny Chan (was: Haisheng Yuan) > Deprecate EquiJoin > -- > >

[jira] [Assigned] (CALCITE-3089) Deprecate EquiJoin

2019-05-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3089: --- Assignee: Haisheng Yuan (was: Danny Chan) > Deprecate EquiJoin > -- > >

[jira] [Resolved] (CALCITE-3102) Deprecation warnings following [CALCITE-2969]

2019-05-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3102. - Resolution: Fixed > Deprecation warnings following [CALCITE-2969] >

[jira] [Commented] (CALCITE-3102) Deprecation warnings following [CALCITE-2969]

2019-05-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852677#comment-16852677 ] Danny Chan commented on CALCITE-3102: - Fixed in 

[jira] [Commented] (CALCITE-2855) Make RelOptCluster constructor public

2019-05-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852640#comment-16852640 ] Danny Chan commented on CALCITE-2855: - Well, the real demand is that user like [~godfreyhe] may

[jira] [Updated] (CALCITE-2855) Make RelMetadataQuery in RelOptCluster pluggable

2019-05-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2855: Summary: Make RelMetadataQuery in RelOptCluster pluggable (was: Make RelOptCluster constructor

[jira] [Commented] (CALCITE-3102) Deprecation warnings following [CALCITE-2969]

2019-05-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852602#comment-16852602 ] Danny Chan commented on CALCITE-3102: - [~julianhyde] thanks for you remind, have fired a PR 

[jira] [Assigned] (CALCITE-3102) Deprecation warnings following [CALCITE-2969]

2019-05-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3102: --- Assignee: Danny Chan > Deprecation warnings following [CALCITE-2969] >

[jira] [Resolved] (CALCITE-2969) Improve design of join-like relational expressions

2019-05-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-2969. - Resolution: Fixed Fix Version/s: 1.20.0 Fixed in 

[jira] [Resolved] (CALCITE-3037) Rename EnumerableThetaJoin to EnumerableNestedLoopJoin

2019-05-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3037. - Resolution: Fixed Assignee: Danny Chan > Rename EnumerableThetaJoin to

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

2019-05-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851455#comment-16851455 ] Danny Chan commented on CALCITE-2969: - Thanks so much for all your nice review comments 

[jira] [Assigned] (CALCITE-3100) cast(? as DATE) won't work with PreparedStatement

2019-05-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3100: --- Assignee: Danny Chan > cast(? as DATE) won't work with PreparedStatement >

[jira] [Commented] (CALCITE-3037) Rename EnumerableThetaJoin to EnumerableNestedLoopJoin

2019-05-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850518#comment-16850518 ] Danny Chan commented on CALCITE-3037: - Thank [~michaelmior], this should not go into 1.20, i will

[jira] [Updated] (CALCITE-3037) Rename EnumerableThetaJoin to EnumerableNestedLoopJoin

2019-05-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3037: Fix Version/s: (was: 1.20.0) > Rename EnumerableThetaJoin to EnumerableNestedLoopJoin >

[jira] [Resolved] (CALCITE-3055) TableScan type mismatch in VolcanoPlanner

2019-05-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3055. - Resolution: Fixed > TableScan type mismatch in VolcanoPlanner >

[jira] [Commented] (CALCITE-3055) TableScan type mismatch in VolcanoPlanner

2019-05-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850304#comment-16850304 ] Danny Chan commented on CALCITE-3055: - Fixed in 

[jira] [Commented] (CALCITE-3094) Code of method grows beyond 64 KB

2019-05-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849668#comment-16849668 ] Danny Chan commented on CALCITE-3094: - [~unmonoqueteclea] Yeah, it's indeed difficult to maintain

[jira] [Commented] (CALCITE-2829) Use consistent types when processing ranges

2019-05-26 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848558#comment-16848558 ] Danny Chan commented on CALCITE-2829: - Kind of related with CALCIE-2302, maybe we should keep the

[jira] [Commented] (CALCITE-2979) Add a block-based nested loop join algorithm

2019-05-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848331#comment-16848331 ] Danny Chan commented on CALCITE-2979: - Thanks for your kindly sharing [~zabetak], it helps a lot.

[jira] [Updated] (CALCITE-3083) Add demos(how to) doc for all supported DDLs and DMLs

2019-05-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3083: Description: Copied from DEV mail: Dear Dev Team's Apache Calcite, My name is Duc. I'm working

[jira] [Commented] (CALCITE-2979) Add a block-based nested loop join algorithm

2019-05-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848052#comment-16848052 ] Danny Chan commented on CALCITE-2979: - I have a question here, how about if the join inputs are not

[jira] [Commented] (CALCITE-2979) Add a block-based nested loop join algorithm

2019-05-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848051#comment-16848051 ] Danny Chan commented on CALCITE-2979: - The runtime filter kind of has the same purpose to promote

[jira] [Resolved] (CALCITE-3020) throws AssertionError:Type mismatch in VolcanoPlanner

2019-05-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3020. - Resolution: Duplicate > throws AssertionError:Type mismatch in VolcanoPlanner >

[jira] [Commented] (CALCITE-3055) TableScan type mismatch in VolcanoPlanner

2019-05-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848036#comment-16848036 ] Danny Chan commented on CALCITE-3055: - [~KazydubB] I'm basically +1 for your PR, just one thing: do

[jira] [Updated] (CALCITE-3088) Multi-groupsets query failed due to data type preservation check

2019-05-23 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3088: Summary: Multi-groupsets query failed due to data type preservation check (was: Multi-groupsets

[jira] [Commented] (CALCITE-3055) TableScan type mismatch in VolcanoPlanner

2019-05-23 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847168#comment-16847168 ] Danny Chan commented on CALCITE-3055: - Reviewing now .. > TableScan type mismatch in

[jira] [Comment Edited] (CALCITE-3055) TableScan type mismatch in VolcanoPlanner

2019-05-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846378#comment-16846378 ] Danny Chan edited comment on CALCITE-3055 at 5/23/19 2:31 AM: -- +1 to add

[jira] [Commented] (CALCITE-3055) TableScan type mismatch in VolcanoPlanner

2019-05-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846378#comment-16846378 ] Danny Chan commented on CALCITE-3055: - +1 to add the RelDataType pair back, we can not remove it if

[jira] [Commented] (CALCITE-3079) Successive dependent windows cannot be implemented in same expression level

2019-05-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846374#comment-16846374 ] Danny Chan commented on CALCITE-3079: - [~donnyzone] Well the Hep planner does not check the

[jira] [Commented] (CALCITE-3085) Unused stack field in RelShuttleImpl

2019-05-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846349#comment-16846349 ] Danny Chan commented on CALCITE-3085: - I don't think it's a good idea to remove the stack, this

[jira] [Commented] (CALCITE-3081) Literal NULL should be generated in SqlDialect

2019-05-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845469#comment-16845469 ] Danny Chan commented on CALCITE-3081: - I kind of have plan to push the CALCITE-2302 forward, i'm

[jira] [Commented] (CALCITE-3081) Literal NULL should be generated in SqlDialect

2019-05-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845420#comment-16845420 ] Danny Chan commented on CALCITE-3081: - This question kind of belongs to the scope of implicit type

[jira] [Commented] (CALCITE-3036) Remove correlate variables from Join

2019-05-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845419#comment-16845419 ] Danny Chan commented on CALCITE-3036: - [~zabetak] thanks so much for your kindly summarize ! >

[jira] [Created] (CALCITE-3083) Add demos(how to) doc for all supported DDLs and DMLs

2019-05-21 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-3083: --- Summary: Add demos(how to) doc for all supported DDLs and DMLs Key: CALCITE-3083 URL: https://issues.apache.org/jira/browse/CALCITE-3083 Project: Calcite

[jira] [Commented] (CALCITE-3079) Successive dependent windows cannot be implemented in same expression level

2019-05-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844833#comment-16844833 ] Danny Chan commented on CALCITE-3079: - I digged into the code a little and think the original Q1

[jira] [Commented] (CALCITE-3079) Successive dependent windows cannot be implemented in same expression level

2019-05-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844737#comment-16844737 ] Danny Chan commented on CALCITE-3079: - Reviewing now ... > Successive dependent windows cannot be

[jira] [Resolved] (CALCITE-3076) AggregateJoinTransposeRule throws error for unique under aggregate keys when generating merged calls

2019-05-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3076. - Resolution: Fixed Fix Version/s: 1.20.0 Fixed in 

[jira] [Comment Edited] (CALCITE-3076) AggregateJoinTransposeRule throws error for unique under aggregate keys when generating merged calls

2019-05-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843984#comment-16843984 ] Danny Chan edited comment on CALCITE-3076 at 5/20/19 1:59 PM: -- [~anha] I

[jira] [Commented] (CALCITE-3076) AggregateJoinTransposeRule throws error for unique under aggregate keys when generating merged calls

2019-05-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843984#comment-16843984 ] Danny Chan commented on CALCITE-3076: - [~anha] I have got the reason, it is not because the

[jira] [Updated] (CALCITE-3076) AggregateJoinTransposeRule throws error for unique under aggregate keys when generating merged calls

2019-05-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3076: Summary: AggregateJoinTransposeRule throws error for unique under aggregate keys when generating

[jira] [Updated] (CALCITE-3076) Error when AggregateJoinTransposeRule is used on unique under aggregate keys

2019-05-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3076: Summary: Error when AggregateJoinTransposeRule is used on unique under aggregate keys (was:

[jira] [Commented] (CALCITE-3065) RexLiteral#getValueAs should consider primitive type

2019-05-19 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843588#comment-16843588 ] Danny Chan commented on CALCITE-3065: - Thanks [~Aron.tao], i do not have strong willingness for

[jira] [Resolved] (CALCITE-3072) Generate right SQL for FLOOR functions in SparkSqlDialect

2019-05-19 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3072. - Resolution: Fixed Assignee: Danny Chan Fix Version/s: 1.20.0 Fixed in 

[jira] [Commented] (CALCITE-3075) Evaluate Travis CI for Windows build

2019-05-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843140#comment-16843140 ] Danny Chan commented on CALCITE-3075: - [https://docs.travis-ci.com/user/reference/windows/] does

[jira] [Assigned] (CALCITE-3076) Error when AggregateJoinTransposeRule is used on empty LogicalValues

2019-05-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3076: --- Assignee: Danny Chan > Error when AggregateJoinTransposeRule is used on empty

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

2019-05-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842244#comment-16842244 ] Danny Chan commented on CALCITE-2969: - Thanks [~julianhyde] and [~zabetak], i think it is okey to

[jira] [Commented] (CALCITE-3065) RexLiteral#getValueAs should consider primitive type

2019-05-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842067#comment-16842067 ] Danny Chan commented on CALCITE-3065: - Wile there are some other way to solve your problem, e.g.

[jira] [Commented] (CALCITE-3075) Evaluate Travis CI for Windows build

2019-05-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841866#comment-16841866 ] Danny Chan commented on CALCITE-3075: - I kind of have interest on this topic, i will try to find

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

2019-05-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841860#comment-16841860 ] Danny Chan commented on CALCITE-2969: - Thanks for all of your nice review comments [~julianhyde]

[jira] [Commented] (CALCITE-3065) RexLiteral#getValueAs should consider primitive type

2019-05-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841856#comment-16841856 ] Danny Chan commented on CALCITE-3065: - [~Aron.tao] I don't know where your plan comes from, but for

[jira] [Commented] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-05-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841122#comment-16841122 ] Danny Chan commented on CALCITE-2933: - Fixed in 

[jira] [Resolved] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-05-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-2933. - Resolution: Fixed Fix Version/s: 1.20.0 > In Druid adapter, expression like

[jira] [Resolved] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-05-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-2282. - Resolution: Fixed Fix Version/s: 1.20.0 Fixed in 

[jira] [Commented] (CALCITE-2979) Add a block-based nested loop join algorithm

2019-05-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840343#comment-16840343 ] Danny Chan commented on CALCITE-2979: - It kind of have same thoughts as [~rubenql], let's make

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840147#comment-16840147 ] Danny Chan commented on CALCITE-3050: - Thx [~julianhyde] and  [~Chunwei Lei], this PR is really

[jira] [Commented] (CALCITE-3065) RexLiteral#getValueAs should consider primitive type

2019-05-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840142#comment-16840142 ] Danny Chan commented on CALCITE-3065: - Firstly Calcite did set the numeric SqlLiteral value as

[jira] [Commented] (CALCITE-3065) RexLiteral#getValueAs should consider primitive type

2019-05-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840099#comment-16840099 ] Danny Chan commented on CALCITE-3065: - [~Aron.tao] While i checked the usage of method

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-05-14 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839900#comment-16839900 ] Danny Chan commented on CALCITE-2282: - I would merge this PR if there are no more comments in 24

[jira] [Assigned] (CALCITE-3034) CSV test case description does not match it's code logic

2019-05-14 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3034: --- Assignee: Danny Chan Affects Version/s: 1.19.0 Fix Version/s: 1.20.0

[jira] [Resolved] (CALCITE-3034) CSV test case description does not match it's code logic

2019-05-14 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3034. - Resolution: Fixed > CSV test case description does not match it's code logic >

[jira] [Commented] (CALCITE-3034) CSV test case description does not match it's code logic

2019-05-14 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839200#comment-16839200 ] Danny Chan commented on CALCITE-3034: - Fixed in 

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-05-13 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839028#comment-16839028 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] Thx for you nice review, i just remove the

[jira] [Comment Edited] (CALCITE-3065) RexLiteral#getValueAs should consider primitive type

2019-05-13 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838504#comment-16838504 ] Danny Chan edited comment on CALCITE-3065 at 5/13/19 12:30 PM: --- Please

[jira] [Commented] (CALCITE-3065) RexLiteral#getValueAs should consider primitive type

2019-05-13 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838504#comment-16838504 ] Danny Chan commented on CALCITE-3065: - Please give us more details about why this issue is fired ?

[jira] [Commented] (CALCITE-3064) [JDBC function escape] String not implemented REPEAT

2019-05-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838287#comment-16838287 ] Danny Chan commented on CALCITE-3064: - Then welcome to contribute this func to Calcite. > [JDBC

[jira] [Assigned] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-05-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2282: --- Assignee: Danny Chan > Allow OperatorTable to be pluggable in the parser >

[jira] [Commented] (CALCITE-3016) Reorganize the operator tables

2019-05-11 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837986#comment-16837986 ] Danny Chan commented on CALCITE-3016: - [~julianhyde] Thx for your work, i have left some comments

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-05-11 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837975#comment-16837975 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] I think we can, there only needs a flag to 

[jira] [Commented] (CALCITE-3062) Do not populate provenanceMap if not used

2019-05-11 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837806#comment-16837806 ] Danny Chan commented on CALCITE-3062: - Well sorry for my mistake, i think you are wright,

[jira] [Commented] (CALCITE-3062) Do not populate provenanceMap if not used

2019-05-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837740#comment-16837740 ] Danny Chan commented on CALCITE-3062: - As far as i know, the provenanceMap is used for rule

[jira] [Commented] (CALCITE-3013) support CeilFuncBigInt TO

2019-05-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837723#comment-16837723 ] Danny Chan commented on CALCITE-3013: - [~xzh_dz] I look up some docs: MYSQL[1], ORACLE[2], and they

[jira] [Commented] (CALCITE-3013) support CeilFuncBigInt TO

2019-05-10 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837722#comment-16837722 ] Danny Chan commented on CALCITE-3013: - [~xzh_dz] I look up some docs: MYSQL[1], ORACLE[2], and they

[jira] [Commented] (CALCITE-3057) Should let tabSize and operatorTable in SqlParser configurable?

2019-05-09 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836230#comment-16836230 ] Danny Chan commented on CALCITE-3057: - Thx [~dijkspicy], i'm intending to make the SqlOperatorTable

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-07 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835268#comment-16835268 ] Danny Chan commented on CALCITE-3050: - I'm thinking about if we can merge these "SqlDialect" like

[jira] [Commented] (CALCITE-3052) Error while applying rule MaterializedViewAggregateRule(Project-Aggregate): ArrayIndexOutOfBoundsException

2019-05-07 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835234#comment-16835234 ] Danny Chan commented on CALCITE-3052: - Thx [~anha] for reporting this. Reproduce this problem in 

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834338#comment-16834338 ] Danny Chan commented on CALCITE-3050: - I'm a little confused about why we need to config

[jira] [Assigned] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-06 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3050: --- Assignee: Danny Chan > Integrate SqlDialect and SqlParser.Config >

[jira] [Commented] (CALCITE-3049) When simplifying expressions, revisit "IS NULL" if its argument has been simplified

2019-05-05 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833245#comment-16833245 ] Danny Chan commented on CALCITE-3049: - Instead of revisit the the simplified RexNode's operand, i

[jira] [Assigned] (CALCITE-3049) When simplifying expressions, revisit "IS NULL" if its argument has been simplified

2019-05-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3049: --- Assignee: Danny Chan > When simplifying expressions, revisit "IS NULL" if its argument

[jira] [Assigned] (CALCITE-3020) throws AssertionError:Type mismatch in VolcanoPlanner

2019-05-03 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3020: --- Assignee: Danny Chan > throws AssertionError:Type mismatch in VolcanoPlanner >

[jira] [Commented] (CALCITE-2846) Document Oracle-specific functions, such as NVL and LTRIM, in the SQL reference

2019-05-03 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832985#comment-16832985 ] Danny Chan commented on CALCITE-2846: - [~zhztheplayer] Does the spatial functions belong to

[jira] [Closed] (CALCITE-3036) Remove correlate variables from Join

2019-04-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan closed CALCITE-3036. --- Resolution: Won't Fix This task has been canceled, see CALCITE-2969 discussion. > Remove

[jira] [Commented] (CALCITE-3041) Query runs endless when setImportance to 0

2019-04-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830814#comment-16830814 ] Danny Chan commented on CALCITE-3041: - [~hyuan] I would like to take this. > Query runs endless

[jira] [Assigned] (CALCITE-3041) Query runs endless when setImportance to 0

2019-04-30 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3041: --- Assignee: Danny Chan > Query runs endless when setImportance to 0 >

[jira] [Commented] (CALCITE-3038) DESCRIBE throws exception when table name is non-reserved keyword

2019-04-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829879#comment-16829879 ] Danny Chan commented on CALCITE-3038: - Can you give more details about the stake trace or give a

[jira] [Updated] (CALCITE-3030) SqlParseException when using component identifier for setting in merge statements

2019-04-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3030: Summary: SqlParseException when using component identifier for setting in merge statements

[jira] [Commented] (CALCITE-3030) SqlParseException when using aliases in merge statements

2019-04-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829056#comment-16829056 ] Danny Chan commented on CALCITE-3030: - [~zabetak] I think this is bug, we can reproduce the bug

[jira] [Assigned] (CALCITE-3030) SqlParseException when using aliases in merge statements

2019-04-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3030: --- Assignee: Danny Chan > SqlParseException when using aliases in merge statements >

[jira] [Commented] (CALCITE-3029) Java-oriented field type is wrongly forced to be NOT NULL after being converted to SQL-oriented

2019-04-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829044#comment-16829044 ] Danny Chan commented on CALCITE-3029: - +1 to remove this flag, we should sync the nullability even

[jira] [Created] (CALCITE-3037) Rename EnumerableThetaJoin to EnumerableNestedLoopJoin

2019-04-29 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-3037: --- Summary: Rename EnumerableThetaJoin to EnumerableNestedLoopJoin Key: CALCITE-3037 URL: https://issues.apache.org/jira/browse/CALCITE-3037 Project: Calcite

[jira] [Created] (CALCITE-3036) Remove correlate variables from Join

2019-04-29 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-3036: --- Summary: Remove correlate variables from Join Key: CALCITE-3036 URL: https://issues.apache.org/jira/browse/CALCITE-3036 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828945#comment-16828945 ] Danny Chan commented on CALCITE-2948: - {quote}We are not going to rewrite the rule and change the

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828880#comment-16828880 ] Danny Chan commented on CALCITE-2948: - [~hyuan] {quote}Because the filter should comparing column

[jira] [Comment Edited] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828872#comment-16828872 ] Danny Chan edited comment on CALCITE-2948 at 4/29/19 2:03 AM: -- [~hyuan]

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828872#comment-16828872 ] Danny Chan commented on CALCITE-2948: - [~hyuan] Thx for your review SubqueryRemoveRule and

[jira] [Comment Edited] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827891#comment-16827891 ] Danny Chan edited comment on CALCITE-2948 at 4/28/19 10:08 AM: --- [~hyuan],

[jira] [Comment Edited] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827891#comment-16827891 ] Danny Chan edited comment on CALCITE-2948 at 4/28/19 10:05 AM: --- [~hyuan],

[jira] [Comment Edited] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827891#comment-16827891 ] Danny Chan edited comment on CALCITE-2948 at 4/28/19 10:03 AM: --- [~hyuan],

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827891#comment-16827891 ] Danny Chan commented on CALCITE-2948: - [~hyuan], [~julianhyde] Instead of making a rule, i extend

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

2019-04-27 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827538#comment-16827538 ] Danny Chan commented on CALCITE-2969: - [~zabetak] Thx so much for your suggestions, {quote}To sum

<    1   2   3   4   5   6   >