[jira] [Assigned] (CALCITE-3368) Nonequivalent simplification happens in RexSimplify

2019-09-24 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-3368: --- Assignee: Danny Chan > Nonequivalent simplification happens in RexSimplify >

[jira] [Resolved] (CALCITE-3159) Distinct can be removed for MIN/MAX/BIT_OR/BIT_AND aggregate functions

2019-09-24 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3159. - Assignee: Danny Chan (was: Julian Hyde) Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-3159) Distinct can be removed for MIN/MAX/BIT_OR/BIT_AND aggregate functions

2019-09-24 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3159: Fix Version/s: 1.21.0 > Distinct can be removed for MIN/MAX/BIT_OR/BIT_AND aggregate functions >

[jira] [Updated] (CALCITE-3159) Distinct can be removed for MIN/MAX/BIT_OR/BIT_AND aggregate functions

2019-09-24 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3159: Affects Version/s: 1.20.0 > Distinct can be removed for MIN/MAX/BIT_OR/BIT_AND aggregate

[jira] [Commented] (CALCITE-3364) Can't group table function result due to a type cast error if table function returns a row with a single value

2019-09-23 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935810#comment-16935810 ] Danny Chan commented on CALCITE-3364: - Well, seems we should fix this problem in the linq4j, i

[jira] [Commented] (CALCITE-3364) Can't group table function result due to a type cast error if table function returns a row with a single value

2019-09-23 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935767#comment-16935767 ] Danny Chan commented on CALCITE-3364: - Thanks [~anha] for reporting this, just curious, if we only

[jira] [Resolved] (CALCITE-3247) In JDBC adapter, when generating SQL for Hive, transform SUBSTRING function to correct format

2019-09-23 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3247. - Fix Version/s: 1.22.0 Assignee: Danny Chan Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3288) linq4j: support Set literals

2019-09-23 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3288. - Fix Version/s: 1.22.0 Assignee: Danny Chan Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-1178) Allow SqlBetweenOperator to compare DATE and TIMESTAMP

2019-09-23 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-1178. - Fix Version/s: 1.22.0 Resolution: Fixed Fixed in

[jira] [Assigned] (CALCITE-1178) Allow SqlBetweenOperator to compare DATE and TIMESTAMP

2019-09-22 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-1178: --- Assignee: Danny Chan (was: Sean Hsuan-Yi Chu) > Allow SqlBetweenOperator to compare DATE

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-20 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934134#comment-16934134 ] Danny Chan commented on CALCITE-3353: - Thanks [~zabetak], i kind of disagree with your point for 2

[jira] [Commented] (CALCITE-3352) ProjectToWindowRule sets wrong collation on generated Window

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934067#comment-16934067 ] Danny Chan commented on CALCITE-3352: - Indeed, but the ProjectToWindowRule can match physical

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934061#comment-16934061 ] Danny Chan commented on CALCITE-3353: - Maybe we should give out a list of the rules that should not

[jira] [Comment Edited] (CALCITE-3360) SqlValidator throws NPE for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933953#comment-16933953 ] Danny Chan edited comment on CALCITE-3360 at 9/20/19 4:18 AM: -- Fixed in

[jira] [Updated] (CALCITE-3360) SqlValidator throws NPE for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3360: Summary: SqlValidator throws NPE for unregistered function without implicit type coercion

[jira] [Commented] (CALCITE-3360) SqlValidator throws NPE for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934033#comment-16934033 ] Danny Chan commented on CALCITE-3360: - Oh, thanks for correct, [~Chunwei Lei] ! > SqlValidator

[jira] [Resolved] (CALCITE-3360) SqlValidator throws NEP for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3360. - Resolution: Fixed Fixed in

[jira] [Comment Edited] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933948#comment-16933948 ] Danny Chan edited comment on CALCITE-3350 at 9/20/19 2:16 AM: -- Personally

[jira] [Comment Edited] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933948#comment-16933948 ] Danny Chan edited comment on CALCITE-3350 at 9/20/19 2:16 AM: -- Personally

[jira] [Comment Edited] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933948#comment-16933948 ] Danny Chan edited comment on CALCITE-3350 at 9/20/19 2:16 AM: -- Personally

[jira] [Commented] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933948#comment-16933948 ] Danny Chan commented on CALCITE-3350: - Personally i'm curious about why the original `STRING`

[jira] [Commented] (CALCITE-3349) Add Function DDL into SqlKind DDL enum

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933213#comment-16933213 ] Danny Chan commented on CALCITE-3349: - Personally, i'm okey with this change, but i have no strong

[jira] [Commented] (CALCITE-3354) RelToSqlConverter does not support LogicalTableFunctionScan

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933211#comment-16933211 ] Danny Chan commented on CALCITE-3354: - Thanks for reporting [~anha], and welcome to contribute ~ >

[jira] [Commented] (CALCITE-1178) Allow SqlBetweenOperator to compare DATE and TIMESTAMP

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933207#comment-16933207 ] Danny Chan commented on CALCITE-1178: - [~jacobroldan], yeah, you are right, 1.21 supports implicit

[jira] [Commented] (CALCITE-3349) Add Function DDL into SqlKind DDL enum

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933197#comment-16933197 ] Danny Chan commented on CALCITE-3349: - [~walterddr], there is no reason, it is just not implemented

[jira] [Commented] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-18 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933046#comment-16933046 ] Danny Chan commented on CALCITE-3355: - Thanks [~kirillkozlov] for reporting this ~ > Deduce

[jira] [Created] (CALCITE-3360) SqlValidator throws NEP for unregistered function without implicit type coercion

2019-09-18 Thread Danny Chan (Jira)
Danny Chan created CALCITE-3360: --- Summary: SqlValidator throws NEP for unregistered function without implicit type coercion Key: CALCITE-3360 URL: https://issues.apache.org/jira/browse/CALCITE-3360

[jira] [Commented] (CALCITE-2707) Information about distinct aggregation is lost in MATCH_RECOGNIZE

2019-09-18 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932181#comment-16932181 ] Danny Chan commented on CALCITE-2707: - When can we fix this issue, there is a copy file of Calcite

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-17 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932081#comment-16932081 ] Danny Chan commented on CALCITE-3353: - Maybe we should forbidden to match convention(non-logical)

[jira] [Commented] (CALCITE-3351) calcite mysql utf8 throws exception in Chinese

2019-09-16 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931072#comment-16931072 ] Danny Chan commented on CALCITE-3351: - The exception is thrown from avatica, and it seems that it

[jira] [Resolved] (CALCITE-3282) HiveSqlDialect unparse Interger type as Int in order to be compatible with Hive1.x

2019-09-16 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3282. - Fix Version/s: 1.22.0 Assignee: Danny Chan Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-3282) HiveSqlDialect unparse Interger type as Int in order to be compatible with Hive1.x

2019-09-16 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3282: Summary: HiveSqlDialect unparse Interger type as Int in order to be compatible with Hive1.x

[jira] [Commented] (CALCITE-2772) Support varargs for user-defined functions (UDFs)

2019-09-16 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930393#comment-16930393 ] Danny Chan commented on CALCITE-2772: - The change is breaking, because the user defined function

[jira] [Commented] (CALCITE-2772) Support varargs for user-defined functions (UDFs)

2019-09-16 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930390#comment-16930390 ] Danny Chan commented on CALCITE-2772: - Let me repeat the review comments again: Before the review

[jira] [Commented] (CALCITE-3349) Add Function DDL into SqlKind DDL enum

2019-09-16 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16930257#comment-16930257 ] Danny Chan commented on CALCITE-3349: - I'm kind of considering if we can add some tests for these

[jira] [Resolved] (CALCITE-3331) Support implicit type cast for operators that use single operand family checker

2019-09-11 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3331. - Resolution: Fixed Thanks [~zabetak] and fixed in

[jira] [Resolved] (CALCITE-3331) Support implicit type cast for operators that use single operand family checker

2019-09-11 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3331. - Resolution: Fixed Fixed in 

[jira] [Updated] (CALCITE-3331) Support implicit type cast for operators that use single operand family checker

2019-09-10 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3331: Description: When the FamilyOperandTypeChecker is used to check single operand data type,

[jira] [Updated] (CALCITE-3331) Support implicit type cast for operators that use single operand family checker

2019-09-10 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3331: Summary: Support implicit type cast for operators that use single operand family checker (was:

[jira] [Updated] (CALCITE-3331) Support implicit type cast for single operand family checker

2019-09-09 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3331: Description: When the FamilyOperandTypeChecker is used to check single operand data type,

[jira] [Created] (CALCITE-3331) Support implicit type cast for single operand family checker

2019-09-09 Thread Danny Chan (Jira)
Danny Chan created CALCITE-3331: --- Summary: Support implicit type cast for single operand family checker Key: CALCITE-3331 URL: https://issues.apache.org/jira/browse/CALCITE-3331 Project: Calcite

[jira] [Commented] (CALCITE-2166) Cumulative cost of RelSubset.best RelNode is increased after calling RelSubset.propagateCostImprovements() for input RelNodes

2019-09-07 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925043#comment-16925043 ] Danny Chan commented on CALCITE-2166: - Thanks [~xndai], Well, i think there are 2 cases that

[jira] [Resolved] (CALCITE-3321) Bigquery does not have correct casing rules

2019-09-05 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3321. - Fix Version/s: 1.21.0 Assignee: Danny Chan Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-2302) Implicit type cast support

2019-09-01 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2302: Description: Now many DBs have support implicit type cast, eg: SqlServer, Oracle, Hive.

[jira] [Resolved] (CALCITE-3310) Approximate and exact aggregate calls are recognized as the same during sql-to-rel conversion

2019-08-31 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3310. - Resolution: Fixed Fixed in 

[jira] [Comment Edited] (CALCITE-3315) Multiple failures in Druid IT tests due to implicit casts

2019-08-30 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920015#comment-16920015 ] Danny Chan edited comment on CALCITE-3315 at 8/31/19 4:25 AM: -- [~zabetak] 

[jira] [Commented] (CALCITE-3315) Multiple failures in Druid IT tests due to implicit casts

2019-08-30 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920015#comment-16920015 ] Danny Chan commented on CALCITE-3315: - [~zabetak] I'm so sorry to be a blocker, but i have tried

[jira] [Resolved] (CALCITE-3311) Add doc to site for implicit type coercion

2019-08-30 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3311. - Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3315) Multiple failures in Druid IT tests due to implicit casts

2019-08-30 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919626#comment-16919626 ] Danny Chan commented on CALCITE-3315: - Thanks [~zabetak] for reporting, fixing ~ > Multiple

[jira] [Commented] (CALCITE-3312) TIMESTAMPDIFF cannot be converted to SQL

2019-08-30 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919517#comment-16919517 ] Danny Chan commented on CALCITE-3312: - Thanks [~Pavel Gubin] for reporting this, maybe we can

[jira] [Commented] (CALCITE-3310) Approximate and exact aggregate calls are recognized as the same during sql-to-rel conversion

2019-08-30 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919513#comment-16919513 ] Danny Chan commented on CALCITE-3310: - The plan is wrong and the agg output should not be reused.

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-30 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919451#comment-16919451 ] Danny Chan commented on CALCITE-3282: - Let's just ignore unparsing the DDL first, Calcite's DDL has

[jira] [Created] (CALCITE-3311) Add doc to site for implicit type coercion

2019-08-30 Thread Danny Chan (Jira)
Danny Chan created CALCITE-3311: --- Summary: Add doc to site for implicit type coercion Key: CALCITE-3311 URL: https://issues.apache.org/jira/browse/CALCITE-3311 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-3307) PigRelExTest fails on Windows

2019-08-30 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919296#comment-16919296 ] Danny Chan commented on CALCITE-3307: - Thanks for the confirm, Ruben ! > PigRelExTest fails on

[jira] [Created] (CALCITE-3310) Approximate and exact aggregate calls are recognized as the same during sql-to-rel conversion

2019-08-30 Thread Danny Chan (Jira)
Danny Chan created CALCITE-3310: --- Summary: Approximate and exact aggregate calls are recognized as the same during sql-to-rel conversion Key: CALCITE-3310 URL: https://issues.apache.org/jira/browse/CALCITE-3310

[jira] [Resolved] (CALCITE-3269) Returns integer for VARCHAR and INT division of PostgreSql dialect

2019-08-29 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3269. - Resolution: Invalid As discussed in CALCITE-2302, we have chose the PostgreSQL style for

[jira] [Commented] (CALCITE-3122) Convert Pig Latin scripts into Calcite logical plans

2019-08-29 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918610#comment-16918610 ] Danny Chan commented on CALCITE-3122: - [~khaitran] Do you mean the Kerb Auth or something ? >

[jira] [Resolved] (CALCITE-2921) Allow NULL as argument to function calls

2019-08-29 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-2921. - Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-2302) Implicit type cast support

2019-08-29 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-2302. - Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-2325) Calcite can not verify a explicit cast column in some scenario

2019-08-29 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-2325. - Fix Version/s: 1.21.0 Assignee: Danny Chan Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-29 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918405#comment-16918405 ] Danny Chan commented on CALCITE-2302: - [~julianhyde] Thanks. There seems to be 2 style type

[jira] [Commented] (CALCITE-3304) SqlValidatorException when use calcite view

2019-08-28 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917694#comment-16917694 ] Danny Chan commented on CALCITE-3304: - This is because you config the FrameworkConfig to match

[jira] [Resolved] (CALCITE-3304) SqlValidatorException when use calcite view

2019-08-28 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3304. - Resolution: Not A Bug > SqlValidatorException when use calcite view >

[jira] [Commented] (CALCITE-3244) RelDecorrelator unable to decorrelate expression with filter and aggregate on top

2019-08-28 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917560#comment-16917560 ] Danny Chan commented on CALCITE-3244: - Yes, it is the RelDecorrelator that cause the error, not the

[jira] [Commented] (CALCITE-3244) RelDecorrelator unable to decorrelate expression with filter and aggregate on top

2019-08-27 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917367#comment-16917367 ] Danny Chan commented on CALCITE-3244: - I haven't digged into the failing test case in misc.iq#L709,

[jira] [Comment Edited] (CALCITE-2302) Implicit type cast support

2019-08-27 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908903#comment-16908903 ] Danny Chan edited comment on CALCITE-2302 at 8/28/19 2:58 AM: -- Thanks so

[jira] [Commented] (CALCITE-3244) RelDecorrelator unable to decorrelate expression with filter and aggregate on top

2019-08-27 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917355#comment-16917355 ] Danny Chan commented on CALCITE-3244: - Thanks [~vvysotskyi], i have fixed the test case you pasted.

[jira] [Issue Comment Deleted] (CALCITE-2302) Implicit type cast support

2019-08-27 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2302: Comment: was deleted (was: [~julianhyde] Does the latest commit solve your review objections ?

[jira] [Comment Edited] (CALCITE-2302) Implicit type cast support

2019-08-27 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914070#comment-16914070 ] Danny Chan edited comment on CALCITE-2302 at 8/28/19 1:32 AM: -- I have made

[jira] [Commented] (CALCITE-3244) RelDecorrelator unable to decorrelate expression with filter and aggregate on top

2019-08-27 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916709#comment-16916709 ] Danny Chan commented on CALCITE-3244: - [~vvysotskyi] I have applied a patch to fix the

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

2019-08-27 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916465#comment-16916465 ] Danny Chan commented on CALCITE-2973: - CALCITE-2302 and CALCITE-1581 are almost ready to be merged,

[jira] [Resolved] (CALCITE-3210) JDBC adapter should generate "CAST(NULL AS type)" rather than "NULL"

2019-08-26 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3210. - Fix Version/s: (was: next) 1.21.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-482) Implement sql and planner hints

2019-08-26 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915532#comment-16915532 ] Danny Chan commented on CALCITE-482: Thanks, [~hyuan] and [~Chunwei Lei] i have attached the design

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-25 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915414#comment-16915414 ] Danny Chan commented on CALCITE-2302: - [~julianhyde] Does the latest commit solve your review

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-25 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915407#comment-16915407 ] Danny Chan commented on CALCITE-3282: - The key point is that we don't want the

[jira] [Comment Edited] (CALCITE-2302) Implicit type cast support

2019-08-23 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914070#comment-16914070 ] Danny Chan edited comment on CALCITE-2302 at 8/24/19 2:31 AM: -- I have made

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-23 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914095#comment-16914095 ] Danny Chan commented on CALCITE-3282: - Add a new method SqlDialect#unparseDataType seems a right

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-23 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914070#comment-16914070 ] Danny Chan commented on CALCITE-2302: - I have made the latest change in commit 

[jira] [Comment Edited] (CALCITE-2302) Implicit type cast support

2019-08-22 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913843#comment-16913843 ] Danny Chan edited comment on CALCITE-2302 at 8/23/19 3:46 AM: -- Thanks,

[jira] [Commented] (CALCITE-3282) Make every SqlDialect unparse their own data type

2019-08-22 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913878#comment-16913878 ] Danny Chan commented on CALCITE-3282: - The SqlTypeNameSpec is a component of SqlDataTypeSpec to

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-22 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913843#comment-16913843 ] Danny Chan commented on CALCITE-2302: - Thanks, [~julianhyde] I kind of agree with your point that

[jira] [Commented] (CALCITE-3282) make every SqlDialect parse their own data type

2019-08-22 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913252#comment-16913252 ] Danny Chan commented on CALCITE-3282: - Sounds reasonable, but i can not figure out a proper way to

[jira] [Commented] (CALCITE-3115) Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet.

2019-08-21 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912928#comment-16912928 ] Danny Chan commented on CALCITE-3115: - Reviewing now .. > Cannot add JdbcRules which have

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-21 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912840#comment-16912840 ] Danny Chan commented on CALCITE-2302: - [~julianhyde] Does my reply answer your questions ? I'm

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-21 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912839#comment-16912839 ] Danny Chan commented on CALCITE-2302: - For "9/2 returns 4.5", we indeed do the type coercion

[jira] [Commented] (CALCITE-2302) Implicit type cast support

2019-08-21 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911987#comment-16911987 ] Danny Chan commented on CALCITE-2302: - [~julianhyde] Personally i propose to add this policy to

[jira] [Resolved] (CALCITE-3213) Support complex type expressions for SqlDataTypeSpec

2019-08-20 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3213. - Resolution: Fixed > Support complex type expressions for SqlDataTypeSpec >

[jira] [Updated] (CALCITE-3271) TVF windowing and EMIT syntax support in Calcite

2019-08-20 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3271: Issue Type: Improvement (was: Bug) > TVF windowing and EMIT syntax support in Calcite >

[jira] [Created] (CALCITE-3271) TVF windowing and EMIT syntax support in Calcite

2019-08-20 Thread Danny Chan (Jira)
Danny Chan created CALCITE-3271: --- Summary: TVF windowing and EMIT syntax support in Calcite Key: CALCITE-3271 URL: https://issues.apache.org/jira/browse/CALCITE-3271 Project: Calcite Issue

[jira] [Updated] (CALCITE-3251) BinaryExpression evaluate method support Long type.

2019-08-20 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3251: Component/s: core Affects Version/s: 1.19.0 1.20.0 >

[jira] [Updated] (CALCITE-3265) Remove useless code in ExpressionTest

2019-08-20 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3265: Fix Version/s: 1.21.0 Affects Version/s: 1.20.0 > Remove useless code in ExpressionTest

[jira] [Updated] (CALCITE-3265) Remove useless code in ExpressionTest

2019-08-20 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3265: Summary: Remove useless code in ExpressionTest (was: remove useless code) > Remove useless code

[jira] [Resolved] (CALCITE-3265) Remove useless code in ExpressionTest

2019-08-20 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3265. - Assignee: Danny Chan Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3251) BinaryExpression evaluate method support Long type.

2019-08-20 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3251. - Fix Version/s: 1.21.0 Assignee: Danny Chan Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3267) Remove method SqlDataTypeSpec#deriveType(RelDataTypefactory)

2019-08-20 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3267. - Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3213) Support complex type expressions for SqlDataTypeSpec

2019-08-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910954#comment-16910954 ] Danny Chan commented on CALCITE-3213: - Thanks Julian, the change list you proposed is much better

[jira] [Created] (CALCITE-3269) Returns integer for VARCHAR and INT division of PostgreSql dialect

2019-08-19 Thread Danny Chan (Jira)
Danny Chan created CALCITE-3269: --- Summary: Returns integer for VARCHAR and INT division of PostgreSql dialect Key: CALCITE-3269 URL: https://issues.apache.org/jira/browse/CALCITE-3269 Project: Calcite

[jira] [Comment Edited] (CALCITE-2302) Implicit type cast support

2019-08-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910144#comment-16910144 ] Danny Chan edited comment on CALCITE-2302 at 8/19/19 2:59 AM: -- Thanks

[jira] [Comment Edited] (CALCITE-2302) Implicit type cast support

2019-08-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908903#comment-16908903 ] Danny Chan edited comment on CALCITE-2302 at 8/19/19 2:55 AM: -- Thanks so

[jira] [Comment Edited] (CALCITE-2302) Implicit type cast support

2019-08-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910144#comment-16910144 ] Danny Chan edited comment on CALCITE-2302 at 8/19/19 2:52 AM: -- Thanks

  1   2   3   4   5   6   >