[jira] [Commented] (CALCITE-5743) Query gives incorrect result when COUNT appears in the correlated subquery select list

2024-04-11 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836376#comment-17836376 ] James Starr commented on CALCITE-5743: -- [~leepb]Yes, that looks correct follow my suggestion, but

[jira] [Comment Edited] (CALCITE-5743) Query gives incorrect result when COUNT appears in the correlated subquery select list

2024-04-10 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835836#comment-17835836 ] James Starr edited comment on CALCITE-5743 at 4/10/24 5:54 PM: --- I think

[jira] [Comment Edited] (CALCITE-5743) Query gives incorrect result when COUNT appears in the correlated subquery select list

2024-04-10 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835836#comment-17835836 ] James Starr edited comment on CALCITE-5743 at 4/10/24 5:51 PM: --- I think

[jira] [Commented] (CALCITE-5743) Query gives incorrect result when COUNT appears in the correlated subquery select list

2024-04-10 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835836#comment-17835836 ] James Starr commented on CALCITE-5743: -- I think you have to join the value generation query above

[jira] [Commented] (CALCITE-6032) Multilevel correlated query is failing in RelDecorrelator code path

2024-02-23 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820211#comment-17820211 ] James Starr commented on CALCITE-6032: -- 6032 fixes part of the problems seen 5418. > Multilevel

[jira] [Commented] (CALCITE-5413) Nested Subqueries with correlated variables are not decorrelated correctly

2023-03-09 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698573#comment-17698573 ] James Starr commented on CALCITE-5413: -- [~libenchao]Would you like me to try and find another

[jira] [Updated] (CALCITE-5516) RelOptRulesTest AggregateReduceFunctionsRule optimized plan not semantically equivalent to the original one after conversion

2023-02-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-5516: - Description: After converting the "plan before" and "plan after" of

[jira] [Commented] (CALCITE-5517) Nested (correlated) subqueries fail at validation | No SELECT scope for inner subquery

2023-02-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694700#comment-17694700 ] James Starr commented on CALCITE-5517: -- How is this a nested correlated sub-query? > Nested

[jira] [Updated] (CALCITE-5517) Nested (correlated) subqueries fail at validation | No SELECT scope for inner subquery

2023-02-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-5517: - Description: Testing with TPC-H Query 2 for reference: {code:sql} SELECT FIRST 100 s_acctbal,

[jira] [Updated] (CALCITE-5517) Nested (correlated) subqueries fail at validation | No SELECT scope for inner subquery

2023-02-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-5517: - Description: Testing with TPC-H Query 2 for reference: {code:sql} SELECT FIRST 100 s_acctbal,

[jira] [Commented] (CALCITE-5413) Nested Subqueries with correlated variables are not decorrelated correctly

2023-02-27 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694306#comment-17694306 ] James Starr commented on CALCITE-5413: -- [~libenchao] All the tests are now passing, could you

[jira] [Commented] (CALCITE-5420) SqlToRel should populate projects corralate id for queries with aggregates.

2023-02-21 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691753#comment-17691753 ] James Starr commented on CALCITE-5420: -- [~libenchao] Could you please look at

[jira] [Commented] (CALCITE-5420) SqlToRel should populate projects corralate id for queries with aggregates.

2022-12-06 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17644138#comment-17644138 ] James Starr commented on CALCITE-5420: -- [~libenchao] The hard one is joins, but maybe how the

[jira] [Comment Edited] (CALCITE-5420) SqlToRel should populate projects corralate id for queries with aggregates.

2022-12-06 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643968#comment-17643968 ] James Starr edited comment on CALCITE-5420 at 12/6/22 5:31 PM: ---

[jira] [Commented] (CALCITE-5420) SqlToRel should populate projects corralate id for queries with aggregates.

2022-12-06 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643968#comment-17643968 ] James Starr commented on CALCITE-5420: -- [~libenchao]There are several queries currently checked in

[jira] [Commented] (CALCITE-5420) SqlToRel should populate projects corralate id for queries with aggregates.

2022-12-05 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643683#comment-17643683 ] James Starr commented on CALCITE-5420: -- The subquery/decorrelation flow: # SqlToRel(expand=false)

[jira] [Updated] (CALCITE-5420) SqlToRel should populate projects corralate id for queries with aggregates.

2022-12-05 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-5420: - Description: The following query does not populate correlate id in the project when

[jira] [Updated] (CALCITE-5421) SqlToRel should populate corralateId for join with corralated query in HAVING condition

2022-12-05 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-5421: - Description: {code:java} class SqlToRelConverterTest extends SqlToRelTestBase { ... @Test

[jira] [Created] (CALCITE-5421) SqlToRel should populate corralateId for join with corralated query in HAVING condition

2022-12-05 Thread James Starr (Jira)
James Starr created CALCITE-5421: Summary: SqlToRel should populate corralateId for join with corralated query in HAVING condition Key: CALCITE-5421 URL: https://issues.apache.org/jira/browse/CALCITE-5421

[jira] [Commented] (CALCITE-5413) Nested Subqueries with correlated variables are not decorrelated correctly

2022-12-05 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643511#comment-17643511 ] James Starr commented on CALCITE-5413: -- SqlToRel not setting the correlate id > Nested Subqueries

[jira] (CALCITE-5413) Nested Subqueries with correlated variables are not decorrelated correctly

2022-12-05 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5413 ] James Starr deleted comment on CALCITE-5413: -- was (Author: jamesstarr): SqlToRel not setting the correlate id > Nested Subqueries with correlated variables are not decorrelated correctly

[jira] [Assigned] (CALCITE-5420) SqlToRel should populate projects corralate id for queries with aggregates.

2022-12-05 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr reassigned CALCITE-5420: Assignee: James Starr > SqlToRel should populate projects corralate id for queries with

[jira] [Created] (CALCITE-5420) SqlToRel should populate projects corralate id for queries with aggregates.

2022-12-02 Thread James Starr (Jira)
James Starr created CALCITE-5420: Summary: SqlToRel should populate projects corralate id for queries with aggregates. Key: CALCITE-5420 URL: https://issues.apache.org/jira/browse/CALCITE-5420

[jira] [Updated] (CALCITE-5418) Nested Queries are not expanded properly

2022-12-02 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-5418: - Description: SubQueryRemoveRule does not expand the subqueries correctly: {code:sql} SELECT

[jira] [Created] (CALCITE-5418) Nested Queries are not expanded properly

2022-12-02 Thread James Starr (Jira)
James Starr created CALCITE-5418: Summary: Nested Queries are not expanded properly Key: CALCITE-5418 URL: https://issues.apache.org/jira/browse/CALCITE-5418 Project: Calcite Issue Type: Bug

[jira] [Updated] (CALCITE-5413) Nested Subqueries with correlated variables are not decorrelated correctly

2022-12-01 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-5413: - Description: When SubQueryRemoveRule decorrelates a nested query, all correlated variables

[jira] [Updated] (CALCITE-5413) Nested Subqueries with correlated variables are not decorrelated correctly

2022-12-01 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-5413: - Description: When SubQueryRemoveRule decorrelates a nested query, all correlated variables

[jira] [Created] (CALCITE-5413) Nested Subqueries with correlated variables are not decorrelated correctly

2022-12-01 Thread James Starr (Jira)
James Starr created CALCITE-5413: Summary: Nested Subqueries with correlated variables are not decorrelated correctly Key: CALCITE-5413 URL: https://issues.apache.org/jira/browse/CALCITE-5413

[jira] [Assigned] (CALCITE-5413) Nested Subqueries with correlated variables are not decorrelated correctly

2022-12-01 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr reassigned CALCITE-5413: Assignee: James Starr > Nested Subqueries with correlated variables are not

[jira] [Commented] (CALCITE-1045) Decorrelate sub-queries in Project and Join

2022-10-04 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612733#comment-17612733 ] James Starr commented on CALCITE-1045: -- [~zabetak], Great work, however, the fix looks to only

[jira] [Commented] (CALCITE-4539) Support pluggable metadata handlers and caching

2022-02-15 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492884#comment-17492884 ] James Starr commented on CALCITE-4539: -- [~baibaichen] All except the pluggable cache is done. >

[jira] [Created] (CALCITE-4942) Deprecate Bolier plate for Rel Metadata

2021-12-15 Thread James Starr (Jira)
James Starr created CALCITE-4942: Summary: Deprecate Bolier plate for Rel Metadata Key: CALCITE-4942 URL: https://issues.apache.org/jira/browse/CALCITE-4942 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-4882) Explore a LambdaMetadataFactory alternative to Janino for metadata retrieval

2021-11-10 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17441935#comment-17441935 ] James Starr commented on CALCITE-4882: -- [~jnadeau], this is great work. I am seeing large per run

[jira] [Comment Edited] (CALCITE-4882) Explore a LambdaMetadataFactory alternative to Janino for metadata retrieval

2021-11-09 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17441415#comment-17441415 ] James Starr edited comment on CALCITE-4882 at 11/9/21, 10:41 PM: - Could

[jira] [Commented] (CALCITE-4882) Explore a LambdaMetadataFactory alternative to Janino for metadata retrieval

2021-11-09 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17441415#comment-17441415 ] James Starr commented on CALCITE-4882: -- Could you post your code for review? > Explore a

[jira] [Commented] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-10-27 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435073#comment-17435073 ] James Starr commented on CALCITE-4544: -- Could you point me to/provide an example where you are

[jira] [Commented] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-10-27 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435050#comment-17435050 ] James Starr commented on CALCITE-4544: -- ReflectiveRelMetadataHandler is not deprecated, using does

[jira] [Commented] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-10-27 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435049#comment-17435049 ] James Starr commented on CALCITE-4544: -- [~bhulette], In my opining Deprecating code should not

[jira] [Commented] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-10-27 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434983#comment-17434983 ] James Starr commented on CALCITE-4544: -- [~bhulette] Their were bugs in the reflection based cached

[jira] [Commented] (CALCITE-4686) SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-10-12 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427993#comment-17427993 ] James Starr commented on CALCITE-4686: -- [~zabetak], CALCITE-4833 is not related, I jumped the gun

[jira] [Assigned] (CALCITE-4550) Simplify JaninoRelMetadataProvider API for binding methods

2021-10-06 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr reassigned CALCITE-4550: Assignee: James Starr > Simplify JaninoRelMetadataProvider API for binding methods >

[jira] [Commented] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-10-06 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425327#comment-17425327 ] James Starr commented on CALCITE-4544: -- [~julianhyde], The second statement is false. The first

[jira] [Commented] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-10-06 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425200#comment-17425200 ] James Starr commented on CALCITE-4544: -- Here is the comment I was referring too.

[jira] [Commented] (CALCITE-4812) RelBuilder.join should error multiple correlate ids

2021-09-30 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422988#comment-17422988 ] James Starr commented on CALCITE-4812: -- Their are none currently. Lateral Joins are explicitly

[jira] [Updated] (CALCITE-4812) RelBuilder.join should error multiple correlate ids

2021-09-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4812: - Description: Relbuilder.join does not correctly handle multiple correlate ids. An error

[jira] [Updated] (CALCITE-4812) RelBuilder.join should error multiple correlate ids

2021-09-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4812: - Summary: RelBuilder.join should error multiple correlate ids (was: RelBuilder.join should

[jira] [Assigned] (CALCITE-4812) RelBuilder.join should handle multiple correlate ids

2021-09-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr reassigned CALCITE-4812: Assignee: James Starr > RelBuilder.join should handle multiple correlate ids >

[jira] [Assigned] (CALCITE-4808) RelOptUtil.getVariablesUsed should assert that correlated variables are used in scope

2021-09-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr reassigned CALCITE-4808: Assignee: James Starr > RelOptUtil.getVariablesUsed should assert that correlated

[jira] [Created] (CALCITE-4812) RelBuilder.join should handle multiple correlate ids

2021-09-28 Thread James Starr (Jira)
James Starr created CALCITE-4812: Summary: RelBuilder.join should handle multiple correlate ids Key: CALCITE-4812 URL: https://issues.apache.org/jira/browse/CALCITE-4812 Project: Calcite

[jira] [Updated] (CALCITE-4792) SqlToRel should populate corralateId for join with corralated query in ON condition

2021-09-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4792: - Description: Relbuilder.join does not check condition for correlated variables. > SqlToRel

[jira] [Commented] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-09-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421579#comment-17421579 ] James Starr commented on CALCITE-4544: -- [~zabetak], If janino backed meta is used, then

[jira] [Created] (CALCITE-4808) RelOptUtil.getVariablesUsed should assert that correlated variables are used in scope

2021-09-27 Thread James Starr (Jira)
James Starr created CALCITE-4808: Summary: RelOptUtil.getVariablesUsed should assert that correlated variables are used in scope Key: CALCITE-4808 URL: https://issues.apache.org/jira/browse/CALCITE-4808

[jira] [Commented] (CALCITE-4798) Gradle build fails due to deprecated metadata APIs

2021-09-27 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420980#comment-17420980 ] James Starr commented on CALCITE-4798: -- I am using oracle on Mac. I can not reproduce it with

[jira] [Commented] (CALCITE-4798) Gradle build fails due to deprecated metadata APIs

2021-09-24 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420060#comment-17420060 ] James Starr commented on CALCITE-4798: -- I have the pull request fixing the error. However, I am

[jira] [Updated] (CALCITE-4792) SqlToRel should populate corralateId for join with corralated query in ON condition

2021-09-22 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4792: - Component/s: core > SqlToRel should populate corralateId for join with corralated query in ON

[jira] [Created] (CALCITE-4792) SqlToRel should populate corralateId for join with corralated query in ON condition

2021-09-22 Thread James Starr (Jira)
James Starr created CALCITE-4792: Summary: SqlToRel should populate corralateId for join with corralated query in ON condition Key: CALCITE-4792 URL: https://issues.apache.org/jira/browse/CALCITE-4792

[jira] [Created] (CALCITE-4791) RelBuilder.join incorrectly rewrites correlated conditions

2021-09-22 Thread James Starr (Jira)
James Starr created CALCITE-4791: Summary: RelBuilder.join incorrectly rewrites correlated conditions Key: CALCITE-4791 URL: https://issues.apache.org/jira/browse/CALCITE-4791 Project: Calcite

[jira] [Commented] (CALCITE-4686) SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-09-21 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17418210#comment-17418210 ] James Starr commented on CALCITE-4686: -- Hi [~zabetak], Great find! I have looked into your patch

[jira] [Commented] (CALCITE-4686) SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-09-17 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17416966#comment-17416966 ] James Starr commented on CALCITE-4686: -- [~zabetak], Could we move forward with merging this? >

[jira] [Commented] (CALCITE-4686) SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-09-14 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17415162#comment-17415162 ] James Starr commented on CALCITE-4686: -- [~zabetak], Thank you for looking into it. So,

[jira] [Commented] (CALCITE-4728) Parse and validate procedural code (such as SQL/PSM, PL/SQL, PL/pgSQL, T-SQL)

2021-08-12 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17398319#comment-17398319 ] James Starr commented on CALCITE-4728: -- [~julianhyde], I see what you are saying about Oracles

[jira] [Commented] (CALCITE-4728) Parse and validate procedural code (such as SQL/PSM, PL/SQL, PL/pgSQL, T-SQL)

2021-08-12 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17398104#comment-17398104 ] James Starr commented on CALCITE-4728: -- Where the parser is bound in, should be pluggable so other

[jira] [Commented] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-08-09 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396183#comment-17396183 ] James Starr commented on CALCITE-4544: -- [~julianhyde], Could we move forward with only deprecating

[jira] [Commented] (CALCITE-4686) SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-08-06 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394942#comment-17394942 ] James Starr commented on CALCITE-4686: -- [~zabetak], So I believe the Hep planner will not fire a

[jira] [Assigned] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-08-06 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr reassigned CALCITE-4544: Assignee: James Starr > Deprecate Metadata API backed by Java Reflection >

[jira] [Updated] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-08-06 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4544: - Description: A large portion of the metadata api is functionally deprecated, we should make

[jira] [Commented] (CALCITE-4686) SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-08-04 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393377#comment-17393377 ] James Starr commented on CALCITE-4686: -- [~zabetak], testJoinOnMultipleCorrelatedSubQueries does

[jira] [Updated] (CALCITE-4686) SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-07-29 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4686: - Description: SubQueryRemoveRule.matchJoin only rewrites the first subquery in an ON condition

[jira] [Commented] (CALCITE-4686) SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-07-07 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17376906#comment-17376906 ] James Starr commented on CALCITE-4686: -- Sub queries in ON conditions do not work, but 1045 covers

[jira] [Assigned] (CALCITE-4686) SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-07-07 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr reassigned CALCITE-4686: Assignee: James Starr > SubQueryRemoveRule.matchJoin should correctly rewrite all

[jira] [Created] (CALCITE-4686) SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries

2021-07-07 Thread James Starr (Jira)
James Starr created CALCITE-4686: Summary: SubQueryRemoveRule.matchJoin should correctly rewrite all sub-queries Key: CALCITE-4686 URL: https://issues.apache.org/jira/browse/CALCITE-4686 Project:

[jira] [Commented] (CALCITE-4668) RelBuilder.join should convert Correlate to Join if correlation variable is unused

2021-07-06 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375866#comment-17375866 ] James Starr commented on CALCITE-4668: -- [~zabetak] [~julianhyde], If no further changes are

[jira] [Commented] (CALCITE-4668) RelBuilder.join should convert Correlate to Join if correlation variable is unused

2021-07-01 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17372905#comment-17372905 ] James Starr commented on CALCITE-4668: -- [~zabetak], I wondering that myself. But it would change

[jira] [Updated] (CALCITE-4668) RelBuilder.join should convert Correlate to Join if correlation variable is unused

2021-06-29 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4668: - Summary: RelBuilder.join should convert Correlate to Join if correlation variable is unused

[jira] [Updated] (CALCITE-4668) RelBuilder.join convert Correlate to Join if correlation variable is unused

2021-06-29 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4668: - Summary: RelBuilder.join convert Correlate to Join if correlation variable is unused (was:

[jira] [Updated] (CALCITE-4668) RelBuilder.join should convert Correlate to Join if correlation variable is used

2021-06-29 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4668: - Summary: RelBuilder.join should convert Correlate to Join if correlation variable is used

[jira] [Updated] (CALCITE-4668) RelBuilder.join should convert Correlate to Join if correlation variable is unused

2021-06-29 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4668: - Summary: RelBuilder.join should convert Correlate to Join if correlation variable is unused

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-29 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371599#comment-17371599 ] James Starr commented on CALCITE-4668: -- [~julianhyde], [~zabetak], Just confirming, the PR, as is

[jira] [Comment Edited] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370963#comment-17370963 ] James Starr edited comment on CALCITE-4668 at 6/29/21, 12:06 AM: -

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370963#comment-17370963 ] James Starr commented on CALCITE-4668: -- [~julianhyde] What if we add another thread local to

[jira] [Comment Edited] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370846#comment-17370846 ] James Starr edited comment on CALCITE-4668 at 6/28/21, 11:06 PM: -

[jira] [Comment Edited] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370846#comment-17370846 ] James Starr edited comment on CALCITE-4668 at 6/28/21, 11:06 PM: -

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370846#comment-17370846 ] James Starr commented on CALCITE-4668: -- {quote} Where does that scan occur? {quote}

[jira] [Commented] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370775#comment-17370775 ] James Starr commented on CALCITE-4668: -- [~julianhyde] ??James Starr, This seems like a useful

[jira] [Updated] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable is used

2021-06-28 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4668: - Summary: RelBuilder.join should only emit a correlate when a correlate variable is used (was:

[jira] [Updated] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable exists

2021-06-25 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4668: - Description: We generate correlated join when no correlate variable is present on the right

[jira] [Created] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable exists

2021-06-25 Thread James Starr (Jira)
James Starr created CALCITE-4668: Summary: RelBuilder.join should only emit a correlate when a correlate variable exists Key: CALCITE-4668 URL: https://issues.apache.org/jira/browse/CALCITE-4668

[jira] [Updated] (CALCITE-4668) RelBuilder.join should only emit a correlate when a correlate variable exists

2021-06-25 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4668: - Description: We generate correlated join when no correlate variable is present on the right

[jira] [Commented] (CALCITE-1045) Decorrelate sub-queries in Project and Join

2021-06-21 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366827#comment-17366827 ] James Starr commented on CALCITE-1045: -- [~zabetak] , do you have any further feed back? >

[jira] [Commented] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-06-21 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366770#comment-17366770 ] James Starr commented on CALCITE-4544: -- [~julianhyde], do have any more feedback? > Deprecate

[jira] [Commented] (CALCITE-4539) Support pluggable metadata handlers and caching

2021-04-19 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325350#comment-17325350 ] James Starr commented on CALCITE-4539: -- [~julianhyde], I have pushed up the changes

[jira] [Updated] (CALCITE-4539) Support pluggable metadata handlers and caching

2021-04-19 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4539: - Description: Calcite janino backed metadata does not support all the functionality that the

[jira] [Updated] (CALCITE-4539) Support pluggable metadata handlers and caching

2021-04-19 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4539: - Description: Calcite janino backed metadata does not support all the functionality that the

[jira] [Commented] (CALCITE-4493) Postgres/Mysql String Literal Equality Creates incorrect results.

2021-04-19 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325225#comment-17325225 ] James Starr commented on CALCITE-4493: --  Mysql appears to not even have a char type internally.

[jira] [Commented] (CALCITE-4493) Postgres/Mysql String Literal Equality Creates incorrect results.

2021-04-19 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325208#comment-17325208 ] James Starr commented on CALCITE-4493: -- >From my observations with mysql, it always appears to be

[jira] [Comment Edited] (CALCITE-4493) Postgres/Mysql String Literal Equality Creates incorrect results.

2021-04-19 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325208#comment-17325208 ] James Starr edited comment on CALCITE-4493 at 4/19/21, 5:23 PM: >From

[jira] [Updated] (CALCITE-4493) Postgres/Mysql String Literal Equality Creates incorrect results.

2021-04-19 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4493: - Summary: Postgres/Mysql String Literal Equality Creates incorrect results. (was: Postgres

[jira] [Updated] (CALCITE-4493) Postgres String Literal Equality Creates incorrect results.

2021-04-16 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4493: - Description: Calcite always interprets String Literals as CHAR type.  This is normally not an

[jira] [Updated] (CALCITE-4493) Postgres String Literal Equality Creates incorrect results.

2021-04-16 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Starr updated CALCITE-4493: - Description: Calcite always interprets String Literals as CHAR type.  This is normally not an

[jira] [Commented] (CALCITE-4544) Deprecate Metadata API backed by Java Reflection

2021-04-14 Thread James Starr (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17321884#comment-17321884 ] James Starr commented on CALCITE-4544: -- [~julianhyde] Thank you for looking at. I have expand the

  1   2   >