[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155796#comment-17155796
]
Xiening Dai commented on CALCITE-3963:
--
There are already a number of bugs here and there with the
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155793#comment-17155793
]
Xiening Dai commented on CALCITE-3963:
--
{quote}
If one RelNode thinks a query returns at least 1
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145911#comment-17145911
]
Xiening Dai commented on CALCITE-3963:
--
[~julianhyde] do you have more comments regarding this?
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140741#comment-17140741
]
Xiening Dai commented on CALCITE-3963:
--
{quote}
For sets of predicates and unique keys, the
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17137804#comment-17137804
]
Xiening Dai commented on CALCITE-3963:
--
{quote}
I don't understand what you mean by 'associative
[
https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135989#comment-17135989
]
Xiening Dai commented on CALCITE-4049:
--
My point is we don't even need shortest path. For
[
https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134931#comment-17134931
]
Xiening Dai commented on CALCITE-4049:
--
Based on the usage pattern, I don't think the shortest
[
https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134593#comment-17134593
]
Xiening Dai commented on CALCITE-4049:
--
I should also mention that getShortestPath() is also used
[
https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134589#comment-17134589
]
Xiening Dai commented on CALCITE-4049:
--
After looking it deeper, I feel the shorted path might not
[
https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134529#comment-17134529
]
Xiening Dai commented on CALCITE-4049:
--
I agree with [~julianhyde]. You cannot say there's no
[
https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134529#comment-17134529
]
Xiening Dai edited comment on CALCITE-4049 at 6/12/20, 8:44 PM:
I agree
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127240#comment-17127240
]
Xiening Dai commented on CALCITE-3963:
--
Thanks for your reply, Julian.
I don't feel that current
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121177#comment-17121177
]
Xiening Dai commented on CALCITE-3963:
--
_*What's wrong with my suggestion to treat all RelNode
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119284#comment-17119284
]
Xiening Dai commented on CALCITE-3963:
--
I create a PR -
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117935#comment-17117935
]
Xiening Dai commented on CALCITE-3972:
--
I agree collation can be expressed as a required property
[
https://issues.apache.org/jira/browse/CALCITE-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116882#comment-17116882
]
Xiening Dai commented on CALCITE-4023:
--
Is this a bug to fix or the rule is just useless?
>
[
https://issues.apache.org/jira/browse/CALCITE-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115005#comment-17115005
]
Xiening Dai commented on CALCITE-3541:
--
Ok, I see. The base class does have a predicate in
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115004#comment-17115004
]
Xiening Dai commented on CALCITE-3972:
--
[~zabetak] this is separate, and has nothing to do with
[
https://issues.apache.org/jira/browse/CALCITE-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114290#comment-17114290
]
Xiening Dai commented on CALCITE-3541:
--
hi [~zabetak], not sure what you mean by adding a
[
https://issues.apache.org/jira/browse/CALCITE-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114283#comment-17114283
]
Xiening Dai commented on CALCITE-3455:
--
After adding transformation rule, this is no longer an
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114280#comment-17114280
]
Xiening Dai commented on CALCITE-3972:
--
We discover that with this change there are a few rules
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109171#comment-17109171
]
Xiening Dai commented on CALCITE-3997:
--
Hi [~rubenql], I agree with most what you said. We should
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108613#comment-17108613
]
Xiening Dai commented on CALCITE-3997:
--
There's an downside with my approach (thanks Haisheng for
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108529#comment-17108529
]
Xiening Dai edited comment on CALCITE-3997 at 5/15/20, 6:21 PM:
I think
[
https://issues.apache.org/jira/browse/CALCITE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108529#comment-17108529
]
Xiening Dai commented on CALCITE-3997:
--
I think [~rubenql] has a good point. If TransformationRule
[
https://issues.apache.org/jira/browse/CALCITE-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106628#comment-17106628
]
Xiening Dai commented on CALCITE-3993:
--
I understand it's new. You claim it's an extremely
[
https://issues.apache.org/jira/browse/CALCITE-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106620#comment-17106620
]
Xiening Dai commented on CALCITE-3993:
--
I don't see the new isDefault() API being used in your PR.
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105666#comment-17105666
]
Xiening Dai commented on CALCITE-3972:
--
Going forward, do you think it makes sense to fork a
[
https://issues.apache.org/jira/browse/CALCITE-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104963#comment-17104963
]
Xiening Dai commented on CALCITE-3990:
--
No problem, [~levv]. Thanks for confirming!
> Use a more
[
https://issues.apache.org/jira/browse/CALCITE-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104954#comment-17104954
]
Xiening Dai commented on CALCITE-3990:
--
Current cost propagation is already done through BFS
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102747#comment-17102747
]
Xiening Dai edited comment on CALCITE-3972 at 5/11/20, 5:46 AM:
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103644#comment-17103644
]
Xiening Dai commented on CALCITE-3972:
--
The thing is you don't want people to update
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102747#comment-17102747
]
Xiening Dai commented on CALCITE-3972:
--
RelFactories.StructwithRelFactories() is not really
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102245#comment-17102245
]
Xiening Dai commented on CALCITE-3972:
--
[~hyuan] [~julianhyde] if you have a chance, can you
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101260#comment-17101260
]
Xiening Dai commented on CALCITE-3972:
--
Tried push/pop approach. It's a little tricky to
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101221#comment-17101221
]
Xiening Dai commented on CALCITE-3972:
--
[~hyuan] I also gave an example in CALCITE-2970.
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101144#comment-17101144
]
Xiening Dai commented on CALCITE-3972:
--
If convention is considered as part of the config, then it
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiening Dai updated CALCITE-3963:
-
Summary: Maintain logical properties at RelSet (equivalent group) instead
of RelNode (was:
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100431#comment-17100431
]
Xiening Dai commented on CALCITE-2970:
--
Also the RelBuilder is not immutable today. The stack can
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100427#comment-17100427
]
Xiening Dai commented on CALCITE-2970:
--
{quote}
It's not about the overhead of object creation.
Xiening Dai created CALCITE-3972:
Summary: Allow RelBuilder to create RelNode with convention and
use it for trait convert
Key: CALCITE-3972
URL: https://issues.apache.org/jira/browse/CALCITE-3972
[
https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiening Dai reassigned CALCITE-3972:
Assignee: Xiening Dai
> Allow RelBuilder to create RelNode with convention and use it
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100223#comment-17100223
]
Xiening Dai commented on CALCITE-2970:
--
It would have been easier if Java supports "const T &"
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099490#comment-17099490
]
Xiening Dai commented on CALCITE-2970:
--
Will create a new JIRA.
{quote}
Struct's constructor
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099402#comment-17099402
]
Xiening Dai commented on CALCITE-2970:
--
I don't think we would ever put it into Calcite - it's a
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099395#comment-17099395
]
Xiening Dai commented on CALCITE-2970:
--
{quote}Out of curiosity can you explain at which point you
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099212#comment-17099212
]
Xiening Dai commented on CALCITE-2970:
--
{quote}
The example outlined by Xiening Dai previously
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098245#comment-17098245
]
Xiening Dai commented on CALCITE-2970:
--
hi [~zabetak], if I understand correctly, if we want to
[
https://issues.apache.org/jira/browse/CALCITE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097074#comment-17097074
]
Xiening Dai commented on CALCITE-3923:
--
I am thinking about this. Once we have the RelBuilder
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097015#comment-17097015
]
Xiening Dai commented on CALCITE-3963:
--
{quote}We shouldn't rely on the first rel or subset's
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097006#comment-17097006
]
Xiening Dai commented on CALCITE-3963:
--
What I mean by "maintain" is more about associating these
Xiening Dai created CALCITE-3963:
Summary: Maintains logical properties at RelSet (equivalent group)
instead of RelNode
Key: CALCITE-3963
URL: https://issues.apache.org/jira/browse/CALCITE-3963
[
https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiening Dai reassigned CALCITE-3963:
Assignee: Xiening Dai
> Maintains logical properties at RelSet (equivalent group)
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095895#comment-17095895
]
Xiening Dai commented on CALCITE-2970:
--
Yes, the #1 point I mentioned. If there's a sub-class
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094107#comment-17094107
]
Xiening Dai commented on CALCITE-2970:
--
[~hyuan] [~julianhyde] I've updated the PR based on
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089171#comment-17089171
]
Xiening Dai commented on CALCITE-2970:
--
Hi [~julianhyde], I am not sure I understand. Do you mean
[
https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088864#comment-17088864
]
Xiening Dai commented on CALCITE-3927:
--
Creating test cases by analyzing the code is totally
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088048#comment-17088048
]
Xiening Dai commented on CALCITE-2970:
--
Thanks [~hyuan] [~julianhyde]. I am working on the
[
https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084302#comment-17084302
]
Xiening Dai commented on CALCITE-3927:
--
Can we come up with a test case? Just try to assess the
[
https://issues.apache.org/jira/browse/CALCITE-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082810#comment-17082810
]
Xiening Dai commented on CALCITE-3917:
--
We can't because the penalty doesn't prevent it from being
[
https://issues.apache.org/jira/browse/CALCITE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiening Dai reassigned CALCITE-3915:
Assignee: Xiening Dai
> Add rule listener to report rule attempts and time at DEBUG log
[
https://issues.apache.org/jira/browse/CALCITE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiening Dai updated CALCITE-3915:
-
Comment: was deleted
(was: The example in the description is messed up due to the indents. We
[
https://issues.apache.org/jira/browse/CALCITE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081075#comment-17081075
]
Xiening Dai commented on CALCITE-3915:
--
The example in the description is messed up due to the
Xiening Dai created CALCITE-3915:
Summary: Add rule listener to report rule attempts and time at
DEBUG log level
Key: CALCITE-3915
URL: https://issues.apache.org/jira/browse/CALCITE-3915
Project:
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077668#comment-17077668
]
Xiening Dai commented on CALCITE-2970:
--
I think whether or not the implementation should/can do
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077486#comment-17077486
]
Xiening Dai commented on CALCITE-2970:
--
{quote}
Note that you can create a physical RelBulder by
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076923#comment-17076923
]
Xiening Dai commented on CALCITE-2970:
--
[~hyuan] I have to admit that your proposal would simply
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076893#comment-17076893
]
Xiening Dai commented on CALCITE-2970:
--
Thanks [~danny0405] for the feedback. My comments inline -
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076710#comment-17076710
]
Xiening Dai commented on CALCITE-2970:
--
By the way, I am not re-inventing RelBuilder. I just
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076709#comment-17076709
]
Xiening Dai commented on CALCITE-2970:
--
Such interface already exists - which is the
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069128#comment-17069128
]
Xiening Dai commented on CALCITE-2970:
--
[~hyuan][~zabetak][~julianhyde] I create a pull request
[
https://issues.apache.org/jira/browse/CALCITE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066260#comment-17066260
]
Xiening Dai commented on CALCITE-3479:
--
[~neoremind] CALCITE-2166 is not fixed completely. In
[
https://issues.apache.org/jira/browse/CALCITE-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062975#comment-17062975
]
Xiening Dai commented on CALCITE-3865:
--
I can see the issue with column mapping here. But why do
[
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062027#comment-17062027
]
Xiening Dai commented on CALCITE-2970:
--
I am working on #2, will have a proposal soon.
>
[
https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050501#comment-17050501
]
Xiening Dai commented on CALCITE-3836:
--
[~rubenql] You are right. I read HotSpot biased lock
[
https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049972#comment-17049972
]
Xiening Dai commented on CALCITE-3836:
--
[~danny0405] this article says - "simply asking for the
[
https://issues.apache.org/jira/browse/CALCITE-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048770#comment-17048770
]
Xiening Dai commented on CALCITE-3836:
--
[~danny0405] how does this would benefit multi threading?
[
https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048083#comment-17048083
]
Xiening Dai commented on CALCITE-3827:
--
We can just use one hash map, which maps vertex to a pair
[
https://issues.apache.org/jira/browse/CALCITE-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047855#comment-17047855
]
Xiening Dai commented on CALCITE-3827:
--
There shouldn't be too much overhead. Every edge contains
[
https://issues.apache.org/jira/browse/CALCITE-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044962#comment-17044962
]
Xiening Dai commented on CALCITE-3821:
--
* I should have update the comments. Sorry, will do in
[
https://issues.apache.org/jira/browse/CALCITE-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiening Dai updated CALCITE-3821:
-
Description: The check of containsMultiset() is shortcut by a "false"
constant. Also what the
Xiening Dai created CALCITE-3821:
Summary: RelOptUtil::containsMultisetOrWindowedAgg doesn't really
check multiset
Key: CALCITE-3821
URL: https://issues.apache.org/jira/browse/CALCITE-3821
Project:
Xiening Dai created CALCITE-3807:
Summary: checkForSatisfiedConverters() is unnecessary
Key: CALCITE-3807
URL: https://issues.apache.org/jira/browse/CALCITE-3807
Project: Calcite
Issue
[
https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035851#comment-17035851
]
Xiening Dai commented on CALCITE-3786:
--
Agree with [~hyuan]. The only benefit of digest is because
[
https://issues.apache.org/jira/browse/CALCITE-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiening Dai reopened CALCITE-3713:
--
The fix incurs performance overhead when using mapDigestToVertex,
mapDigestToRel, since now the
Xiening Dai created CALCITE-3785:
Summary: HepPlanner.belongToDag() doesn't have to use
mapDigestToVertex
Key: CALCITE-3785
URL: https://issues.apache.org/jira/browse/CALCITE-3785
Project: Calcite
Xiening Dai created CALCITE-3768:
Summary: VolcanoPlanner.changeTraitsUsingConverters() has
parameter that's never used
Key: CALCITE-3768
URL: https://issues.apache.org/jira/browse/CALCITE-3768
[
https://issues.apache.org/jira/browse/CALCITE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027058#comment-17027058
]
Xiening Dai commented on CALCITE-3753:
--
{quote}
Roman Kondakov Calcite's engine always had the
[
https://issues.apache.org/jira/browse/CALCITE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017342#comment-17017342
]
Xiening Dai commented on CALCITE-3676:
--
Ok, that is a good workaround for now.
I am using our own
[
https://issues.apache.org/jira/browse/CALCITE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016185#comment-17016185
]
Xiening Dai commented on CALCITE-3676:
--
Any progress on this, [~vladimirsitnikov] ? I have to
[
https://issues.apache.org/jira/browse/CALCITE-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010880#comment-17010880
]
Xiening Dai commented on CALCITE-2166:
--
[~rubenql] No, part of the fix of CALCITE-3479 was to
[
https://issues.apache.org/jira/browse/CALCITE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989097#comment-16989097
]
Xiening Dai commented on CALCITE-2223:
--
[~volodymyr] [~vladimirsitnikov] Thanks for your
[
https://issues.apache.org/jira/browse/CALCITE-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988262#comment-16988262
]
Xiening Dai commented on CALCITE-2223:
--
I am not able to reproduce this on the latest master.
>
[
https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978665#comment-16978665
]
Xiening Dai commented on CALCITE-3503:
--
I explained this before. The reason to create a new MQ
[
https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977955#comment-16977955
]
Xiening Dai edited comment on CALCITE-3503 at 11/20/19 12:53 AM:
-
[
https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977955#comment-16977955
]
Xiening Dai commented on CALCITE-3503:
--
{quote}I don't think it is meaningless to do `isValid()`
[
https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976087#comment-16976087
]
Xiening Dai commented on CALCITE-3503:
--
As I've mentioned multiple times, it's meaningless to do
[
https://issues.apache.org/jira/browse/CALCITE-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974834#comment-16974834
]
Xiening Dai commented on CALCITE-3491:
--
Yes, you can open a JIRA. From what I can tell, the other
[
https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974447#comment-16974447
]
Xiening Dai commented on CALCITE-3503:
--
I have a PR out -
[
https://issues.apache.org/jira/browse/CALCITE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973992#comment-16973992
]
Xiening Dai commented on CALCITE-3503:
--
Adding a quick check would just fix it -
if (root ==
1 - 100 of 154 matches
Mail list logo
