[GitHub] carbondata pull request #2274: [CARBONDATA-2440] default value of ENABLE_OFF...

2018-05-11 Thread rahulforallp
Github user rahulforallp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2274#discussion_r187533693 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -340,7 +342,13 @@ private CarbonLoadModel

[GitHub] carbondata pull request #2274: [CARBONDATA-2440] default value of ENABLE_OFF...

2018-05-11 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2274#discussion_r187530598 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -340,7 +342,13 @@ private CarbonLoadModel

[GitHub] carbondata pull request #2274: [CARBONDATA-2440] default value of ENABLE_OFF...

2018-05-10 Thread rahulforallp
Github user rahulforallp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2274#discussion_r187368858 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -340,7 +342,13 @@ private CarbonLoadModel

[GitHub] carbondata pull request #2274: [CARBONDATA-2440] default value of ENABLE_OFF...

2018-05-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2274#discussion_r186921945 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -340,7 +342,13 @@ private CarbonLoadModel

[GitHub] carbondata pull request #2274: [CARBONDATA-2440] default value of ENABLE_OFF...

2018-05-06 Thread rahulforallp
GitHub user rahulforallp opened a pull request: https://github.com/apache/carbondata/pull/2274 [CARBONDATA-2440] default value of ENABLE_OFFHEAP_SORT for sdk set as false Be sure to do all of the following checklist to help us incorporate your contribution quickly