[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-08 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r200843765 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -53,11 +60,75 @@ public int

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-08 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r200843282 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java --- @@ -359,38 +412,36 @@ public void

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-08 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r200842962 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -53,11 +60,75 @@ public int

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-05 Thread sounakr
GitHub user sounakr reopened a pull request: https://github.com/apache/carbondata/pull/2417 [WIP][Complex Column Enhancements]Primitive DataType Adaptive Encoding Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily:

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-05 Thread sounakr
Github user sounakr closed the pull request at: https://github.com/apache/carbondata/pull/2417 ---

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-05 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r200320193 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -3177,4 +3177,34 @@ public static void

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-05 Thread dhatchayani
Github user dhatchayani commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r200307851 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java --- @@ -3177,4 +3177,34 @@ public static void

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r199482930 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java --- @@ -161,14 +174,16 @@ private static

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r199481217 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -77,14 +127,70 @@ public boolean

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-07-02 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r199481192 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -30,32 +40,72 @@ public

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r199081933 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -405,13 +446,30 @@ public void putData(int rowId, Object

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r199081333 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java --- @@ -58,16 +67,36 @@ public static

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r199081394 --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java --- @@ -436,10 +436,11 @@ public static boolean

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r199081355 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java --- @@ -354,6 +341,18 @@ public EncodedTablePage

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-29 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r199081296 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java --- @@ -38,6 +38,15 @@ import

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198877123 --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java --- @@ -436,10 +436,11 @@ public static boolean

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198877038 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java --- @@ -354,6 +341,18 @@ public EncodedTablePage

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198874999 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java --- @@ -58,16 +67,36 @@ public static

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198874161 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java --- @@ -38,6 +38,15 @@ import

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198873521 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/LazyColumnPage.java --- @@ -283,16 +283,16 @@ public byte getByte(int rowId)

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198872182 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -405,13 +446,30 @@ public void putData(int rowId,

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198872075 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java --- @@ -405,13 +446,30 @@ public void putData(int rowId,

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198868873 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -77,14 +134,115 @@ public boolean

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198867991 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -77,14 +134,115 @@ public boolean

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198866126 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -17,45 +17,102 @@ package

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198865395 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -77,14 +134,115 @@ public boolean

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198864334 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -77,14 +134,115 @@ public boolean

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198864176 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -77,14 +134,115 @@ public boolean

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198864088 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -77,14 +134,115 @@ public boolean

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198861716 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -17,45 +17,102 @@ package

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198861844 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -17,45 +17,102 @@ package

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198861537 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java --- @@ -17,45 +17,102 @@ package

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-28 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2417#discussion_r198857878 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/CompressedDimensionChunkFileBasedReaderV3.java --- @@

[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

2018-06-26 Thread sounakr
GitHub user sounakr opened a pull request: https://github.com/apache/carbondata/pull/2417 [WIP][Complex Column Enhancements]Primitive DataType Adaptive Encoding Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: -