Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2725
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218298762
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1831,6 +1831,16 @@
public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218298776
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/DataRefNode.java ---
@@ -125,4 +125,12 @@ DimensionRawColumnChunk
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218298749
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapRowIndexes.java
---
@@ -40,12 +40,14 @@
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218273696
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1831,6 +1831,16 @@
public static
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218273764
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/DataRefNode.java ---
@@ -125,4 +125,12 @@ DimensionRawColumnChunk
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218274542
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapRowIndexes.java
---
@@ -40,12 +40,14 @@
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218139529
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/DataRefNode.java ---
@@ -125,4 +125,12 @@ DimensionRawColumnChunk
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218139409
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java
---
@@ -194,9 +198,12 @@
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218139494
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataRefNode.java
---
@@ -133,6 +134,21 @@
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218139378
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
---
@@ -122,11 +122,11 @@ public boolean
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218139444
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -108,10 +108,13 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218139467
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/index/BlockletIndex.java
---
@@ -75,4 +80,12 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218138883
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonMetadataUtil.java ---
@@ -250,6 +275,42 @@ public static BlockletIndex
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218066737
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonMetadataUtil.java ---
@@ -250,6 +275,42 @@ public static BlockletIndex
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218062043
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java
---
@@ -194,9 +198,12 @@
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218062180
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
---
@@ -122,11 +122,11 @@ public boolean
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218061484
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -108,10 +108,13 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218060271
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/index/BlockletIndex.java
---
@@ -75,4 +80,12 @@ public void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218059894
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataRefNode.java
---
@@ -133,6 +134,21 @@
return
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2725#discussion_r218048262
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/DataRefNode.java ---
@@ -125,4 +125,12 @@ DimensionRawColumnChunk
21 matches
Mail list logo
