Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244947464
--- Diff: store/CSDK/test/main.cpp ---
@@ -709,6 +709,7 @@ bool testWithTableProperty(JNIEnv *env, char *path, int
argc, char **argv) {
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244946154
--- Diff: store/CSDK/test/main.cpp ---
@@ -546,7 +546,7 @@ bool testWriteData(JNIEnv *env, char *path, int argc,
char *argv[]) {
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244945691
--- Diff: store/CSDK/test/main.cpp ---
@@ -853,7 +854,7 @@ int main(int argc, char *argv[]) {
} else {
int batch = 32000;
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244915526
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -291,9 +291,6 @@ void CarbonWriter::localDictionaryThreshold(int
localDictionaryThreshold) {
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244908015
--- Diff: store/CSDK/test/main.cpp ---
@@ -709,6 +709,7 @@ bool testWithTableProperty(JNIEnv *env, char *path, int
argc, char **argv) {
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244907927
--- Diff: store/CSDK/test/main.cpp ---
@@ -546,7 +546,7 @@ bool testWriteData(JNIEnv *env, char *path, int argc,
char *argv[]) {
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244907282
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -291,9 +291,6 @@ void CarbonWriter::localDictionaryThreshold(int
localDictionaryThreshold) {
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244907183
--- Diff: store/CSDK/test/main.cpp ---
@@ -853,7 +854,7 @@ int main(int argc, char *argv[]) {
} else {
int batch = 32000;
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/3035
[CARBONDATA-3216] Fix some bugs in CSDK
1.enableLocalDictionary can' t set false
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and
