[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532620944 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532663075 ## File path: integration/spark/src/test/scala/org/apache/carbondata/geo/GeoTest.scala ## @@ -276,17 +274,14 @@ class GeoTest extends QueryTest

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532665839 ## File path: integration/spark/src/test/scala/org/apache/carbondata/geo/GeoTest.scala ## @@ -354,16 +349,12 @@ class GeoTest extends QueryTest

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4015: [CARBONDATA-4052] Handled insert overwrite scenario for SI

2020-11-30 Thread GitBox
akashrn5 commented on a change in pull request #4015: URL: https://github.com/apache/carbondata/pull/4015#discussion_r532701657 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/index/CarbonIndexUtil.scala ## @@ -299,6 +300,13 @@ object CarbonIndexUtil {

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4026: [CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#issuecomment-735701479 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3218/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532495549 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoHashUtils.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532711858 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532614945 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] Kejian-Li commented on pull request #4026: [CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions

2020-11-30 Thread GitBox
Kejian-Li commented on pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#issuecomment-735804531 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532630913 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532637439 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/filter/executor/PolygonFilterExecutorImpl.java ## @@ -73,8 +77,24 @@ private int

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532640192 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
akashrn5 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r532675730 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4025: [WIP] Make TableStatus/UpdateTableStatus/SegmentFile Smaller

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4025: URL: https://github.com/apache/carbondata/pull/4025#issuecomment-735874956 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3222/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532614945 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4025: [WIP] Make TableStatus/UpdateTableStatus/SegmentFile Smaller

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4025: URL: https://github.com/apache/carbondata/pull/4025#issuecomment-735874480 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4977/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532710929 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] Zhangshunyu commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
Zhangshunyu commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r532405435 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/MajorCompactionIgnoreInMinorTest.scala ## @@

[GitHub] [carbondata] Zhangshunyu commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
Zhangshunyu commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r532405537 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala ## @@ -191,6

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-735676431 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4971/

[GitHub] [carbondata] Zhangshunyu commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
Zhangshunyu commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r532406054 ## File path: docs/dml-of-carbondata.md ## @@ -529,6 +529,10 @@ CarbonData DML statements are documented here,which includes: * Level 1:

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4000: [CARBONDATA-4020] Fixed drop index when multiple index exists

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4000: URL: https://github.com/apache/carbondata/pull/4000#issuecomment-735637553 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4969/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4030: [CARBONDATA-4064] Fix tpcds query failure with SI

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4030: URL: https://github.com/apache/carbondata/pull/4030#issuecomment-735650739 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4970/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
vikramahuja1001 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r532412599 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4026: [WIP] blockid code clean

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#issuecomment-735636724 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4972/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4000: [CARBONDATA-4020] Fixed drop index when multiple index exists

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4000: URL: https://github.com/apache/carbondata/pull/4000#issuecomment-735640398 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3214/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532442900 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoHashUtils.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] Zhangshunyu commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
Zhangshunyu commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r532405803 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ## @@ -292,6 +293,33 @@ object CommonUtil {

[GitHub] [carbondata] Zhangshunyu commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
Zhangshunyu commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r532405630 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala ## @@ -292,6 +293,33 @@ object CommonUtil {

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4026: [WIP] blockid code clean

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#issuecomment-735636334 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3217/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4030: [CARBONDATA-4064] Fix tpcds query failure with SI

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4030: URL: https://github.com/apache/carbondata/pull/4030#issuecomment-735651850 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3215/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-735679565 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3216/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4025: [WIP] Make TableStatus/UpdateTableStatus/SegmentFile Smaller

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4025: URL: https://github.com/apache/carbondata/pull/4025#issuecomment-735714775 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4974/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
vikramahuja1001 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r532538210 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
vikramahuja1001 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r532537780 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -2086,6 +2087,41 @@ public int

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532606936 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4026: [CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4026: URL: https://github.com/apache/carbondata/pull/4026#issuecomment-735694164 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4973/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532495549 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoHashUtils.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532569787 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonListExpression.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-735776525 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3221/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532495549 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoHashUtils.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532524051 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoOperationType.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532524051 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoOperationType.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
vikramahuja1001 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r532539140 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532541638 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonListExpression.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532546661 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-735720446 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4975/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-735722366 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3220/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-735774065 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4976/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532607226 ## File path: geo/src/main/java/org/apache/carbondata/geo/GeoConstants.java ## @@ -26,4 +26,34 @@ private GeoConstants() { // GeoHash type

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4025: [WIP] Make TableStatus/UpdateTableStatus/SegmentFile Smaller

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4025: URL: https://github.com/apache/carbondata/pull/4025#issuecomment-735714585 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3219/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532546661 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonRangeListExpression.java ## @@ -0,0 +1,211 @@ +/* + * Licensed

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532541638 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonListExpression.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532547569 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolylineListExpression.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
vikramahuja1001 commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r532749779 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532715580 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolylineListExpression.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
VenuReddy2103 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r532569787 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonListExpression.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to

[GitHub] [carbondata] akkio-97 opened a new pull request #4031: Presto UT optimization

2020-11-30 Thread GitBox
akkio-97 opened a new pull request #4031: URL: https://github.com/apache/carbondata/pull/4031 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4004: [WIP] update actomity

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4004: URL: https://github.com/apache/carbondata/pull/4004#issuecomment-735943690 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4978/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-735972783 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4979/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-735973871 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3224/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4004: [WIP] update actomity

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4004: URL: https://github.com/apache/carbondata/pull/4004#issuecomment-735944674 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3223/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
akashrn5 commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r532795309 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -998,6 +998,33 @@ public long getMajorCompactionSize()

[GitHub] [carbondata] akashrn5 commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

2020-11-30 Thread GitBox
akashrn5 commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-735967954 @Kejian-Li please add a detailed explanation of issue and the solution in PR description. This is an

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4031: Presto UT optimization

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#issuecomment-736092041 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4980/

[GitHub] [carbondata] Zhangshunyu commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
Zhangshunyu commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-736162189 @akashrn5 @ajantha-bhat fixed all review comments, pls check. This is an automated message from the

[GitHub] [carbondata] QiangCai commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
QiangCai commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533028217 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [carbondata] QiangCai commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
QiangCai commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533026365 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -2086,6 +2087,49 @@ public int

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-736195578 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3227/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4031: Presto UT optimization

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#issuecomment-736094188 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3225/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-736194768 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4982/

[GitHub] [carbondata] QiangCai commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
QiangCai commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533026831 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -2086,6 +2087,49 @@ public int

[GitHub] [carbondata] QiangCai commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
QiangCai commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533026831 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -2086,6 +2087,49 @@ public int

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
ajantha-bhat commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r533036780 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -998,6 +998,31 @@ public long

[GitHub] [carbondata] QiangCai commented on a change in pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
QiangCai commented on a change in pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#discussion_r533016768 ## File path: core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java ## @@ -183,16 +186,18 @@ private static boolean

[GitHub] [carbondata] Zhangshunyu commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
Zhangshunyu commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r533018015 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -998,6 +998,33 @@ public long

[GitHub] [carbondata] Zhangshunyu commented on a change in pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
Zhangshunyu commented on a change in pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#discussion_r533040901 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -998,6 +998,31 @@ public long

[GitHub] [carbondata] QiangCai commented on pull request #4005: [CARBONDATA-3978] Trash Folder support in carbondata

2020-11-30 Thread GitBox
QiangCai commented on pull request #4005: URL: https://github.com/apache/carbondata/pull/4005#issuecomment-736166552 After you force push the old commit, I don't know what is your change for my review. Better to add a new commit instead of merging into the old commit.

[GitHub] [carbondata] Zhangshunyu commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
Zhangshunyu commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-736195948 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-736225542 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4983/

[GitHub] [carbondata] brijoobopanna commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

2020-11-30 Thread GitBox
brijoobopanna commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-736288833 Thanks for your contribution, please raise disucssion in communtiy and get the design approved

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4020: [CARBONDATA-4054] Support data size control for minor compaction

2020-11-30 Thread GitBox
CarbonDataQA2 commented on pull request #4020: URL: https://github.com/apache/carbondata/pull/4020#issuecomment-736228088 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3228/

[GitHub] [carbondata] Indhumathi27 commented on pull request #4000: [CARBONDATA-4020] Fixed drop index when multiple index exists

2020-11-30 Thread GitBox
Indhumathi27 commented on pull request #4000: URL: https://github.com/apache/carbondata/pull/4000#issuecomment-736216044 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] ajantha-bhat commented on pull request #4030: [CARBONDATA-4064] Fix tpcds query failure with SI

2020-11-30 Thread GitBox
ajantha-bhat commented on pull request #4030: URL: https://github.com/apache/carbondata/pull/4030#issuecomment-736230509 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on