Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/3023
Besides, I think the title of the PR can be optimized to 'Include the
merging bloomindex procedure in data loading transaction' -- just for your
reference
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r245469143
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala
---
@@ -24,59 +24,96 @@ import
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r245469279
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala
---
@@ -24,59 +24,96 @@ import
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3023#discussion_r245469201
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
@@ -184,6 +184,9 @@ object CarbonEnv {
[
https://issues.apache.org/jira/browse/CARBONDATA-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liang Chen updated CARBONDATA-2420:
---
Fix Version/s: (was: 1.4.1)
1.5.2
> Support string longer than
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3048
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10427/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3048
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2386/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1933
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10426/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3048
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2171/
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245336706
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -179,7 +182,8 @@ public CarbonWriterBuilder
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3001
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10425/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3001
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2385/
---
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245328731
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -179,7 +182,8 @@ public CarbonWriterBuilder
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3050#discussion_r245328482
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapFactory.java
---
@@ -57,7 +57,7 @@ public
[
https://issues.apache.org/jira/browse/CARBONDATA-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 resolved CARBONDATA-3226.
-
Resolution: Resolved
> Remove duplicated and useless files
>
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3049
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/3032
Just some nit comments, and others LGTM
---
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r245324988
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -108,13 +113,45 @@ object CarbonSparkUtil {
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3032#discussion_r245324728
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/util/CarbonSparkUtil.scala
---
@@ -30,6 +31,10 @@ import
[
https://issues.apache.org/jira/browse/CARBONDATA-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 reassigned CARBONDATA-3213:
---
Assignee: chenzhenhua
> Add License for all doc
>
>
>
[
https://issues.apache.org/jira/browse/CARBONDATA-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 resolved CARBONDATA-3213.
-
Resolution: Resolved
> Add License for all doc
>
>
>
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/3049
LGTM!
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3050
@bbinwang Please optimize the title to:[CARBONDATA-3211] Optimize the
documentation
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 reassigned CARBONDATA-3211:
---
Assignee: wangbin
> Optimize the documentation
> --
>
>
[
https://issues.apache.org/jira/browse/CARBONDATA-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 reassigned CARBONDATA-3227:
---
Assignee: Bellamy Yi
> There are some spell errors in the project
>
[
https://issues.apache.org/jira/browse/CARBONDATA-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 reassigned CARBONDATA-3228:
---
Assignee: liangxiongwei
> Optimize import and fix some spell errors
>
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3024
@KanakaKumar @ravipesala Please review it.
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3001
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2170/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3024
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10424/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3024
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2384/
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3049
LGTM! Thanks for your contribution!
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3051
@KanakaKumar @kunal642 @jackylk @QiangCai @zzcclp @ravikiran23 Please
review it.
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3014
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10423/
---
Github user runzhliu commented on the issue:
https://github.com/apache/carbondata/pull/3049
@xubo245 I have checked the whole projects, there are those two duplicated
files.
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3029
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10422/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3024
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2169/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3010
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2382/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3029
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2380/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3010
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10421/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3047
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10420/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3047
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2379/
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3024
@ravipesala add test case in this PR:
1.add column
2.drop column
3.rename column
4.change datatype of column
Add test case for carbon and parquet.
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3014
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2381/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3010
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2168/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3014
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2167/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3029
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2166/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2971
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10418/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2971
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2377/
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245275753
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245275437
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245274310
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245274147
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245273039
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3045#discussion_r245272931
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
---
@@ -110,22
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3047
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2165/
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kumar vishal resolved CARBONDATA-3217.
--
Resolution: Fixed
Assignee: Manish Gupta
> Optimize implicit filter
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3044
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3014
retest this please
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3029
retest this please
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3010
retest this please
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3039
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/3039
LGTM
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/3048
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3051
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2376/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3051
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10417/
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/3044
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3044
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10415/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2971
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2164/
---
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/2971
@ravipesala @kumarvishal09
please review again.
---
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2971#discussion_r245260405
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
---
@@ -156,4 +161,206 @@
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3044
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2374/
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3035
---
xubo245 created CARBONDATA-3230:
---
Summary: Add ALTER test case with datasource for using parquet
and carbon
Key: CARBONDATA-3230
URL: https://issues.apache.org/jira/browse/CARBONDATA-3230
Project:
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/3039
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2971
Build Success with Spark 2.3.2, Please check CI
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10413/
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245252822
--- Diff: store/CSDK/test/main.cpp ---
@@ -526,6 +526,71 @@ void testCarbonProperties(JNIEnv *env) {
}
}
+bool
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2971
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2372/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3051
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2163/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3051
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2162/
---
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/3035
LGTM
---
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3048#discussion_r245246228
--- Diff: store/CSDK/test/main.cpp ---
@@ -526,6 +526,71 @@ void testCarbonProperties(JNIEnv *env) {
}
}
+bool
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3044
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2161/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3051
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2160/
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3050#discussion_r245244853
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapFactory.java
---
@@ -57,7 +57,7 @@ public
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/3051
[CARBONDATA-3221] Fix the error of SDK don't support read multiple file
from S3
SDK reader is ok with filter, but when we read data without filter, the
((CarbonInputSplit)
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2971
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2159/
---
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/2971
@ravipesala
After the compaction, it will become local_sort.
In my opinion, we can use Range_column to partition the input data.
So it can reduce the scope of sorting during data
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2971#discussion_r245237625
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
---
@@ -156,4 +161,206 @@
Github user kevinjmh commented on the issue:
https://github.com/apache/carbondata/pull/2973
I test this PR by running `CarbonSessionExample`. Please check following
exception:
```
java.lang.ClassCastException:
org.apache.spark.sql.catalyst.catalog.ExternalCatalogWithListener
89 matches
Mail list logo
