Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1032
Not required as partition feature is re-implemented.
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1830
[CARBONDATA-2051] Added like query ends with and contains with filter push
down suport to carbondata
**Problem**
Current like filter with start with expression is only pushed down
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1810#discussion_r162253805
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -598,16 +627,16 @@ public boolean
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1813#discussion_r161963254
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/NonDictionaryFieldConverterImpl.java
---
@@ -70,13
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1818
[CARBONDATA-2020][Old Store Support] Add filter support for old store
reading to improve query performance
**Problem**
For old stores blocklet level min/max comparison
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1789
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1810#discussion_r161739311
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -604,18 +731,26 @@ private
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1785
LGTM
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1796
[WIP] Modified code to add relative blocklet id during initialization in
the blocklet data map
Modified code to add relative blocklet id during initialization in the
blocklet data map
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1769
LGTM...will merge once all build run
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1785#discussion_r161144886
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -113,6 +113,9 @@ object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1785#discussion_r161144455
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataGeneral.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1785#discussion_r161144939
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataGeneral.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1785#discussion_r161144435
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestLoadDataGeneral.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1769#discussion_r161143694
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -251,7 +255,9
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1782
@ravipesala ..handled review comments...kindly review and merge
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1782
retest sdv please
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1782
[WIP] Changes for creating carbon index merge file from old store which did
not contain the blocklet info in index information
Changes for creating carbon index merge file from old store
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1702
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1718
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1734
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1734
LGTMwill merge after all builds run
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1760
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1740
LGTM..I will merge once all build complete
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1747#discussion_r159589331
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -231,7 +231,22 @@ public String getSchemaFilePath
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1747#discussion_r159589266
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -291,4 +291,52 @@ object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1747#discussion_r159589250
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -291,4 +291,52 @@ object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1082#discussion_r159586543
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
---
@@ -145,6 +147,15 @@ public static
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1082#discussion_r159584326
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/badrecordloger/BadRecordLoggerTest.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1732#discussion_r159585172
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -775,4 +775,25 @@ public static DataType valueOf(String
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1732#discussion_r159585515
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/vectorreader/ChangeDataTypeTestCases.scala
---
@@ -164,6
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1754
LGTM...please attach the test results snapshots when the jira and github
issue is resolved
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1734
@ManoharVanam ...In that case can we change the logger error to warning in
case of non existence of file and check whether still the warning log is
getting printed. If warning logs
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1740
@geetikagupta16 Can you please add a test case for describe formatted
command wherein you can take all the rows from 1st column and assert for total
rows and match each row value
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1734
@ManoharVanam...what is need of releasing the locks in catch block when
finally block assures that lock is released?
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1732
retest this please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1718
@mohammadshahidkhan ..IDG update is required for the min and max values of
the properties in this PR
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1703
@dhatchayani ...From my perspective I think this PR is not required. This
is a case when user deletes the dictionary and sort index file intentionally
from back end from the system
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1723
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1732
retest this please
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1732
[WIP] Fixed select query failure after alter change data type operation for
dictionary exclude columns
Fixed select query failure after alter change data type operation for
dictionary
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1721
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1708
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1715
retest this please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1708
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1696
LGTM
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1715
[CARBONDATA-1934] Incorrect results are returned by select query in case
when the number of blocklets for one part file are > 1 in the same task
Problem: When a select query is trigge
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1311
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1126
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1311
retest this please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1670
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1670
LGTM...once build runs I will merge
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1676
@xubo245 ..actual modification of code is in 2-3 files, remaining files
have been modified for import changes..kindly revert unwanted file changes
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1670#discussion_r157947962
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/ConcurrencyTest.scala
---
@@ -0,0 +1,355 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1670#discussion_r157947459
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/ConcurrencyTest.scala
---
@@ -0,0 +1,355 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1670#discussion_r157946201
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/ConcurrencyTest.scala
---
@@ -0,0 +1,355 @@
+/*
+ * Licensed
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1670
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1126
retest this please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1679
@kumarvishal09 ..please review
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1679
[CARBONDATA-1907] Avoid unnecessary logging to improve query performance
for no dictionary non string columns
Changes done to return null in case of no dictionary column for non string
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1666
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1126
Correct the PR header also...remove dots from the end and put a proper
message
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1126#discussion_r157700973
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/DateDirectDictionaryGenerator.java
---
@@ -42,12
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1665
retest this please
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1665#discussion_r157405351
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetaStore.scala
---
@@ -144,6 +145,15 @@ trait CarbonMetaStore
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1311
retest this please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1641
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1167
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1653
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1665
retest this please
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1665
[CARBONDATA-1884] Add CTAS support to carbondata
Implemented CTAS feature in carbondata. This will hep to create a carbon
table from other parquet/orc tables.
- [ ] Any
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1167#discussion_r157133954
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/TestUpdateCarbonTableWithPersistFalse.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1167#discussion_r157133997
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/TestUpdateCarbonTableWithSinglePass.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1167#discussion_r157134388
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
@@ -314,14 +315,19
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1663
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157009066
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r157009247
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadOptions.scala
---
@@ -0,0 +1,83
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r156958685
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -932,6 +958,11 @@ abstract class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1632#discussion_r156954293
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
---
@@ -121,17 +121,18
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1632#discussion_r156919460
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/NonDictionaryUtil.java ---
@@ -108,60 +105,21 @@ public static Object getMeasure(int
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1311
@shivangi1015 ...kindly rebase this PR..it has merge conflicts
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1655
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1653#discussion_r156888264
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -871,6 +871,32 @@ abstract class
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1637
retest sdv please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1643
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1622
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1646
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1627
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1630
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1643#discussion_r156416528
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1630#discussion_r156305867
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
---
@@ -175,6 +175,15 @@ object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1627#discussion_r156275385
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/DeleteLoadFolders.java
---
@@ -122,26 +122,21 @@ private static boolean
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1625
LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1630#discussion_r156134688
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
---
@@ -175,6 +175,17 @@ object
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1624
@ravipesala ..handled review comments..kindly review and merge
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1624
[WIP][CARBONDATA-1867] Add support for task/segment level pruning
Added support for task/segment level pruning. Added code to compute task
level min/max which can be helpful for task
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1619
[CARBONDATA-1854] Add support for implicit column filter
Added code to support implicit column filtering
- [ ] Any interfaces changed?
- [ ] Any backward
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1617
[CARBONDATA-1592] Added TaskPreSubmitExecutionEvent for any operations to
be done before submitting a task
Added TaskPreSubmitExecutionEvent for any operations to be done before
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1574
LGTM
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1561
LGMT
---
601 - 700 of 771 matches
Mail list logo
