[jira] [Created] (CARBONDATA-3249) SQL and SDK float value is different

2019-01-14 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3249: --- Summary: SQL and SDK float value is different Key: CARBONDATA-3249 URL: https://issues.apache.org/jira/browse/CARBONDATA-3249 Project: CarbonData Issue Type

[jira] [Commented] (CARBONDATA-3248) Spark carbon file format can't read transactional table segment path

2019-01-13 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741834#comment-16741834 ] xubo245 commented on CARBONDATA-3248: - LOAD DATA is not supported for datasource tables

[jira] [Created] (CARBONDATA-3248) Spark carbon file format can't read transactional table segment path

2019-01-13 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3248: --- Summary: Spark carbon file format can't read transactional table segment path Key: CARBONDATA-3248 URL: https://issues.apache.org/jira/browse/CARBONDATA-3248 Project

[GitHub] carbondata pull request #3069: [WIP][CARBONDATA-3232] Add test case for allu...

2019-01-11 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/3069 [WIP][CARBONDATA-3232] Add test case for alluxio UT Add test case for alluxio UT 1. install alluxio UT environment, start alluxio minicluster before running test case. 2. add

[GitHub] carbondata issue #3065: [HOTFIX] Optimize presto-guide

2019-01-10 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3065 I mean we need test 0.210,0.211,0.212,0.213,. when it change to 0.210+ ---

[GitHub] carbondata issue #3065: Optimize presto-guide

2019-01-10 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3065 @zzcclp I think we should test before change to 0.210+ ---

[GitHub] carbondata issue #3065: Optimize presto-guide

2019-01-10 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3065 Please optimize the title. ---

[GitHub] carbondata issue #2991: [CARBONDATA-3043] Add build script and add test case...

2019-01-10 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2991 Please fix the CI error @BJangir ---

[GitHub] carbondata issue #3033: [CARBONDATA-3215] Optimize the documentation

2019-01-10 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3033 retest this please ---

[GitHub] carbondata issue #2991: [CARBONDATA-3043] Add build script and add test case...

2019-01-10 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2991 retest this please ---

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2019-01-09 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3037 retest this please ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-09 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3032 LGTM! Thanks for you contribution! ---

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Add example and doc for all...

2019-01-08 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3054#discussion_r246280098 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/AlluxioExample.scala --- @@ -28,46 +33,86 @@ import

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Add example and doc for all...

2019-01-08 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3054#discussion_r246249496 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/AlluxioExample.scala --- @@ -28,46 +33,86 @@ import

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Add example and doc for all...

2019-01-08 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3054#discussion_r246249301 --- Diff: docs/alluxio-guide.md --- @@ -0,0 +1,42 @@ + + + +# Presto guide --- End diff -- changed ---

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2019-01-08 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3037 @KanakaKumar @ravipesala @jackylk @QiangCai @kunal642 Please review it. ---

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Add example and doc for all...

2019-01-08 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3054#discussion_r245905219 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/util/ExampleUtils.scala --- @@ -30,13 +30,20 @@ object ExampleUtils

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2019-01-08 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3037 rebased ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-07 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3032 retest this please ---

[GitHub] carbondata issue #3054: [CARBONDATA-3232] Add example and doc for alluxio in...

2019-01-07 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3054 ok, changed @chenliang613 ---

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Optimize carbonData using a...

2019-01-07 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3054#discussion_r245893919 --- Diff: README.md --- @@ -68,8 +68,8 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com * [FAQs](https

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Optimize carbonData using a...

2019-01-07 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3054#discussion_r245893905 --- Diff: docs/Integration/alluxio-guide.md --- @@ -0,0 +1,44 @@ + + + +# Presto guide +This tutorial provides a quick introduction

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Optimize carbonData using a...

2019-01-07 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3054#discussion_r245893187 --- Diff: docs/Integration/alluxio-guide.md --- @@ -0,0 +1,44 @@ + + + +# Presto guide +This tutorial provides a quick introduction

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Optimize carbonData using a...

2019-01-07 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3054#discussion_r245890480 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/util/ExampleUtils.scala --- @@ -30,13 +30,17 @@ object ExampleUtils

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Optimize carbonData using a...

2019-01-07 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3054#discussion_r245890285 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/AlluxioExample.scala --- @@ -26,48 +30,88 @@ import

[GitHub] carbondata issue #2161: [CARBONDATA-2218] AlluxioCarbonFile while trying to ...

2019-01-07 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2161 @chandrasaripaka Please add venkata...@dbs.com to your GitHub mail list. Because your commit is Chandra . ---

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2019-01-07 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r245861536 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/S3Example.scala --- @@ -18,11 +18,10 @@ package org.apache.carbondata.examples

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2019-01-07 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r245861501 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala --- @@ -28,12 +28,13 @@ import org.slf4j

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2019-01-07 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r245861440 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/S3UsingSDkExample.scala --- @@ -16,28 +16,26 @@ */ package

[jira] [Resolved] (CARBONDATA-3227) There are some spell errors in the project

2019-01-07 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 resolved CARBONDATA-3227. - Resolution: Fixed > There are some spell errors in the proj

[GitHub] carbondata issue #3050: [CARBONDATA-3211] Optimize the documentation

2019-01-07 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3050 LGTM! Thanks for you contribution! ---

[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...

2019-01-07 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3052 LGTM! Thanks for you contribution! ---

[jira] [Created] (CARBONDATA-3232) Optimize carbonData using alluxio

2019-01-07 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3232: --- Summary: Optimize carbonData using alluxio Key: CARBONDATA-3232 URL: https://issues.apache.org/jira/browse/CARBONDATA-3232 Project: CarbonData Issue Type

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Optimize carbonData using a...

2019-01-07 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/3054 [CARBONDATA-3232] Optimize carbonData using alluxio Optimize carbonData using alluxio: 1.Add doc 2.optimize the example Be sure to do all of the following checklist to help us

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2019-01-07 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3037 @KanakaKumar @ravipesala @jackylk @QiangCai @kunal642 Please review it. ---

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Optimize getVersionDetails

2019-01-07 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2919 @KanakaKumar Please review it again. ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3048 @KanakaKumar Please review it again. ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3048 retest this please ---

[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3052 @XiaotaoYi Please fix the CI errors. ---

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3037 retest this please ---

[GitHub] carbondata pull request #3050: [CARBONDATA-3211] Optimize the documentation

2019-01-06 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3050#discussion_r245534776 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapFactory.java --- @@ -57,7 +57,7 @@ public

[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3052 @XiaotaoYi Please optimize the title, like: [CARBONDATA-3227] Fix some spell errors in the project ---

[GitHub] carbondata pull request #3048: [CARBONDATA-3224] Support SDK/CSDK validate t...

2019-01-06 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3048#discussion_r245534079 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -179,7 +181,8 @@ public CarbonWriterBuilder

[GitHub] carbondata issue #3050: [CARBONDATA-3211] Optimize the documentation

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3050 add to whitelist ---

[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3052 add to whitelist ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-05 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3048 @KanakaKumar Optimized and CI pass, please check it again. ---

[GitHub] carbondata pull request #3048: [CARBONDATA-3224] Support SDK/CSDK validate t...

2019-01-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3048#discussion_r245336706 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -179,7 +182,8 @@ public CarbonWriterBuilder

[jira] [Resolved] (CARBONDATA-3226) Remove duplicated and useless files

2019-01-04 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 resolved CARBONDATA-3226. - Resolution: Resolved > Remove duplicated and useless fi

[jira] [Assigned] (CARBONDATA-3213) Add License for all doc

2019-01-04 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 reassigned CARBONDATA-3213: --- Assignee: chenzhenhua > Add License for all

[jira] [Resolved] (CARBONDATA-3213) Add License for all doc

2019-01-04 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 resolved CARBONDATA-3213. - Resolution: Resolved > Add License for all

[GitHub] carbondata issue #3050: 【CARBONDATA-3211】 Optimize the documentation

2019-01-04 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3050 @bbinwang Please optimize the title to:[CARBONDATA-3211] Optimize the documentation ---

[jira] [Assigned] (CARBONDATA-3211) Optimize the documentation

2019-01-04 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 reassigned CARBONDATA-3211: --- Assignee: wangbin > Optimize the documentat

[jira] [Assigned] (CARBONDATA-3227) There are some spell errors in the project

2019-01-04 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 reassigned CARBONDATA-3227: --- Assignee: Bellamy Yi > There are some spell errors in the proj

[jira] [Assigned] (CARBONDATA-3228) Optimize import and fix some spell errors

2019-01-04 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 reassigned CARBONDATA-3228: --- Assignee: liangxiongwei > Optimize import and fix some spell err

[GitHub] carbondata issue #3024: [CARBONDATA-3230] Add alter test case for datasource

2019-01-04 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3024 @KanakaKumar @ravipesala Please review it. ---

[GitHub] carbondata issue #3049: [CARBONDATA-3226] Remove duplicated and useless file...

2019-01-04 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3049 LGTM! Thanks for your contribution! ---

[GitHub] carbondata issue #3051: [CARBONDATA-3221] Fix the error of SDK don't support...

2019-01-04 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3051 @KanakaKumar @kunal642 @jackylk @QiangCai @zzcclp @ravikiran23 Please review it. ---

[GitHub] carbondata issue #3024: [CARBONDATA-3230] Add alter test case for datasource

2019-01-04 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3024 @ravipesala add test case in this PR: 1.add column 2.drop column 3.rename column 4.change datatype of column Add test case for carbon and parquet. ---

[jira] [Created] (CARBONDATA-3230) Add ALTER test case with datasource for using parquet and carbon

2019-01-04 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3230: --- Summary: Add ALTER test case with datasource for using parquet and carbon Key: CARBONDATA-3230 URL: https://issues.apache.org/jira/browse/CARBONDATA-3230 Project

[GitHub] carbondata pull request #3048: [CARBONDATA-3224] Support SDK/CSDK validate t...

2019-01-04 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3048#discussion_r245252822 --- Diff: store/CSDK/test/main.cpp --- @@ -526,6 +526,71 @@ void testCarbonProperties(JNIEnv *env) { } } +bool

[GitHub] carbondata pull request #3051: [CARBONDATA-3221] Fix the error of SDK don't ...

2019-01-04 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/3051 [CARBONDATA-3221] Fix the error of SDK don't support read multiple file from S3 SDK reader is ok with filter, but when we read data without filter, the ((CarbonInputSplit

[jira] [Created] (CARBONDATA-3228) Optimize import and fix some spell errors

2019-01-03 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3228: --- Summary: Optimize import and fix some spell errors Key: CARBONDATA-3228 URL: https://issues.apache.org/jira/browse/CARBONDATA-3228 Project: CarbonData Issue

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2019-01-03 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r245183568 --- Diff: docs/csdk-guide.md --- @@ -29,6 +29,32 @@ code and without CarbonSession. In the carbon jars package, there exist a carbondata

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2019-01-03 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r245183433 --- Diff: docs/csdk-guide.md --- @@ -29,6 +29,32 @@ code and without CarbonSession. In the carbon jars package, there exist a carbondata

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2019-01-03 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r245183464 --- Diff: docs/csdk-guide.md --- @@ -29,6 +29,32 @@ code and without CarbonSession. In the carbon jars package, there exist a carbondata

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2019-01-03 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r245183255 --- Diff: store/CSDK/test/main_ft.cpp --- @@ -0,0 +1,1172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] carbondata pull request #2991: [CARBONDATA-3043] Add build script and add te...

2019-01-03 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2991#discussion_r245183196 --- Diff: docs/csdk-guide.md --- @@ -29,6 +29,32 @@ code and without CarbonSession. In the carbon jars package, there exist a carbondata

[GitHub] carbondata issue #3030: [HOTFIX] Optimize the code style in csdk/sdk markdow...

2019-01-03 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3030 LGTM! Thanks for your contribution! ---

[GitHub] carbondata issue #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-03 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3035 @ajantha-bhat @KanakaKumar Please review it. ---

[jira] [Created] (CARBONDATA-3227) There are some spell errors in the project

2019-01-03 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3227: --- Summary: There are some spell errors in the project Key: CARBONDATA-3227 URL: https://issues.apache.org/jira/browse/CARBONDATA-3227 Project: CarbonData Issue

[GitHub] carbondata issue #3050: Optimize the upper/lower case problem

2019-01-03 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3050 @bbinwang Please optimize the title and content of this PR. for example: [CARBONDATA-3226] Remove duplicated and useless files ---

[GitHub] carbondata issue #3049: [CARBONDATA-3226] Remove duplicated and useless file...

2019-01-03 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3049 @runzhliu Are there any other similar files in the project? Can you help to check? ---

[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-03 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3035#discussion_r244947464 --- Diff: store/CSDK/test/main.cpp --- @@ -709,6 +709,7 @@ bool testWithTableProperty(JNIEnv *env, char *path, int argc, char **argv

[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-03 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3035#discussion_r244946154 --- Diff: store/CSDK/test/main.cpp --- @@ -546,7 +546,7 @@ bool testWriteData(JNIEnv *env, char *path, int argc, char *argv

[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-03 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3035#discussion_r244945691 --- Diff: store/CSDK/test/main.cpp --- @@ -853,7 +854,7 @@ int main(int argc, char *argv[]) { } else { int batch = 32000

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-03 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3048 @ajantha-bhat @KanakaKumar Please review it. ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-03 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3048 @ajantha-bhat a) It won't throw exception when we give invalid actions in bad record, because SDK didn't validate it. b) CarbonSession hasn't this issue because CarbonSession has

[GitHub] carbondata pull request #3048: [CARBONDATA-3224] Support SDK validate the im...

2019-01-02 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/3048 [CARBONDATA-3224] Support SDK validate the improper value when using withLoadOptions 1. validate BAD_RECORDS_ACTION 2. validate BAD_RECORDS_LOGGER_ENABLE Be sure to do all

[jira] [Created] (CARBONDATA-3224) SDK should validate the improper value

2019-01-02 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3224: --- Summary: SDK should validate the improper value Key: CARBONDATA-3224 URL: https://issues.apache.org/jira/browse/CARBONDATA-3224 Project: CarbonData Issue Type

[GitHub] carbondata issue #3035: [CARBONDATA-3216] Fix some bugs in CSDK

2019-01-02 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3035 @KanakaKumar @ajantha-bhat @jackylk @ravipesala Please review it. ---

[jira] [Created] (CARBONDATA-3221) SDK don't support read multiple file from S3

2019-01-01 Thread xubo245 (JIRA)
xubo245 created CARBONDATA-3221: --- Summary: SDK don't support read multiple file from S3 Key: CARBONDATA-3221 URL: https://issues.apache.org/jira/browse/CARBONDATA-3221 Project: CarbonData

[jira] [Resolved] (CARBONDATA-3206) Fix some spell error in CarbonData

2019-01-01 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 resolved CARBONDATA-3206. - Resolution: Resolved > Fix some spell error in CarbonD

[GitHub] carbondata issue #3042: [CARBONDATA-3206] Fix some spell error in CarbonData

2019-01-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3042 Some review comments in https://github.com/apache/carbondata/pull/3040 ---

[GitHub] carbondata issue #3042: [CARBONDATA-3206] Fix some spell error in CarbonData

2019-01-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3042 LGTM. Thanks you for your contribution. ---

[GitHub] carbondata issue #3043: [Carbondata 3213] Fix no license files

2019-01-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3043 @iture123 Thank you for working on it. ---

[GitHub] carbondata issue #3043: [Carbondata 3213] Fix no license files

2019-01-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3043 LGTM ---

[GitHub] carbondata issue #3043: Carbondata 3213

2019-01-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3043 add to whitelist ---

[GitHub] carbondata issue #3043: Carbondata 3213

2019-01-01 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3043 @iture123 Please optimize the title, like: [CARBONDATA-3182] Fixed SDV Testcase failures ---

[jira] [Resolved] (CARBONDATA-3209) Remove unused import

2018-12-31 Thread xubo245 (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xubo245 resolved CARBONDATA-3209. - Resolution: Resolved > Remove unused import > > >

[GitHub] carbondata issue #3038: [CARBONDATA-3209] Remove unused import

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 @WangGuangxin Thank you for working on it. ---

[GitHub] carbondata issue #3042: There are some spell error in CarbonData

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3042 @WangQingNa 1. Please optimize this title, for example: [CARBONDATA-3206] Fix some spell errors in CarbonData. 2. Please finish the checklist 3.Please fix the CI errors. ---

[GitHub] carbondata issue #3038: [CARBONDATA-3209] Remove unused import

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 LGTM ---

[GitHub] carbondata pull request #3037: [CARBONDATA-3190] Open example module code st...

2018-12-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3037#discussion_r244593712 --- Diff: examples/spark2/src/main/java/org/apache/carbondata/examples/sdk/CarbonReaderExample.java --- @@ -33,127 +29,129 @@ import

[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 add to whitelist ---

[GitHub] carbondata issue #3038: [CARBONDATA-3209]remove unused import

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3038 @WangGuangxin Please optimize the title: [CARBONDATA-3209] Remove unused import ---

[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:

2018-12-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3040#discussion_r244592133 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/NonDictionaryFieldConverterImpl.java --- @@ -34,21 +34,21

[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:

2018-12-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3040#discussion_r244592098 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java --- @@ -43,7 +43,7 @@ /** * @return

[GitHub] carbondata pull request #3040: There are some spell error in CarbonData:

2018-12-31 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3040#discussion_r244592034 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -55,7 +55,7 @@ /** * parent

[GitHub] carbondata issue #3040: There are some spell error in CarbonData:

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3040 @WangQingNa Please optimize the title and finish the checklist in the content of this PR. ---

[GitHub] carbondata issue #3040: There are some spell error in CarbonData:

2018-12-31 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3040 add to whitelist ---

<    1   2   3   4   5   6   7   8   9   10   >