[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2444 ---

[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-06 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2444#discussion_r200568172 --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/DefaultMatchMaker.scala --- @@ -245,15 +269,22 @@ object

[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-06 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2444#discussion_r200568159 --- Diff: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/Harmonizer.scala --- @@ -36,17 +36,33 @@ abstract class

[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-06 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2444#discussion_r200568031 --- Diff: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/ModularRelation.scala --- @@ -86,10 +87,28 @@ object

[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-06 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2444#discussion_r200568141 --- Diff: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/Harmonizer.scala --- @@ -36,17 +36,33 @@ abstract class

[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-06 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2444#discussion_r200561054 --- Diff: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/ModularRelation.scala --- @@ -86,10 +87,28 @@ object

[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-06 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2444#discussion_r200560931 --- Diff: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/Harmonizer.scala --- @@ -36,17 +36,33 @@ abstract class

[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-06 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2444#discussion_r200560875 --- Diff: datamap/mv/plan/src/main/scala/org/apache/carbondata/mv/plans/modular/Harmonizer.scala --- @@ -36,17 +36,33 @@ abstract class

[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-06 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2444#discussion_r200560747 --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/DefaultMatchMaker.scala --- @@ -245,15 +269,22 @@ object

[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-06 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2444#discussion_r200560651 --- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/DefaultMatchMaker.scala --- @@ -127,8 +126,27 @@ object

[GitHub] carbondata pull request #2444: [CARBONDATA-2686] Implement Left join on MV d...

2018-07-04 Thread ravipesala
GitHub user ravipesala opened a pull request: https://github.com/apache/carbondata/pull/2444 [CARBONDATA-2686] Implement Left join on MV datamap Code ported from another branch done by @eychih to implement Left outer join. Be sure to do all of the following checklist to