Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/560
It is already merged to master please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/565
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/264
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/264
Found you have checked in binary table schema for testcase, you cannot
check-in binary file, please modify testcase
---
If your project is set up for it, you can reply to this email
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/264
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/264
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/557
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/423
Please rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/264#discussion_r95140944
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -188,13 +194,26 @@ public static void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/264#discussion_r95959773
--- Diff:
hadoop/src/test/java/org/apache/carbondata/hadoop/CarbonInputFormatTest.java ---
@@ -0,0 +1,58 @@
+/*
+ * Licensed
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/398#discussion_r91021993
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
---
@@ -836,8 +836,15 @@ object
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/454#discussion_r94445029
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CacheClient.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/509
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/492
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/678
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106800606
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106800910
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106799773
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106799714
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106798507
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/expression/Expression.java
---
@@ -42,6 +42,8 @@ public abstract
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106800228
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106798401
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/expression/BinaryExpression.java
---
@@ -38,4 +38,17 @@ public Expression
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106799658
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106799973
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106799796
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106800140
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106800320
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/670#discussion_r106800118
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
---
@@ -0,0 +1,557
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105936938
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java
---
@@ -46,44
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106189693
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -747,14 +835,14 @@ case
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106174923
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -313,6 +307,100
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/641
compilation errors in 1.6.2, please fix the same
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/641
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/669
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/668
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/676
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/675#discussion_r106865916
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/CarbonHiveCommands.scala
---
@@ -0,0 +1,42
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/674#discussion_r106864706
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommands.scala
---
@@ -174,7 +175,7 @@ private
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/675
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/674
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/673
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/660
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/681#discussion_r107334744
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -229,31 +229,37
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/678#discussion_r107334090
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommands.scala
---
@@ -198,6 +200,27
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/641
modified ManualApacheCarbonPRBuilder2.1 to test spark1.6 and tried
building. tests have failed, @manishgupta88 please fix.
http://136.243.101.176:8080/job
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106095253
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -136,6 +140,298 @@ case
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106093450
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -304,38 +341,76 @@ class CarbonMetastore
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106092052
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala
---
@@ -129,4 +134,80 @@ class
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106090749
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
---
@@ -784,4 +786,105
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106092997
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala
---
@@ -129,4 +134,80 @@ class
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106090051
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -194,4 +196,102 @@ object
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106091809
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala
---
@@ -129,4 +134,80 @@ class
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106091632
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSpark2SqlParser.scala
---
@@ -129,4 +134,80 @@ class
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106094811
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -136,6 +140,298 @@ case
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106095089
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -136,6 +140,298 @@ case
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106090264
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
---
@@ -784,4 +786,105
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r106090223
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/DataTypeConverterUtil.scala
---
@@ -77,4 +77,40
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/660#discussion_r106583662
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/MeasureFieldConverterImpl.java
---
@@ -57,11
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/660#discussion_r106588349
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java
---
@@ -164,6 +169,39
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/660#discussion_r106582255
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -185,8 +185,7
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/771#discussion_r110643139
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/RestructureBasedVectorResultCollector.java
---
@@ -177,22
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/656#discussion_r106595337
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -514,7 +514,7 @@ case
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/656#discussion_r106594167
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -963,15 +962,14 @@ object
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/656#discussion_r106593403
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
@@ -43,42 +43,71
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/656#discussion_r106593774
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
@@ -43,42 +43,71
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/656#discussion_r106595169
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -963,15 +962,14 @@ object
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/656#discussion_r106596051
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -524,8 +524,9 @@ case
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/765
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/802
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/801
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/781
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/771
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/802
Handle all the validation in driver and remove from executor.
parameters: csvheadercolumns, maxcolumns(default 2000), Threashold(2).
1) User configures both
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/803
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/803
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gvramana commented on the issue:
https://github.com/apache/incubator-carbondata/pull/804
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105868970
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/RestructureBasedRawResultCollector.java
---
@@ -0,0 +1,265
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105867937
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/RestructureBasedRawResultCollector.java
---
@@ -0,0 +1,265
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105883296
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -353,12 +312,15 @@ protected
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105852481
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/ResultCollectorFactory.java
---
@@ -0,0 +1,77
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105895041
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java
---
@@ -420,6 +438,54 @@ private static void
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105879703
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/RestructureBasedVectorResultCollector.java
---
@@ -0,0 +1,321
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105883959
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -429,9 +396,10 @@ protected
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105887002
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java
---
@@ -249,6 +248,25
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105962095
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/resolver/resolverinfo/visitor/NoDictionaryTypeVisitor.java
---
@@ -45,7
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105972588
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -1520,6 +1572,69 @@ public static String
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105969726
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -966,20 +974,22 @@ public static void
clearBlockCache
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105913851
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
---
@@ -38,37 +52,174 @@
* table
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105922838
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
@@ -571,6 +603,53 @@ public static
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/641#discussion_r105974874
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -245,6 +248,36 @@ public static DataType getDataType
90 matches
Mail list logo
