GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/583
[CARBONDATA-692]Supporting scalar subquery in carbon
Scalar subqueries like below not working in carbon.
```
select sum(salary) from scalarsubquery t1
where ID
GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/584
[WIP] Added code for new V3 format to optimize scan
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator
GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/585
[CARBONDATA-690]Fix load fail with unsafe enabled and with bigdecimal
datatypes
Load fails when columns have big decimal datatypes in unsafe mode. This PR
fixes it.
You can merge
GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/571
[CARBONDATA-680]Added stats like rows processed in each step. And also
fixes unsafe sort enable issue.
Currently stats like number of rows processed in each step is not added
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/571
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/571
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/576
[WIP] Improve query performance with read a head blocklet and changed
number compressor.
Need to work out with backward compatability
You can merge this pull request into a Git
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/571#discussion_r98164700
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/CarbonLateDecodeStrategy.scala
---
@@ -484,12 +485,14 @@ private
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/571#discussion_r98164711
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/CarbonLateDecodeStrategy.scala
---
@@ -484,12 +485,14 @@ private
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/571#discussion_r98164805
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/AbstractDataLoadProcessorStep.java
---
@@ -36,14 +39,37
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/571
Some problem with single-pass testcases , it hangs the jenkins, I had to
manually stop the build.
---
If your project is set up for it, you can reply to this email and have your
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/571
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/571
@jackylk Fixed comments, please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/572
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101443741
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/Sorter.java
---
@@ -39,11 +39,13 @@
* Sorts
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/606
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/607#discussion_r102887862
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataConverterProcessorWithBucketingStepImpl.java
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/607#discussion_r102887832
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java
---
@@ -135,6 +135,7
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/607#discussion_r102887927
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/607#discussion_r102887780
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataConverterProcessorStepImpl.java
---
@@ -93,6 +93,7
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/576
Same has been handled in
https://github.com/apache/incubator-carbondata/pull/584, so closing this PR.
---
If your project is set up for it, you can reply to this email and have
Github user ravipesala closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/576
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/578
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/607
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/572
This issue has been handled in PR
https://github.com/apache/incubator-carbondata/pull/584, Please close it.
---
If your project is set up for it, you can reply to this email
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/578
@Vimal-Das can you fix compile errors as per latest code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102693282
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
@@ -83,9 +81,12 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102693310
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryKey.java
---
@@ -36,17 +36,76
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102682365
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClient.java
---
@@ -86,7 +78,11 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102682570
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -77,20 +79,13 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102682394
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -16,57 +16,59
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102693979
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java
---
@@ -104,23 +129,12
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102692740
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryKey.java
---
@@ -16,12 +16,12
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102692785
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
@@ -42,38 +38,40 @@
private
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102692767
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryKeyType.java
---
@@ -0,0 +1,38
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/605
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102682192
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClient.java
---
@@ -44,7 +40,7
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102692574
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -77,20 +79,13 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/605#discussion_r102692467
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/client/DictionaryClientHandler.java
---
@@ -77,20 +79,13 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/597#discussion_r101950635
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -272,26 +274,26 @@ class
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/603
@Zhangshunyu checkstyle is failing.
CarbonCSVBasedSeqGenStep.java:48: error: Wrong order for
'org.apache.carbondata.core.constants.CarbonCommonConstants' import
---
If your
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/604#discussion_r102224557
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonInputSplitTaskInfo.java
---
@@ -0,0 +1,129
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/604#discussion_r102224519
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonInputSplitTaskInfo.java
---
@@ -0,0 +1,129
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/607#discussion_r102144509
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordsLogger.java
---
@@ -179,6
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/608
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/600#discussion_r102137715
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
@@ -141,6 +142,17 @@ class
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/597
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/605
[CARBONDATA-715] Optimize Single-Pass data load flow
1. Upgrade to latest netty-4.1.8
2. Optimize the serialization of key for passing in network.
3. Launch individual
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/607
@anubhav100 it is not correct way to close streams for every row, how the
other rows will be added to bad records if it is closed for each row.
---
If your project is set up
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/607#discussion_r102637522
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordsLogger.java
---
@@ -176,7
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102641238
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/FileHolder.java ---
@@ -18,8 +18,12 @@
package
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102642027
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/AbstractRawColumnChunk.java
---
@@ -0,0 +1,124
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102642118
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/DimensionColumnChunkReader.java
---
@@ -35,7 +36,7
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102645351
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v1/CompressedDimensionChunkFileBasedReaderV1.java
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102646332
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v2/CompressedDimensionChunkFileBasedReaderV2.java
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102647488
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RestructureFilterExecuterImpl.java
---
@@ -35,18 +37,18
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102641037
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -589,7 +591,7
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102641961
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/AbstractRawColumnChunk.java
---
@@ -0,0 +1,124
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102646213
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v1/CompressedDimensionChunkFileBasedReaderV1.java
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102646478
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/btree/BTreeNonLeafNode.java
---
@@ -24,8 +24,8 @@
import
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/584#discussion_r102647332
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java
---
@@ -343,24 +339,39
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/588
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/598#discussion_r101038699
--- Diff: build/README.md ---
@@ -57,3 +48,9 @@ Build with test
```
mvn clean package
```
+
+## For any contributors
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/596
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/596
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/596
[WIP]Test for repository
This PR is for testing carbondata repository. At the time of IPMC voting it
can fetch from carbondata repository.
You can merge this pull request
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/596
@chenliang613 Nothing we can update in build document, as it is internal
and only used at the time of IPMC voting. So I think we don't require expose
this outside. We can update
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/592
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/588
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/600
[CARBONDATA-705]Make partition distribution as configurable
Make the partition distribution as configurable and keep spark distribution
as default.
User can use
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/597#discussion_r101241648
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -193,15 +194,21 @@ case class
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/597#discussion_r101241491
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -175,16 +175,25 @@ case class
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/591
Yes @Zhangshunyu , Can you reopen that PR
https://github.com/apache/incubator-carbondata/pull/222 and rebase it, we can
merge it now.
---
If your project is set up for it, you can
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/599#discussion_r101198486
--- Diff: docs/quick-start-guide.md ---
@@ -62,9 +62,17 @@ import org.apache.spark.sql.CarbonSession._
* Create a CarbonSession
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/599#discussion_r101214103
--- Diff: docs/quick-start-guide.md ---
@@ -62,9 +62,16 @@ import org.apache.spark.sql.CarbonSession._
* Create a CarbonSession
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/588
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/599#discussion_r101228367
--- Diff: docs/quick-start-guide.md ---
@@ -62,8 +62,9 @@ import org.apache.spark.sql.CarbonSession._
* Create a CarbonSession
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/599
LGTM. Thanks for working on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/598
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721427
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterImpl.java
---
@@ -86,11
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721771
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/IntermediateFileMerger.java
---
@@ -116,8
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721258
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -641,7 +641,7
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/597#discussion_r100721184
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala
---
@@ -175,16 +175,25 @@ case class
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721876
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java
---
@@ -375,6 +376,9
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/547#discussion_r96601089
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala
---
@@ -53,11 +43,8 @@ object
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/548
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/547
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/546
@jackylk Handled comment, please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/553
[CARBONDATA-635]Insert query fails when functions are used in select query
This PR fixes the insert query when functions are used in select query.
You can merge this pull request
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/556
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/332
@akashrn5 Please add testcase in nokettle flow as well using
'USE_KETTLE'='false'
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/332
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/553
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user ravipesala opened a pull request:
https://github.com/apache/incubator-carbondata/pull/557
[WIP] Set carbon properties location proper
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/551#discussion_r96883829
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/DirectDictionaryKeyGeneratorFactory.java
---
@@ -57,9
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/551#discussion_r96883596
--- Diff:
core/src/main/java/org/apache/carbondata/core/cache/dictionary/ColumnDictionaryInfo.java
---
@@ -285,9 +285,17 @@ private int
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/551#discussion_r96884951
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/DateDirectDictionaryGenerator.java
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/551#discussion_r96884908
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/expression/ExpressionResult.java
---
@@ -175,9 +175,17 @@ public String
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/551#discussion_r96885076
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/expression/ExpressionResult.java
---
@@ -523,9 +531,17 @@ public boolean
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/551#discussion_r96885139
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
@@ -1078,9 +1078,17 @@ public static int
1 - 100 of 523 matches
Mail list logo
