Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/806
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/797
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/779#discussion_r111276805
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSource.java
---
@@ -0,0 +1,192
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/779#discussion_r111276661
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSource.java
---
@@ -0,0 +1,192
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/779
@bhavya411 verified, it works fine.
Can you change title to : Added Support for DecimalType and Timestamp for
spark-2.1 for integration/presto, please change JIRA description
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/785
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/779
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/785
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/782
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/751#discussion_r110723264
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -0,0 +1,179
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/773
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/751
@cenyuhai HiveExample can more to examples/ later once hive integration
module be completely moved into master.
---
If your project is set up for it, you can reply to this email
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/772
[CARBONDATA-891] Fix compilation issue of LocalFileLockTest generate new
folder "carbon.store"
[CARBONDATA-891] Fix compilation issue of LocalFileLockTest generate n
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/770
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/751#discussion_r110533556
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -0,0 +1,166
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/769
@sanoj-mg please let me know your JIRA account's emailid, i will give your
contributor right, then you can assign issues to yourself.
---
If your project is set up for it, you
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/766
Refactor integration/presto by optimizing some name definition
Refactor integration/presto by optimizing some name definition.
You can merge this pull request into a Git
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/758
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/756
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/756
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/747
Please update the title, how about :
[CARBONDATA - 878] Fixed Formatting Issues in document quick-start-guide.md
---
If your project is set up for it, you can reply
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/752
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/738
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/738
@ffpeng90 can you remove this file
(integration/presto/src/checkstyle/checks.xml) .
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/744
Please put all files under integration/hive for all hive related PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/744#discussion_r110134827
--- Diff: format/src/main/thrift/sort_index.thrift ---
@@ -1,28 +1,26 @@
-/**
- * Licensed to the Apache Software Foundation (ASF
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/746
LGTM
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/744#discussion_r110121865
--- Diff: format/src/main/thrift/sort_index.thrift ---
@@ -1,28 +1,26 @@
-/**
- * Licensed to the Apache Software Foundation (ASF
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/750
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/738#discussion_r110118287
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataSplitManager.java
---
@@ -106,6 +110,12 @@ public
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/738#discussion_r110118360
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataSplitManager.java
---
@@ -249,6 +250,11 @@ public
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/738#discussion_r110116629
--- Diff: integration/presto/src/checkstyle/checks.xml ---
@@ -0,0 +1,7 @@
+
+http://www.puppycrawl.com/dtds/configuration_1_3
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/738#discussion_r110117100
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordCursor.java
---
@@ -78,6 +78,10 @@ public
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/747
Two comments:
1. The pr title is not correct.
2.Can you explain why need to reformat the document ?
---
If your project is set up for it, you can reply to this email
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/748
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/749
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/743
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/743
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/734
LGTM, thanks for your contributing.
Indeed, by default the data loading will not use kettle, so the cluster
installation document can remove kettle part.
---
If your project
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/731
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/740
@cenyuhai please add [CARBONDATA-815] for the PR title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/738
@ffpeng90 can you optimize other code also, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/734
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/710
Can you provide more detail info for help me to reproduce the issue ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/728
verified. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/729#discussion_r109636424
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -1,223 +1,226 @@
-/**
- * Licensed to the Apache Software Foundation
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/672
@cenyuhai can you raise this PR to branch hive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/729#discussion_r109628602
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -1,223 +1,226 @@
-/**
- * Licensed to the Apache Software Foundation
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/728#discussion_r109627894
--- Diff: pom.xml ---
@@ -98,6 +98,7 @@
hadoop
integration/spark-common
integration/spark-common-test
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/721
Fix typo issues of integration/ presto
Fix typo issues of integration/ presto
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/714
Move integration/presto module to branch "presto"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenliang613
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/710
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/712
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/705
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/707
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/707
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/707
@tianlileer please use english to describe the pr title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/704
[CARBONDATA-826] Create carbondata-connector of presto
Create carbondata-connector for query carbon data in presto
1.In CarbonData project, generate carbondata-connector
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
@watermen
You are right, the fileName actually is a path parameter.
Agree to change fileName to carbonDataFileTempPath, please modify it in
your PR.
---
If your
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
@watermen
Thanks for your contribution, everything looks good.
Only one comment, in AbstractFactDataWriter.java, there are two
parameters(fileName, carbonDataFileName
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/696#discussion_r108052532
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -528,8
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/696#discussion_r108052521
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v1/CarbonFactDataWriterImplV1.java
---
@@ -373,7
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/696#discussion_r108052363
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestDataLoadWithFileName.scala
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107842840
--- Diff: dev/java-code-format-template.xml ---
@@ -34,8 +34,8
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/672
@cenyuhai please change title to : [CARBONDATA-815] add hive integration
for carbon
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107839323
--- Diff: pom.xml ---
@@ -381,6 +389,15 @@
+ hive-1.2.1
--- End diff --
suggest
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/687
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/687
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/693
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/692
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/693
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/693
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/693
[CARBONDATA-813] Fix all issues to build success for integration/presto
Fix pom issues and add the correct dependency jar to build success for
integration/presto
You can merge
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/686
Fix groupid,package name,Class name issues of presto integration
Fix groupid,package name,Class name issues of presto integration
You can merge this pull request into a Git
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107606797
--- Diff: dev/java-code-format-template.xml ---
@@ -34,8 +34,8
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/650
@ffpeng90
In presto/pom.xml, please change groupid from "com.facebook.presto" to
"org.apache.carbondata"
---
If your project is set up for it, you can
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/650
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/650
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/606
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/672
@cenyuhai Thank you contributed this feature.
Suggest creating a new profile for "integration/hive" module, and let all
hive related code decoupled from current mod
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/650
@ffpeng90 please update the PR title also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user chenliang613 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/684
Update file structure info as per V3 format definition
The master has merged new V3 format for improving performance, this PR is
for updating file structure info as per V3 format
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/679
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/671
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/667
@rahulforallp please change tile to : [CARBONDATA-772] xxx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/655
@lionelcao please push a null commit to trigger the travis CI again, CI
should be ok.
verified in my machine ,it is ok.
---
If your project is set up for it, you can reply
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/650#discussion_r105558847
--- Diff: integration/presto/pom.xml ---
@@ -0,0 +1,167 @@
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/650
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/649
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105549626
--- Diff:
core/src/test/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImplTest.java
---
@@ -96,13 +93,39
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105548337
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -138,23 +138,23
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105548338
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -138,23 +138,23
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105548334
--- Diff:
core/src/test/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImplTest.java
---
@@ -41,21 +41,20
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/620
please change the title as per the format: [CARBONDATA-issue number>] Title
of the pull request (need to add a blank)
---
If your project is set up for it, you can re
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/640
please close this PR, because you have raised another PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/427
please change the title as per the format: [CARBONDATA-issue number>] Title
of the pull request (need to add a blank)
---
If your project is set up for it, you can re
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/429
please change the title as per the format: [CARBONDATA-issue number>] Title
of the pull request (need to add a blank)
---
If your project is set up for it, you can re
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/630
please change the title as per the format: [CARBONDATA-issue number>] Title
of the pull request (need to add a blank)
---
If your project is set up for it, you can re
1 - 100 of 255 matches
Mail list logo
