[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036412#comment-16036412 ] Gilles commented on NUMBERS-38: --- It is still not clear to me what is the benefit of moving t

[jira] [Commented] (IO-537) BOMInputStream shouldn't sort array of BOMs in-place

2017-06-04 Thread Borys Zibrov (JIRA)
[ https://issues.apache.org/jira/browse/IO-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036392#comment-16036392 ] Borys Zibrov commented on IO-537: - Perfect, thanks a lot! > BOMInputStream shouldn't sort arr

[jira] [Closed] (IO-537) BOMInputStream shouldn't sort array of BOMs in-place

2017-06-04 Thread Borys Zibrov (JIRA)
[ https://issues.apache.org/jira/browse/IO-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Borys Zibrov closed IO-537. --- > BOMInputStream shouldn't sort array of BOMs in-place > > >

[jira] [Commented] (IO-537) BOMInputStream shouldn't sort array of BOMs in-place

2017-06-04 Thread Borys Zibrov (JIRA)
[ https://issues.apache.org/jira/browse/IO-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036393#comment-16036393 ] Borys Zibrov commented on IO-537: - Perfect, thanks a lot! > BOMInputStream shouldn't sort arr

[jira] [Updated] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-04 Thread Amey Jadiye (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amey Jadiye updated NUMBERS-38: --- Attachment: NUMBERS-38.patch > No unit tests for "LanczosApproximation" class > --

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-04 Thread Amey Jadiye (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036289#comment-16036289 ] Amey Jadiye commented on NUMBERS-38: bq. I'm now confused as to what the problem is. S

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036266#comment-16036266 ] Gilles commented on NUMBERS-38: --- bq. I think all that you copied from commons math is correc

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-04 Thread Amey Jadiye (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036264#comment-16036264 ] Amey Jadiye commented on NUMBERS-38: Hi [~erans], I think all that you copied from co

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-04 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036261#comment-16036261 ] Gilles commented on NUMBERS-38: --- Hi Amey, Great that you could dig deeper into the review.

[jira] [Commented] (NUMBERS-38) No unit tests for "LanczosApproximation" class

2017-06-04 Thread Amey Jadiye (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036254#comment-16036254 ] Amey Jadiye commented on NUMBERS-38: Hi [~erans] My initial thoughts was the formula

[jira] [Closed] (TEXT-84) RandomStringGenerator claims to be immutable, but isn't

2017-06-04 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones closed TEXT-84. Resolution: Fixed Assignee: Duncan Jones Fix Version/s: 1.2 Fixed in 4004cfdee. > RandomString