[GitHub] [commons-lang] coveralls commented on issue #443: Optimize string split methods: 1. Use ThreadLocal to make reuse of th…

2019-08-20 Thread GitBox
coveralls commented on issue #443: Optimize string split methods: 1. Use ThreadLocal to make reuse of th… URL: https://github.com/apache/commons-lang/pull/443#issuecomment-523302164 [![Coverage Status](https://coveralls.io/builds/25256593/badge)](https://coveralls.io/builds/25256593)

[jira] [Work logged] (LANG-1474) JavaDoc was not updated of isAnyXXX in StringUtils

2019-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1474?focusedWorklogId=298462=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298462 ] ASF GitHub Bot logged work on LANG-1474: Author: ASF GitHub Bot

[GitHub] [commons-lang] Stzx commented on issue #442: LANG-1474 documentation correction

2019-08-20 Thread GitBox
Stzx commented on issue #442: LANG-1474 documentation correction URL: https://github.com/apache/commons-lang/pull/442#issuecomment-523301200 @kinow Sorry. Make you feel confused. The conclusion of my test is the same as yours.

[jira] [Resolved] (COMPRESS-478) compress should handle ".zim" files as well (especially customized for wikipedia pages)

2019-08-20 Thread Stefan Bodewig (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig resolved COMPRESS-478. - Resolution: Fixed > compress should handle ".zim" files as well (especially customized

[GitHub] [commons-lang] kinow commented on issue #442: LANG-1474 documentation correction

2019-08-20 Thread GitBox
kinow commented on issue #442: LANG-1474 documentation correction URL: https://github.com/apache/commons-lang/pull/442#issuecomment-523288094 @Stzx do you think the documentation changes are correct, or did you get the same as I did testing it? (sorry, couldn't tell if +1 was for my

[jira] [Work logged] (LANG-1474) JavaDoc was not updated of isAnyXXX in StringUtils

2019-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1474?focusedWorklogId=298437=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298437 ] ASF GitHub Bot logged work on LANG-1474: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1474) JavaDoc was not updated of isAnyXXX in StringUtils

2019-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1474?focusedWorklogId=298434=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298434 ] ASF GitHub Bot logged work on LANG-1474: Author: ASF GitHub Bot

[GitHub] [commons-lang] Stzx commented on issue #442: LANG-1474 documentation correction

2019-08-20 Thread GitBox
Stzx commented on issue #442: LANG-1474 documentation correction URL: https://github.com/apache/commons-lang/pull/442#issuecomment-523286572 +1 This is an automated message from the Apache Git Service. To respond to the

[jira] [Work logged] (LANG-1474) JavaDoc was not updated of isAnyXXX in StringUtils

2019-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1474?focusedWorklogId=298427=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298427 ] ASF GitHub Bot logged work on LANG-1474: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1474) JavaDoc was not updated of isAnyXXX in StringUtils

2019-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1474?focusedWorklogId=298429=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298429 ] ASF GitHub Bot logged work on LANG-1474: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1474) JavaDoc was not updated of isAnyXXX in StringUtils

2019-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1474?focusedWorklogId=298426=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298426 ] ASF GitHub Bot logged work on LANG-1474: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1474) JavaDoc was not updated of isAnyXXX in StringUtils

2019-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1474?focusedWorklogId=298428=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298428 ] ASF GitHub Bot logged work on LANG-1474: Author: ASF GitHub Bot

[GitHub] [commons-lang] kinow commented on a change in pull request #442: LANG-1474 documentation correction

2019-08-20 Thread GitBox
kinow commented on a change in pull request #442: LANG-1474 documentation correction URL: https://github.com/apache/commons-lang/pull/442#discussion_r315990246 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -3600,7 +3600,7 @@ public static

[GitHub] [commons-lang] kinow commented on a change in pull request #442: LANG-1474 documentation correction

2019-08-20 Thread GitBox
kinow commented on a change in pull request #442: LANG-1474 documentation correction URL: https://github.com/apache/commons-lang/pull/442#discussion_r315990126 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -3402,7 +3402,7 @@ public static

[GitHub] [commons-lang] kinow commented on a change in pull request #442: LANG-1474 documentation correction

2019-08-20 Thread GitBox
kinow commented on a change in pull request #442: LANG-1474 documentation correction URL: https://github.com/apache/commons-lang/pull/442#discussion_r315990197 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -3575,7 +3575,7 @@ public static

[GitHub] [commons-lang] kinow commented on a change in pull request #442: LANG-1474 documentation correction

2019-08-20 Thread GitBox
kinow commented on a change in pull request #442: LANG-1474 documentation correction URL: https://github.com/apache/commons-lang/pull/442#discussion_r315990087 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java ## @@ -3369,7 +3369,7 @@ public static

[GitHub] [commons-lang] YuyuZha0 opened a new pull request #443: Optimize string split methods: 1. Use ThreadLocal to make reuse of th…

2019-08-20 Thread GitBox
YuyuZha0 opened a new pull request #443: Optimize string split methods: 1. Use ThreadLocal to make reuse of th… URL: https://github.com/apache/commons-lang/pull/443 Optimize string split methods: - In current impl of split methods, a string array list is created every time the

[jira] [Updated] (LANG-1475) StringUtils.unwrap StringIndexOutOfBoundsException

2019-08-20 Thread Silence Tai (Jira)
[ https://issues.apache.org/jira/browse/LANG-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Silence Tai updated LANG-1475: -- Fix Version/s: 3.10 > StringUtils.unwrap StringIndexOutOfBoundsException >

[GitHub] [commons-imaging] kinow edited a comment on issue #49: Add support for EXIF 2.32

2019-08-20 Thread GitBox
kinow edited a comment on issue #49: Add support for EXIF 2.32 URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-523195306 @GITNE it's a checkstyle issue. If you click on "Details" next to the Travis CI check ( ) there should be a few jobs within this PR's build.

[GitHub] [commons-imaging] kinow commented on issue #49: Add support for EXIF 2.32

2019-08-20 Thread GitBox
kinow commented on issue #49: Add support for EXIF 2.32 URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-523195306 @GITNE it's a checkstyle issue. If you click on "Details" next to the Travis CI check ( ) there should be a few jobs within this PR's build. Looking

[GitHub] [commons-imaging] GITNE edited a comment on issue #49: Add support for EXIF 2.32

2019-08-20 Thread GitBox
GITNE edited a comment on issue #49: Add support for EXIF 2.32 URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-523085053 The Travis CI job fails for some PR unrelated reason. Can you fix it? Basically, this PR is done, unless you want me to change something.

[GitHub] [commons-imaging] GITNE edited a comment on issue #49: Add support for EXIF 2.32

2019-08-20 Thread GitBox
GITNE edited a comment on issue #49: Add support for EXIF 2.32 URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-523085053 The Travis CI job fails for some PR unrelated reason. Can you fix it? Basically, this PR is done, unless you want me to something change.

[GitHub] [commons-imaging] GITNE commented on issue #49: Add support for EXIF 2.32

2019-08-20 Thread GitBox
GITNE commented on issue #49: Add support for EXIF 2.32 URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-523085053 The Travis CI job fails for some PR unrelated reason. Can you fix it? Basically, this PR is done, unless you want me something to change.

[jira] [Created] (COLLECTIONS-727) A potential misleading comment

2019-08-20 Thread XiangzheXu (Jira)
XiangzheXu created COLLECTIONS-727: -- Summary: A potential misleading comment Key: COLLECTIONS-727 URL: https://issues.apache.org/jira/browse/COLLECTIONS-727 Project: Commons Collections

[GitHub] [commons-lang] coveralls commented on issue #442: LAN-1474 documentation correction

2019-08-20 Thread GitBox
coveralls commented on issue #442: LAN-1474 documentation correction URL: https://github.com/apache/commons-lang/pull/442#issuecomment-523044537 [![Coverage Status](https://coveralls.io/builds/25241120/badge)](https://coveralls.io/builds/25241120) Coverage remained the same at

[jira] [Commented] (LANG-1474) JavaDoc was not updated of isAnyXXX in StringUtils

2019-08-20 Thread Silence Tai (Jira)
[ https://issues.apache.org/jira/browse/LANG-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911404#comment-16911404 ] Silence Tai commented on LANG-1474: --- Hey, I tested the 3.9 version locally. I checked the test case

[GitHub] [commons-lang] verhas opened a new pull request #442: LAN-1474 documentation correction

2019-08-20 Thread GitBox
verhas opened a new pull request #442: LAN-1474 documentation correction URL: https://github.com/apache/commons-lang/pull/442 This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Closed] (LANG-1477) Implement castToXXX in Functions class

2019-08-20 Thread Peter Verhas (Jira)
[ https://issues.apache.org/jira/browse/LANG-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Verhas closed LANG-1477. -- Resolution: Fixed > Implement castToXXX in Functions class > -- > >

[jira] [Updated] (LANG-1477) Implement castToXXX in Functions class

2019-08-20 Thread Peter Verhas (Jira)
[ https://issues.apache.org/jira/browse/LANG-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Verhas updated LANG-1477: --- Description: Proposal to implement functional interface conversion functions in the class 

[jira] [Commented] (COMPRESS-478) compress should handle ".zim" files as well (especially customized for wikipedia pages)

2019-08-20 Thread Stefan Bodewig (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911355#comment-16911355 ] Stefan Bodewig commented on COMPRESS-478: -

[jira] [Updated] (LANG-1477) Implement castToXXX in Functions class

2019-08-20 Thread Peter Verhas (Jira)
[ https://issues.apache.org/jira/browse/LANG-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Verhas updated LANG-1477: --- Summary: Implement castToXXX in Functions class (was: Implement caseToXXX in Functions class) >

[jira] [Created] (LANG-1477) Implement caseToXXX in Functions class

2019-08-20 Thread Peter Verhas (Jira)
Peter Verhas created LANG-1477: -- Summary: Implement caseToXXX in Functions class Key: LANG-1477 URL: https://issues.apache.org/jira/browse/LANG-1477 Project: Commons Lang Issue Type: Bug

[jira] [Commented] (MATH-1494) Find exponential curve fit to data using Jacquelin method

2019-08-20 Thread Gilles (Jira)
[ https://issues.apache.org/jira/browse/MATH-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911228#comment-16911228 ] Gilles commented on MATH-1494: -- Thanks for your interest in contributing. There are however several issues

[jira] [Resolved] (LANG-1476) Use synchronise on a set created with Collections.synchronizedSet before iterating

2019-08-20 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/LANG-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved LANG-1476. -- Resolution: Fixed > Use synchronise on a set created with Collections.synchronizedSet

[GitHub] [commons-lang] kinow commented on issue #399: Synchronize before looping over synchronized collection

2019-08-20 Thread GitBox
kinow commented on issue #399: Synchronize before looping over synchronized collection URL: https://github.com/apache/commons-lang/pull/399#issuecomment-522947570 Thanks @emopers ! This is an automated message from the

[GitHub] [commons-lang] kinow closed pull request #399: Synchronize before looping over synchronized collection

2019-08-20 Thread GitBox
kinow closed pull request #399: Synchronize before looping over synchronized collection URL: https://github.com/apache/commons-lang/pull/399 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-lang] kinow commented on issue #399: Synchronize before looping over synchronized collection

2019-08-20 Thread GitBox
kinow commented on issue #399: Synchronize before looping over synchronized collection URL: https://github.com/apache/commons-lang/pull/399#issuecomment-522947432 Placeholder ticket: https://issues.apache.org/jira/browse/LANG-1476

[jira] [Created] (LANG-1476) Use synchronise on a set created with Collections.synchronizedSet before iterating

2019-08-20 Thread Bruno P. Kinoshita (Jira)
Bruno P. Kinoshita created LANG-1476: Summary: Use synchronise on a set created with Collections.synchronizedSet before iterating Key: LANG-1476 URL: https://issues.apache.org/jira/browse/LANG-1476

[GitHub] [commons-lang] kinow commented on issue #399: Synchronize before looping over synchronized collection

2019-08-20 Thread GitBox
kinow commented on issue #399: Synchronize before looping over synchronized collection URL: https://github.com/apache/commons-lang/pull/399#issuecomment-522944037 Kicked Travis CI and the build passed with no issues. Will create a JIRA ticket for this (even though small change, always

[jira] [Resolved] (LANG-1460) Trivial: year of release for 3.9 says 2018, should be 2019

2019-08-20 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/LANG-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved LANG-1460. -- Fix Version/s: 3.10 Resolution: Fixed > Trivial: year of release for 3.9 says

[jira] [Work logged] (LANG-1460) Trivial: year of release for 3.9 says 2018, should be 2019

2019-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1460?focusedWorklogId=297735=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297735 ] ASF GitHub Bot logged work on LANG-1460: Author: ASF GitHub Bot

[GitHub] [commons-lang] kinow closed pull request #427: LANG-1460: (doc) (trivial) correct release year for v3.9 in release-history.xml

2019-08-20 Thread GitBox
kinow closed pull request #427: LANG-1460: (doc) (trivial) correct release year for v3.9 in release-history.xml URL: https://github.com/apache/commons-lang/pull/427 This is an automated message from the Apache Git Service.

[jira] [Updated] (LANG-1460) Trivial: year of release for 3.9 says 2018, should be 2019

2019-08-20 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/LANG-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated LANG-1460: - Assignee: Bruno P. Kinoshita > Trivial: year of release for 3.9 says 2018, should be 2019

[jira] [Work logged] (LANG-1460) Trivial: year of release for 3.9 says 2018, should be 2019

2019-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1460?focusedWorklogId=297726=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297726 ] ASF GitHub Bot logged work on LANG-1460: Author: ASF GitHub Bot

[GitHub] [commons-lang] kinow commented on issue #427: LANG-1460: (doc) (trivial) correct release year for v3.9 in release-history.xml

2019-08-20 Thread GitBox
kinow commented on issue #427: LANG-1460: (doc) (trivial) correct release year for v3.9 in release-history.xml URL: https://github.com/apache/commons-lang/pull/427#issuecomment-522940721 Spent some time looking for any documentation about `release-history.xml`, found the commits that

[GitHub] [commons-lang] kinow commented on issue #419: Lang 1456 either

2019-08-20 Thread GitBox
kinow commented on issue #419: Lang 1456 either URL: https://github.com/apache/commons-lang/pull/419#issuecomment-522933833 It would be a good fit for Commons Functor if we were close to a release. Not sure what others thing about restarting work there and adding some interesting code

[GitHub] [commons-lang] kinow commented on a change in pull request #425: RandomUtils : comment error

2019-08-20 Thread GitBox
kinow commented on a change in pull request #425: RandomUtils : comment error URL: https://github.com/apache/commons-lang/pull/425#discussion_r315588120 ## File path: src/main/java/org/apache/commons/lang3/RandomUtils.java ## @@ -166,23 +166,23 @@ public static long

[GitHub] [commons-lang] kinow commented on issue #434: Fixed a problem when parsing Chinese using the ToStringStyle.JSON_STYLE

2019-08-20 Thread GitBox
kinow commented on issue #434: Fixed a problem when parsing Chinese using the ToStringStyle.JSON_STYLE URL: https://github.com/apache/commons-lang/pull/434#issuecomment-522926480 I don't feel confident enough to vote +1 on this change. It seems to fix the bug described here, and the test

[GitHub] [commons-lang] kinow commented on issue #437: Add GenericArrayType support to TypeUtils.containsTypeVariables

2019-08-20 Thread GitBox
kinow commented on issue #437: Add GenericArrayType support to TypeUtils.containsTypeVariables URL: https://github.com/apache/commons-lang/pull/437#issuecomment-522924504 > resulting in overall build failure. Is there a possibility to rerun checks without committing anything else?