[GitHub] [commons-collections] dota17 opened a new pull request #118: Fixed the typo and deal the NPE with Objects.requireNonNull in Abstr…

2019-11-24 Thread GitBox
dota17 opened a new pull request #118: Fixed the typo and deal the NPE with Objects.requireNonNull in Abstr… URL: https://github.com/apache/commons-collections/pull/118 Fixed the typo and deal the NPE with Objects.requireNonNull in AbstractLinkedList

[GitHub] [commons-compress] coveralls commented on issue #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives

2019-11-24 Thread GitBox
coveralls commented on issue #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives URL: https://github.com/apache/commons-compress/pull/87#issuecomment-557956506 [![Coverage Status](https://coveralls.io/builds/27209256/badge)](https://coveralls.io/builds/27209

[jira] [Work logged] (COMPRESS-124) Unable to extract a sparse entries from tar archives

2019-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-124?focusedWorklogId=348883&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348883 ] ASF GitHub Bot logged work on COMPRESS-124: --- Author: ASF GitHub B

[jira] [Work logged] (COMPRESS-124) Unable to extract a sparse entries from tar archives

2019-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-124?focusedWorklogId=348880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348880 ] ASF GitHub Bot logged work on COMPRESS-124: --- Author: ASF GitHub B

[GitHub] [commons-compress] PeterAlfreadLee opened a new pull request #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives

2019-11-24 Thread GitBox
PeterAlfreadLee opened a new pull request #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives URL: https://github.com/apache/commons-compress/pull/87 [COMPRESS-124](https://issues.apache.org/jira/browse/COMPRESS-124) Add support for extracting sparse entries f

[GitHub] [commons-codec] coveralls commented on issue #29: [CODEC-270] Base32/64: Fix masked check of the final bits to discard.

2019-11-24 Thread GitBox
coveralls commented on issue #29: [CODEC-270] Base32/64: Fix masked check of the final bits to discard. URL: https://github.com/apache/commons-codec/pull/29#issuecomment-557947630 [![Coverage Status](https://coveralls.io/builds/27208428/badge)](https://coveralls.io/builds/27208428)

[jira] [Commented] (CODEC-270) Base32 and Base64 still allow decoding some invalid trailing characters

2019-11-24 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/CODEC-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981218#comment-16981218 ] Alex Herbert commented on CODEC-270: Fix is in PR #29. When implementing the fix I no

[jira] [Work logged] (CODEC-270) Base32 and Base64 still allow decoding some invalid trailing characters

2019-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CODEC-270?focusedWorklogId=348857&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348857 ] ASF GitHub Bot logged work on CODEC-270: Author: ASF GitHub Bot

[GitHub] [commons-codec] aherbert opened a new pull request #29: [CODEC-270] Base32/64: Fix masked check of the final bits to discard.

2019-11-24 Thread GitBox
aherbert opened a new pull request #29: [CODEC-270] Base32/64: Fix masked check of the final bits to discard. URL: https://github.com/apache/commons-codec/pull/29 Fixed the Base32/64 mask check to ensure it checks all the bits to be discarded are zero. Added tests that enumerate all

[GitHub] [commons-geometry] asfgit merged pull request #40: GEOMETRY-32: Refactor Partitioning Code

2019-11-24 Thread GitBox
asfgit merged pull request #40: GEOMETRY-32: Refactor Partitioning Code URL: https://github.com/apache/commons-geometry/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [commons-geometry] asfgit merged pull request #40: GEOMETRY-32: Refactor Partitioning Code

2019-11-24 Thread GitBox
asfgit merged pull request #40: GEOMETRY-32: Refactor Partitioning Code URL: https://github.com/apache/commons-geometry/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Updated] (CODEC-270) Base32 and Base64 still allow decoding some invalid trailing characters

2019-11-24 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/CODEC-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert updated CODEC-270: --- Description: Both Base32 and Base64 check that the final bits from the trailing digit that will be di

[jira] [Created] (CODEC-270) Base32 and Base64 still allow decoding some invalid trailing characters

2019-11-24 Thread Alex Herbert (Jira)
Alex Herbert created CODEC-270: -- Summary: Base32 and Base64 still allow decoding some invalid trailing characters Key: CODEC-270 URL: https://issues.apache.org/jira/browse/CODEC-270 Project: Commons Code

[jira] [Commented] (CODEC-134) Base32 would decode some invalid Base32 encoded string into arbitrary value

2019-11-24 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/CODEC-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981199#comment-16981199 ] Alex Herbert commented on CODEC-134: This is not totally fixed. For example the fix fo

[jira] [Commented] (CODEC-263) Base64.decodeBase64 throw exception

2019-11-24 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/CODEC-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981194#comment-16981194 ] Alex Herbert commented on CODEC-263: When encoding bytes which are 8-bit into 6-bit ch

[jira] [Commented] (GEOMETRY-32) BSPTree Updates

2019-11-24 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981171#comment-16981171 ] Matt Juntunen commented on GEOMETRY-32: --- bq. Isn't it possible to increase the num

[jira] [Commented] (GEOMETRY-32) BSPTree Updates

2019-11-24 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981151#comment-16981151 ] Gilles Sadowski commented on GEOMETRY-32: - {quote}VectorXD.linearCombination() {

[jira] [Commented] (GEOMETRY-32) BSPTree Updates

2019-11-24 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981142#comment-16981142 ] Matt Juntunen commented on GEOMETRY-32: --- {quote}there are too many files {quote} A

[jira] [Commented] (CODEC-268) Deprecate methods in MurmurHash3 with no equivalent in the reference c++ source.

2019-11-24 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CODEC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981103#comment-16981103 ] Claude Warren commented on CODEC-268: - I think it was the last line of the original po

[jira] [Commented] (GEOMETRY-32) BSPTree Updates

2019-11-24 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981097#comment-16981097 ] Gilles Sadowski commented on GEOMETRY-32: - Thanks! I wish I could  review this,

[jira] [Resolved] (CODEC-267) MurmurHash3.hash32() does not process trailing bytes as unsigned

2019-11-24 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/CODEC-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved CODEC-267. Fix Version/s: 1.14 Resolution: Fixed New method hash32x86 with fix for trailing negative byt

[jira] [Resolved] (CODEC-264) murmur3.hash128() does not account for unsigned seed argument

2019-11-24 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/CODEC-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved CODEC-264. Fix Version/s: 1.14 Resolution: Fixed New method hash128x64 to handle unsigned seed argument

[jira] [Commented] (CODEC-264) murmur3.hash128() does not account for unsigned seed argument

2019-11-24 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CODEC-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981049#comment-16981049 ] Claude Warren commented on CODEC-264: - This issues should be closed with the changes t

[GitHub] [commons-codec] Claudenw closed pull request #27: Murmur3fix

2019-11-24 Thread GitBox
Claudenw closed pull request #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [commons-codec] Claudenw commented on issue #27: Murmur3fix

2019-11-24 Thread GitBox
Claudenw commented on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-557881487 Pull request objective fulfilled by other changes to master branch This is an automated message from the A

[GitHub] [commons-codec] aherbert commented on issue #27: Murmur3fix

2019-11-24 Thread GitBox
aherbert commented on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-557881044 Yes. I have separated them into tests for positive and negative seed. This is an automated message from th

[jira] [Commented] (CODEC-268) Deprecate methods in MurmurHash3 with no equivalent in the reference c++ source.

2019-11-24 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/CODEC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981047#comment-16981047 ] Alex Herbert commented on CODEC-268: {quote}The older implementations should not be re

[jira] [Work logged] (IMAGING-242) Move to JUnit 5

2019-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-242?focusedWorklogId=348688&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348688 ] ASF GitHub Bot logged work on IMAGING-242: -- Author: ASF GitHub Bot

[jira] [Work logged] (IMAGING-242) Move to JUnit 5

2019-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-242?focusedWorklogId=348687&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348687 ] ASF GitHub Bot logged work on IMAGING-242: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] kinow edited a comment on issue #59: [IMAGING-242] Upgrade to Junit5

2019-11-24 Thread GitBox
kinow edited a comment on issue #59: [IMAGING-242] Upgrade to Junit5 URL: https://github.com/apache/commons-imaging/pull/59#issuecomment-557875098 >The side advantage of this is to lock down the dependencies and not allow people to mix Jupiter and Vintage in the same class as was done in T

[GitHub] [commons-imaging] kinow commented on issue #59: [IMAGING-242] Upgrade to Junit5

2019-11-24 Thread GitBox
kinow commented on issue #59: [IMAGING-242] Upgrade to Junit5 URL: https://github.com/apache/commons-imaging/pull/59#issuecomment-557875098 >The side advantage of this is to lock down the dependencies and not allow people to mix Jupiter and Vintage in the same class as was done in TestImag

[jira] [Work logged] (IMAGING-242) Move to JUnit 5

2019-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-242?focusedWorklogId=348685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348685 ] ASF GitHub Bot logged work on IMAGING-242: -- Author: ASF GitHub Bot

[jira] [Work logged] (IMAGING-242) Move to JUnit 5

2019-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-242?focusedWorklogId=348686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348686 ] ASF GitHub Bot logged work on IMAGING-242: -- Author: ASF GitHub Bot

[GitHub] [commons-imaging] kinow merged pull request #61: IMAGING-242 Complete the migration to JUnit Jupiter

2019-11-24 Thread GitBox
kinow merged pull request #61: IMAGING-242 Complete the migration to JUnit Jupiter URL: https://github.com/apache/commons-imaging/pull/61 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [commons-imaging] kinow commented on a change in pull request #61: IMAGING-242 Complete the migration to JUnit Jupiter

2019-11-24 Thread GitBox
kinow commented on a change in pull request #61: IMAGING-242 Complete the migration to JUnit Jupiter URL: https://github.com/apache/commons-imaging/pull/61#discussion_r349914359 ## File path: src/test/java/org/apache/commons/imaging/roundtrip/BitmapRoundtripTest.java ## @

[GitHub] [commons-imaging] kinow commented on issue #61: IMAGING-242 Complete the migration to JUnit Jupiter

2019-11-24 Thread GitBox
kinow commented on issue #61: IMAGING-242 Complete the migration to JUnit Jupiter URL: https://github.com/apache/commons-imaging/pull/61#issuecomment-557874998 Thanks a lot @mureinik ! I learned a bit more after this PR, and now Imaging is fully Junit 5 :confetti_ball: --

[jira] [Work logged] (IMAGING-242) Move to JUnit 5

2019-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-242?focusedWorklogId=348684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348684 ] ASF GitHub Bot logged work on IMAGING-242: -- Author: ASF GitHub Bot

[GitHub] [commons-collections] Claudenw commented on issue #83: Initial bloom filter code contribution

2019-11-24 Thread GitBox
Claudenw commented on issue #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-557871331 Are there any open issues against this pull request. The latest change places a dependency on commons-codec 1.14-SNAPSHOT so that

[jira] [Commented] (CODEC-268) Deprecate methods in MurmurHash3 with no equivalent in the reference c++ source.

2019-11-24 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CODEC-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981011#comment-16981011 ] Claude Warren commented on CODEC-268: - I agree with most of this resolution steps in t

[GitHub] [commons-codec] Claudenw commented on issue #27: Murmur3fix

2019-11-24 Thread GitBox
Claudenw commented on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-557868665 Nit: I think that in MurmurHash3Test line 740 it should use answers2 not answers: for (int i = 0; i < answers*2*.length; i++) { not for (int i = 0;