garydgregory merged PR #239:
URL: https://github.com/apache/commons-net/pull/239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #610:
URL: https://github.com/apache/commons-io/pull/610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #212:
URL: https://github.com/apache/commons-scxml/pull/212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #211:
URL: https://github.com/apache/commons-scxml/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/IO-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved IO-854.
Fix Version/s: 2.16.1
Resolution: Fixed
> ThresholdingOutputStream never calls
[
https://issues.apache.org/jira/browse/IO-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated IO-854:
---
External issue URL: https://github.com/apache/commons-io/pull/609
> ThresholdingOutputStream never calls
garydgregory commented on PR #609:
URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038458663
Merged. I canceled 2.16.1 RC1; RC2 is on the way.
TY @rproserpio !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
garydgregory merged PR #609:
URL: https://github.com/apache/commons-io/pull/609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rproserpio commented on PR #609:
URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038430046
Yes, that sounds like the better solution. The only observable difference
from before 2.16.0 should be in `isThresholdExceeded`, where a count of zero
bytes and what was a negative
[
https://issues.apache.org/jira/browse/NET-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834097#comment-17834097
]
Gary D. Gregory commented on NET-729:
-
You're inventing a new meaning for "binary compatibility", binary
[
https://issues.apache.org/jira/browse/IMAGING-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philipp Ottlinger updated IMAGING-374:
--
Fix Version/s: 1.0.0-alpha5
> JavaDoc-Link is broken
> --
>
>
[
https://issues.apache.org/jira/browse/IMAGING-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834094#comment-17834094
]
Philipp Ottlinger commented on IMAGING-374:
---
Thanks for the hint, thus I got to know about
garydgregory commented on PR #609:
URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038404206
Hi @rproserpio
Thank you for your update. Unless there is actually meaning to having a
negative threshold, I think it should be normalized to 0 in the constructor. 0
has
[
https://issues.apache.org/jira/browse/NET-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834093#comment-17834093
]
Henrik Lindqvist commented on NET-729:
--
Sorry typo, i meant "binary compatibility" was broken in
rproserpio commented on PR #609:
URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038335346
@garydgregory I'm confident on the part of keeping the same behavior for
zero and negatives thresholds. However:
> Writing zero bytes writes nothing, so there is nothing to
Bill Orpet created IO-854:
-
Summary: ThresholdingOutputStream never calls thresholdReached()
when threshold < 0
Key: IO-854
URL: https://issues.apache.org/jira/browse/IO-854
Project: Commons IO
[
https://issues.apache.org/jira/browse/NET-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834083#comment-17834083
]
Henrik Lindqvist edited comment on NET-729 at 4/4/24 9:54 PM:
--
Thanks for the
[
https://issues.apache.org/jira/browse/NET-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834088#comment-17834088
]
Gary D. Gregory edited comment on NET-729 at 4/4/24 9:48 PM:
-
[~hlindqvi]
[
https://issues.apache.org/jira/browse/NET-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834088#comment-17834088
]
Gary D. Gregory commented on NET-729:
-
[~hlindqvi]
>Android 7 was released in 2016, that's 8 years old
rproserpio commented on PR #609:
URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038284583
I still not sure about this method:
```
public boolean isThresholdExceeded() {
return written > threshold;
}
```
--
This is an automated message
garydgregory commented on PR #609:
URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038269279
Hello @rproserpio
> I agree. However, this would amount to essentially revert #587 (minus the
the tests) and I don't know if that PR was done for some other reasons.
rproserpio commented on PR #609:
URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038245846
I agree. However, this would amount to essentially revert #507 (minus the
the tests) and I don't know if that PR was done for some other reasons.
--
This is an automated message
garydgregory commented on PR #609:
URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038233510
Hi @rproserpio
Feel free to fix the code in this PR.
The behavior for a negative threshold should be the same as 0 IMO. WDYT?
What does it even mean that a threshold is
[
https://issues.apache.org/jira/browse/NET-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834083#comment-17834083
]
Henrik Lindqvist commented on NET-729:
--
Thanks for the release log link, i must have missed that.
rproserpio commented on PR #609:
URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038217930
Thank you. Let me know if I could be of any help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
garydgregory commented on PR #609:
URL: https://github.com/apache/commons-io/pull/609#issuecomment-2038216160
Yeah, I'm not sure how I missed that. I don't understand why we don't just
map a negative value to just 0, mapping it to "threshold reached" is
suspicious. This needs a closer
rproserpio opened a new pull request, #609:
URL: https://github.com/apache/commons-io/pull/609
#587 introduces a change in behavior regarding cases where a
`ThresholdingOutputStream` is initialized with a negative threshold.
Previously, the `thresholdConsumer` would be notified upon
[
https://issues.apache.org/jira/browse/NET-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved NET-729.
-
Fix Version/s: 3.11.0
Resolution: Information Provided
> Undisclosed Java 8 requirement.
>
[
https://issues.apache.org/jira/browse/NET-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834062#comment-17834062
]
Gary D. Gregory commented on NET-729:
-
Hello [~hlindqvi]
The Java platform requirement has been
[
https://issues.apache.org/jira/browse/CODEC-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved CODEC-323.
---
Fix Version/s: 1.16.2
Resolution: Fixed
> Possible Out-of-Memory problem in Apache
[
https://issues.apache.org/jira/browse/CODEC-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833916#comment-17833916
]
Gary D. Gregory edited comment on CODEC-323 at 4/4/24 12:39 PM:
Hello
[
https://issues.apache.org/jira/browse/CODEC-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833916#comment-17833916
]
Gary D. Gregory commented on CODEC-323:
---
I don't think this is the case in git master at least.
garydgregory merged PR #290:
URL: https://github.com/apache/commons-bcel/pull/290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on PR #509:
URL: https://github.com/apache/commons-compress/pull/509#issuecomment-2036974533
Hello @krite
You'll need a unit test and possibly a test fixture to prove this fixes
anything and to avoid future regressions.
TY!
--
This is an automated message
garydgregory merged PR #510:
URL: https://github.com/apache/commons-compress/pull/510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/IO-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833906#comment-17833906
]
Gary D. Gregory commented on IO-850:
[~jcompan...@gmail.com]
I cannot reproduce your text in a unit
krite opened a new pull request, #509:
URL: https://github.com/apache/commons-compress/pull/509
Current implementation cannot read tar-files with folders.
This can easily be tested either by using commons-compress or any other
valid tar-tool.
Create a simple folder-structure
Sheung Chi Chan created CODEC-323:
-
Summary: Possible Out-of-Memory problem in Apache Commons Codec
PhoneticEngine class
Key: CODEC-323
URL: https://issues.apache.org/jira/browse/CODEC-323
Project:
[
https://issues.apache.org/jira/browse/IMAGING-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833837#comment-17833837
]
Dominik Stadler commented on IMAGING-332:
-
This seems to be fixed now via {{Allocator.check()}}
39 matches
Mail list logo
