[jira] [Commented] (NET-459) FTPClient.storeFile never returns in active mode if data channel cannot be established

2012-04-20 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/NET-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258318#comment-13258318 ] Sebb commented on NET-459: -- Where exactly does the method block? Can you take a thread dump to see?

[jira] [Commented] (IO-323) What should happen in FileUtils.sizeOf[Directory] when an overflow takes place?

2012-04-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254935#comment-13254935 ] Sebb commented on IO-323: - bq. How about a BigInteger method that will give you the right answer no

[jira] [Commented] (NET-458) MVSFTPEntryParser.parseSimpleEntry - ArrayIndexOutOfBoundsException

2012-04-13 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/NET-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253283#comment-13253283 ] Sebb commented on NET-458: -- Looks like the problem is caused by trying to split a string containing

[jira] [Commented] (LANG-799) DateUtils#parseDate uses default locale instead of US (or trying both default locale and Locale.English)

2012-04-12 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LANG-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252960#comment-13252960 ] Sebb commented on LANG-799: --- There seems no reason to treat Locale.ENGLISH specially here. I

[jira] [Commented] (IO-319) FileUtils.sizeOfDirectory follows symbolic links.

2012-04-11 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251777#comment-13251777 ] Sebb commented on IO-319: - Symbolic links are likely to be very rare on Windows. IMO it does not

[jira] [Commented] (EXEC-54) Problem with argument containing spaces

2012-04-03 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/EXEC-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245102#comment-13245102 ] Sebb commented on EXEC-54: -- Note that the quoting / escaping requirements vary by OS. AFAIK, not

[jira] [Commented] (CODEC-138) Complete FilterInputStream interface for BaseNCodecInputStream

2012-04-03 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245570#comment-13245570 ] Sebb commented on CODEC-138: Note: InputStream.reset() throws IOE so I think the patch is

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-04-02 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244472#comment-13244472 ] Sebb commented on CODEC-96: --- The mark/reset patch should really be on a separate JIRA, as it is

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-04-01 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243742#comment-13243742 ] Sebb commented on CODEC-96: --- codec-96-3rd-attempt.patch is very old (2010). I think it can be

[jira] [Commented] (CSV-78) Use Character instead of char for char fields except delimiter

2012-03-29 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241211#comment-13241211 ] Sebb commented on CSV-78: - I no longer like the idea of using a null Character to disable the setting,

[jira] [Commented] (CSV-35) Escaped line separators are not supported

2012-03-29 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241295#comment-13241295 ] Sebb commented on CSV-35: - The Lexer does currently (r1036896) handle escLF and escCR. The code

[jira] [Commented] (CSV-88) Not possible to create a CSVFormat from scratch

2012-03-29 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241526#comment-13241526 ] Sebb commented on CSV-88: - bq. PRISTINE is useless as a base format because all properties have to be

[jira] [Commented] (CSV-52) Keep track of record numbers

2012-03-29 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241528#comment-13241528 ] Sebb commented on CSV-52: - Maybe the number should also be stored in the record? The counter should

[jira] [Commented] (CSV-90) CSVFormat isEscaping/isEscaping are not public

2012-03-29 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241969#comment-13241969 ] Sebb commented on CSV-90: - Likewise there could be a public version of getHeader(). It would need to

[jira] [Commented] (CODEC-137) Main documentation page links wrong javadocs

2012-03-28 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240351#comment-13240351 ] Sebb commented on CODEC-137: As a work-round the current Javadocs (i.e. 1.6) are available from

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-03-28 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240542#comment-13240542 ] Sebb commented on CODEC-96: --- bq. BaseNCodec has a member xcontext which is never used Sorry, looks

[jira] [Commented] (CSV-88) Not possible to create a CSVFormat from scratch

2012-03-27 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239359#comment-13239359 ] Sebb commented on CSV-88: - bq. +0 for a no arg constructor equivalent to the default format. If you

[jira] [Commented] (CSV-53) Allow to always enclose printed values into quotes

2012-03-27 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239364#comment-13239364 ] Sebb commented on CSV-53: - +1 to including an OutputQuoting setting along those lines, e.g. an Enum.

[jira] [Commented] (CSV-53) Allow to always enclose printed values into quotes

2012-03-27 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239491#comment-13239491 ] Sebb commented on CSV-53: - If the user selects QUOTE_NONE then the only options for printing a value

[jira] [Commented] (JELLY-290) Links to source code in tutorial page are broken

2012-03-27 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/JELLY-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239530#comment-13239530 ] Sebb commented on JELLY-290: The files had moved from their original locations, which is why

[jira] [Commented] (JELLY-290) Links to source code in tutorial page are broken

2012-03-27 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/JELLY-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239549#comment-13239549 ] Sebb commented on JELLY-290: Also fixed XML source files so eventual rebuild will hopefully

[jira] [Commented] (CSV-84) Clarify comment handling

2012-03-27 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240074#comment-13240074 ] Sebb commented on CSV-84: - OK, so we should only allow comments at the start of a record. This may be

[jira] [Commented] (CSV-84) Clarify comment handling

2012-03-27 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240089#comment-13240089 ] Sebb commented on CSV-84: - bq. This case is not covered by the tests, In fact - as I discovered when

[jira] [Commented] (IO-315) Replace all String encoding parameters with a value type

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238278#comment-13238278 ] Sebb commented on IO-315: - I don't think this is a good idea. There are a lot of different encodings,

[jira] [Commented] (IO-233) Add Methods for Buffering Streams/Writers To IOUtils

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238298#comment-13238298 ] Sebb commented on IO-233: - @Aaron As I understand it, this issue is about adding buffering to I/O

[jira] [Commented] (CSV-82) CSVRecord inconsistent behaviour when header mapping is not found

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238362#comment-13238362 ] Sebb commented on CSV-82: - bq. In case 2 a null value is returned, because some column may be

[jira] [Commented] (IO-315) Replace all String encoding parameters with a value type

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238378#comment-13238378 ] Sebb commented on IO-315: - Thanks for the list. However, I don't think that makes a significant

[jira] [Commented] (IO-315) Replace all String encoding parameters with a value type

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238598#comment-13238598 ] Sebb commented on IO-315: - That makes a more sense now, but I think it would be overkill to introduce

[jira] [Commented] (CSV-73) HSQLDB supports two different field separators

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238623#comment-13238623 ] Sebb commented on CSV-73: - Nor do I, but for whatever reason, they do use two different separators.

[jira] [Commented] (CSV-86) Remove current character input parameter from Lexer methods

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238827#comment-13238827 ] Sebb commented on CSV-86: - I cannot see the point of dropping the current char from the

[jira] [Commented] (CSV-85) Allow comments to be returned in CSVRecord

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238863#comment-13238863 ] Sebb commented on CSV-85: - {code} a,b,c#Inline comment (1) #Separate comment (2) d,e,f,#Inline comment

[jira] [Commented] (CSV-84) Comment handling

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238874#comment-13238874 ] Sebb commented on CSV-84: - I don't know if there are formats with inline comments. The code currently

[jira] [Commented] (CSV-83) Provide a header encapsulator class

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238876#comment-13238876 ] Sebb commented on CSV-83: - bq. This would allow more a more flexible implementation if required.

[jira] [Commented] (CSV-85) Allow comments to be returned in CSVRecord

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238916#comment-13238916 ] Sebb commented on CSV-85: - OK, that makes sense, and should be relatively easy to implement. The only

[jira] [Commented] (CSV-77) RFC 4180 (DEFAULT) format is wrong; should not ignore spaces or blank lines

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238991#comment-13238991 ] Sebb commented on CSV-77: - I think we should keep the strict RFC4180 definition. RFC

[jira] [Commented] (CSV-83) Provide a header encapsulator class

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239032#comment-13239032 ] Sebb commented on CSV-83: - It looks as though the header Map is not part of the public API. If that is

[jira] [Commented] (CSV-75) ExtendedBufferReader does not handle EOL consistently

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239072#comment-13239072 ] Sebb commented on CSV-75: - Yes, perhaps it should be done by the lexer. But the quickest fix would be

[jira] [Commented] (CSV-75) ExtendedBufferReader does not handle EOL consistently

2012-03-26 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239084#comment-13239084 ] Sebb commented on CSV-75: - Enabled new test and added patch to fix it. But we should still consider if

[jira] [Commented] (CSV-86) Remove current character input parameter from Lexer methods

2012-03-25 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238032#comment-13238032 ] Sebb commented on CSV-86: - As I wrote on the dve list, the current character may perhaps be required

[jira] [Commented] (CSV-70) Improve readability of CSVLexer

2012-03-25 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13238039#comment-13238039 ] Sebb commented on CSV-70: - Yes, I tried something similar and it broke the tests. I think it would be

[jira] [Commented] (CSV-84) Comment handling

2012-03-24 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13237549#comment-13237549 ] Sebb commented on CSV-84: - At present (r1304503), the comment introducer is not recognised whilst

[jira] [Commented] (CSV-35) Escaped line separators are not supported

2012-03-23 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236649#comment-13236649 ] Sebb commented on CSV-35: - What should happen in the case of escapeCRLF? I presume only the CR should

[jira] [Commented] (CSV-54) Confusing semantic of the ignore leading/trailing spaces parameters

2012-03-23 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236661#comment-13236661 ] Sebb commented on CSV-54: - Definitely better to drop the separate leading/trailing space options.

[jira] [Commented] (CSV-70) Improve readability of CSVLexer

2012-03-23 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236687#comment-13236687 ] Sebb commented on CSV-70: - Another tricky aspect of the lexer is that currently it does a recursive

[jira] [Commented] (CSV-78) Use Character instead of char for char fields except delimiter

2012-03-23 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236732#comment-13236732 ] Sebb commented on CSV-78: - Two alternatives: 1) provide methods to disable the setting, e.g.

[jira] [Commented] (CSV-78) Use Character instead of char for char fields except delimiter

2012-03-23 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236783#comment-13236783 ] Sebb commented on CSV-78: - Also, it would speed up the isEscaping() etc methods; the Lexer would not

[jira] [Commented] (NET-455) FTPClient listFiles(FTPFileFilter) can be faster...

2012-03-23 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/NET-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13236849#comment-13236849 ] Sebb commented on NET-455: -- Does seem rather odd, because the listFiles() method actually filters

[jira] [Commented] (CSV-72) CSVFormat.DEFAULT should be renamed as RFC4180

2012-03-21 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234253#comment-13234253 ] Sebb commented on CSV-72: - I would expect DEFAULT to be an instance of CSVFormat with the default

[jira] [Commented] (CSV-71) Add convenience Methods to CSVLexer

2012-03-21 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234856#comment-13234856 ] Sebb commented on CSV-71: - Just tried on my system, and I see similar performance both with and

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-03-20 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233362#comment-13233362 ] Sebb commented on CODEC-96: --- I think it might be possible to move the mutable fields out of the

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-03-20 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234003#comment-13234003 ] Sebb commented on CODEC-96: --- I've got a prototype which passes all the tests. Basically I put all

[jira] [Commented] (IO-295) FileUtils.isSymlinks misses symlink folders

2012-03-18 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232280#comment-13232280 ] Sebb commented on IO-295: - It's far from ideal using a command shell for this, but if it is the only

[jira] [Commented] (CSV-58) Unicode escapes are lost if escape character is backslash

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231924#comment-13231924 ] Sebb commented on CSV-58: - I think the default should be to retain the original source characters if

[jira] [Commented] (IO-305) New copy() method in IOUtils that takes additional offset, length and buffersize arguments

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231927#comment-13231927 ] Sebb commented on IO-305: - The default buffer size of 4096 was chosen because it gives good

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231930#comment-13231930 ] Sebb commented on CSV-68: - I've just discovered another disadvantage of the current code. Removal of

[jira] [Commented] (NET-454) paths with spaces result in inaccurate file information

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/NET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232018#comment-13232018 ] Sebb commented on NET-454: -- bq. ftp ls 78/1295213/0/476312ca9c653ffc6cc8fb6e1649dae6/ModComp PO

[jira] [Commented] (CONFIGURATION-486) BeanHelper.setDefaultBeanFactory() is thread-hostile and not thread-safe

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232022#comment-13232022 ] Sebb commented on CONFIGURATION-486: Fixing the thread-safety issue is trivial.

[jira] [Commented] (CONFIGURATION-486) BeanHelper.setDefaultBeanFactory() is thread-hostile and not thread-safe

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232043#comment-13232043 ] Sebb commented on CONFIGURATION-486: Same problem with

[jira] [Commented] (CONFIGURATION-490) DefaultConfigurationKey.setExpressionEngine - non-final method called by constructor

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232045#comment-13232045 ] Sebb commented on CONFIGURATION-490: ConfigurationFactory as well

[jira] [Commented] (CONFIGURATION-490) DefaultConfigurationKey.setExpressionEngine - non-final method called by constructor

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232047#comment-13232047 ] Sebb commented on CONFIGURATION-490: Also: ConfigurationXMLReader()

[jira] [Commented] (CONFIGURATION-486) BeanHelper.setDefaultBeanFactory() is thread-hostile and not thread-safe

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232048#comment-13232048 ] Sebb commented on CONFIGURATION-486: ALso FileSystem.fileSystem

[jira] [Commented] (CONFIGURATION-486) BeanHelper.setDefaultBeanFactory() is thread-hostile and not thread-safe

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232049#comment-13232049 ] Sebb commented on CONFIGURATION-486:

[jira] [Commented] (IO-269) Tailer locks file from deletion/rename on Windows

2012-03-17 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232137#comment-13232137 ] Sebb commented on IO-269: - Thanks for the patch. In the benchmark, how big was the file that you were

[jira] [Commented] (IO-305) New copy() method in IOUtils that takes additional offset, length and buffersize arguments

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231047#comment-13231047 ] Sebb commented on IO-305: - The code would probably be simplified by using copyLarge for the case where

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231073#comment-13231073 ] Sebb commented on CSV-68: - The extra verbosity is .init(',') and .build() Not a lot. The gains are: -

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231369#comment-13231369 ] Sebb commented on CSV-68: - bq. how about renaming init(char) to withDelimiter(char) The delimiter is

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231440#comment-13231440 ] Sebb commented on CSV-68: - How about: {code} CSVFormat.withDelimiter(';').withEncapsulator('').go();

[jira] [Commented] (CSV-71) Add convenience Methods to CSVLexer

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231452#comment-13231452 ] Sebb commented on CSV-71: - What performance test is that? On my system the tests take about 3 times as

[jira] [Commented] (CSV-67) UnicodeUnescapeReader should not be applied before parsing

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231472#comment-13231472 ] Sebb commented on CSV-67: - OK, I'm working on removing it and moving the reader class to IO for a

[jira] [Commented] (CSV-71) Add convenience Methods to CSVLexer

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231474#comment-13231474 ] Sebb commented on CSV-71: - I meant that *all* the tests take about 3 times longer (including the

[jira] [Commented] (CSV-68) Use Builder pattern for CSVFormat

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231794#comment-13231794 ] Sebb commented on CSV-68: - OK, let's use build, which is only two characters longer. Is it really that

[jira] [Commented] (NET-454) paths with spaces result in inaccurate file information

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/NET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231798#comment-13231798 ] Sebb commented on NET-454: -- What are the file names on the server? paths with

[jira] [Commented] (NET-454) paths with spaces result in inaccurate file information

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/NET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231801#comment-13231801 ] Sebb commented on NET-454: -- Also, can you perform the listing using command-line FTP ?

[jira] [Commented] (NET-454) paths with spaces result in inaccurate file information

2012-03-16 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/NET-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231820#comment-13231820 ] Sebb commented on NET-454: -- What happens if you try: {code}

[jira] [Commented] (CSV-65) Header support

2012-03-15 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230085#comment-13230085 ] Sebb commented on CSV-65: - It should still be possible to read a CSV file without a header and without

[jira] [Commented] (CSV-65) Header support

2012-03-15 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230103#comment-13230103 ] Sebb commented on CSV-65: - I think the header should be initialised in the CSVParser ctor (failing

[jira] [Commented] (CSV-65) Header support

2012-03-15 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230147#comment-13230147 ] Sebb commented on CSV-65: - bq. I preferred a null array to save some memory. The empty string array

[jira] [Commented] (CSV-57) CSVParser.getRecords() contract is confusing

2012-03-14 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229206#comment-13229206 ] Sebb commented on CSV-57: - Patch dated 13/Mar/12 19:39 looks good to me.

[jira] [Commented] (CSV-58) Unicode escapes are lost if escape character is backslash

2012-03-14 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229415#comment-13229415 ] Sebb commented on CSV-58: - If unicode parsing is not selected, the unicode sequences lose their escape

[jira] [Commented] (CSV-61) CSVFormat combines input and output settings in a single class; might be clearer as separate classes

2012-03-14 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229522#comment-13229522 ] Sebb commented on CSV-61: - Applications that read CSV files don't necessarily want to write them and

[jira] [Commented] (CSV-63) CSVPrinter always quotes empty string if it is the first on a line

2012-03-14 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229532#comment-13229532 ] Sebb commented on CSV-63: - Yes, I saw that, but it does not apply to records with multiple values.

[jira] [Commented] (CSV-57) CSVParser.getRecords() contract is confusing

2012-03-14 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229562#comment-13229562 ] Sebb commented on CSV-57: - I use displayed tab width 4, use spaces for tabs. I've not found out how

[jira] [Commented] (CSV-63) CSVPrinter always quotes empty string if it is the first on a line

2012-03-14 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229567#comment-13229567 ] Sebb commented on CSV-63: - I don't think we should take account of the number of fields, because again

[jira] [Commented] (CSV-64) CSVPrinter does not distinguish null and the empty string

2012-03-14 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229764#comment-13229764 ] Sebb commented on CSV-64: - Other databases may use explicit text strings for null. I used to work on

[jira] [Commented] (CSV-65) Header support

2012-03-14 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229825#comment-13229825 ] Sebb commented on CSV-65: - If the file does not provide a header record, it should be possible for the

[jira] [Commented] (IO-295) FileUtils.isSymlinks misses symlink folders

2012-03-13 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228909#comment-13228909 ] Sebb commented on IO-295: - At present, the method always returns false for Windows systems. Not sure

[jira] [Commented] (CSV-56) Do not use exotic escape characters for sequences like \r or \n

2012-03-12 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227654#comment-13227654 ] Sebb commented on CSV-56: - I think there are two kinds of escaping here. Sequences such as \r and \n

[jira] [Commented] (CSV-54) Confusing semantic of the ignore leading/trailing spaces parameters

2012-03-12 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227659#comment-13227659 ] Sebb commented on CSV-54: - I'm not sure I would expect any space removal to ever occur within quoted

[jira] [Commented] (CSV-51) Support unicode line separators

2012-03-12 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228058#comment-13228058 ] Sebb commented on CSV-51: - Would these be used as an alternative to CR/LF? Or would both be operative

[jira] [Commented] (CSV-34) CSVFormat describes itself as immutable, but it is not - in particular it is not thread-safe

2012-03-11 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227307#comment-13227307 ] Sebb commented on CSV-34: - That's quite surprising. Obviously volatile will have some overhead, but

[jira] [Commented] (COMMONSSITE-67) Add instructions for migrating Sandbox component to Proper

2012-03-10 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/COMMONSSITE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226847#comment-13226847 ] Sebb commented on COMMONSSITE-67: - More updates to POM: Change

[jira] [Commented] (CSV-43) CSVFormat fluent API is rather inefficient

2012-03-10 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226862#comment-13226862 ] Sebb commented on CSV-43: - Yes, every fluent method creates a new instance. That seems very wasteful.

[jira] [Commented] (CSV-43) CSVFormat fluent API is rather inefficient

2012-03-10 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226888#comment-13226888 ] Sebb commented on CSV-43: - Yes, a builder would also work, and would allow the class to be truly

[jira] [Commented] (CSV-43) CSVFormat fluent API is rather inefficient

2012-03-09 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CSV-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13226591#comment-13226591 ] Sebb commented on CSV-43: - OK, but so long as the predefined formats are frozen, it would still be

[jira] [Commented] (LANG-792) ToStringStyle registry may retain entries between invocations - is this a problem?

2012-03-08 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LANG-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225361#comment-13225361 ] Sebb commented on LANG-792: --- bq. If the registry was not a thread local, then all threads would

[jira] [Commented] (NET-451) FTPClient list and listName gives 500 error but when i use listFiles it is working fine

2012-03-08 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/NET-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225365#comment-13225365 ] Sebb commented on NET-451: -- You need to give a bit more information. What is the exact error

[jira] [Commented] (IO-305) New copy() method in IOUtils that takes additional offset, length and buffersize arguments

2012-03-07 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/IO-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224225#comment-13224225 ] Sebb commented on IO-305: - Should use long for the offset and length. It would be useful to return

[jira] [Commented] (SANDBOX-408) CSVFormat describes itself as immutable, but it is not - in particular it is not thread-safe

2012-03-07 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/SANDBOX-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224859#comment-13224859 ] Sebb commented on SANDBOX-408: -- I thought you wanted to be able to pass CSVFormat objects

[jira] [Commented] (COLLECTIONS-397) BoundedFifoBuffer could allow null entries

2012-03-07 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224885#comment-13224885 ] Sebb commented on COLLECTIONS-397: -- If COLLECTIONS-398-2.patch is applied (see

[jira] [Commented] (COLLECTIONS-285) TreeBidiMap should implement Serializable

2012-03-07 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13224934#comment-13224934 ] Sebb commented on COLLECTIONS-285: -- This patch only adds transient markers to the

  1   2   3   >