Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/354
Build failure seems to be unrelated.
---
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/354
Okay, as there is positive feedback for this change, I'm going to migrate
the whole `ValidateTest` to this style and then merge it ð
---
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/355
I'm going to reach out to the JUnit maintainers to find out whether we can
even inject zone values via parameter source.
---
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/355
Use @ParameterizedTest to iterate over available locales
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/commons-lang
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/354
@kinow @PascalSchumacher @chtompki WDYT?
---
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/354
Convert tests for Validate.isTrue overloads to @Nested test
Proposal for a better structure of tests using `@Nested`. Each method
should have it's own `@Nested` container which is called like
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/353
In general it's hard to review gigantic change sets which have been created
automatically, so I'd welcome an approach where we migrate one test case after
another.
---
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/353
It looks like an approach that can potentially some some work. I personally
would do it by hand. There is a lot of stuff that can't be detected
automatically. For example we have some tests
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/352
LANG-1416: Update to JUnit 5
- Add dependencies required for JUnit 5
- Update one test (ValidateTest) to use the JUnit 5 test API
You can merge this pull request into a Git repository
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/351
LANG-1417: Add @FunctionalInterface to ThreadPredicate and ThreadGrouâ¦
â¦pPredicate
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/349
We agreed to just add `@FunctionalInterface` to `ThreadPredicate` and
`ThreadGroupPredicate`
---
Github user britter closed the pull request at:
https://github.com/apache/commons-lang/pull/349
---
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/349
Build is failing on Travis but not locally... ð¤
---
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/349
In this proposal I added the java.util.function.Predicate APIs to the
ThreadUtils class. Another option is to deprecate ThreadUtils all together and
put a new ThreadUtils class alongside which
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/349
LANG-1417: Deprecate ThreadPredicate and ThreadGroupPredicate in favoâ¦
â¦r of java.util.function.Predicate
I don't see a way to let ThreadGroupPredicate and ThreadPredicate inherit
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/348
Explicit type parameters can be removed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/commons-lang remove-type-parameters
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/347
Looks like Java 11 no longer fails the build
Remove the allow_failures section for Java 11.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/346
LANG-1415: Update Java Language requirement to 1.8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/britter/commons-lang LANG-1415
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/343#discussion_r211340995
--- Diff: src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
---
@@ -25,10 +29,6 @@
import java.util.List;
import
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/343#discussion_r211342005
--- Diff: src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
---
@@ -58,14 +58,17 @@
* }
* MyClass rhs = (MyClass) obj
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/343#discussion_r211341588
--- Diff: src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
---
@@ -58,14 +58,17 @@
* }
* MyClass rhs = (MyClass) obj
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/341
Update maven-pmd-plugin to latest version
Just a tiny change to show everybody I'm still alive :o)
You can merge this pull request into a Git repository by running:
$ git pull https
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/299
I'll bring this up a last time on the ML to make sure nobody has objections
against merging this.
---
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/275
Removing the dependency in 4.x is the way to go. I don't see a way to get
this into 3.x :-(
---
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/301
Thank you!
Don't forget to have a look at CONTRIBUTING.md. If you intend to contribute
on a regular basis, it would be great if you could sign an Indivicual
Contributor License
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/301#discussion_r146108051
--- Diff: src/test/java/org/apache/commons/lang3/event/EventUtilsTest.java
---
@@ -135,9 +129,9 @@ public void testBindFilteredEventsToMethod
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/302
Thank you!
---
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/299#discussion_r144693421
--- Diff: .travis.yml ---
@@ -17,12 +17,10 @@ language: java
sudo: false
jdk:
- - openjdk7
--- End diff --
I think we
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/299
Awesome! Would be create if you could create and reference a JIRA ticket as
described in CONTRIBUTING.md, so this will show up in our release notes.
---
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/290
I agree with @garydgregory. @chtompki WDYT?
---
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/268
Travis build failed. Any idea why? Java 8 has an heap space error, while
the Java 9 build reports an unrecognized VM option.
---
If your project is set up for it, you can reply to this email
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/270
LANG-1338: Add Automatic-Module-Name MANIFEST entry for Java 9
compatibility.
This change duplicates the maven-jar-plugin configuration from parent
pom. After we have implemented
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/269#discussion_r120549733
--- Diff:
src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java ---
@@ -316,7 +317,7 @@ public void testReflectionHierarchyArrayList
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/commit/dfecbe970917754511a081f8b86efac211e624f6#commitcomment-21813145
Thank you! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/216
Great, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/214
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/213#discussion_r89192411
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -429,6 +429,65 @@ public StringEscapeUtils() {
super
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/208#discussion_r88777893
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -413,6 +447,47 @@ public int translate(final CharSequence input, final
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/208#discussion_r88777926
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -801,4 +876,61 @@ public static final String unescapeCsv(final String
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/208#discussion_r88777887
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -272,6 +272,40 @@ public int translate(final CharSequence input, final
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/213#discussion_r88745033
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -429,6 +429,65 @@ public StringEscapeUtils() {
super
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/213#discussion_r88745694
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -429,6 +429,65 @@ public StringEscapeUtils() {
super
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/213#discussion_r88745531
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -429,6 +429,65 @@ public StringEscapeUtils() {
super
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/213#discussion_r88745205
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -429,6 +429,65 @@ public StringEscapeUtils() {
super
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/196
@chtompki we don' need jira for these kind of changes, since they do not
affect the behavior of Commons Lang in any way. Feel free to merge.
---
If your project is set up for it, you can
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/192
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/194
@wangdongxun thanks for this PR, but I don't see this as a feature in
`StringUtils`. Can you elaborate some more what use case you have for this?
---
If your project is set up for it, you can
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/191
@amaral7 do you really want to configure this on a per field basis or would
it be enough to add a configuration option to `ToStringBuilder` to configure
the general behavior for all fields
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387226
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387208
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387206
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387223
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387200
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80387175
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,59 @@ public void testToCalendar
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/189
@kinow can you take the lead in reviewing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80358050
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,43 @@ public void testToCalendar
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80357986
--- Diff: src/main/java/org/apache/commons/lang3/time/DateUtils.java ---
@@ -668,6 +668,19 @@ public static Calendar toCalendar(final Date date
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/192#discussion_r80358033
--- Diff: src/test/java/org/apache/commons/lang3/time/DateUtilsTest.java ---
@@ -693,6 +693,43 @@ public void testToCalendar
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/193#discussion_r80357934
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -358,6 +387,36 @@ public static boolean isAnyBlank(final CharSequence...
css
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/193#discussion_r80357925
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -258,6 +258,35 @@ public static boolean isAnyEmpty(final CharSequence...
css
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/179#discussion_r79649084
--- Diff: src/main/java/org/apache/commons/lang3/text/WordUtils.java ---
@@ -172,6 +173,84 @@ public static String wrap(final String str, final int
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/179#discussion_r79648930
--- Diff: src/main/java/org/apache/commons/lang3/text/WordUtils.java ---
@@ -172,6 +173,84 @@ public static String wrap(final String str, final int
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/188
The issue has been moved to https://issues.apache.org/jira/browse/TEXT-19
Please reference TEXT-19 in your PR against the Commons Text repository. Thank
you!
---
If your project is set up
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/187
We already have `SystemUtils.isJavaVersionAtLeast(JavaVersion)` so there is
no reason to add this API.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user britter closed the pull request at:
https://github.com/apache/commons-lang/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/189
Hello @yufcuy,
can you provide more information as to why you think this change is
necessary? Does it improve performance properties? Do you have benchmarked the
new implementation
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/163
No, it contains no fix for Java 9 at all :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/163
@PascalSchumacher but why? This was going in the right direction!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/187
@PascalSchumacher I've changed the implementation to use the `IS_JAVA_XX`
fields from `SystemUtils`. However, Java 9 detection is still broken, since it
is broken in `SystemUtils
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/163
> Not complete: JavaVersion expects the java.version system property to
return 1.x but for java 9 it will return 9*. Not sure how to handle this.
I think we should better w
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/163#discussion_r78301302
--- Diff: src/main/java/org/apache/commons/lang3/JavaVersion.java ---
@@ -72,8 +72,15 @@
/**
* Java 1.9
GitHub user britter opened a pull request:
https://github.com/apache/commons-lang/pull/187
LANG-1263 Add possibility to retrieve the current JavaVersion
Added a constant `CURRENT` to the `JavaVersion` enum which represents the
JavaVersion for the `java.specification.version` system
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/186
Please also add your change to `src/changes/changes.xml`. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/186#discussion_r78298119
--- Diff: src/main/java/org/apache/commons/lang3/math/NumberUtils.java ---
@@ -1360,11 +1361,44 @@ public static boolean isDigits(final String str
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/186#discussion_r78293625
--- Diff: src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
---
@@ -1216,91 +1217,104 @@ public void testIsDigits
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/186#discussion_r78293587
--- Diff: src/main/java/org/apache/commons/lang3/math/NumberUtils.java ---
@@ -1374,8 +1407,11 @@ public static boolean isNumber(final String str
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/185
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/167
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/9
@PascalSchumacher I think @lingeng1986 should take care of clearing the PR
up so that it can be easily reviewed and applied.
---
If your project is set up for it, you can reply to this email
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/95#issuecomment-222085429
@oheger @PascalSchumacher: Nobody objected adding it to the concurrent
package. So from PoV it can be integrated into LANG.
---
If your project is set up
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/34#issuecomment-153749334
It has already been made public. The change will be released in 3.5,
probably before the end of the year.
---
If your project is set up for it, you can reply
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/111#issuecomment-151862191
@Punkratz312 I don't have a date for you. But I think I'll have some time
in Nov/Dec to push out a release.
---
If your project is set up for it, you can reply
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/commit/131917a0d3303ca2c38fd1d6765b9bed2c23ff89#commitcomment-13893327
In src/test/java/org/apache/commons/lang3/StringUtilsTest.java:
In src/test/java/org/apache/commons/lang3
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/112#issuecomment-149307896
Looks good to me. But we should also drop:
* default.properties
* src/release-tools (it also depends on the main ant build)
---
If your project is set up
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/112#issuecomment-149324877
Looks good to me now. Feel free to merge to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/112#discussion_r42408499
--- Diff: src/changes/changes.xml ---
@@ -22,6 +22,7 @@
+Remove Ant-based build
--- End diff --
Copy
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/112#discussion_r42416452
--- Diff: src/assembly/src.xml ---
@@ -32,7 +32,6 @@
pom.xml
PROPOSAL.html
RELEASE
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/112#discussion_r42408375
--- Diff: .gitignore ---
@@ -4,6 +4,7 @@ target
maven-eclipse.xml
build.properties
--- End diff --
Can be dropped from .gitignore
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/112#discussion_r42408346
--- Diff: .gitignore ---
@@ -4,6 +4,7 @@ target
maven-eclipse.xml
build.properties
site-content
+*~
--- End diff --
What
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/111#issuecomment-148897047
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/103#issuecomment-119846022
Hello @gliptak,
sorry for the delay. There are a lot of pending PRs but I don't have time
for OSS at the moment :-( I'll have a look as soon as I have
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/94#discussion_r32494301
--- Diff: src/test/java/org/apache/commons/lang3/RandomStringUtilsTest.java
---
@@ -16,18 +16,18 @@
*/
package org.apache.commons.lang3
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/94#discussion_r32494411
--- Diff: src/main/java/org/apache/commons/lang3/RandomStringUtils.java ---
@@ -95,6 +95,21 @@ public static String randomAscii(final int count
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/93#discussion_r32494469
--- Diff:
src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java ---
@@ -16,19 +16,16 @@
*/
package
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/94#issuecomment-112309707
Can you describe a use case for this functionality?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/93#issuecomment-112310767
Shouldn't this result in ` StringUtils.ordinalIndexOf(aa, aa, 2) ==
1` because the sequence 'aa' is at every index?
---
If your project is set up for it, you
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/87#issuecomment-102938179
Very nice, I'll have a look later this week!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/75#issuecomment-102940510
@rikles thank you for your thorough feedback. Give me some time to go
through your comments. I'll have time to have a look later this week.
---
If your project
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/87#issuecomment-102938770
@Lady-Stardust, what is the name you want to be listed with in
[changes.xml](https://github.com/apache/commons-lang/blob/master/src/changes/changes.xml
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/87#discussion_r30207724
--- Diff: src/main/java/org/apache/commons/lang3/Validate.java ---
@@ -874,7 +888,752 @@ public static void matchesPattern(final CharSequence
input
1 - 100 of 142 matches
Mail list logo
