Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/238
@mureinik I think removing these calls should be fine. Specially given that
other classes in lang use a normal String, and not `String.format` when there
are no parameters, e.g.
https
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/239
Yesterday learned something new about `String.format` via pull request
#238, and now learning about [UN M.49](https://en.wikipedia.org/wiki/UN_M.49).
Thanks again @PascalSchumacher
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/238
Didn't know about this use of `String.format` @PascalSchumacher , thanks :-)
I'm +1 for merging the pull request. Agree it's unlikely, and not sure if
its use was intentional
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/231
Oh, good point @PascalSchumacher have no objection to it. We could probably
avoid a few misunderstandings that way. Happy with that too @Tomschi ?
---
If your project is set up for it, you can
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/231
Gotcha, found this example
https://github.com/Tomschi/jacob-parent/blob/ec3f1c10169c26f14ee1f61bd6622c67a73e26fc/jacob/src/main/java/com/jacob/com/LibraryLoader.java#L202
Looks like
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/231
Thanks for updating the pull request @Tomschi.
I don't have a use case for this. I can see where it could be used, but I
don't have any project where I would use it. Code is clear
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/231
I remember a discussion about it some time ago.
The issue with this approach was that os.arch tells only the JVM arch, not
really OS arch.
If there is a strong use case
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/182
Hi @C0rWin
Some time ago I found this pull request and had to learn what was JMH :-)
added a comment on
[LANG-1110](https://issues.apache.org/jira/browse/LANG-1110), and today had
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/227
Merged. Thanks @Abrasha !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/commit/103b64a373256feae6ca85f2bf220e7694e48fa4#commitcomment-19637078
:grinning:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/198
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/199
Patch looks good. I wonder if the inline if will raise a warning in
checkstyle. Other than that, +1 :D
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user kinow opened a pull request:
https://github.com/apache/commons-lang/pull/195
LANG-1160 StringUtils.abbreviate() to support 'custom ellipses' parameter
From [LANG-1160](https://issues.apache.org/jira/browse/LANG-1160).
Before this pull request the code contained
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/194
Likewise @wangdongxun :-) are you albe to close this pull request?
Otherwise I believe there is some integration in our infrastructure to let us
close it.
Please do not hesitate
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/189
Ack @PascalSchumacher after @yufcuy 's feedback we can merge it and include
in 3.x releases, and then think where, and if, we should move text-related code
:-)
Thanks!
---
If your
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/194
Thanks for your contribution @wangdongxun !
>The method would be very confusing, as the String "null" is not all bank.
Agree with @PascalSchumacher . Adding this
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/189
Hi @yufcuy,
Sorry for the delay to look into this.
I looked at the first two implements this morning to refresh my memory. The
first one creating the whole comparison table
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/189
Though I also agree with @britter that some better description would help
reviewing it :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/189
I think string distances were the one of the first things we thought about
moving to [text]. Might be interesting to discuss implementing - if it makes
sense - this change there.
---
If your
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/171
@august782, thanks for being understanding. I think finding redundant
tests, and simplifying it is a good idea, just not in the case of tests
covering many different scenarios.
I think
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/171
Both tests use ClassUtils#wrapperToPrimitive. One passes a String.class,
and the other a null value. Then the method looks at a map, created and filled
in a static constructor.
Since
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/125#issuecomment-213862327
Adding an entry to changes.xml with dev=ggregory and the text "... closes
#125" in order to close this pull request.
---
If your project is set up for i
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/125#issuecomment-213862318
Placeholder ticket created https://issues.apache.org/jira/browse/LANG-1222
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/129#issuecomment-213861995
Adding an entry in changes.xml for that with dev= ggregory, with a message
containing the closes #129 in order to close this pull request in GitHub and
also keep
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/129#issuecomment-213861965
Placeholder ticket created https://issues.apache.org/jira/browse/LANG-1221
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/133#issuecomment-213860528
Tested locally. All tests pass. Line coverage for Date keeps in 95%, branch
coverage went from 90% to 92%, having 194/210 whereas it previously was 189/210
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/133#issuecomment-213860127
Merged in
https://github.com/apache/commons-lang/commit/fac65b868c549d28b786568636bbc8362d2a78f2
---
If your project is set up for it, you can reply to this email
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/133#issuecomment-213859206
Placeholder ticket created in JIRA
https://issues.apache.org/jira/browse/LANG-1220
---
If your project is set up for it, you can reply to this email and have your
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/101#issuecomment-116237900
#94, #100 and #101 are useful for generating random data for (for example)
testing. I thought about suggesting these methods to the incubating [text]
component
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/98#issuecomment-116250029
+1 @jochenw. Do you think it would be a good idea to start a discussion
thread in the dev mailing list as well?
---
If your project is set up for it, you can reply
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/98#issuecomment-113741510
@gzak feel free to update the pull request comment here or in JIRA,
otherwise we may close it as the current implementation needs rework.
Nice catch @netomi
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/98#issuecomment-113734542
Place holder ticket created in JIRA
https://issues.apache.org/jira/browse/LANG-1149
Feel free to write to the Commons Dev Mailing list (use the [lang] prefix
Github user kinow commented on the pull request:
https://github.com/apache/commons-lang/pull/98#issuecomment-113734438
Checked out the pull request locally, it compiles and the tests pass. The
minor checkstyle errors, the author tag and the missing license headers have to
be fixed
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/98#discussion_r32883472
--- Diff: src/main/java/org/apache/commons/lang3/exception/ThrowUtils.java
---
@@ -0,0 +1,35 @@
+package org.apache.commons.lang3.exception
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/98#discussion_r32883469
--- Diff:
src/test/java/org/apache/commons/lang3/exception/ThrowUtilsTest.java ---
@@ -0,0 +1,30 @@
+package org.apache.commons.lang3.exception
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/98#discussion_r32883445
--- Diff: src/main/java/org/apache/commons/lang3/exception/ThrowUtils.java
---
@@ -0,0 +1,35 @@
+package org.apache.commons.lang3.exception
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/98#discussion_r32883446
--- Diff: src/main/java/org/apache/commons/lang3/exception/ThrowUtils.java
---
@@ -0,0 +1,35 @@
+package org.apache.commons.lang3.exception
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/98#discussion_r32881012
--- Diff: src/main/java/org/apache/commons/lang3/exception/ThrowUtils.java
---
@@ -0,0 +1,35 @@
+package org.apache.commons.lang3.exception
101 - 138 of 138 matches
Mail list logo
