[
https://issues.apache.org/jira/browse/LANG-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923500#comment-16923500
]
Gary Gregory commented on LANG-1485:
We welcome PRs on GitHub, with unit tests of course ;)
>
coveralls commented on issue #451: LANG-1485 : Add getters for lhs and rhs
objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#issuecomment-528423902
[](https://coveralls.io/builds/25548920)
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307233=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307233
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
nicolasbd opened a new pull request #451: LANG-1485 : Add getters for lhs and
rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451
As explained in the [JIRA
ticket](https://issues.apache.org/jira/browse/LANG-1485) I add a getter for the
`lhs` and `rhs` objects
garydgregory commented on a change in pull request #451: LANG-1485 : Add
getters for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321334364
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas BARTHE-DEJEAN updated LANG-1485:
External issue URL: https://github.com/apache/commons-lang/pull/451
[
https://issues.apache.org/jira/browse/LANG-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923524#comment-16923524
]
Nicolas BARTHE-DEJEAN commented on LANG-1485:
-
Thanks [~ggregory] ! I just submitted it :
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307252=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307252
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
nicolasbd commented on a change in pull request #451: LANG-1485 : Add getters
for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321336631
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas BARTHE-DEJEAN updated LANG-1485:
Priority: Trivial (was: Major)
> DiffResult should expose its Left & Right objects
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307244=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307244
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
garydgregory commented on a change in pull request #451: LANG-1485 : Add
getters for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321334364
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307249=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307249
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
Nicolas BARTHE-DEJEAN created LANG-1485:
---
Summary: DiffResult should expose its Left & Right objects with
getters
Key: LANG-1485
URL: https://issues.apache.org/jira/browse/LANG-1485
Project:
[
https://issues.apache.org/jira/browse/LANG-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923376#comment-16923376
]
Chen commented on LANG-1453:
Add replace method in RegExUtils.java
public static String
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307257=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307257
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321342956
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -6654,10 +6656,8 @@
garydgregory commented on a change in pull request #451: LANG-1485 : Add
getters for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321364417
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307302=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307302
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
nicolasbd commented on a change in pull request #451: LANG-1485 : Add getters
for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321362834
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307298=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307298
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
nicolasbd commented on a change in pull request #451: LANG-1485 : Add getters
for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321367498
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory resolved LANG-1485.
Fix Version/s: 3.10
Resolution: Fixed
[~nicolasbd],
In git master; please verify and close.
garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321342200
##
File path: src/main/java/org/apache/commons/lang3/RandomStringUtils.java
##
@@ -359,7 +361,7 @@
garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321342040
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -211,7 +213,7 @@ public
garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321341997
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -153,7 +155,7 @@ public
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307280=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307280
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
nicolasbd commented on a change in pull request #451: LANG-1485 : Add getters
for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321353695
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
nicolasbd commented on a change in pull request #451: LANG-1485 : Add getters
for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321367498
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307305=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307305
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
garydgregory merged pull request #451: LANG-1485 : Add getters for lhs and rhs
objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307348=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307348
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
coveralls edited a comment on issue #451: LANG-1485 : Add getters for lhs and
rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#issuecomment-528423902
[](https://coveralls.io/builds/25551398)
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307320=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307320
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
nicolasbd commented on a change in pull request #451: LANG-1485 : Add getters
for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321370931
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307349=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307349
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307260=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307260
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321344922
##
File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
##
@@ -5098,8 +5097,8 @@ public
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307300=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307300
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1486?focusedWorklogId=307396=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307396
]
ASF GitHub Bot logged work on LANG-1486:
Author: ASF GitHub Bot
coveralls commented on issue #452: [LANG-1486] Generify builder classes
Diffable, DiffBuilder, and
URL: https://github.com/apache/commons-lang/pull/452#issuecomment-528537284
[](https://coveralls.io/builds/25553774)
nicolasbd commented on a change in pull request #451: LANG-1485 : Add getters
for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321336631
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321339846
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -95,7 +97,7 @@
public
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307292=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307292
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
garydgregory commented on a change in pull request #451: LANG-1485 : Add
getters for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321360417
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory updated LANG-1486:
---
External issue ID: 452
External issue URL: https://github.com/apache/commons-lang/pull/452
>
garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321339675
##
File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
##
@@ -267,15 +268,13 @@ public
garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321339846
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -95,7 +97,7 @@
public
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321358138
##
File path: src/main/java/org/apache/commons/lang3/Validate.java
##
@@ -106,7 +108,7 @@ public Validate()
coveralls edited a comment on issue #450: Add and use IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#issuecomment-527700188
[](https://coveralls.io/builds/25550034)
Coverage decreased
nicolasbd commented on a change in pull request #451: LANG-1485 : Add getters
for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321362834
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/RNG-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles resolved RNG-19.
---
Fix Version/s: 1.3
Resolution: Delivered
> System generator (/dev/random)
> --
>
>
garydgregory commented on a change in pull request #451: LANG-1485 : Add
getters for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321369998
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307310=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307310
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
garydgregory opened a new pull request #452: [LANG-1486] Generify builder
classes Diffable, DiffBuilder, and
URL: https://github.com/apache/commons-lang/pull/452
[LANG-1486] Generify builder classes Diffable, DiffBuilder, and DiffResult.
[
https://issues.apache.org/jira/browse/LANG-1486?focusedWorklogId=307387=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307387
]
ASF GitHub Bot logged work on LANG-1486:
Author: ASF GitHub Bot
nicolasbd commented on a change in pull request #451: LANG-1485 : Add getters
for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321336631
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307264=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307264
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321344141
##
File path: src/main/java/org/apache/commons/lang3/Functions.java
##
@@ -536,23 +545,22 @@ public
garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321343698
##
File path: src/main/java/org/apache/commons/lang3/Validate.java
##
@@ -106,7 +108,7 @@ public
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307309=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307309
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
nicolasbd commented on a change in pull request #451: LANG-1485 : Add getters
for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321367498
##
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##
[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307308=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307308
]
ASF GitHub Bot logged work on LANG-1485:
Author: ASF GitHub Bot
Gary Gregory created LANG-1486:
--
Summary: Generify builder classes Diffable, DiffBuilder, and
DiffResult
Key: LANG-1486
URL: https://issues.apache.org/jira/browse/LANG-1486
Project: Commons Lang
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321508013
##
File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
##
@@ -267,15 +268,13 @@ public static
Osy created JEXL-313:
Summary: Can one expression return a Float even when its elements
are Integer?
Key: JEXL-313
URL: https://issues.apache.org/jira/browse/JEXL-313
Project: Commons JEXL
Issue Type:
[
https://issues.apache.org/jira/browse/LANG-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923740#comment-16923740
]
Gerardo Torres Ontiveros commented on LANG-1453:
See LANG-1406 last comments, this is the
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321358138
##
File path: src/main/java/org/apache/commons/lang3/Validate.java
##
@@ -106,7 +108,7 @@ public Validate()
[
https://issues.apache.org/jira/browse/VFS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michiel Hendriks closed VFS-729.
Verified.
> Upgrade hadoop to 2.7.4 or later; will use current 3.2.0
>
[
https://issues.apache.org/jira/browse/LANG-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923235#comment-16923235
]
Chen commented on LANG-1453:
Since case mappings are not always 1:1 char mappings, the resulting may be a
[
https://issues.apache.org/jira/browse/MATH-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sudheer updated MATH-1497:
--
Affects Version/s: 3.6.1
> Performance issue with SVD calculation
> --
>
>
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321187877
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -372,10 +374,11 @@ public static
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321192501
##
File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
##
@@ -5098,8 +5097,8 @@ public static
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321186291
##
File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
##
@@ -267,15 +268,13 @@ public static
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321188879
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@ -6654,10 +6656,8 @@ private
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321187665
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -211,7 +213,7 @@ public static
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321188429
##
File path: src/main/java/org/apache/commons/lang3/RandomStringUtils.java
##
@@ -359,7 +361,7 @@ public
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321189874
##
File path: src/main/java/org/apache/commons/lang3/Validate.java
##
@@ -106,7 +108,7 @@ public Validate()
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321187746
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -269,7 +271,7 @@ public static
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321187445
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -95,7 +97,7 @@
public
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321187557
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -153,7 +155,7 @@ public static
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321190760
##
File path: src/main/java/org/apache/commons/lang3/Functions.java
##
@@ -536,23 +545,22 @@ public static
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321188061
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -372,10 +374,11 @@ public static
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321188207
##
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##
@@ -372,10 +374,11 @@ public static
sebbASF commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321186144
##
File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
##
@@ -267,15 +268,13 @@ public static
85 matches
Mail list logo
