Re: [PR] DBCP-595: Connection pool can be exhausted when connections are killed on the DB side [commons-dbcp]

2024-02-11 Thread via GitHub
dionusos commented on PR #348: URL: https://github.com/apache/commons-dbcp/pull/348#issuecomment-1938181413 @garydgregory Sure, I will do. I won't add/change any tests at the first place, because I don't intend to merge my change, but **start a conversation** if my findings are valid

[jira] [Closed] (LANG-1634) ObjectUtils - apply Consumer with non-null value

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LANG-1634. - Resolution: Duplicate > ObjectUtils - apply Consumer with non-null value >

[jira] [Commented] (DBCP-595) Connection pool can be exhausted when connections are killed on the DB side

2024-02-11 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816463#comment-17816463 ] Phil Steitz commented on DBCP-595: -- I am still working through the repro code, but the symptoms don't make

[jira] [Commented] (LOGGING-152) Helper class that redirects OutputStream to Log

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816438#comment-17816438 ] Elliotte Rusty Harold commented on LOGGING-152: --- Generally logs are redirected where the

[jira] [Commented] (LANG-1653) API visibility issues: Internal types are exposed in public API

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816436#comment-17816436 ] Elliotte Rusty Harold commented on LANG-1653: - Good catch. I'm not sure what to do here. These

[jira] [Commented] (LANG-1634) ObjectUtils - apply Consumer with non-null value

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816435#comment-17816435 ] Elliotte Rusty Harold commented on LANG-1634: - Dupe of LANG-1633. Close this one >

[jira] [Commented] (LANG-1599) Creating a Kotlin Commons Lang package.

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816434#comment-17816434 ] Elliotte Rusty Harold commented on LANG-1599: - I agree. If Kotlin folks want and are willing

[jira] [Commented] (LOGGING-152) Helper class that redirects OutputStream to Log

2024-02-11 Thread Dmitry Katsubo (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816433#comment-17816433 ] Dmitry Katsubo commented on LOGGING-152: What is in your opinion the right place to put this to?

[jira] [Closed] (LANG-607) StringUtils methods do not handle Unicode 2.0+ supplementary characters correctly.

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LANG-607. Fix Version/s: 3.14.0 (was: Patch Needed) Resolution: Fixed >

[jira] [Commented] (LANG-607) StringUtils methods do not handle Unicode 2.0+ supplementary characters correctly.

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816432#comment-17816432 ] Elliotte Rusty Harold commented on LANG-607: ping, should be closed per comment > StringUtils

[jira] [Closed] (LANG-1414) commons.componentId is incorrectly set to lang3

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LANG-1414. - Fix Version/s: 3.14.0 (was: 3.15.0) Resolution: Fixed >

[jira] [Updated] (LOGGING-112) Commons Logging in SLF4J flavour

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LOGGING-112: Fix Version/s: (was: 2.0) Affects Version/s: (was: 2.0) > Commons Logging

[jira] [Closed] (LOGGING-112) Commons Logging in SLF4J flavour

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LOGGING-112. --- Fix Version/s: 1.3.0 Resolution: Fixed Commons Logging now supports slf4j:

[jira] [Closed] (LOGGING-181) Remove log4j1 from commons-logging

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LOGGING-181. --- Resolution: Duplicate > Remove log4j1 from commons-logging >

[jira] [Closed] (LOGGING-175) Change Deprecated API usage

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LOGGING-175. --- Fix Version/s: 1.3.0 Resolution: Fixed > Change Deprecated API usage >

[jira] [Closed] (LOGGING-179) Redundant type cast and boxing

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LOGGING-179. --- Fix Version/s: 1.3.0 Resolution: Fixed > Redundant type cast and boxing >

[jira] [Closed] (LOGGING-166) Log4J2 Wrapper Class

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LOGGING-166. --- Fix Version/s: 1.3.0 Resolution: Fixed This was done separately for 1.3.0. > Log4J2

[jira] [Closed] (LANG-1531) escapeXml10 does not escape newline and tab characters to #xA

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LANG-1531. - Resolution: Invalid > escapeXml10 does not escape newline and tab characters to #xA >

[jira] [Closed] (LANG-1650) Release notes link is broken

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LANG-1650. - Fix Version/s: 3.14.0 Resolution: Fixed > Release notes link is broken >

[jira] [Closed] (LOGGING-165) Add Automatic-Module-Name Manifest Header for Java 9 compatibility

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LOGGING-165. --- Fix Version/s: 1.3.0 (was: 1.3.1) Resolution: Fixed Done. >

[jira] [Closed] (LANG-923) JDK 1.8 Changes

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed LANG-923. Resolution: Fixed Closing: Lang 3 has no time package.   > JDK 1.8 Changes > --- > >

[jira] [Updated] (LANG-923) JDK 1.8 Changes

2024-02-11 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-923: - Fix Version/s: (was: 4.0) > JDK 1.8 Changes > --- > > Key:

Re: [PR] Set GitHub repository for SCM URL & fix Java version in README [commons-lang]

2024-02-11 Thread via GitHub
garydgregory commented on code in PR #1170: URL: https://github.com/apache/commons-lang/pull/1170#discussion_r1485603943 ## README.md: ## @@ -56,7 +56,7 @@ Apache Commons Lang, a package of Java utility classes for the The code is tested using the latest revision of the JDK

Re: [PR] remove TODO from deprecated class we're not going to refactor [commons-lang]

2024-02-11 Thread via GitHub
garydgregory merged PR #1173: URL: https://github.com/apache/commons-lang/pull/1173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LANG-923) JDK 1.8 Changes

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816423#comment-17816423 ] Elliotte Rusty Harold commented on LANG-923: probably time to close this one > JDK 1.8 Changes

[jira] [Commented] (LANG-1531) escapeXml10 does not escape newline and tab characters to #xA

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816422#comment-17816422 ] Elliotte Rusty Harold commented on LANG-1531: - This is a misreading of the XML spec. There's

[jira] [Comment Edited] (LANG-1531) escapeXml10 does not escape newline and tab characters to #xA

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816421#comment-17816421 ] Elliotte Rusty Harold edited comment on LANG-1531 at 2/11/24 2:11 PM: --

[jira] [Comment Edited] (LANG-1531) escapeXml10 does not escape newline and tab characters to #xA

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816421#comment-17816421 ] Elliotte Rusty Harold edited comment on LANG-1531 at 2/11/24 2:10 PM: --

[PR] remove TODO from deprecated class we're not going to refactor [commons-lang]

2024-02-11 Thread via GitHub
elharo opened a new pull request, #1173: URL: https://github.com/apache/commons-lang/pull/1173 @garydgregory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (LANG-1531) escapeXml10 does not escape newline and tab characters to #xA

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816421#comment-17816421 ] Elliotte Rusty Harold commented on LANG-1531: - I disagree if the class still exists and it has

[jira] [Commented] (LANG-1650) Release notes link is broken

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816420#comment-17816420 ] Elliotte Rusty Harold commented on LANG-1650: - I think this one is moot given other changes on

[jira] [Commented] (LANG-1414) commons.componentId is incorrectly set to lang3

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LANG-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816419#comment-17816419 ] Elliotte Rusty Harold commented on LANG-1414: - This is what I see today in pom.xml: lang

[PR] cure generics warnings [commons-logging]

2024-02-11 Thread via GitHub
elharo opened a new pull request, #213: URL: https://github.com/apache/commons-logging/pull/213 Fixes some, not all, generics warnings in the code base. @garydgregory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (LOGGING-143) Update dependency on avalon-framework

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816414#comment-17816414 ] Elliotte Rusty Harold commented on LOGGING-143: --- Avalon is dead, and we should remove it

[jira] [Commented] (LOGGING-95) Extended API: getChildLogger(String)

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816412#comment-17816412 ] Elliotte Rusty Harold commented on LOGGING-95: -- probably close as won't do if we're now

[jira] [Commented] (LOGGING-166) Log4J2 Wrapper Class

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816411#comment-17816411 ] Elliotte Rusty Harold commented on LOGGING-166: --- There are no tests. You can send patches

[jira] [Commented] (LOGGING-184) Logging DOAP file has an error

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816410#comment-17816410 ] Elliotte Rusty Harold commented on LOGGING-184: --- wrong project. This is in log4cxx. Please

[jira] [Commented] (LOGGING-179) Redundant type cast and boxing

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816409#comment-17816409 ] Elliotte Rusty Harold commented on LOGGING-179: --- This was done and can be closed. >

[jira] [Commented] (LOGGING-152) Helper class that redirects OutputStream to Log

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816406#comment-17816406 ] Elliotte Rusty Harold commented on LOGGING-152: --- Feels like the wrong place to put this.

[jira] [Commented] (LOGGING-112) Commons Logging in SLF4J flavour

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816405#comment-17816405 ] Elliotte Rusty Harold commented on LOGGING-112: --- Will probably happen one of these days,

[jira] [Commented] (LOGGING-136) API Enhancements: 'String.format(String, Object...)' Functionality & Delegate Convenience Methods

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816404#comment-17816404 ] Elliotte Rusty Harold commented on LOGGING-136: --- sounds like this issue should be closed a

[jira] [Commented] (LOGGING-181) Remove log4j1 from commons-logging

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816402#comment-17816402 ] Elliotte Rusty Harold commented on LOGGING-181: --- This can be closed as a dupe of 180 and

[jira] [Commented] (LOGGING-175) Change Deprecated API usage

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816401#comment-17816401 ] Elliotte Rusty Harold commented on LOGGING-175: --- This one seems to be done and can be

[jira] [Commented] (LOGGING-165) Add Automatic-Module-Name Manifest Header for Java 9 compatibility

2024-02-11 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816400#comment-17816400 ] Elliotte Rusty Harold commented on LOGGING-165: --- This one seems to be done and can be