[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529016#comment-14529016 ] ASF GitHub Bot commented on LANG-701: - Github user britter commented on the pull request

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529006#comment-14529006 ] ASF GitHub Bot commented on LANG-701: - Github user asfgit closed the pull request at:

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527357#comment-14527357 ] ASF GitHub Bot commented on LANG-701: - Github user coveralls commented on the pull reque

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527356#comment-14527356 ] ASF GitHub Bot commented on LANG-701: - Github user coveralls commented on the pull reque

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527327#comment-14527327 ] ASF GitHub Bot commented on LANG-701: - Github user jamessawle closed the pull request at

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527329#comment-14527329 ] ASF GitHub Bot commented on LANG-701: - GitHub user jamessawle opened a pull request:

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527326#comment-14527326 ] ASF GitHub Bot commented on LANG-701: - Github user jamessawle commented on the pull requ

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514843#comment-14514843 ] ASF GitHub Bot commented on LANG-701: - Github user britter commented on the pull request

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514829#comment-14514829 ] ASF GitHub Bot commented on LANG-701: - GitHub user jamessawle reopened a pull request:

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514740#comment-14514740 ] ASF GitHub Bot commented on LANG-701: - Github user asfgit closed the pull request at:

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501503#comment-14501503 ] Benedikt Ritter commented on LANG-701: -- Hello [~jamessawle], I've reviewed the changes

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501504#comment-14501504 ] Benedikt Ritter commented on LANG-701: -- Hello [~jamessawle], I've reviewed the changes

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487005#comment-14487005 ] James Sawle commented on LANG-701: -- The changes have been made. > StringUtils join with va

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485848#comment-14485848 ] Benedikt Ritter commented on LANG-701: -- Thank you! > StringUtils join with var args >

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482781#comment-14482781 ] James Sawle commented on LANG-701: -- Sorry took a new job in October and have been trying to

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259129#comment-14259129 ] Benedikt Ritter commented on LANG-701: -- Hello [~jamessawle], I like your enthusiasm :)

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258839#comment-14258839 ] James Sawle commented on LANG-701: -- Ok... I will remove the check on the message for now,

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258781#comment-14258781 ] Benedikt Ritter commented on LANG-701: -- {quote} The issue I have with the @Expected ann

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247980#comment-14247980 ] James Sawle commented on LANG-701: -- I have updated the pull request to handle nulls the sam

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246414#comment-14246414 ] James Sawle commented on LANG-701: -- I will have a look at the null input value today or thi

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246397#comment-14246397 ] Benedikt Ritter commented on LANG-701: -- Hello James, nice idea to use ExpectedExceptio

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237607#comment-14237607 ] James Sawle commented on LANG-701: -- Are there any more comments on the pull request - http

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214930#comment-14214930 ] ASF GitHub Bot commented on LANG-701: - GitHub user jamessawle opened a pull request:

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080182#comment-14080182 ] Josh Cain commented on LANG-701: I really like the first option - looked for it at work toda

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494155#comment-13494155 ] Matt Benson commented on LANG-701: -- The current {{join}} APIs allow Objects for greatest ea

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493807#comment-13493807 ] Joerg Schaible commented on LANG-701: - bq. the input array should be of Object type, not

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493703#comment-13493703 ] Gary Gregory commented on LANG-701: --- I tried code inspired by this patch and the patch nee

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493403#comment-13493403 ] Matt Benson commented on LANG-701: -- Sounds good; keeping it short will make it that much ea

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493394#comment-13493394 ] Gary Gregory commented on LANG-701: --- Or simply {{joinWith}}. > StringUtil

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493380#comment-13493380 ] Matt Benson commented on LANG-701: -- That makes sense; arguably "delimited" better represent

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493342#comment-13493342 ] Gary Gregory commented on LANG-701: --- Let's review what we have: join(Iterable, char) join

[jira] [Commented] (LANG-701) StringUtils join with var args

[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493275#comment-13493275 ] Gary Gregory commented on LANG-701: --- Simple things first ;) {quote} commit -m "[LANG-701]