[jira] [Commented] (CB-12232) [cordova-android] Skipping HTTPS certificate validation should be hidden behind a flag, and not a default in debug builds
[ https://issues.apache.org/jira/browse/CB-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746620#comment-15746620 ] Joe Bowser commented on CB-12232: - The unpopular opinion is that we should never skip HTTP certificate verification, and it should always fail, and there should be no flag to turn it off. That said, I know developers who would be extremely irate if you were to do this. The debug flag was set because it was believed that people would be developing their server APIs and their application in parallel and that getting a proper SSL certificate would be done because it was the right thing to do. It's common for people to have local configuration with a self-signed SSL certificate for development as well. We do document this behaviour in our docs, and any time we want to revisit this behaviour, we get serious pushback from many enterprise users. (BTW: If you're one of them, please comment here) [~kerrishotts] Crosswalk always throws errors? I wasn't aware that it was doing the right thing all the time. > [cordova-android] Skipping HTTPS certificate validation should be hidden > behind a flag, and not a default in debug builds > - > > Key: CB-12232 > URL: https://issues.apache.org/jira/browse/CB-12232 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Affects Versions: 6.2.0 >Reporter: jakub-g > Labels: android > > Right now, when you create a debuggable Cordova build (default behavior for > commands like `cordova run android` etc.), it by default ignores all HTTPS > certificate errors, as you can see in the code below: > https://github.com/apache/cordova-android/blob/23fd0982b0faa6b7e169c2946eab07930f1f4d16/framework/src/org/apache/cordova/engine/SystemWebViewClient.java#L232-L239 > HTTPS certs are only validated when you create a release build, explicitly > passing a flag, e.g. > {{cordova run android --release}} > This behavior is IMO harmful, and let me tell you why (see below for two > real-life stories) > *TL;DR I believe it would be better to not bind the lax HTTPS behavior to > {{\-\-debug}} vs {{\-\-release}} build type, but hide it behind a special > flag (to follow Chrome's naming convention, that would be > {{\-\-ignore-certificate-errors}}, but we can name it whatever we like). This > would expose developers to HTTPS errors much earlier in the dev process, > which IMO is beneficial; it will also make it easier to understand and debug > the problems, and avoid last-minute surprises.* > _Question: do we have a portion of code already that makes runtime behavior > depend on build-time flag? i.e. would it be easy to add a new flag in a > similar way, without herculean effort?_ > So, the promised real-life stories: > 1) Consider, that you have an HTTPS website and your HTTPS certificate is > somehow invalid (but you don't know about that). You develop your stuff _for > weeks and weeks_ in debug builds and everything is great. You prepare for > grand APK upload to Play Store, do a {{\-\-release}} build, and... stuff > doesn't work! You want to debug it, but you can't - because {{\-\-release}} > build is non-debuggable! This looks super mysterious and you're totally > baffled. > Doing black-box debugging on --release build ain't easy, but you give it a > try. > You're thinking about all possible things that could go wrong (code > minification? some issue with signing keys? Cordova/Chrome/Android are > broken?), finally after a while you reach to google and you figure out the > issue is due to cordova only checking HTTPS certs in {{\-\-release}} mode. > People tell about self-signed certs, but your cert looks legit, after all, it > works on all desktop client. But at least you know where to look. > Luckily for you, the staging platform has a publicly accessible domain name. > You test your cert with SSLLabs and it tells you that your server doesn't > send all intermediary certs. It's still not sure if this is the issue, but > you ask the ops team to update the server. > They get a better cert and update server config to send the intermediary > cert. You're saved! This was the missing piece to make the app work. > 2) Suppose you never had the issue 1), you built an app, it works in > production, all is well. One day, you change the HTTPS cert in production > (because an old one expired etc.), you do quick tests, all is well (or, even > worse: when in big corporation, ops guys change the HTTPS cert without > telling you). You forget about it, and continue developing your app. You're a > dev and you're constantly in the Chrome DevTools, so naturally you always > build debuggable builds. You keep adding features for weeks, all works great > in
[jira] [Commented] (CB-11628) Cordova Screen Orientation Plugin
[ https://issues.apache.org/jira/browse/CB-11628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746601#comment-15746601 ] ASF GitHub Bot commented on CB-11628: - Github user purplecabbage commented on the issue: https://github.com/apache/cordova-plugin-screen-orientation/pull/4 This pull request is missing about 10 tests. There is also some weird history happening, ex. `www/screenorientation.android.js → tests/tests.js` > Cordova Screen Orientation Plugin > - > > Key: CB-11628 > URL: https://issues.apache.org/jira/browse/CB-11628 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Screen Orientation > Environment: Android,iOS, Windows >Reporter: Vishal Mishra >Assignee: Vishal Mishra > Original Estimate: 336h > Remaining Estimate: 336h > > Make sure the orientation plugin matches the spec. > We should also include tests. > repo: https://github.com/apache/cordova-plugin-screen-orientation > spec: https://www.w3.org/TR/screen-orientation/ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-12232) [cordova-android] Skipping HTTPS certificate validation should be hidden behind a flag, and not a default in debug builds
[ https://issues.apache.org/jira/browse/CB-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746620#comment-15746620 ] Joe Bowser edited comment on CB-12232 at 12/13/16 11:41 PM: The unpopular opinion is that we should never skip HTTP certificate verification, and it should always fail, and there should be no flag to turn it off. That said, I know developers who would be extremely irate if you were to do this, and to them even adding this flag is doing this. The flag is a good idea, but I can see people rage over this one. The debug flag was set because it was believed that people would be developing their server APIs and their application in parallel and that getting a proper SSL certificate would be done because it was the right thing to do. It's common for people to have local configuration with a self-signed SSL certificate for development as well. We do document this behaviour in our docs, and any time we want to revisit this behaviour, we get serious pushback from many enterprise users. (BTW: If you're one of them, please comment here) [~kerrishotts] Crosswalk always throws errors? I wasn't aware that it was doing the right thing all the time. was (Author: bowserj): The unpopular opinion is that we should never skip HTTP certificate verification, and it should always fail, and there should be no flag to turn it off. That said, I know developers who would be extremely irate if you were to do this. The debug flag was set because it was believed that people would be developing their server APIs and their application in parallel and that getting a proper SSL certificate would be done because it was the right thing to do. It's common for people to have local configuration with a self-signed SSL certificate for development as well. We do document this behaviour in our docs, and any time we want to revisit this behaviour, we get serious pushback from many enterprise users. (BTW: If you're one of them, please comment here) [~kerrishotts] Crosswalk always throws errors? I wasn't aware that it was doing the right thing all the time. > [cordova-android] Skipping HTTPS certificate validation should be hidden > behind a flag, and not a default in debug builds > - > > Key: CB-12232 > URL: https://issues.apache.org/jira/browse/CB-12232 > Project: Apache Cordova > Issue Type: Improvement > Components: Android >Affects Versions: 6.2.0 >Reporter: jakub-g > Labels: android > > Right now, when you create a debuggable Cordova build (default behavior for > commands like `cordova run android` etc.), it by default ignores all HTTPS > certificate errors, as you can see in the code below: > https://github.com/apache/cordova-android/blob/23fd0982b0faa6b7e169c2946eab07930f1f4d16/framework/src/org/apache/cordova/engine/SystemWebViewClient.java#L232-L239 > HTTPS certs are only validated when you create a release build, explicitly > passing a flag, e.g. > {{cordova run android --release}} > This behavior is IMO harmful, and let me tell you why (see below for two > real-life stories) > *TL;DR I believe it would be better to not bind the lax HTTPS behavior to > {{\-\-debug}} vs {{\-\-release}} build type, but hide it behind a special > flag (to follow Chrome's naming convention, that would be > {{\-\-ignore-certificate-errors}}, but we can name it whatever we like). This > would expose developers to HTTPS errors much earlier in the dev process, > which IMO is beneficial; it will also make it easier to understand and debug > the problems, and avoid last-minute surprises.* > _Question: do we have a portion of code already that makes runtime behavior > depend on build-time flag? i.e. would it be easy to add a new flag in a > similar way, without herculean effort?_ > So, the promised real-life stories: > 1) Consider, that you have an HTTPS website and your HTTPS certificate is > somehow invalid (but you don't know about that). You develop your stuff _for > weeks and weeks_ in debug builds and everything is great. You prepare for > grand APK upload to Play Store, do a {{\-\-release}} build, and... stuff > doesn't work! You want to debug it, but you can't - because {{\-\-release}} > build is non-debuggable! This looks super mysterious and you're totally > baffled. > Doing black-box debugging on --release build ain't easy, but you give it a > try. > You're thinking about all possible things that could go wrong (code > minification? some issue with signing keys? Cordova/Chrome/Android are > broken?), finally after a while you reach to google and you figure out the > issue is due to cordova only checking HTTPS certs in {{\-\-release}} mode. > People tell about self-signed
[jira] [Created] (CB-12245) CB-5195 patch causes EXIF data to completely disappear from images taken on a Samsung Galaxy S5/6/7 device
Joe Bowser created CB-12245: --- Summary: CB-5195 patch causes EXIF data to completely disappear from images taken on a Samsung Galaxy S5/6/7 device Key: CB-12245 URL: https://issues.apache.org/jira/browse/CB-12245 Project: Apache Cordova Issue Type: Bug Components: Plugin Camera Reporter: Joe Bowser Assignee: Joe Bowser Priority: Critical EXIF data has been stripped from photos from a very popular application that is currently deployed in the app store after they migrated to the latest version of Camera when dealing with CB-11625. It appears that the fix for CB-5195 has caused this issue on Samsung and LG devices. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1
[ https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746659#comment-15746659 ] ASF GitHub Bot commented on CB-3232: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-screen-orientation/pull/5 > "cordova platform add blackberry" fails on 2.7.1-rc.1 > - > > Key: CB-3232 > URL: https://issues.apache.org/jira/browse/CB-3232 > Project: Apache Cordova > Issue Type: Bug > Components: BlackBerry, CLI >Affects Versions: 2.7.0 >Reporter: Michael Brooks >Assignee: Michael Brooks > Fix For: 2.7.0 > > > The following error is thrown when running {{$ cordova platform add > blackberry}}: > {code} > [Error: An error occured during creation of blackberry sub-project. Creating > BlackBerry project... > Updating config.xml ... > sed: > /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml: > No such file or directory > Cleaning up ... > Remember to update the project.properties file inside your application > directory! > ] > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11628) Cordova Screen Orientation Plugin
[ https://issues.apache.org/jira/browse/CB-11628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746649#comment-15746649 ] ASF GitHub Bot commented on CB-11628: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-screen-orientation/pull/4 > Cordova Screen Orientation Plugin > - > > Key: CB-11628 > URL: https://issues.apache.org/jira/browse/CB-11628 > Project: Apache Cordova > Issue Type: Improvement > Components: Plugin Screen Orientation > Environment: Android,iOS, Windows >Reporter: Vishal Mishra >Assignee: Vishal Mishra > Original Estimate: 336h > Remaining Estimate: 336h > > Make sure the orientation plugin matches the spec. > We should also include tests. > repo: https://github.com/apache/cordova-plugin-screen-orientation > spec: https://www.w3.org/TR/screen-orientation/ -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12240) Recording audio with MediaPlugin on Android failed with exception
[ https://issues.apache.org/jira/browse/CB-12240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-12240: Labels: Android (was: ) Component/s: (was: Android) > Recording audio with MediaPlugin on Android failed with exception > - > > Key: CB-12240 > URL: https://issues.apache.org/jira/browse/CB-12240 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media > Environment: Android >Reporter: Marijn Giesen > Labels: Android > > Recording audio using the MediaPlugin on Android fails with exception. The > audiorecorder seems to be working, but the file never gets created. > The following exception is shown in the logs: > {noformat} > 12-12 05:57:08.397 1777 1818 D AudioPlayer: stopping recording > 12-12 05:57:08.401 1777 1818 D AudioPlayer: size = 2 > 12-12 05:57:08.402 1777 1818 E AudioPlayer: > /storage/emulated/0/tmprecording-1481540219004.3gp: open failed: ENOENT (No > such file or directory) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: java.io.FileNotFoundException: > /storage/emulated/0/tmprecording-1481540219004.3gp: open failed: ENOENT (No > such file or directory) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > libcore.io.IoBridge.open(IoBridge.java:452) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > java.io.FileInputStream.(FileInputStream.java:76) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.media.AudioPlayer.moveFile(AudioPlayer.java:213) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.media.AudioPlayer.stopRecording(AudioPlayer.java:271) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.media.AudioPlayer.destroy(AudioPlayer.java:133) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.media.AudioHandler.release(AudioHandler.java:276) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.media.AudioHandler.execute(AudioHandler.java:170) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.CordovaPlugin.execute(CordovaPlugin.java:98) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.PluginManager.exec(PluginManager.java:132) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:57) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.engine.SystemExposedJsApi.exec(SystemExposedJsApi.java:41) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:53) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > android.os.Handler.dispatchMessage(Handler.java:102) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > android.os.Looper.loop(Looper.java:148) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > android.os.HandlerThread.run(HandlerThread.java:61) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: Caused by: > android.system.ErrnoException: open failed: ENOENT (No such file or directory) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > libcore.io.Posix.open(Native Method) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > libcore.io.BlockGuardOs.open(BlockGuardOs.java:186) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > libcore.io.IoBridge.open(IoBridge.java:438) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: ... 15 more > 12-12 05:57:08.402 1777 1818 E AudioPlayer: > /storage/emulated/0/tmprecording-1481540219004.3gp: open failed: ENOENT (No > such file or directory) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: java.io.FileNotFoundException: > /storage/emulated/0/tmprecording-1481540219004.3gp: open failed: ENOENT (No > such file or directory) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > libcore.io.IoBridge.open(IoBridge.java:452) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > java.io.FileInputStream.(FileInputStream.java:76) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.media.AudioPlayer.moveFile(AudioPlayer.java:213) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.media.AudioPlayer.stopRecording(AudioPlayer.java:271) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.media.AudioPlayer.destroy(AudioPlayer.java:133) > 12-12 05:57:08.402 1777 1818 E AudioPlayer: at > org.apache.cordova.media.AudioHandler.release(AudioHandler.java:276) > 12-12
[jira] [Resolved] (CB-12220) CordovaActivity leaked ServiceConnection when phone's back key pressed
[ https://issues.apache.org/jira/browse/CB-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser resolved CB-12220. - Resolution: Won't Fix It looks like Chrome Accessibility has a bug! Unfortunately, we can't anything about this issue other than recommend that you try Crosswalk. This is a system error caused by the eyes-free service in Chrome. Are you using this service? > CordovaActivity leaked ServiceConnection when phone's back key pressed > -- > > Key: CB-12220 > URL: https://issues.apache.org/jira/browse/CB-12220 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: Master > Environment: Eclipse With AndroidSDKVer6.0 > Test On AndroidOS4.4.4 >Reporter: WillZhang > Original Estimate: 72h > Remaining Estimate: 72h > > when press the back key on my AndroidPhone in the page that integrated > CordovaLib and extends CordovaActivity,the following error occurred in the > LogCat. > 12-06 15:41:51.785: I/Timeline(20818): Timeline: Activity_idle id: > android.os.BinderProxy@431c2e00 time:30570018 > 12-06 15:41:52.085: D/CordovaActivity(20818): Stopped the activity. > 12-06 15:41:52.085: D/CordovaActivity(20818): CordovaActivity.onDestroy() > 12-06 15:41:52.085: D/CordovaWebViewImpl(20818): >>> loadUrl(about:blank) > 12-06 15:41:52.125: E/ActivityThread(20818): Activity > com.test.cordova.activity.H5WebActivity has leaked ServiceConnection > com.android.org.chromium.com.googlecode.eyesfree.braille.selfbraille.SelfBrailleClient$Connection@42ad4bb0 > that was originally bound here > 12-06 15:41:52.125: E/ActivityThread(20818): > android.app.ServiceConnectionLeaked: Activity > com.test.cordova.activity.H5WebActivity has leaked ServiceConnection > com.android.org.chromium.com.googlecode.eyesfree.braille.selfbraille.SelfBrailleClient$Connection@42ad4bb0 > that was originally bound here > 12-06 15:41:52.125: E/ActivityThread(20818):at > android.app.LoadedApk$ServiceDispatcher.(LoadedApk.java:972) > 12-06 15:41:52.125: E/ActivityThread(20818):at > android.app.LoadedApk.getServiceDispatcher(LoadedApk.java:866) > 12-06 15:41:52.125: E/ActivityThread(20818):at > android.app.ContextImpl.bindServiceCommon(ContextImpl.java:1593) > 12-06 15:41:52.125: E/ActivityThread(20818):at > android.app.ContextImpl.bindService(ContextImpl.java:1576) > 12-06 15:41:52.125: E/ActivityThread(20818):at > android.content.ContextWrapper.bindService(ContextWrapper.java:517) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.org.chromium.com.googlecode.eyesfree.braille.selfbraille.SelfBrailleClient.doBindService(SelfBrailleClient.java:125) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.org.chromium.com.googlecode.eyesfree.braille.selfbraille.SelfBrailleClient.(SelfBrailleClient.java:99) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.org.chromium.content.browser.accessibility.AccessibilityInjector$TextToSpeechWrapper.(AccessibilityInjector.java:399) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.org.chromium.content.browser.accessibility.AccessibilityInjector.addAccessibilityApis(AccessibilityInjector.java:278) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.org.chromium.content.browser.accessibility.JellyBeanAccessibilityInjector.addAccessibilityApis(JellyBeanAccessibilityInjector.java:86) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.org.chromium.content.browser.accessibility.AccessibilityInjector.addOrRemoveAccessibilityApisIfNecessary(AccessibilityInjector.java:160) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.org.chromium.content.browser.ContentViewCore.setInjectedAccessibility(ContentViewCore.java:3563) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.org.chromium.content.browser.ContentViewCore.setAccessibilityState(ContentViewCore.java:3554) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.org.chromium.content.browser.ContentViewCore.onAttachedToWindow(ContentViewCore.java:1672) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.org.chromium.android_webview.AwContents.onAttachedToWindow(AwContents.java:1568) > 12-06 15:41:52.125: E/ActivityThread(20818):at > com.android.webview.chromium.WebViewChromium.onAttachedToWindow(WebViewChromium.java:1691) > 12-06 15:41:52.125: E/ActivityThread(20818):at > android.webkit.WebView.onAttachedToWindow(WebView.java:2103) > 12-06 15:41:52.125: E/ActivityThread(20818):at > android.view.View.dispatchAttachedToWindow(View.java:12596) > 12-06 15:41:52.125: E/ActivityThread(20818):at > android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:2458) > 12-06 15:41:52.125:
[jira] [Commented] (CB-12197) Remove personal copyright notice
[ https://issues.apache.org/jira/browse/CB-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1574#comment-1574 ] ASF GitHub Bot commented on CB-12197: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/507 > Remove personal copyright notice > > > Key: CB-12197 > URL: https://issues.apache.org/jira/browse/CB-12197 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon, CordovaLib >Reporter: Shazron Abdullah >Assignee: Audrey So > Labels: easyfix > > 1. > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/plugman/util/search-and-replace.js#L4 > 2. > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-common/src/util/plist-helpers.js#L3 > 3. > https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/plugman/util/plist-helpers.js#L3 > Brett Rudd is an Apache Cordova committer and thus has signed the iCLA. > Also, there are multiple occurrences of copyright from "Anis Kadri" > (Copyright 2013 Anis Kadri) that need to be removed as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11914) media-capture plugin captureVideo doesn't restrict video to specified duration (Android)
[ https://issues.apache.org/jira/browse/CB-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Bowser updated CB-11914: Labels: Android (was: ) Component/s: (was: Android) > media-capture plugin captureVideo doesn't restrict video to specified > duration (Android) > > > Key: CB-11914 > URL: https://issues.apache.org/jira/browse/CB-11914 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media Capture > Environment: Issue is seen on almost all phones with Android 6.0.1 or > above except a Samsung S6 Edge running 6.0.1; >Reporter: Prabhu Sengal > Labels: Android > > The following code fails to end video capture after 10 seconds on phones > running Android 6.0.1 or above. In all other versions, the video capture is > ended in 10 seconds with message "Maximum recording time reached". > {code:title=index.js|borderStyle=solid} > captureVideo: function() { > navigator.device.capture.captureVideo( > function(mediaFiles) { > // success callback > var i, path, len; > for (i = 0, len = mediaFiles.length; i < len; i += 1) { > path = mediaFiles[i].fullPath; > console.log("Success : " + path); > } > }, > function(error) { > // error callback > console.log('Error code: ' + error.code, null, 'Capture > Error'); > }, > { > limit: 1, > quality: 0, > duration: 10 > } > ); > } > {code} > I am on, > phonegap@6.2.6 (tried with 6.3.3 - same behaviour) > cordova@6.1.1 > cordova-plugin-media-capture@1.4.1-dev -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12241) Cordova Device plugin: device.serial value does not match the phone's serial number
[ https://issues.apache.org/jira/browse/CB-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Muhamed updated CB-12241: - Description: the device.serial value returns an incorrect value. The phone devices serial number starts with RF but the device.serial value is starting with numbers. I am able to get the model and android version, so i can rule out the option of plugin is not working. Tested using Samsung Note 5, android version:6.0.1 device.serial value gives a 15 digit number while my serial number is only 11 alphanumeric character. I have also checked the value against the IMEI number but it is not a match. was: the device.serial value returns an incorrect value. The phone devices serial number starts with RF but the device.serial value is starting with numbers. I am able to get the model and android version, so i can rule out the option of plugin is not working. Tested using Samsung Note 5, android version:6.0.1 > Cordova Device plugin: device.serial value does not match the phone's serial > number > --- > > Key: CB-12241 > URL: https://issues.apache.org/jira/browse/CB-12241 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Device >Reporter: Muhamed > > the device.serial value returns an incorrect value. The phone devices serial > number starts with RF but the device.serial value is starting with numbers. I > am able to get the model and android version, so i can rule out the option of > plugin is not working. > Tested using Samsung Note 5, android version:6.0.1 > device.serial value gives a 15 digit number while my serial number is only 11 > alphanumeric character. > I have also checked the value against the IMEI number but it is not a match. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9954) Update npm dep to npm@3
[ https://issues.apache.org/jira/browse/CB-9954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747168#comment-15747168 ] Mikhail Nasyrov commented on CB-9954: - Cordova-fetch proposal is completed (https://github.com/cordova/cordova-discuss/blob/master/proposals/fetching.md, CB-9858, CB-11349). However `cordova-lib` still has npm@2 as a dependency. Having a local installed npm@2 while a user expects system npm@3 or npm@4 leads to unexpected behaviours during running npm scripts and installing packages by spawned npm processed because npm@2 install peer dependencies automatically. It is a critical issue and should be reopened. > Update npm dep to npm@3 > --- > > Key: CB-9954 > URL: https://issues.apache.org/jira/browse/CB-9954 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib >Reporter: Robert Baker >Assignee: Steve Gill > Labels: cordova-fetch > Fix For: 6.0.0 > > > I'm using cordova. My system has NPM@3.3.12 on Node 4.1.2. > I tried Node 5, NPM 3.3.12, NPM 3.3.6 (was working on 3.3.6 about a month > ago). Was working on Node 4.1.1 > Cordova-Lib has NPM@2 as a dependency, which NPM@2 gets installed under my > project node_modules folder. > The NPM team recommends Cordova-Lib updates the dependency to use NPM@3 ASAP. > https://github.com/npm/npm/issues/10234#issuecomment-153710853 > ``` > async@1.5.0 .cordova\hooks\node_modules\async > [12:01:32] '' errored after 2.55 s > [12:01:32] ReferenceError: resolver is not defined > at null._onTimeout (c:\git\pos\node_modules\npm\lib\install.js:840:7) > at Timer.listOnTimeout (timers.js:92:15) > [12:01:32] 'cordova:debug' errored after 40 s > [12:01:32] ReferenceError: resolver is not defined > at null._onTimeout (c:\git\pos\node_modules\npm\lib\install.js:840:7) > at Timer.listOnTimeout (timers.js:92:15) > ``` -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9626) Cordova-Lib requires NPM as a dependency
[ https://issues.apache.org/jira/browse/CB-9626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747184#comment-15747184 ] Mikhail Nasyrov commented on CB-9626: - +1 Having a local installed npm@2 while a user expects system npm@3 or npm@4 leads to unexpected behaviours during running npm scripts and installing packages by spawned npm processed because npm@2 installs peer dependencies automatically. > Cordova-Lib requires NPM as a dependency > > > Key: CB-9626 > URL: https://issues.apache.org/jira/browse/CB-9626 > Project: Apache Cordova > Issue Type: Wish > Components: CordovaLib >Reporter: Robert Baker > > I'm using NPM 3.x (3.3.2) and cordova-create is installing NPM 2.x in my node > modules folder. > There should be a way around this, I rather not have a copy of NPM > (especially an older copy) in my node_modules. > NPM 3.x is stable, included in node 5. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12246) After recording a video when I click over movie to see it asks me what program I want to open it
Elysio created CB-12246: --- Summary: After recording a video when I click over movie to see it asks me what program I want to open it Key: CB-12246 URL: https://issues.apache.org/jira/browse/CB-12246 Project: Apache Cordova Issue Type: Bug Components: Android, Plugin Media Capture Reporter: Elysio Hello everyone! I need a big help! When I record a video over android the duration option not works. After I record, when I click Play it asks me what application to use to show the video. Is there anyway to play inside the app like iOS? If not, is there anyway to pass this process programmatically(User select Use or ✓)? Sincerely, Elysio -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12239) Allow passing build flags to MSBuild
[ https://issues.apache.org/jira/browse/CB-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744761#comment-15744761 ] ASF GitHub Bot commented on CB-12239: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/217 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/217?src=pr) is 76.22% (diff: 63.63%) > Merging [#217](https://codecov.io/gh/apache/cordova-windows/pull/217?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will increase coverage by **0.09%** ```diff @@ master #217 diff @@ == Files16 16 Lines 2204 2204 Methods 413412 -1 Messages 0 0 Branches430433 +3 == + Hits 1678 1680 +2 + Misses 526524 -2 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [707bf96...6308e69](https://codecov.io/gh/apache/cordova-windows/compare/707bf962823b9585a22dfaa3ffa6f0185562df5a...6308e6974f5499857254fb79c91ded422b46486f?src=pr) > Allow passing build flags to MSBuild > > > Key: CB-12239 > URL: https://issues.apache.org/jira/browse/CB-12239 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: buildFlag, triaged, windows > > Similar to iOS (see CB-11952 and CB-12127) it'd be great if developers could > pass arbitrary build flags to MSBuild. This is particularily useful for those > who wants their app that contains plugins w/ native code to be compiled w/ > specific version of C++ build toolset (or if the plugin specifies toolset > that is not available on build machine) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12239) Allow passing build flags to MSBuild
[ https://issues.apache.org/jira/browse/CB-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744748#comment-15744748 ] ASF GitHub Bot commented on CB-12239: - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/217 CB-12239 Add buildFlag option similar to iOS ### What does this PR do? This PR adds `buildFlag` CLI argument and corresponding option for `build.json` file (similar to iOS) to allow users to pass arbitrary options directly to MSBuild ### What testing has been done on this change? Added new tests, ran unit and e2e tests ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-windows build-flags-support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/217.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #217 commit 6308e6974f5499857254fb79c91ded422b46486f Author: Vladimir KotikovDate: 2016-12-12T15:45:51Z CB-12239 Add buildFlag option similar to iOS > Allow passing build flags to MSBuild > > > Key: CB-12239 > URL: https://issues.apache.org/jira/browse/CB-12239 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: buildFlag, triaged, windows > > Similar to iOS (see CB-11952 and CB-12127) it'd be great if developers could > pass arbitrary build flags to MSBuild. This is particularily useful for those > who wants their app that contains plugins w/ native code to be compiled w/ > specific version of C++ build toolset (or if the plugin specifies toolset > that is not available on build machine) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12239) Allow passing build flags to MSBuild
[ https://issues.apache.org/jira/browse/CB-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744861#comment-15744861 ] ASF GitHub Bot commented on CB-12239: - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/668 CB-12239 (windows) Add documentation about build flags for Windows ### Platforms affected Windows ### What does this PR do? Documents use of `buildFlag` option ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. ![image](https://cloud.githubusercontent.com/assets/3857604/21137756/0ce2c024-c13c-11e6-9e8d-43243de1559e.png) You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-docs CB-12239 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/668.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #668 commit 9fc8b3aafaf75091ce03aa68d474f7bd7943d517 Author: Vladimir KotikovDate: 2016-12-06T14:58:31Z CB-12239 Add documentation about build flags for Windows > Allow passing build flags to MSBuild > > > Key: CB-12239 > URL: https://issues.apache.org/jira/browse/CB-12239 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: buildFlag, triaged, windows > > Similar to iOS (see CB-11952 and CB-12127) it'd be great if developers could > pass arbitrary build flags to MSBuild. This is particularily useful for those > who wants their app that contains plugins w/ native code to be compiled w/ > specific version of C++ build toolset (or if the plugin specifies toolset > that is not available on build machine) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12239) Allow passing build flags to MSBuild
[ https://issues.apache.org/jira/browse/CB-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744863#comment-15744863 ] ASF GitHub Bot commented on CB-12239: - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/217 Pls also see corresponding documentation update here: https://github.com/apache/cordova-docs/pull/668 > Allow passing build flags to MSBuild > > > Key: CB-12239 > URL: https://issues.apache.org/jira/browse/CB-12239 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: buildFlag, triaged, windows > > Similar to iOS (see CB-11952 and CB-12127) it'd be great if developers could > pass arbitrary build flags to MSBuild. This is particularily useful for those > who wants their app that contains plugins w/ native code to be compiled w/ > specific version of C++ build toolset (or if the plugin specifies toolset > that is not available on build machine) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12240) Recording audio with MediaPlugin on Android failed with exception
Marijn Giesen created CB-12240: -- Summary: Recording audio with MediaPlugin on Android failed with exception Key: CB-12240 URL: https://issues.apache.org/jira/browse/CB-12240 Project: Apache Cordova Issue Type: Bug Components: Android, Plugin Media Environment: Android Reporter: Marijn Giesen Recording audio using the MediaPlugin on Android fails with exception. The audiorecorder seems to be working, but the file never gets created. The following exception is shown in the logs: {noformat} 12-12 05:57:08.397 1777 1818 D AudioPlayer: stopping recording 12-12 05:57:08.401 1777 1818 D AudioPlayer: size = 2 12-12 05:57:08.402 1777 1818 E AudioPlayer: /storage/emulated/0/tmprecording-1481540219004.3gp: open failed: ENOENT (No such file or directory) 12-12 05:57:08.402 1777 1818 E AudioPlayer: java.io.FileNotFoundException: /storage/emulated/0/tmprecording-1481540219004.3gp: open failed: ENOENT (No such file or directory) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at libcore.io.IoBridge.open(IoBridge.java:452) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at java.io.FileInputStream.(FileInputStream.java:76) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.media.AudioPlayer.moveFile(AudioPlayer.java:213) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.media.AudioPlayer.stopRecording(AudioPlayer.java:271) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.media.AudioPlayer.destroy(AudioPlayer.java:133) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.media.AudioHandler.release(AudioHandler.java:276) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.media.AudioHandler.execute(AudioHandler.java:170) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.CordovaPlugin.execute(CordovaPlugin.java:98) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.PluginManager.exec(PluginManager.java:132) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:57) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.engine.SystemExposedJsApi.exec(SystemExposedJsApi.java:41) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:53) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at android.os.Handler.dispatchMessage(Handler.java:102) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at android.os.Looper.loop(Looper.java:148) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at android.os.HandlerThread.run(HandlerThread.java:61) 12-12 05:57:08.402 1777 1818 E AudioPlayer: Caused by: android.system.ErrnoException: open failed: ENOENT (No such file or directory) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at libcore.io.Posix.open(Native Method) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at libcore.io.BlockGuardOs.open(BlockGuardOs.java:186) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at libcore.io.IoBridge.open(IoBridge.java:438) 12-12 05:57:08.402 1777 1818 E AudioPlayer: ... 15 more 12-12 05:57:08.402 1777 1818 E AudioPlayer: /storage/emulated/0/tmprecording-1481540219004.3gp: open failed: ENOENT (No such file or directory) 12-12 05:57:08.402 1777 1818 E AudioPlayer: java.io.FileNotFoundException: /storage/emulated/0/tmprecording-1481540219004.3gp: open failed: ENOENT (No such file or directory) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at libcore.io.IoBridge.open(IoBridge.java:452) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at java.io.FileInputStream.(FileInputStream.java:76) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.media.AudioPlayer.moveFile(AudioPlayer.java:213) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.media.AudioPlayer.stopRecording(AudioPlayer.java:271) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.media.AudioPlayer.destroy(AudioPlayer.java:133) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.media.AudioHandler.release(AudioHandler.java:276) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.media.AudioHandler.execute(AudioHandler.java:170) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.CordovaPlugin.execute(CordovaPlugin.java:98) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.PluginManager.exec(PluginManager.java:132) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at org.apache.cordova.CordovaBridge.jsExec(CordovaBridge.java:57) 12-12 05:57:08.402 1777 1818 E AudioPlayer: at
[jira] [Commented] (CB-12239) Allow passing build flags to MSBuild
[ https://issues.apache.org/jira/browse/CB-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744850#comment-15744850 ] ASF subversion and git services commented on CB-12239: -- Commit 9fc8b3aafaf75091ce03aa68d474f7bd7943d517 in cordova-docs's branch refs/heads/CB-12239 from [~vladimir.kotikov] [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=9fc8b3a ] CB-12239 Add documentation about build flags for Windows > Allow passing build flags to MSBuild > > > Key: CB-12239 > URL: https://issues.apache.org/jira/browse/CB-12239 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: buildFlag, triaged, windows > > Similar to iOS (see CB-11952 and CB-12127) it'd be great if developers could > pass arbitrary build flags to MSBuild. This is particularily useful for those > who wants their app that contains plugins w/ native code to be compiled w/ > specific version of C++ build toolset (or if the plugin specifies toolset > that is not available on build machine) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12239) Allow passing build flags to MSBuild
[ https://issues.apache.org/jira/browse/CB-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744785#comment-15744785 ] ASF GitHub Bot commented on CB-12239: - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/217 @TimBarham, @alsorokin, @daserge, could you please take a look? > Allow passing build flags to MSBuild > > > Key: CB-12239 > URL: https://issues.apache.org/jira/browse/CB-12239 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows >Reporter: Vladimir Kotikov >Assignee: Vladimir Kotikov > Labels: buildFlag, triaged, windows > > Similar to iOS (see CB-11952 and CB-12127) it'd be great if developers could > pass arbitrary build flags to MSBuild. This is particularily useful for those > who wants their app that contains plugins w/ native code to be compiled w/ > specific version of C++ build toolset (or if the plugin specifies toolset > that is not available on build machine) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12239) Allow passing build flags to MSBuild
Vladimir Kotikov created CB-12239: - Summary: Allow passing build flags to MSBuild Key: CB-12239 URL: https://issues.apache.org/jira/browse/CB-12239 Project: Apache Cordova Issue Type: Improvement Components: Windows Reporter: Vladimir Kotikov Assignee: Vladimir Kotikov Similar to iOS (see CB-11952 and CB-12127) it'd be great if developers could pass arbitrary build flags to MSBuild. This is particularily useful for those who wants their app that contains plugins w/ native code to be compiled w/ specific version of C++ build toolset (or if the plugin specifies toolset that is not available on build machine) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12238) [Windows] Colorize titlebar to match splash bg color
[ https://issues.apache.org/jira/browse/CB-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745132#comment-15745132 ] ASF GitHub Bot commented on CB-12238: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/218 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/218?src=pr) is 76.13% (diff: 100%) > Merging [#218](https://codecov.io/gh/apache/cordova-windows/pull/218?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change coverage ```diff @@ master #218 diff @@ == Files16 16 Lines 2204 2204 Methods 413413 Messages 0 0 Branches430430 == Hits 1678 1678 Misses 526526 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [707bf96...f6d766a](https://codecov.io/gh/apache/cordova-windows/compare/707bf962823b9585a22dfaa3ffa6f0185562df5a...f6d766a6c3efb9deddcb7bb7bdcd060162f18f20?src=pr) > [Windows] Colorize titlebar to match splash bg color > > > Key: CB-12238 > URL: https://issues.apache.org/jira/browse/CB-12238 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov > Labels: splashscreen, triaged, windows > > 8.1/10 title bar color should match splashscreen background color - otherwise > there is a kind of flashing to the white/accent color when extended splash is > shown. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12238) [Windows] Colorize titlebar to match splash bg color
[ https://issues.apache.org/jira/browse/CB-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745119#comment-15745119 ] ASF GitHub Bot commented on CB-12238: - GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/218 CB-12238 [Windows] Colorize titlebar to match splash bg color ### Platforms affected Windows ### What does this PR do? Colorize titlebar to match splash background color ### What testing has been done on this change? Manual testing ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-windows CB-12238 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/218.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #218 commit f6d766a6c3efb9deddcb7bb7bdcd060162f18f20 Author: dasergeDate: 2016-12-13T12:34:42Z CB-12238 [Windows] Colorize titlebar to match splash bg color > [Windows] Colorize titlebar to match splash bg color > > > Key: CB-12238 > URL: https://issues.apache.org/jira/browse/CB-12238 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov > Labels: splashscreen, triaged, windows > > 8.1/10 title bar color should match splashscreen background color - otherwise > there is a kind of flashing to the white/accent color when extended splash is > shown. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12241) Cordova Device plugin: device.serial value does not match the phone's serial number
Muhamed created CB-12241: Summary: Cordova Device plugin: device.serial value does not match the phone's serial number Key: CB-12241 URL: https://issues.apache.org/jira/browse/CB-12241 Project: Apache Cordova Issue Type: Bug Components: Plugin Device Reporter: Muhamed the device.serial value returns an incorrect value. The phone devices serial number starts with RF but the device.serial value is starting with numbers. I am able to get the model and android version, so i can rule out the option of plugin is not working. Tested using Samsung Note 5, android version:6.0.1 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques de Villiers updated CB-12242: - Description: Currently it can take quite long to add certain plugins to my project (using cordova plugin add), especially if I need to re-add the plugins. My suggestion is to update the cordova cli to start using yarn js instead of npm directly. When I looked at this page, I realised yarn was just a wrapper for npm, and much better at caching packages locally. https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc I would imagine this change would be relatively straightforward, and would be a massive win for the cli. I was thinking of creating a fork to do a PR but realised I am not totally sure how to proceed on this. was: Currently it can take quite long to add certain plugins to my project, especially if I need to re-add the plugins. My suggestion is to update the cordova cli to start using yarn js instead of npm directly. When I looked at this page, I realised yarn was just a wrapper for npm, and much better at caching packages locally. https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc I would imagine this change would be relatively straightforward, and would be a massive win for the cli. I was thinking of creating a fork to do a PR but realised I am not totally sure how to proceed on this. > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Wish > Components: CLI, CordovaLib >Reporter: Jacques de Villiers >Priority: Minor > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12242) Use yarn js instead of npm when adding plugins
Jacques de Villiers created CB-12242: Summary: Use yarn js instead of npm when adding plugins Key: CB-12242 URL: https://issues.apache.org/jira/browse/CB-12242 Project: Apache Cordova Issue Type: Wish Components: CLI, CordovaLib Reporter: Jacques de Villiers Priority: Minor Currently it can take quite long to add certain plugins to my project, especially if I need to re-add the plugins. My suggestion is to update the cordova cli to start using yarn js instead of npm directly. When I looked at this page, I realised yarn was just a wrapper for npm, and much better at caching packages locally. https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc I would imagine this change would be relatively straightforward, and would be a massive win for the cli. I was thinking of creating a fork to do a PR but realised I am not totally sure how to proceed on this. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12244) After I run openFilePicker and pick and image, a white rectangle remains on screen
Camilo Pérez Vélez created CB-12244: --- Summary: After I run openFilePicker and pick and image, a white rectangle remains on screen Key: CB-12244 URL: https://issues.apache.org/jira/browse/CB-12244 Project: Apache Cordova Issue Type: Bug Environment: ios 10 Reporter: Camilo Pérez Vélez I'm using the example code of openFilePicker, after I run this code, I pick the image, the the gallery close and when the app returns to main screen, there is a white rectangle Occupying the middle of the screen, this rectangle doesn't belongs to HTML or BODY, i can't selected with the console and I can't remove it whit any javascript action -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11908) Add edit-config to config.xml
[ https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745743#comment-15745743 ] ASF GitHub Bot commented on CB-11908: - GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/508 CB-11908 Add tests for edit-config in config.xml and fix typo ### Platforms affected cordova-common ### What does this PR do? I had this commit ready to go, but forgot to commit and push it. Here I'm adding tests for the 'edit-config' functionality that was added to config.xml. ### What testing has been done on this change? Manual tests and adding unit tests. ### Checklist - [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ktop/cordova-lib editconfigxml Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/508.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #508 commit aa4c6e8380c6e5edf1bf20a508b450e64a1d6e7c Author: ktopDate: 2016-12-09T19:53:50Z CB-11908 Add tests for edit-config in config.xml and fix typo Add one more test case > Add edit-config to config.xml > - > > Key: CB-11908 > URL: https://issues.apache.org/jira/browse/CB-11908 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaCommon, CordovaLib >Affects Versions: Master >Reporter: Karen Tran >Assignee: Karen Tran > Fix For: Master > > > edit-config tag in plugin.xml allows users to modify xml elements from > plugins. > This feature should be added to config.xml as well, so that users wouldn't > need a plugin in order to modify xml elements. > *config.xml changes takes precedence over plugin changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-12243) Website bug
Sunny Cupertino created CB-12243: Summary: Website bug Key: CB-12243 URL: https://issues.apache.org/jira/browse/CB-12243 Project: Apache Cordova Issue Type: Bug Components: Website Reporter: Sunny Cupertino The plugin search on the website does not give the same results on firefox and chrome. Check here https://cordova.apache.org/plugins/?q=file It seems the chrome version returns incorrect results, especially if you look over other keywords. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-12244) After I run openFilePicker and pick and image, a white rectangle remains on screen
[ https://issues.apache.org/jira/browse/CB-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Camilo Pérez Vélez updated CB-12244: Description: I'm using the example code of openFilePicker of the camera plugin, after I run this code, I pick the image, the the gallery close and when the app returns to main screen, there is a white rectangle Occupying the middle of the screen, this rectangle doesn't belongs to HTML or BODY, i can't selected with the console and I can't remove it whit any javascript action was: I'm using the example code of openFilePicker, after I run this code, I pick the image, the the gallery close and when the app returns to main screen, there is a white rectangle Occupying the middle of the screen, this rectangle doesn't belongs to HTML or BODY, i can't selected with the console and I can't remove it whit any javascript action > After I run openFilePicker and pick and image, a white rectangle remains on > screen > -- > > Key: CB-12244 > URL: https://issues.apache.org/jira/browse/CB-12244 > Project: Apache Cordova > Issue Type: Bug > Environment: ios 10 >Reporter: Camilo Pérez Vélez > > I'm using the example code of openFilePicker of the camera plugin, after I > run this code, I pick the image, the the gallery close and when the app > returns to main screen, there is a white rectangle Occupying the middle of > the screen, this rectangle doesn't belongs to HTML or BODY, i can't selected > with the console and I can't remove it whit any javascript action > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12163) plugin.xml 'resource-file' does not copy file to target for Windows
[ https://issues.apache.org/jira/browse/CB-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745769#comment-15745769 ] ASF GitHub Bot commented on CB-12163: - GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/509 CB-12163 Add reference attrib to resource-file for Windows ### Platforms affected cordova-common for Windows ### What does this PR do? Adds a new attribute to the resource-file tag for Windows. The attribute is for moving the current functionality of "referencing files" to be switched on by this flag in order to bring back the copy functionality to be default for resource-file. ex. ``` ``` ### What testing has been done on this change? Manual testing and unit testing. Need to pull in changes from the cordova-windows pull request to get it to work properly. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ktop/cordova-lib cb12163 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/509.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #509 commit 9d69d3df1d765ad9c05ece48864fc47c6c3e7061 Author: ktopDate: 2016-12-12T19:35:04Z CB-12163 Add reference attrib to resource-file for Windows > plugin.xml 'resource-file' does not copy file to target for Windows > --- > > Key: CB-12163 > URL: https://issues.apache.org/jira/browse/CB-12163 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: Master > Environment: Windows 8/Windows10 >Reporter: Karen Tran >Assignee: Karen Tran > Labels: Windows > > From plugin.xml: > {noformat} target="myprops.properties"/>{noformat} > does not copy the file from src to target anymore. It used > to, but was changed. This creates a couple of issues since I expect it to be > in the application, but it technically isn't. This means that I cannot update > the file that doesn't exist and very much limits the functionality of > (Also the documentation is wrong for Windows since it doesn't > copy any files). Visual Studio also only shows the file from the src path. > This doesn't make much sense since that file wouldn't be in the application. > The expected behavior should be if the target is specified, > should copy the file to the target location. In turn, Visual Studio should > show the target file instead of the src file because the target is part of > the application whereas the src file is not. > This used to be expected behavior, but was changed as a result of CB-10326. > The intention of that issue is limited to use cases of only having the src > attribute, ignoring the possibility that we would want to update files in the > target instead (which imo makes more sense). Resource files are not all .dll > files, so it's not very user friendly to limit the tag to > handling just those kinds of files. > Proposed changes in JsprojManager.js and PluginHandler.js: > If target attribute is specified, copy the file to the target and point the > Include attribute to the path of the target. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12226) cordova-plugin-contacts: Not Getting Events
[ https://issues.apache.org/jira/browse/CB-12226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745866#comment-15745866 ] Vishal Mishra commented on CB-12226: Hi Tojo, I do not see a default field called Anniversary in the contacts in iOS. Is it a custom field that you are trying to add ? I cannot see anniversary as a custom field as well. > cordova-plugin-contacts: Not Getting Events > --- > > Key: CB-12226 > URL: https://issues.apache.org/jira/browse/CB-12226 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Contacts >Reporter: TOJO PAUL >Priority: Critical > Labels: Android, Cordova, Ios > > cordova-plugin-contacts only allows to get the birthday of the contact. > Not getting event dates like > Birthdays > Anniversary > Custom > Others -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org