date:20161006


[ 
https://issues.apache.org/jira/browse/CB-11777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554166#comment-15554166
 ] 

ASF GitHub Bot commented on CB-11777:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/487
  
Guess this won't matter if we rip restore out of prepare!

https://github.com/cordova/cordova-discuss/pull/54


> Plugins superseding config.xml
> --
>
> Key: CB-11777
> URL: https://issues.apache.org/jira/browse/CB-11777
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.1
>Reporter: Darryl Pogue
>Assignee: Darryl Pogue
>  Labels: triaged
>
> The ongoing saga of CB-11589 and CB-11698...
> When running {{cordova prepare}} to restore platforms and plugins, the 
> platform has prepare called before the plugins are restored. This leads to 
> the top-level config.xml data being copied into the platform at prepare time, 
> and then plugin config being appended when they are later restored.
> In my case, this was causing the Crosswalk version defined in my top-level 
> config.xml to be overwritten by an undefined version when the plugin was 
> installed. A workaround is to run {{cordova prepare}} a second time.
> A better fix is probably to restore the platforms, restore the plugins, and 
> then run prepare after everything has been restored.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11968) add support to config.xml


 [ 
https://issues.apache.org/jira/browse/CB-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill updated CB-11968:

Description: Need a way for users to add new settings to config files from 
config.xml. Lets add  support to config.xml. Right now, 
 only works in plugin.xml  (was: Need a way for users to add new 
settings to config files from config.xml. I propose add  support 
to config.xml. Right now,  only works in plugin.xml)

> add  support to config.xml
> ---
>
> Key: CB-11968
> URL: https://issues.apache.org/jira/browse/CB-11968
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Steve Gill
>  Labels: cordova-7.0.0
>
> Need a way for users to add new settings to config files from config.xml. 
> Lets add  support to config.xml. Right now,  only 
> works in plugin.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11968) add support to config.xml

2016-10-06 Thread ASF subversion and git services (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill updated CB-11968:

Labels: cordova-7.0.0  (was: )

> add  support to config.xml
> ---
>
> Key: CB-11968
> URL: https://issues.apache.org/jira/browse/CB-11968
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Steve Gill
>  Labels: cordova-7.0.0
>
> Need a way for users to add new settings to config files from config.xml. I 
> propose add  support to config.xml. Right now,  
> only works in plugin.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11969) Cordova-common@1.5.0 Release Oct 6, 2016


[ 
https://issues.apache.org/jira/browse/CB-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554123#comment-15554123
 ] 

ASF subversion and git services commented on CB-11969:
--

Commit 4ca3b4ca12a01ded923734e4d92d7f9325d540dc in cordova-lib's branch 
refs/heads/master from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=4ca3b4c ]

CB-11969 Incremented package version to -dev


> Cordova-common@1.5.0 Release Oct 6, 2016
> 
>
> Key: CB-11969
> URL: https://issues.apache.org/jira/browse/CB-11969
> Project: Apache Cordova
>  Issue Type: Task
>  Components: CordovaCommon
>Reporter: Steve Gill
>Assignee: Steve Gill
>
> "Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11969) Cordova-common@1.5.0 Release Oct 6, 2016

2016-10-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554122#comment-15554122
 ] 

ASF subversion and git services commented on CB-11969:
--

Commit 0b56f9c6e52d4b0356187f69a14422d2e080b4e6 in cordova-lib's branch 
refs/heads/master from [~stevegill]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=0b56f9c ]

CB-11969 Updated version and RELEASENOTES.md for release 1.5.0


> Cordova-common@1.5.0 Release Oct 6, 2016
> 
>
> Key: CB-11969
> URL: https://issues.apache.org/jira/browse/CB-11969
> Project: Apache Cordova
>  Issue Type: Task
>  Components: CordovaCommon
>Reporter: Steve Gill
>Assignee: Steve Gill
>
> "Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11969) Cordova-common@1.5.0 Release Oct 6, 2016

Steve Gill created CB-11969:
---

 Summary: Cordova-common@1.5.0 Release Oct 6, 2016
 Key: CB-11969
 URL: https://issues.apache.org/jira/browse/CB-11969
 Project: Apache Cordova
  Issue Type: Task
  Components: CordovaCommon
Reporter: Steve Gill
Assignee: Steve Gill


"Following steps at 
https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets


[ 
https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554053#comment-15554053
 ] 

ASF GitHub Bot commented on CB-11776:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/491
  
Thanks @ktop! Merged!


> Can't add two plugins with different edit-config targets
> 
>
> Key: CB-11776
> URL: https://issues.apache.org/jira/browse/CB-11776
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon
>Affects Versions: 1.4.0
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: edit-config, triaged
> Fix For: Master
>
>
> When adding two plugins where both plugins are using edit-config, the second 
> plugin will have issues being added. The conflict checking for edit-config is 
> missing a case where the target cannot resolve to an existing target. Should 
> check if the target exists before proceeding. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11777) Plugins superseding config.xml

2016-10-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554020#comment-15554020
 ] 

ASF GitHub Bot commented on CB-11777:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/487
  
Nice investigating @dpogue! 

Good point about the hook order changing. My gut says it should be fine. 
Would that be a considered a major change is the question. 


> Plugins superseding config.xml
> --
>
> Key: CB-11777
> URL: https://issues.apache.org/jira/browse/CB-11777
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.1
>Reporter: Darryl Pogue
>Assignee: Darryl Pogue
>  Labels: triaged
>
> The ongoing saga of CB-11589 and CB-11698...
> When running {{cordova prepare}} to restore platforms and plugins, the 
> platform has prepare called before the plugins are restored. This leads to 
> the top-level config.xml data being copied into the platform at prepare time, 
> and then plugin config being appended when they are later restored.
> In my case, this was causing the Crosswalk version defined in my top-level 
> config.xml to be overwritten by an undefined version when the plugin was 
> installed. A workaround is to run {{cordova prepare}} a second time.
> A better fix is probably to restore the platforms, restore the plugins, and 
> then run prepare after everything has been restored.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets


[ 
https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553998#comment-15553998
 ] 

ASF subversion and git services commented on CB-11776:
--

Commit c921bc07764ede2218c55eb8399ae335ff5bb1fc in cordova-lib's branch 
refs/heads/master from [~ktop500]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=c921bc0 ]

CB-11776 Add test case for different edit-config targets

 This closes #491


> Can't add two plugins with different edit-config targets
> 
>
> Key: CB-11776
> URL: https://issues.apache.org/jira/browse/CB-11776
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon
>Affects Versions: 1.4.0
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: edit-config, triaged
> Fix For: Master
>
>
> When adding two plugins where both plugins are using edit-config, the second 
> plugin will have issues being added. The conflict checking for edit-config is 
> missing a case where the target cannot resolve to an existing target. Should 
> check if the target exists before proceeding. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11776) Can't add two plugins with different edit-config targets


[ 
https://issues.apache.org/jira/browse/CB-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553999#comment-15553999
 ] 

ASF GitHub Bot commented on CB-11776:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/491


> Can't add two plugins with different edit-config targets
> 
>
> Key: CB-11776
> URL: https://issues.apache.org/jira/browse/CB-11776
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon
>Affects Versions: 1.4.0
>Reporter: Karen Tran
>Assignee: Karen Tran
>  Labels: edit-config, triaged
> Fix For: Master
>
>
> When adding two plugins where both plugins are using edit-config, the second 
> plugin will have issues being added. The conflict checking for edit-config is 
> missing a case where the target cannot resolve to an existing target. Should 
> check if the target exists before proceeding. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml


[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553985#comment-15553985
 ] 

ASF GitHub Bot commented on CB-11908:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
Thanks for sending this pr @ktop! I've merged it in. 


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml


[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553886#comment-15553886
 ] 

ASF GitHub Bot commented on CB-11908:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/493


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml

2016-10-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553885#comment-15553885
 ] 

ASF GitHub Bot commented on CB-11908:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/492


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml


[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553883#comment-15553883
 ] 

ASF subversion and git services commented on CB-11908:
--

Commit 59faf88024faa697647dec1ddda045db8038edab in cordova-lib's branch 
refs/heads/master from [~ktop500]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=59faf88 ]

CB-11908 Handle edit-config in config.xml on prepare

 This closes #493


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml

2016-10-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553884#comment-15553884
 ] 

ASF subversion and git services commented on CB-11908:
--

Commit 121fdc3f80bf98764733763996b46e6af28991e3 in cordova-lib's branch 
refs/heads/master from [~ktop500]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=121fdc3 ]

CB-11908 Add edit-config to config.xml

This closes #492


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml


[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553881#comment-15553881
 ] 

ASF GitHub Bot commented on CB-11908:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
I'm going to merge this in for now so I can get the common release out. But 
it is definitely worth discussing some of these points. 


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-3785) Channel.prototype.subscribe to support EventListener interface


[ 
https://issues.apache.org/jira/browse/CB-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553863#comment-15553863
 ] 

ASF GitHub Bot commented on CB-3785:


Github user rayshan commented on the issue:

https://github.com/apache/cordova-js/pull/130
  
Yay! No worries.


> Channel.prototype.subscribe to support EventListener interface
> --
>
> Key: CB-3785
> URL: https://issues.apache.org/jira/browse/CB-3785
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaJS
>Affects Versions: 2.8.0
> Environment: All platforms
>Reporter: Nikolai Kotchetkov
>Assignee: Ray Shan
>  Labels: features, javascript, patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> As number of Cordova-specific events use monkey-patch for add/remove/fire 
> listeners it would be nice if Channel functions support EventListener 
> interface:
> - https://developer.mozilla.org/en-US/docs/Web/API/EventListener
> - http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-EventListener
> I assume only a small patch to Channel module is required. Here are the 
> modified functions to resolve the issue:
> {code:javascript}
> /**
>  * Subscribes the given function to the channel. Any time that
>  * Channel.fire is called so too will the function.
>  * Optionally specify an execution context for the function
>  * and a guid that can be used to stop subscribing to the channel.
>  * Returns the guid.
>  */
> Channel.prototype.subscribe = function(f, c) {
> var func;
> if (f && "object" === typeof f) {
> // EventListener interface
> func = f["handleEvent"];
> c = f;
> } else {
> // Function interface
> func = f;
> }
> // need a function to call
> forceFunction(func);
> if (this.state == 2) {
> func.apply(c || this, this.fireArgs);
> return;
> }
> var guid = f.observer_guid;
> if (typeof c == "object") { func = utils.close(c, func); }
> if (!guid) {
> // first time any channel has seen this subscriber
> guid = '' + nextGuid++;
> }
> func.observer_guid = guid;
> f.observer_guid = guid;
> // Don't add the same handler more than once.
> if (!this.handlers[guid]) {
> this.handlers[guid] = func;
> this.numHandlers++;
> if (this.numHandlers == 1) {
> this.onHasSubscribersChange && this.onHasSubscribersChange();
> }
> }
> };
> /**
>  * Unsubscribes the function with the given guid from the channel.
>  */
> Channel.prototype.unsubscribe = function(f) {
> var func;
> if (f && "object" === typeof f) {
> // EventListener interface
> func = f["handleEvent"];
> c = f;
> } else {
> // Function interface
> func = f;
> }
> // need a function to unsubscribe
> forceFunction(func);
> var guid = f.observer_guid,
> handler = this.handlers[guid];
> if (handler) {
> delete this.handlers[guid];
> this.numHandlers--;
> if (this.numHandlers === 0) {
> this.onHasSubscribersChange && this.onHasSubscribersChange();
> }
> }
> };
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11968) add support to config.xml

Steve Gill created CB-11968:
---

 Summary: add  support to config.xml
 Key: CB-11968
 URL: https://issues.apache.org/jira/browse/CB-11968
 Project: Apache Cordova
  Issue Type: New Feature
  Components: CordovaLib
Reporter: Steve Gill


Need a way for users to add new settings to config files from config.xml. I 
propose add  support to config.xml. Right now,  only 
works in plugin.xml



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild


[ 
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553609#comment-15553609
 ] 

ASF GitHub Bot commented on CB-11952:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/265
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-ios/pull/265?src=pr) is 59.92% 
(diff: 97.67%)
> Merging [#265](https://codecov.io/gh/apache/cordova-ios/pull/265?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) 
will increase coverage by **3.41%**

```diff
@@ master   #265   diff @@
==
  Files12 12  
  Lines  1230   1280+50   
  Methods 198200 +2   
  Messages  0  0  
  Branches193216+23   
==
+ Hits695767+72   
+ Misses  535513-22   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[636113f...e393738](https://codecov.io/gh/apache/cordova-ios/compare/636113f047ee2c7dae742dff2beafae2121ceb62...e393738fe1f26824555bd090d1e08a725ed75f88?src=pr)


> Should be able to pass flags to xcodebuild
> --
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Andrew Zellman
>Assignee: Shazron Abdullah
>  Labels: features
>
> Cordova developers should be able to pass additional flags to xcodebuild when 
> compiling their projects. This can be done by adding a --buildFlag option in 
> cordova-ios that allows multiples declarations. There will need to be 
> additional attention to conflicts that may happen with xcodebuild arguments 
> injected by Cordova.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml


[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553597#comment-15553597
 ] 

ASF GitHub Bot commented on CB-11908:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
`remove` wouldn't be a revert right. Since you have no way to store what 
got overwritten/merged


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation


[ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553574#comment-15553574
 ] 

ASF GitHub Bot commented on CB-11964:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/339
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/339?src=pr) is 
34.85% (diff: 45.45%)
> Merging 
[#339](https://codecov.io/gh/apache/cordova-android/pull/339?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will decrease coverage by **0.30%**

```diff
@@ master   #339   diff @@
==
  Files12 13 +1   
  Lines  1007   1142   +135   
  Methods 198219+21   
  Messages  0  0  
  Branches168186+18   
==
+ Hits354398+44   
- Misses  653744+91   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[37384c5...333b30f](https://codecov.io/gh/apache/cordova-android/compare/37384c583d5a2e5b9b5c5d2cbf150f07f329d16c...333b30f3961fc269cda064c7f8ff3812fdc4a9ca?src=pr)


> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml


[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553572#comment-15553572
 ] 

ASF GitHub Bot commented on CB-11908:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
do you have a usecase example when remove might be useful?


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11908) Add edit-config to config.xml


[ 
https://issues.apache.org/jira/browse/CB-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553568#comment-15553568
 ] 

ASF GitHub Bot commented on CB-11908:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/492
  
@ktop so if I remove an `edit-config` tag from my `config.xml`, it won't 
actually remove it from `AndroidManifest.xml`. Guessing the solution for users 
in this case would be to rm and re-add the android platform. That seems fine to 
me. 

This is only for merging and overwriting. For adding new elements, we 
should use `config-file` still?


> Add edit-config to config.xml
> -
>
> Key: CB-11908
> URL: https://issues.apache.org/jira/browse/CB-11908
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaCommon, CordovaLib
>Affects Versions: Master
>Reporter: Karen Tran
>Assignee: Karen Tran
> Fix For: Master
>
>
> edit-config tag in plugin.xml allows users to modify xml elements from 
> plugins. 
> This feature should be added to config.xml as well, so that users wouldn't 
> need a plugin in order to modify xml elements. 
> *config.xml changes takes precedence over plugin changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-3785) Channel.prototype.subscribe to support EventListener interface


[ 
https://issues.apache.org/jira/browse/CB-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553505#comment-15553505
 ] 

ASF GitHub Bot commented on CB-3785:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/130


> Channel.prototype.subscribe to support EventListener interface
> --
>
> Key: CB-3785
> URL: https://issues.apache.org/jira/browse/CB-3785
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaJS
>Affects Versions: 2.8.0
> Environment: All platforms
>Reporter: Nikolai Kotchetkov
>Assignee: Ray Shan
>  Labels: features, javascript, patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> As number of Cordova-specific events use monkey-patch for add/remove/fire 
> listeners it would be nice if Channel functions support EventListener 
> interface:
> - https://developer.mozilla.org/en-US/docs/Web/API/EventListener
> - http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-EventListener
> I assume only a small patch to Channel module is required. Here are the 
> modified functions to resolve the issue:
> {code:javascript}
> /**
>  * Subscribes the given function to the channel. Any time that
>  * Channel.fire is called so too will the function.
>  * Optionally specify an execution context for the function
>  * and a guid that can be used to stop subscribing to the channel.
>  * Returns the guid.
>  */
> Channel.prototype.subscribe = function(f, c) {
> var func;
> if (f && "object" === typeof f) {
> // EventListener interface
> func = f["handleEvent"];
> c = f;
> } else {
> // Function interface
> func = f;
> }
> // need a function to call
> forceFunction(func);
> if (this.state == 2) {
> func.apply(c || this, this.fireArgs);
> return;
> }
> var guid = f.observer_guid;
> if (typeof c == "object") { func = utils.close(c, func); }
> if (!guid) {
> // first time any channel has seen this subscriber
> guid = '' + nextGuid++;
> }
> func.observer_guid = guid;
> f.observer_guid = guid;
> // Don't add the same handler more than once.
> if (!this.handlers[guid]) {
> this.handlers[guid] = func;
> this.numHandlers++;
> if (this.numHandlers == 1) {
> this.onHasSubscribersChange && this.onHasSubscribersChange();
> }
> }
> };
> /**
>  * Unsubscribes the function with the given guid from the channel.
>  */
> Channel.prototype.unsubscribe = function(f) {
> var func;
> if (f && "object" === typeof f) {
> // EventListener interface
> func = f["handleEvent"];
> c = f;
> } else {
> // Function interface
> func = f;
> }
> // need a function to unsubscribe
> forceFunction(func);
> var guid = f.observer_guid,
> handler = this.handlers[guid];
> if (handler) {
> delete this.handlers[guid];
> this.numHandlers--;
> if (this.numHandlers === 0) {
> this.onHasSubscribersChange && this.onHasSubscribersChange();
> }
> }
> };
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-3785) Channel.prototype.subscribe to support EventListener interface


 [ 
https://issues.apache.org/jira/browse/CB-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill resolved CB-3785.

Resolution: Fixed

> Channel.prototype.subscribe to support EventListener interface
> --
>
> Key: CB-3785
> URL: https://issues.apache.org/jira/browse/CB-3785
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaJS
>Affects Versions: 2.8.0
> Environment: All platforms
>Reporter: Nikolai Kotchetkov
>Assignee: Ray Shan
>  Labels: features, javascript, patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> As number of Cordova-specific events use monkey-patch for add/remove/fire 
> listeners it would be nice if Channel functions support EventListener 
> interface:
> - https://developer.mozilla.org/en-US/docs/Web/API/EventListener
> - http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-EventListener
> I assume only a small patch to Channel module is required. Here are the 
> modified functions to resolve the issue:
> {code:javascript}
> /**
>  * Subscribes the given function to the channel. Any time that
>  * Channel.fire is called so too will the function.
>  * Optionally specify an execution context for the function
>  * and a guid that can be used to stop subscribing to the channel.
>  * Returns the guid.
>  */
> Channel.prototype.subscribe = function(f, c) {
> var func;
> if (f && "object" === typeof f) {
> // EventListener interface
> func = f["handleEvent"];
> c = f;
> } else {
> // Function interface
> func = f;
> }
> // need a function to call
> forceFunction(func);
> if (this.state == 2) {
> func.apply(c || this, this.fireArgs);
> return;
> }
> var guid = f.observer_guid;
> if (typeof c == "object") { func = utils.close(c, func); }
> if (!guid) {
> // first time any channel has seen this subscriber
> guid = '' + nextGuid++;
> }
> func.observer_guid = guid;
> f.observer_guid = guid;
> // Don't add the same handler more than once.
> if (!this.handlers[guid]) {
> this.handlers[guid] = func;
> this.numHandlers++;
> if (this.numHandlers == 1) {
> this.onHasSubscribersChange && this.onHasSubscribersChange();
> }
> }
> };
> /**
>  * Unsubscribes the function with the given guid from the channel.
>  */
> Channel.prototype.unsubscribe = function(f) {
> var func;
> if (f && "object" === typeof f) {
> // EventListener interface
> func = f["handleEvent"];
> c = f;
> } else {
> // Function interface
> func = f;
> }
> // need a function to unsubscribe
> forceFunction(func);
> var guid = f.observer_guid,
> handler = this.handlers[guid];
> if (handler) {
> delete this.handlers[guid];
> this.numHandlers--;
> if (this.numHandlers === 0) {
> this.onHasSubscribersChange && this.onHasSubscribersChange();
> }
> }
> };
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-3785) Channel.prototype.subscribe to support EventListener interface

2016-10-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553506#comment-15553506
 ] 

ASF GitHub Bot commented on CB-3785:


Github user stevengill commented on the issue:

https://github.com/apache/cordova-js/pull/130
  
Thanks @rayshan! Sorry it took so long to merge. 


> Channel.prototype.subscribe to support EventListener interface
> --
>
> Key: CB-3785
> URL: https://issues.apache.org/jira/browse/CB-3785
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaJS
>Affects Versions: 2.8.0
> Environment: All platforms
>Reporter: Nikolai Kotchetkov
>Assignee: Ray Shan
>  Labels: features, javascript, patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> As number of Cordova-specific events use monkey-patch for add/remove/fire 
> listeners it would be nice if Channel functions support EventListener 
> interface:
> - https://developer.mozilla.org/en-US/docs/Web/API/EventListener
> - http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-EventListener
> I assume only a small patch to Channel module is required. Here are the 
> modified functions to resolve the issue:
> {code:javascript}
> /**
>  * Subscribes the given function to the channel. Any time that
>  * Channel.fire is called so too will the function.
>  * Optionally specify an execution context for the function
>  * and a guid that can be used to stop subscribing to the channel.
>  * Returns the guid.
>  */
> Channel.prototype.subscribe = function(f, c) {
> var func;
> if (f && "object" === typeof f) {
> // EventListener interface
> func = f["handleEvent"];
> c = f;
> } else {
> // Function interface
> func = f;
> }
> // need a function to call
> forceFunction(func);
> if (this.state == 2) {
> func.apply(c || this, this.fireArgs);
> return;
> }
> var guid = f.observer_guid;
> if (typeof c == "object") { func = utils.close(c, func); }
> if (!guid) {
> // first time any channel has seen this subscriber
> guid = '' + nextGuid++;
> }
> func.observer_guid = guid;
> f.observer_guid = guid;
> // Don't add the same handler more than once.
> if (!this.handlers[guid]) {
> this.handlers[guid] = func;
> this.numHandlers++;
> if (this.numHandlers == 1) {
> this.onHasSubscribersChange && this.onHasSubscribersChange();
> }
> }
> };
> /**
>  * Unsubscribes the function with the given guid from the channel.
>  */
> Channel.prototype.unsubscribe = function(f) {
> var func;
> if (f && "object" === typeof f) {
> // EventListener interface
> func = f["handleEvent"];
> c = f;
> } else {
> // Function interface
> func = f;
> }
> // need a function to unsubscribe
> forceFunction(func);
> var guid = f.observer_guid,
> handler = this.handlers[guid];
> if (handler) {
> delete this.handlers[guid];
> this.numHandlers--;
> if (this.numHandlers === 0) {
> this.onHasSubscribersChange && this.onHasSubscribersChange();
> }
> }
> };
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-3785) Channel.prototype.subscribe to support EventListener interface


[ 
https://issues.apache.org/jira/browse/CB-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553504#comment-15553504
 ] 

ASF subversion and git services commented on CB-3785:
-

Commit 81d8b9924b78804017fbce2ee7bd3f92560d341a in cordova-js's branch 
refs/heads/master from [~rayshan]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=81d8b99 ]

Fix CB-3785

Enable support of EventListener interface for
Channel.prototype.subscribe / unsubscribe

 This closes #130


> Channel.prototype.subscribe to support EventListener interface
> --
>
> Key: CB-3785
> URL: https://issues.apache.org/jira/browse/CB-3785
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaJS
>Affects Versions: 2.8.0
> Environment: All platforms
>Reporter: Nikolai Kotchetkov
>Assignee: Ray Shan
>  Labels: features, javascript, patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> As number of Cordova-specific events use monkey-patch for add/remove/fire 
> listeners it would be nice if Channel functions support EventListener 
> interface:
> - https://developer.mozilla.org/en-US/docs/Web/API/EventListener
> - http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-EventListener
> I assume only a small patch to Channel module is required. Here are the 
> modified functions to resolve the issue:
> {code:javascript}
> /**
>  * Subscribes the given function to the channel. Any time that
>  * Channel.fire is called so too will the function.
>  * Optionally specify an execution context for the function
>  * and a guid that can be used to stop subscribing to the channel.
>  * Returns the guid.
>  */
> Channel.prototype.subscribe = function(f, c) {
> var func;
> if (f && "object" === typeof f) {
> // EventListener interface
> func = f["handleEvent"];
> c = f;
> } else {
> // Function interface
> func = f;
> }
> // need a function to call
> forceFunction(func);
> if (this.state == 2) {
> func.apply(c || this, this.fireArgs);
> return;
> }
> var guid = f.observer_guid;
> if (typeof c == "object") { func = utils.close(c, func); }
> if (!guid) {
> // first time any channel has seen this subscriber
> guid = '' + nextGuid++;
> }
> func.observer_guid = guid;
> f.observer_guid = guid;
> // Don't add the same handler more than once.
> if (!this.handlers[guid]) {
> this.handlers[guid] = func;
> this.numHandlers++;
> if (this.numHandlers == 1) {
> this.onHasSubscribersChange && this.onHasSubscribersChange();
> }
> }
> };
> /**
>  * Unsubscribes the function with the given guid from the channel.
>  */
> Channel.prototype.unsubscribe = function(f) {
> var func;
> if (f && "object" === typeof f) {
> // EventListener interface
> func = f["handleEvent"];
> c = f;
> } else {
> // Function interface
> func = f;
> }
> // need a function to unsubscribe
> forceFunction(func);
> var guid = f.observer_guid,
> handler = this.handlers[guid];
> if (handler) {
> delete this.handlers[guid];
> this.numHandlers--;
> if (this.numHandlers === 0) {
> this.onHasSubscribersChange && this.onHasSubscribersChange();
> }
> }
> };
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8722) Android should move icons to res/mipmap-* rather than drawable


[ 
https://issues.apache.org/jira/browse/CB-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553326#comment-15553326
 ] 

ASF GitHub Bot commented on CB-8722:


Github user codecov-io commented on the issue:

https://github.com/apache/cordova-android/pull/340
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-android/pull/340?src=pr) is 
35.15% (diff: 100%)
> Merging 
[#340](https://codecov.io/gh/apache/cordova-android/pull/340?src=pr) into 
[master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #340   diff @@
==
  Files12 12  
  Lines  1007   1007  
  Methods 198198  
  Messages  0  0  
  Branches168168  
==
  Hits354354  
  Misses  653653  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[37384c5...9785501](https://codecov.io/gh/apache/cordova-android/compare/37384c583d5a2e5b9b5c5d2cbf150f07f329d16c...97855018e9aeb955f3dd7e31c91fb6b8f67e0c29?src=pr)


> Android should move icons to res/mipmap-* rather than drawable
> --
>
> Key: CB-8722
> URL: https://issues.apache.org/jira/browse/CB-8722
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, CordovaLib
>Reporter: Andrew Grieve
>Priority: Minor
>
> Refer to: http://developer.android.com/tools/projects/index.html#mipmap



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11961) do a shallow clone if git_ref is a remote ref

2016-10-06 Thread Brett Rudd (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553287#comment-15553287
 ] 

Brett Rudd commented on CB-11961:
-

needGitCheckout is true if git_ref is present

depth=1 is used when needGitCheckout is false

we had to patch this for build as some clones were taking 90s for a branch.

> do a shallow clone if git_ref is a remote ref
> -
>
> Key: CB-11961
> URL: https://issues.apache.org/jira/browse/CB-11961
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Brett Rudd
>Assignee: Brett Rudd
>Priority: Minor
>
> Currently when cloning with a reference the entire repo is cloned then is 
> checked out.
> If the reference is a valid remote reference then it should be shallow cloned 
> so as to save time / lower bandwidth.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild


[ 
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553266#comment-15553266
 ] 

ASF GitHub Bot commented on CB-11952:
-

GitHub user adzellman opened a pull request:

https://github.com/apache/cordova-ios/pull/265

CB-11952 - Introduce buildFlag option

### Platforms affected
iOS

### What does this PR do?

- adds buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting

### What testing has been done on this change?

- Added unit tests for build.js
- I have tried this out with by passing various legal and illegal flags 
using the --buildFlag option. I used the xcodebuild man page to develop test 
cases.

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adzellman/aemm-ios CB-11952

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #265


commit e393738fe1f26824555bd090d1e08a725ed75f88
Author: Andrew Zellman 
Date:   2016-10-05T22:14:59Z

CB-11952 - Introduce buildFlag option
- adds buildFlag option for passing args to xcodebuild
- There can be multiple --buildFlag declarations
- Warns if buildFlag would override a built-in setting




> Should be able to pass flags to xcodebuild
> --
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Andrew Zellman
>Assignee: Shazron Abdullah
>  Labels: features
>
> Cordova developers should be able to pass additional flags to xcodebuild when 
> compiling their projects. This can be done by adding a --buildFlag option in 
> cordova-ios that allows multiples declarations. There will need to be 
> additional attention to conflicts that may happen with xcodebuild arguments 
> injected by Cordova.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11931) cordova-create@1.0.1 and cordova-app-hello-world@3.11.0 release. Sept 28, 2016


 [ 
https://issues.apache.org/jira/browse/CB-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill resolved CB-11931.
-
Resolution: Fixed

> cordova-create@1.0.1 and cordova-app-hello-world@3.11.0 release. Sept 28, 2016
> --
>
> Key: CB-11931
> URL: https://issues.apache.org/jira/browse/CB-11931
> Project: Apache Cordova
>  Issue Type: Task
>  Components: App Hello World, cordova-create
>Reporter: Steve Gill
>Assignee: Steve Gill
>
> "Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11950) CORDOVA + MULTIPLE FILE SELECTION = NO

2016-10-06 Thread Mr. V (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553185#comment-15553185
 ] 

Mr. V commented on CB-11950:


I don't consider this a feature request. Selecting (multiple) files is a pretty 
standard feature and Cordova actually prevents this feature from working 
properly. 

> CORDOVA + MULTIPLE FILE SELECTION = NO
> --
>
> Key: CB-11950
> URL: https://issues.apache.org/jira/browse/CB-11950
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, iOS
>Affects Versions: 6.3.1
>Reporter: Mr. V
>
> Selecting multiple files using the input file tag, with type set to 'file', 
> does not work for HTML5 projects packaged with Cordova. Selecting multiple 
> files should be considered a fundamental, standard feature and should not 
> require the use of any kind of plugin. As multiple file selection is now a 
> standard mobile-browser feature, Cordova should additionally support this 
> feature as well - without requiring a plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11961) do a shallow clone if git_ref is a remote ref


[ 
https://issues.apache.org/jira/browse/CB-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553181#comment-15553181
 ] 

Shazron Abdullah commented on CB-11961:
---

Just tried it out, the flag styles are equivalent.

> do a shallow clone if git_ref is a remote ref
> -
>
> Key: CB-11961
> URL: https://issues.apache.org/jira/browse/CB-11961
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Brett Rudd
>Assignee: Brett Rudd
>Priority: Minor
>
> Currently when cloning with a reference the entire repo is cloned then is 
> checked out.
> If the reference is a valid remote reference then it should be shallow cloned 
> so as to save time / lower bandwidth.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11961) do a shallow clone if git_ref is a remote ref


[ 
https://issues.apache.org/jira/browse/CB-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553172#comment-15553172
 ] 

Shazron Abdullah edited comment on CB-11961 at 10/6/16 9:07 PM:


I wonder if {code}--depth=1{code} is the same as {code}--depth 1{code} 
according to git though. The docs suggest the latter, we are doing the former


was (Author: shazron):
I wonder if `--depth=1` is the same as `--depth 1` according to git though. The 
docs suggest the latter, we are doing the former

> do a shallow clone if git_ref is a remote ref
> -
>
> Key: CB-11961
> URL: https://issues.apache.org/jira/browse/CB-11961
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Brett Rudd
>Assignee: Brett Rudd
>Priority: Minor
>
> Currently when cloning with a reference the entire repo is cloned then is 
> checked out.
> If the reference is a valid remote reference then it should be shallow cloned 
> so as to save time / lower bandwidth.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11961) do a shallow clone if git_ref is a remote ref


[ 
https://issues.apache.org/jira/browse/CB-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553172#comment-15553172
 ] 

Shazron Abdullah commented on CB-11961:
---

I wonder if `--depth=1` is the same as `--depth 1` according to git though. The 
docs suggest the latter, we are doing the former

> do a shallow clone if git_ref is a remote ref
> -
>
> Key: CB-11961
> URL: https://issues.apache.org/jira/browse/CB-11961
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Brett Rudd
>Assignee: Brett Rudd
>Priority: Minor
>
> Currently when cloning with a reference the entire repo is cloned then is 
> checked out.
> If the reference is a valid remote reference then it should be shallow cloned 
> so as to save time / lower bandwidth.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11961) do a shallow clone if git_ref is a remote ref


[ 
https://issues.apache.org/jira/browse/CB-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553169#comment-15553169
 ] 

Shazron Abdullah commented on CB-11961:
---

Seems like we already do it: 
https://github.com/apache/cordova-lib/blob/f8b58c782c71558516adbbd81929ee31ec3ded7f/cordova-lib/src/gitclone.js#L50

> do a shallow clone if git_ref is a remote ref
> -
>
> Key: CB-11961
> URL: https://issues.apache.org/jira/browse/CB-11961
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Brett Rudd
>Assignee: Brett Rudd
>Priority: Minor
>
> Currently when cloning with a reference the entire repo is cloned then is 
> checked out.
> If the reference is a valid remote reference then it should be shallow cloned 
> so as to save time / lower bandwidth.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation


[ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553129#comment-15553129
 ] 

ASF GitHub Bot commented on CB-11964:
-

Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/339
  
OK, so, WTF was that? It appears that we have a test suite problem.


> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8722) Android should move icons to res/mipmap-* rather than drawable


[ 
https://issues.apache.org/jira/browse/CB-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553108#comment-15553108
 ] 

ASF GitHub Bot commented on CB-8722:


Github user dpogue commented on the issue:

https://github.com/apache/cordova-android/pull/340
  
If they were specifying icons via config.xml, this should just work.
If they had the platform already installed and had modified files, this 
shouldn't affect those existing files.


> Android should move icons to res/mipmap-* rather than drawable
> --
>
> Key: CB-8722
> URL: https://issues.apache.org/jira/browse/CB-8722
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, CordovaLib
>Reporter: Andrew Grieve
>Priority: Minor
>
> Refer to: http://developer.android.com/tools/projects/index.html#mipmap



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8722) Android should move icons to res/mipmap-* rather than drawable


[ 
https://issues.apache.org/jira/browse/CB-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553028#comment-15553028
 ] 

ASF GitHub Bot commented on CB-8722:


Github user infil00p commented on the issue:

https://github.com/apache/cordova-android/pull/340
  
If someone knew nothing about Android, and they just fiddled with their 
icons, would this change, or would we have to delete their old drawable for 
this to work?


> Android should move icons to res/mipmap-* rather than drawable
> --
>
> Key: CB-8722
> URL: https://issues.apache.org/jira/browse/CB-8722
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, CordovaLib
>Reporter: Andrew Grieve
>Priority: Minor
>
> Refer to: http://developer.android.com/tools/projects/index.html#mipmap



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8722) Android should move icons to res/mipmap-* rather than drawable


[ 
https://issues.apache.org/jira/browse/CB-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553012#comment-15553012
 ] 

ASF GitHub Bot commented on CB-8722:


GitHub user dpogue opened a pull request:

https://github.com/apache/cordova-android/pull/340

CB-8722 - Move app icons from drawable to mipmap

https://issues.apache.org/jira/browse/CB-8722

Reasoning behind the change: 
https://androidbycode.wordpress.com/2015/02/14/goodbye-launcher-drawables-hello-mipmaps/

/cc @infil00p 
This probably counts as a breaking change, so we might want to get this 
into 6.0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpogue/cordova-android mipmap

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #340


commit 97855018e9aeb955f3dd7e31c91fb6b8f67e0c29
Author: Darryl Pogue 
Date:   2016-10-06T19:55:26Z

CB-8722 - Move icons from drawable to mipmap




> Android should move icons to res/mipmap-* rather than drawable
> --
>
> Key: CB-8722
> URL: https://issues.apache.org/jira/browse/CB-8722
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android, CordovaLib
>Reporter: Andrew Grieve
>Priority: Minor
>
> Refer to: http://developer.android.com/tools/projects/index.html#mipmap



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild


[ 
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552957#comment-15552957
 ] 

ASF GitHub Bot commented on CB-11952:
-

Github user adzellman commented on the issue:

https://github.com/apache/cordova-ios/pull/263
  
I'm going to clean this up and submit a new PR.


> Should be able to pass flags to xcodebuild
> --
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Andrew Zellman
>Assignee: Shazron Abdullah
>  Labels: features
>
> Cordova developers should be able to pass additional flags to xcodebuild when 
> compiling their projects. This can be done by adding a --buildFlag option in 
> cordova-ios that allows multiples declarations. There will need to be 
> additional attention to conflicts that may happen with xcodebuild arguments 
> injected by Cordova.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11952) Should be able to pass flags to xcodebuild


[ 
https://issues.apache.org/jira/browse/CB-11952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552956#comment-15552956
 ] 

ASF GitHub Bot commented on CB-11952:
-

Github user adzellman closed the pull request at:

https://github.com/apache/cordova-ios/pull/263


> Should be able to pass flags to xcodebuild
> --
>
> Key: CB-11952
> URL: https://issues.apache.org/jira/browse/CB-11952
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: iOS
>Reporter: Andrew Zellman
>Assignee: Shazron Abdullah
>  Labels: features
>
> Cordova developers should be able to pass additional flags to xcodebuild when 
> compiling their projects. This can be done by adding a --buildFlag option in 
> cordova-ios that allows multiples declarations. There will need to be 
> additional attention to conflicts that may happen with xcodebuild arguments 
> injected by Cordova.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11936) Support four new App Transport Security (ATS) keys

2016-10-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552813#comment-15552813
 ] 

ASF GitHub Bot commented on CB-11936:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/496


> Support four new App Transport Security (ATS) keys
> --
>
> Key: CB-11936
> URL: https://issues.apache.org/jira/browse/CB-11936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon, Docs, iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> https://forums.developer.apple.com/thread/6767
> NSAllowsArbitraryLoadsInWebContent (defaults to NO)
> NSRequiresCertificateTransparency (defaults to NO)
> NSAllowsLocalNetworking (defaults to NO)
> NSAllowsArbitraryLoadsInMedia (defaults to NO)
> NSRequiresCertificateTransparency is not top level, but is under 
> NSExceptionDomains
> 1. Add this feature to the iOS platform
> 2. Add new attribute parsing to ConfigParser in CordovaCommon
> 3. Add docs for new attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11936) Support four new App Transport Security (ATS) keys


[ 
https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552812#comment-15552812
 ] 

ASF subversion and git services commented on CB-11936:
--

Commit 934757c0a2d0a0463a747ba3fa32d2ddcdf652d5 in cordova-lib's branch 
refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=934757c ]

CB-11936 - Support four new App Transport Security (ATS) keys

 This closes #496


> Support four new App Transport Security (ATS) keys
> --
>
> Key: CB-11936
> URL: https://issues.apache.org/jira/browse/CB-11936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon, Docs, iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> https://forums.developer.apple.com/thread/6767
> NSAllowsArbitraryLoadsInWebContent (defaults to NO)
> NSRequiresCertificateTransparency (defaults to NO)
> NSAllowsLocalNetworking (defaults to NO)
> NSAllowsArbitraryLoadsInMedia (defaults to NO)
> NSRequiresCertificateTransparency is not top level, but is under 
> NSExceptionDomains
> 1. Add this feature to the iOS platform
> 2. Add new attribute parsing to ConfigParser in CordovaCommon
> 3. Add docs for new attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation


[ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552790#comment-15552790
 ] 

ASF GitHub Bot commented on CB-11964:
-

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-android/pull/339

CB-11964: Do a clean when installing a plugin to et around the bug

This is a quick fix for the problem, and it might fix some other build 
errors.  I'm not sure about doing it here, because it might break more stuff, 
but hey, that's what PRs and CI are for. :)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-android PluginInstallClean

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #339


commit 9faf99c1b47abc020cf080d04a179254e60acff4
Author: Joe Bowser 
Date:   2016-10-06T18:41:28Z

CB-11964: Do a clean when installing a plugin to et around the bug




> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11936) Support four new App Transport Security (ATS) keys


[ 
https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552782#comment-15552782
 ] 

ASF GitHub Bot commented on CB-11936:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-docs/pull/648
  
Only pull in for *cordova-ios 4.3.0* release.


> Support four new App Transport Security (ATS) keys
> --
>
> Key: CB-11936
> URL: https://issues.apache.org/jira/browse/CB-11936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon, Docs, iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> https://forums.developer.apple.com/thread/6767
> NSAllowsArbitraryLoadsInWebContent (defaults to NO)
> NSRequiresCertificateTransparency (defaults to NO)
> NSAllowsLocalNetworking (defaults to NO)
> NSAllowsArbitraryLoadsInMedia (defaults to NO)
> NSRequiresCertificateTransparency is not top level, but is under 
> NSExceptionDomains
> 1. Add this feature to the iOS platform
> 2. Add new attribute parsing to ConfigParser in CordovaCommon
> 3. Add docs for new attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11936) Support four new App Transport Security (ATS) keys


[ 
https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552781#comment-15552781
 ] 

ASF GitHub Bot commented on CB-11936:
-

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-docs/pull/648

CB-11936 - Add docs for the four new App Transport Security (ATS) keys

### Platforms affected
iOS

### What does this PR do?
Support docs for:
1. https://github.com/apache/cordova-lib/pull/496
2. https://github.com/apache/cordova-ios/pull/264

### What testing has been done on this change?

Ran "gulp serve" and inspected the output in a browser.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-docs CB-11936

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #648


commit 041642f128d3bd4086e9acf0e23ac633fb9c04cd
Author: Shazron Abdullah 
Date:   2016-10-06T18:39:10Z

CB-11936 - Add docs for the four new App Transport Security (ATS) keys




> Support four new App Transport Security (ATS) keys
> --
>
> Key: CB-11936
> URL: https://issues.apache.org/jira/browse/CB-11936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon, Docs, iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> https://forums.developer.apple.com/thread/6767
> NSAllowsArbitraryLoadsInWebContent (defaults to NO)
> NSRequiresCertificateTransparency (defaults to NO)
> NSAllowsLocalNetworking (defaults to NO)
> NSAllowsArbitraryLoadsInMedia (defaults to NO)
> NSRequiresCertificateTransparency is not top level, but is under 
> NSExceptionDomains
> 1. Add this feature to the iOS platform
> 2. Add new attribute parsing to ConfigParser in CordovaCommon
> 3. Add docs for new attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11936) Support four new App Transport Security (ATS) keys


[ 
https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552713#comment-15552713
 ] 

ASF GitHub Bot commented on CB-11936:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/496
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-lib/pull/496?src=pr) is 80.38% 
(diff: 100%)
> Merging [#496](https://codecov.io/gh/apache/cordova-lib/pull/496?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) 
will not change coverage

```diff
@@ master   #496   diff @@
==
  Files67 67  
  Lines  5184   5184  
  Methods 835835  
  Messages  0  0  
  Branches   1005   1005  
==
  Hits   4167   4167  
  Misses 1017   1017  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[97e98ed...a5c780a](https://codecov.io/gh/apache/cordova-lib/compare/97e98ed9ae4d55f815bc0ee6300d1ce9f3fde55a...a5c780aa19802c0c429a33f0ebe2610d22e0f4a6?src=pr)


> Support four new App Transport Security (ATS) keys
> --
>
> Key: CB-11936
> URL: https://issues.apache.org/jira/browse/CB-11936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon, Docs, iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> https://forums.developer.apple.com/thread/6767
> NSAllowsArbitraryLoadsInWebContent (defaults to NO)
> NSRequiresCertificateTransparency (defaults to NO)
> NSAllowsLocalNetworking (defaults to NO)
> NSAllowsArbitraryLoadsInMedia (defaults to NO)
> NSRequiresCertificateTransparency is not top level, but is under 
> NSExceptionDomains
> 1. Add this feature to the iOS platform
> 2. Add new attribute parsing to ConfigParser in CordovaCommon
> 3. Add docs for new attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11936) Support four new App Transport Security (ATS) keys


[ 
https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552668#comment-15552668
 ] 

ASF GitHub Bot commented on CB-11936:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/264
  
The tests are expected to fail. 

Depends on https://github.com/apache/cordova-lib/pull/496 cordova-common 
being pulled into this repo first. Once that is done, rebase, squash, and the 
tests should pass.


> Support four new App Transport Security (ATS) keys
> --
>
> Key: CB-11936
> URL: https://issues.apache.org/jira/browse/CB-11936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon, Docs, iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> https://forums.developer.apple.com/thread/6767
> NSAllowsArbitraryLoadsInWebContent (defaults to NO)
> NSRequiresCertificateTransparency (defaults to NO)
> NSAllowsLocalNetworking (defaults to NO)
> NSAllowsArbitraryLoadsInMedia (defaults to NO)
> NSRequiresCertificateTransparency is not top level, but is under 
> NSExceptionDomains
> 1. Add this feature to the iOS platform
> 2. Add new attribute parsing to ConfigParser in CordovaCommon
> 3. Add docs for new attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11936) Support four new App Transport Security (ATS) keys


[ 
https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552660#comment-15552660
 ] 

ASF GitHub Bot commented on CB-11936:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-lib/pull/496
  
This needs to go into the next cordova-common release, that will go into 
the cordova-ios platform, before cordova-ios 4.3.0 is released.


> Support four new App Transport Security (ATS) keys
> --
>
> Key: CB-11936
> URL: https://issues.apache.org/jira/browse/CB-11936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon, Docs, iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> https://forums.developer.apple.com/thread/6767
> NSAllowsArbitraryLoadsInWebContent (defaults to NO)
> NSRequiresCertificateTransparency (defaults to NO)
> NSAllowsLocalNetworking (defaults to NO)
> NSAllowsArbitraryLoadsInMedia (defaults to NO)
> NSRequiresCertificateTransparency is not top level, but is under 
> NSExceptionDomains
> 1. Add this feature to the iOS platform
> 2. Add new attribute parsing to ConfigParser in CordovaCommon
> 3. Add docs for new attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11955) InAppBrowser - Add support for OSX


[ 
https://issues.apache.org/jira/browse/CB-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552608#comment-15552608
 ] 

ASF GitHub Bot commented on CB-11955:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/190
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/190/commits/804cec3e3f15544ef105630b358f3ded8b2aaa52)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/80//PLATFORM=android/artifact/)
 |
 



> InAppBrowser - Add support for OSX
> --
>
> Key: CB-11955
> URL: https://issues.apache.org/jira/browse/CB-11955
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin InAppBrowser
>Reporter: Tobias Bocanegra
>Assignee: Tobias Bocanegra
>Priority: Minor
>
> It would be great to support cordova-osx in the InAppBrowserPlugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11936) Support four new App Transport Security (ATS) keys


[ 
https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552600#comment-15552600
 ] 

ASF GitHub Bot commented on CB-11936:
-

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-lib/pull/496

CB-11936 - Support four new App Transport Security (ATS) keys

### Platforms affected
iOS

### What does this PR do?
This PR is to support the feature in 
https://github.com/apache/cordova-ios/pull/264

### What testing has been done on this change?

Extensive unit tests in the cordova-ios platform.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-lib CB-11936

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #496


commit a5c780aa19802c0c429a33f0ebe2610d22e0f4a6
Author: Shazron Abdullah 
Date:   2016-10-06T17:29:29Z

CB-11936 - Support four new App Transport Security (ATS) keys




> Support four new App Transport Security (ATS) keys
> --
>
> Key: CB-11936
> URL: https://issues.apache.org/jira/browse/CB-11936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon, Docs, iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> https://forums.developer.apple.com/thread/6767
> NSAllowsArbitraryLoadsInWebContent (defaults to NO)
> NSRequiresCertificateTransparency (defaults to NO)
> NSAllowsLocalNetworking (defaults to NO)
> NSAllowsArbitraryLoadsInMedia (defaults to NO)
> NSRequiresCertificateTransparency is not top level, but is under 
> NSExceptionDomains
> 1. Add this feature to the iOS platform
> 2. Add new attribute parsing to ConfigParser in CordovaCommon
> 3. Add docs for new attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11945) Suppress webview's default right context menu

2016-10-06 Thread PwLin (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552544#comment-15552544
 ] 

PwLin edited comment on CB-11945 at 10/6/16 5:14 PM:
-

Agreed on all points. An addition to point 3: I think letting _some_ harmless 
context menu entries such as _Copy Link_ or _Share..._ go through would be very 
helpful for the user. Enabling it via __ is indeed the ideal 
choice.


was (Author: pwlin):
Agreed on all points. An addition to point 3: I think letting _some_ harmless 
context menu entries such as `Copy Link` or `Share...` go through would be very 
helpful for the user. Enabling it via `` is indeed the ideal 
choice.

> Suppress webview's default right context menu
> -
>
> Key: CB-11945
> URL: https://issues.apache.org/jira/browse/CB-11945
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: OSX
>Reporter: PwLin
>Assignee: Tobias Bocanegra
>
> Currently upon right clicking on an anchor link, a default webveiw's context 
> menu is shown to the user:
> Open Link
> Open Link In New Window
> Download Linked File
> Copy Link
> 
> Share ► 
> As "Open Link In New Window" and "Download Linked File" options do not 
> function at all, it might be a better idea to disable right clicking on a 
> page all together in order to conform with general Cordova behavior in other 
> supported platforms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11945) Suppress webview's default right context menu

2016-10-06 Thread PwLin (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552544#comment-15552544
 ] 

PwLin commented on CB-11945:


Agreed on all points. An addition to point 3: I think letting _some_ harmless 
context menu entries such as `Copy Link` or `Share...` go through would be very 
helpful for the user. Enabling it via `` is indeed the ideal 
choice.

> Suppress webview's default right context menu
> -
>
> Key: CB-11945
> URL: https://issues.apache.org/jira/browse/CB-11945
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: OSX
>Reporter: PwLin
>Assignee: Tobias Bocanegra
>
> Currently upon right clicking on an anchor link, a default webveiw's context 
> menu is shown to the user:
> Open Link
> Open Link In New Window
> Download Linked File
> Copy Link
> 
> Share ► 
> As "Open Link In New Window" and "Download Linked File" options do not 
> function at all, it might be a better idea to disable right clicking on a 
> page all together in order to conform with general Cordova behavior in other 
> supported platforms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11936) Support four new App Transport Security (ATS) keys


 [ 
https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-11936:
--
Component/s: CordovaCommon

> Support four new App Transport Security (ATS) keys
> --
>
> Key: CB-11936
> URL: https://issues.apache.org/jira/browse/CB-11936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon, Docs, iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> https://forums.developer.apple.com/thread/6767
> NSAllowsArbitraryLoadsInWebContent (defaults to NO)
> NSRequiresCertificateTransparency (defaults to NO)
> NSAllowsLocalNetworking (defaults to NO)
> NSAllowsArbitraryLoadsInMedia (defaults to NO)
> NSRequiresCertificateTransparency is not top level, but is under 
> NSExceptionDomains
> Don't forget to add this to the docs, if applicable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11936) Support four new App Transport Security (ATS) keys


 [ 
https://issues.apache.org/jira/browse/CB-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-11936:
--
Description: 
https://forums.developer.apple.com/thread/6767

NSAllowsArbitraryLoadsInWebContent (defaults to NO)
NSRequiresCertificateTransparency (defaults to NO)
NSAllowsLocalNetworking (defaults to NO)
NSAllowsArbitraryLoadsInMedia (defaults to NO)

NSRequiresCertificateTransparency is not top level, but is under 
NSExceptionDomains

1. Add this feature to the iOS platform
2. Add new attribute parsing to ConfigParser in CordovaCommon
3. Add docs for new attributes

  was:
https://forums.developer.apple.com/thread/6767

NSAllowsArbitraryLoadsInWebContent (defaults to NO)
NSRequiresCertificateTransparency (defaults to NO)
NSAllowsLocalNetworking (defaults to NO)
NSAllowsArbitraryLoadsInMedia (defaults to NO)

NSRequiresCertificateTransparency is not top level, but is under 
NSExceptionDomains

Don't forget to add this to the docs, if applicable.


> Support four new App Transport Security (ATS) keys
> --
>
> Key: CB-11936
> URL: https://issues.apache.org/jira/browse/CB-11936
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaCommon, Docs, iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> https://forums.developer.apple.com/thread/6767
> NSAllowsArbitraryLoadsInWebContent (defaults to NO)
> NSRequiresCertificateTransparency (defaults to NO)
> NSAllowsLocalNetworking (defaults to NO)
> NSAllowsArbitraryLoadsInMedia (defaults to NO)
> NSRequiresCertificateTransparency is not top level, but is under 
> NSExceptionDomains
> 1. Add this feature to the iOS platform
> 2. Add new attribute parsing to ConfigParser in CordovaCommon
> 3. Add docs for new attributes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11955) InAppBrowser - Add support for OSX


[ 
https://issues.apache.org/jira/browse/CB-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552514#comment-15552514
 ] 

ASF GitHub Bot commented on CB-11955:
-

GitHub user pwlin opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/190

CB-11955 (osx) Added Initial OSX platform support

### Platforms affected
OSX

### What does this PR do?
It adds preliminary support for OSX platform

### What testing has been done on this change?
Running `npm test` on this changes shows no error.

### Checklist
- [ x] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

- Added src/osx plugin folder structure.
- Added OSX platform to plugin.xml and package.json files.
- Added _system target functionality for OSX.
- Modified README.md to include information about OSX support.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pwlin/cordova-plugin-inappbrowser 
CB-11955cordova-plugin-inappbrowser

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #190


commit 804cec3e3f15544ef105630b358f3ded8b2aaa52
Author: pwlin 
Date:   2016-10-06T16:39:10Z

CB-11955 Added Initial OSX platform support

- Added src/osx plugin folder structure.
- Added OSX platform to plugin.xml and package.json files.
- Added _system target functionality for OSX.
- Modified README.md to include information about OSX support.




> InAppBrowser - Add support for OSX
> --
>
> Key: CB-11955
> URL: https://issues.apache.org/jira/browse/CB-11955
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin InAppBrowser
>Reporter: Tobias Bocanegra
>Assignee: Tobias Bocanegra
>Priority: Minor
>
> It would be great to support cordova-osx in the InAppBrowserPlugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11910) cordova run android --device doesn't work (while --target does)

2016-10-06 Thread Audrey So (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Audrey So closed CB-11910.
--
Resolution: Not A Problem

Commands are working as expected according to documentation.

>  cordova run android --device doesn't work (while --target does)
> 
>
> Key: CB-11910
> URL: https://issues.apache.org/jira/browse/CB-11910
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 6.2.0
> Environment: macOS Sierra, Android Studio 2.2 (and related Android 
> SDK updates)
>Reporter: Ash Ryan Arnwine
>Assignee: Audrey So
>Priority: Minor
>
> $ cordova run android --device=
> gives this error:
> > Error: Unknown platforms: 
> $ cordova run android --target=
> is working fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11910) cordova run android --device doesn't work (while --target does)

2016-10-06 Thread Audrey So (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552493#comment-15552493
 ] 

Audrey So commented on CB-11910:


[~ashryan]

Hi! We are closing this for now. If you think it is still a problem, please 
reopen the case. Thank you! - Audrey 

>  cordova run android --device doesn't work (while --target does)
> 
>
> Key: CB-11910
> URL: https://issues.apache.org/jira/browse/CB-11910
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 6.2.0
> Environment: macOS Sierra, Android Studio 2.2 (and related Android 
> SDK updates)
>Reporter: Ash Ryan Arnwine
>Assignee: Audrey So
>Priority: Minor
>
> $ cordova run android --device=
> gives this error:
> > Error: Unknown platforms: 
> $ cordova run android --target=
> is working fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11910) cordova run android --device doesn't work (while --target does)

2016-10-06 Thread Audrey So (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Audrey So reassigned CB-11910:
--

Assignee: Audrey So

>  cordova run android --device doesn't work (while --target does)
> 
>
> Key: CB-11910
> URL: https://issues.apache.org/jira/browse/CB-11910
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 6.2.0
> Environment: macOS Sierra, Android Studio 2.2 (and related Android 
> SDK updates)
>Reporter: Ash Ryan Arnwine
>Assignee: Audrey So
>Priority: Minor
>
> $ cordova run android --device=
> gives this error:
> > Error: Unknown platforms: 
> $ cordova run android --target=
> is working fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation


[ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552373#comment-15552373
 ] 

Joe Bowser commented on CB-11964:
-

Bug affects both CLI and plugman native workflows.  The strange thing is that 
running the build twice does fix it, so this is clearly a gradle bug.  I still 
think we should run clean as a work-around to Gradle flakiness, and to get 
around other weird build Heisenbugs that have been popping up.

> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation


[ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552221#comment-15552221
 ] 

Joe Bowser commented on CB-11964:
-

It seems that the latest gradle is having problems with directories on MacOS, 
and that this isn't a permissions thing:
{noformat}
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':packageDebug'.
> java.io.FileNotFoundException: 
> /Users/jbowser/GradleFail/platforms/android/build/intermediates/assets/debug/www/plugins/cordova-plugin-device
>  (Is a directory)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED
{noformat}

When I run a clean and then do a build, it works fine.  After further thought, 
we SHOULD force a clean after every plugin installation, since we're changing 
both the Java and the JS code.  I know that this may slow down builds slightly, 
but it's better for it to be slower and correct than for it to error out 
because assets have changed and don't have the same signature or because Java 
code has changed.

> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11964) Gradle build failure after any plugin installation


[ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552196#comment-15552196
 ] 

Joe Bowser edited comment on CB-11964 at 10/6/16 3:24 PM:
--

Well, having this cleanly import into Android Studio is non-negotiable, so we 
have to find a way around it.  Is gradle running as a different user in the 
latest version?


was (Author: bowserj):
Well, having this cleanly import into Android Studio is non-negotiable, so we 
have to find a way around it.

> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation


[ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552196#comment-15552196
 ] 

Joe Bowser commented on CB-11964:
-

Well, having this cleanly import into Android Studio is non-negotiable, so we 
have to find a way around it.

> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11964) Gradle build failure after any plugin installation


[ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552183#comment-15552183
 ] 

Alexander Sorokin commented on CB-11964:


It seems that this has been introduced by updating gradle plugin to a recent 
version:
https://github.com/apache/cordova-android/pull/336

This seems like a gradle plugin or gradle bug to me.

> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11967) Cordova Plugin default preferences loaded as 'undefined' value inside cordova project.


 [ 
https://issues.apache.org/jira/browse/CB-11967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Iñaki Vitoria updated CB-11967:
---
Description: 
Scenario


Creating a new cordova Plugin.

Setting preferences and default values in different platforms inside plugin.xml 
file.

Once the plugin is added to the project and built, resultant DEFAULT values 
aren´t loaded and set to 'undefined'.

PROJECT SAMPLE CODE PROVIDED


Only relevant lines of code are included, everything else has been removed 
since is automatically generated by cordova.


http://www.phonegap.com/ns/plugins/1.0;
xmlns:android="http://schemas.android.com/apk/res/android;>

Plugin











   










Given the following preference configuration and default values PROVIDED

the resultant config.xml file inside res/xml/config.xml (android example) 
contains all default values set to 'undefined'







  was:
Scenario


Creating a new cordova Plugin.

Setting preferences and default values in different platforms inside plugin.xml 
file.

Once the plugin is added to the project and built, resultant DEFAULT values 
aren´t loaded and set to 'undefined'.

PROJECT SAMPLE CODE PROVIDED


Only relevant lines of code are included, everything else has been removed 
since is automatically generated by cordova.


http://www.phonegap.com/ns/plugins/1.0;
xmlns:android="http://schemas.android.com/apk/res/android;>

Cells-mxsofttoken











   










Given the following preference configuration and default values PROVIDED

the resultant config.xml file inside res/xml/config.xml (android example) 
contains all default values set to 'undefined'








> Cordova Plugin default preferences loaded as 'undefined' value inside cordova 
> project.
> --
>
> Key: CB-11967
> URL: https://issues.apache.org/jira/browse/CB-11967
> Project: Apache Cordova
>  Issue Type: Bug
>Affects Versions: 6.3.1
>Reporter: Iñaki Vitoria
>
> Scenario
> 
> Creating a new cordova Plugin.
> Setting preferences and default values in different platforms inside 
> plugin.xml file.
> Once the plugin is added to the project and built, resultant DEFAULT values 
> aren´t loaded and set to 'undefined'.
> PROJECT SAMPLE CODE PROVIDED
> 
> Only relevant lines of code are included, everything else has been removed 
> since is automatically generated by cordova.
> 
>  
> xmlns="http://www.phonegap.com/ns/plugins/1.0;
> xmlns:android="http://schemas.android.com/apk/res/android;>
> Plugin
> 
> 
> 
> 
> 
> 
> 
> 
> 
>
> 
> 
> 
> 
> 
> 
> 
> 
> 
> Given the following preference configuration and default values PROVIDED
> the resultant config.xml file inside res/xml/config.xml (android example) 
> contains all default values set to 'undefined'
> 
> 
> 
> 
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11967) Cordova Plugin default preferences loaded as 'undefined' value inside cordova project.


 [ 
https://issues.apache.org/jira/browse/CB-11967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Iñaki Vitoria updated CB-11967:
---
Description: 
Scenario


Creating a new cordova Plugin.

Setting preferences and default values in different platforms inside plugin.xml 
file.

Once the plugin is added to the project and built, resultant DEFAULT values 
aren´t loaded and set to 'undefined'.

PROJECT SAMPLE CODE PROVIDED


Only relevant lines of code are included, everything else has been removed 
since is automatically generated by cordova.


http://www.phonegap.com/ns/plugins/1.0;
xmlns:android="http://schemas.android.com/apk/res/android;>

Cells-mxsofttoken











   










Given the following preference configuration and default values PROVIDED

the resultant config.xml file inside res/xml/config.xml (android example) 
contains all default values set to 'undefined'







  was:
Scenario


Creating a new cordova Plugin.

Setting preferences and default values in different platforms inside plugin.xml 
file.

Once the plugin is added to the project and built, resultant DEFAULT values 
aren´t loaded and set to 'undefined'.

PROJECT SAMPLE CODE PROVIDED


Only relevant lines of code are included, everything else has been removed 
since is automatically generated by cordova.


http://www.phonegap.com/ns/plugins/1.0;
xmlns:android="http://schemas.android.com/apk/res/android;>

Cells-mxsofttoken











   










Given the following preference configuration and default values PROVIDED

the resultant config.xml file inside res/xml/config.xml (android example) 
contains all default values set to 'undefined'








> Cordova Plugin default preferences loaded as 'undefined' value inside cordova 
> project.
> --
>
> Key: CB-11967
> URL: https://issues.apache.org/jira/browse/CB-11967
> Project: Apache Cordova
>  Issue Type: Bug
>Affects Versions: 6.3.1
>Reporter: Iñaki Vitoria
>
> Scenario
> 
> Creating a new cordova Plugin.
> Setting preferences and default values in different platforms inside 
> plugin.xml file.
> Once the plugin is added to the project and built, resultant DEFAULT values 
> aren´t loaded and set to 'undefined'.
> PROJECT SAMPLE CODE PROVIDED
> 
> Only relevant lines of code are included, everything else has been removed 
> since is automatically generated by cordova.
> 
>  
> xmlns="http://www.phonegap.com/ns/plugins/1.0;
> xmlns:android="http://schemas.android.com/apk/res/android;>
> Cells-mxsofttoken
> 
> 
> 
> 
> 
> 
> 
> 
> 
>
> 
> 
> 
> 
> 
> 
> 
> 
> 
> Given the following preference configuration and default values PROVIDED
> the resultant config.xml file inside res/xml/config.xml (android example) 
> contains all default values set to 'undefined'
> 
> 
> 
> 
> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11967) Cordova Plugin default preferences loaded as 'undefined' value inside cordova project.

Iñaki Vitoria created CB-11967:
--

 Summary: Cordova Plugin default preferences loaded as 'undefined' 
value inside cordova project.
 Key: CB-11967
 URL: https://issues.apache.org/jira/browse/CB-11967
 Project: Apache Cordova
  Issue Type: Bug
Affects Versions: 6.3.1
Reporter: Iñaki Vitoria


Scenario


Creating a new cordova Plugin.

Setting preferences and default values in different platforms inside plugin.xml 
file.

Once the plugin is added to the project and built, resultant DEFAULT values 
aren´t loaded and set to 'undefined'.

PROJECT SAMPLE CODE PROVIDED


Only relevant lines of code are included, everything else has been removed 
since is automatically generated by cordova.


http://www.phonegap.com/ns/plugins/1.0;
xmlns:android="http://schemas.android.com/apk/res/android;>

Cells-mxsofttoken











   










Given the following preference configuration and default values PROVIDED

the resultant config.xml file inside res/xml/config.xml (android example) 
contains all default values set to 'undefined'









--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11966) Make durationHint parameter for requestAudioContext configurable


 [ 
https://issues.apache.org/jira/browse/CB-11966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jörn Zaefferer updated CB-11966:

 Labels: android  (was: )
Component/s: (was: Android)

> Make durationHint parameter for requestAudioContext configurable
> 
>
> Key: CB-11966
> URL: https://issues.apache.org/jira/browse/CB-11966
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Media
>Reporter: Jörn Zaefferer
>  Labels: android
>
> Android supports playback of so-called transient audio, like instructions 
> from navigation software or a beep from a timer or messenger, via the 
> AudioManager#requestAudioFocus method's `durationHint` parameter. Currently 
> this is hardcoded to AUDIOFOCUS_GAIN: 
> https://github.com/apache/cordova-plugin-media/blob/0a5a72df42ddd91c50f2a36d0c58408c3b43a9fd/src/android/AudioHandler.java#L445
> That causes all other audio, like music or a podcast, to be stopped. Setting 
> it instead to AUDIOFOCUS_GAIN_TRANSIENT would only pause other audio while 
> the sound is playing. AUDIOFOCUS_GAIN_TRANSIENT_MAY_DUCK allows other audio 
> to only lower volume, without pausing. There's also 
> AUDIOFOCUS_GAIN_TRANSIENT_EXCLUSIVE, but I don't understand what that does.
> For more background, see 
> https://developer.android.com/training/managing-audio/audio-focus.html
> I suggest adding a (Android specific) option to override the default to one 
> of the transient values.
> Since the caller is itself called by `startPlayingAudio()` ( 
> https://github.com/apache/cordova-plugin-media/blob/0a5a72df42ddd91c50f2a36d0c58408c3b43a9fd/src/android/AudioHandler.java#L318
>  ), it might make sense to make this a parameter of the `media.play()` 
> method. I'm not sure what a good format would be. Passing an `int` is kinda 
> bad. Apparently none of the existing methods have any configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11964) Gradle build failure after adding any plugin


 [ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Sorokin updated CB-11964:
---
Summary: Gradle build failure after adding any plugin  (was: Gradle build 
failure after plugin add)

> Gradle build failure after adding any plugin
> 
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11964) Gradle build failure after any plugin installation


 [ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Sorokin updated CB-11964:
---
Summary: Gradle build failure after any plugin installation  (was: Gradle 
build failure after adding any plugin)

> Gradle build failure after any plugin installation
> --
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-10-06 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov resolved CB-11848.
---
Resolution: Fixed

> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Reopened] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-10-06 Thread Vladimir Kotikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov reopened CB-11848:
---

> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-10-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552057#comment-15552057
 ] 

ASF GitHub Bot commented on CB-11848:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/195


> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename


[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552056#comment-15552056
 ] 

ASF subversion and git services commented on CB-11848:
--

Commit 7ae74f5385e14b1e81ed7396ba12c21782d6eac7 in cordova-plugin-file's branch 
refs/heads/master from [~Nikita Matrosov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=7ae74f5 ]

CB-11848 windows: Remove duplicate slash after file system path

 This closes #195, this closes #112


> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11966) Make durationHint parameter for requestAudioContext configurable

Jörn Zaefferer created CB-11966:
---

Summary: Make durationHint parameter for requestAudioContext
configurable
Key: CB-11966
URL: https://issues.apache.org/jira/browse/CB-11966
Project: Apache Cordova
Issue Type: New Feature
Components: Android, Plugin Media
Reporter: Jörn Zaefferer

Android supports playback of so-called transient audio, like instructions from
navigation software or a beep from a timer or messenger, via the
AudioManager#requestAudioFocus method's `durationHint` parameter. Currently
this is hardcoded to AUDIOFOCUS_GAIN:
https://github.com/apache/cordova-plugin-media/blob/0a5a72df42ddd91c50f2a36d0c58408c3b43a9fd/src/android/AudioHandler.java#L445

That causes all other audio, like music or a podcast, to be stopped. Setting it
instead to AUDIOFOCUS_GAIN_TRANSIENT would only pause other audio while the
sound is playing. AUDIOFOCUS_GAIN_TRANSIENT_MAY_DUCK allows other audio to only
lower volume, without pausing. There's also
AUDIOFOCUS_GAIN_TRANSIENT_EXCLUSIVE, but I don't understand what that does.

For more background, see
https://developer.android.com/training/managing-audio/audio-focus.html

I suggest adding a (Android specific) option to override the default to one of
the transient values.

Since the caller is itself called by `startPlayingAudio()` (
https://github.com/apache/cordova-plugin-media/blob/0a5a72df42ddd91c50f2a36d0c58408c3b43a9fd/src/android/AudioHandler.java#L318
), it might make sense to make this a parameter of the `media.play()` method.
I'm not sure what a good format would be. Passing an `int` is kinda bad.
Apparently none of the existing methods have any configuration.

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11965) Remove WinJS dependency

Philipp Kursawe created CB-11965:


 Summary: Remove WinJS dependency
 Key: CB-11965
 URL: https://issues.apache.org/jira/browse/CB-11965
 Project: Apache Cordova
  Issue Type: Improvement
  Components: Windows
Reporter: Philipp Kursawe
Priority: Minor


As far as I can see cordova uses WinJS only for managing life-cycle events, 
which can be easily handled without WinJS using native WinRT.

I propose to get rid of the (discontinued) WinJS library dependency to reduce 
package deploy size and runtime overhead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11964) Gradle build failure after plugin add


[ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551903#comment-15551903
 ] 

Alexander Sorokin commented on CB-11964:


What's interesting about this one is that if we try to `cordova build` again, 
there is no error.

> Gradle build failure after plugin add
> -
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
> OS: Windows 10
>Reporter: Alexander Sorokin
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11964) Gradle build failure after plugin add


 [ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Sorokin updated CB-11964:
---
Labels: found-by-ci triaged  (was: )

> Gradle build failure after plugin add
> -
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11964) Gradle build failure after plugin add


 [ 
https://issues.apache.org/jira/browse/CB-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Sorokin updated CB-11964:
---
Environment: 
node 4.4.3
cordova 6.3.0

  was:
node 4.4.3
cordova 6.3.0
OS: Windows 10


> Gradle build failure after plugin add
> -
>
> Key: CB-11964
> URL: https://issues.apache.org/jira/browse/CB-11964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Affects Versions: Master
> Environment: node 4.4.3
> cordova 6.3.0
>Reporter: Alexander Sorokin
>  Labels: found-by-ci, triaged
>
> {noformat}
> cordova create foo
> cd foo
> cordova platform add android@https://github.com/apache/cordova-android
> cordova build
> cordova plugin add cordova-plugin-device
> cordova build
> {noformat}
> Results in the following error:
> {noformat}
> BUILD FAILED
> Total time: 2.439 secs
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output.
> Error: cmd: Command failed with exit code 1 Error output:
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':packageDebug'.
> > java.io.FileNotFoundException: 
> > C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins
> >  (Access is denied)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11964) Gradle build failure after plugin add

Alexander Sorokin created CB-11964:
--

 Summary: Gradle build failure after plugin add
 Key: CB-11964
 URL: https://issues.apache.org/jira/browse/CB-11964
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
Affects Versions: Master
 Environment: node 4.4.3
cordova 6.3.0
OS: Windows 10
Reporter: Alexander Sorokin


{noformat}
cordova create foo
cd foo
cordova platform add android@https://github.com/apache/cordova-android
cordova build
cordova plugin add cordova-plugin-device
cordova build
{noformat}

Results in the following error:
{noformat}
BUILD FAILED

Total time: 2.439 secs
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':packageDebug'.
> java.io.FileNotFoundException: 
> C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins 
> (Access is denied)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
Error: cmd: Command failed with exit code 1 Error output:
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':packageDebug'.
> java.io.FileNotFoundException: 
> C:\Cordova\foo\platforms\android\build\intermediates\assets\debug\www\plugins 
> (Access is denied)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11956) camera plugin in android shows a blank screen after capturing the picture.

2016-10-06 Thread seema (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551412#comment-15551412
 ] 

seema commented on CB-11956:


Hi 
The android version is 6.0.1
cordova-android version : 5.1.1
cordova-camera-plugin : 2.3.0
 Below is script that we are using to get the picture from camera
 navigator.camera.getPicture(function (imageData) {
   callback()
}, function onFail(message) {
  
fcallback();
}, {
quality: 25,
destinationType: Camera.DestinationType.FILE_URI,
encodingType: Camera.EncodingType.PNG, 
sourceType: Camera.PictureSourceType.CAMERA
correctOrientation: true,
});

> camera plugin in android shows a blank screen after capturing the picture.
> --
>
> Key: CB-11956
> URL: https://issues.apache.org/jira/browse/CB-11956
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Reporter: seema
> Attachments: logfile.txt
>
>
> We are using camera plugin to take pictures .
> In android phone after picture is captured and confirmed , it is showing 
> blank screen for almost 10 - 15 sec. It looks like app has hanged. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8285) Don't create .fetch.json files within plugin directories


[ 
https://issues.apache.org/jira/browse/CB-8285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551371#comment-15551371
 ] 

Philipp Kursawe commented on CB-8285:
-

What is this file used for anyway? It contains completely redundant information 
already in config.xml

> Don't create .fetch.json files within plugin directories
> 
>
> Key: CB-8285
> URL: https://issues.apache.org/jira/browse/CB-8285
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Reporter: Andrew Grieve
>Assignee: Andrew Grieve
>Priority: Minor
>
> Right now cordova creates `.fetch.json` files at: 
> `project/plugins/ID/.fetch.json`.
> This is super annoying when using `cordova plugin add --link`, since now the 
> `.fetch.json` file appears in the original plugin directory.
> We should instead record this information within the plugins/ directory 
> directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11394) backbutton eventlistener should be able to let cordova execute the default native behaviour


 [ 
https://issues.apache.org/jira/browse/CB-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philipp Kursawe updated CB-11394:
-
Issue Type: Improvement  (was: Bug)

> backbutton eventlistener should be able to let cordova execute the default 
> native behaviour
> ---
>
> Key: CB-11394
> URL: https://issues.apache.org/jira/browse/CB-11394
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Philipp Kursawe
>
> When we override the "backbutton" with a custom handler, cordova completly 
> skips handling of the native behaviour (as written in the docs).
> It does this even though the events `defaultPrevented` property is set to 
> `false`. A proper implementation of event handling would look into this 
> property  and act accordingly.
> Not sure how this could be introduced now without breaking old code.
> Probably old code never returns a value from the event handler. So a patch 
> could check if the return value is `===true` then it should perform the 
> default native behaviour of that button.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11394) backbutton eventlistener should be able to let cordova execute the default native behaviour


 [ 
https://issues.apache.org/jira/browse/CB-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philipp Kursawe updated CB-11394:
-
Issue Type: Bug  (was: Improvement)

> backbutton eventlistener should be able to let cordova execute the default 
> native behaviour
> ---
>
> Key: CB-11394
> URL: https://issues.apache.org/jira/browse/CB-11394
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Android
>Reporter: Philipp Kursawe
>
> When we override the "backbutton" with a custom handler, cordova completly 
> skips handling of the native behaviour (as written in the docs).
> It does this even though the events `defaultPrevented` property is set to 
> `false`. A proper implementation of event handling would look into this 
> property  and act accordingly.
> Not sure how this could be introduced now without breaking old code.
> Probably old code never returns a value from the event handler. So a patch 
> could check if the return value is `===true` then it should perform the 
> default native behaviour of that button.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11963) Get rid of fetch.json and in plugins folders

Philipp Kursawe created CB-11963:


 Summary: Get rid of fetch.json and  in plugins 
folders
 Key: CB-11963
 URL: https://issues.apache.org/jira/browse/CB-11963
 Project: Apache Cordova
  Issue Type: Bug
  Components: AllPlugins
Reporter: Philipp Kursawe


In a cordova project you define the plugins in config.xml which kind of serves 
as the project file.

Since some time now it also contains the plugins the project is using.
I wonder why there is still a /plugins/fetch.json and a /plugins/PLATFORM.json 
for each installed platform. 
Both somehow list plugins in a redundant way, since the same information is 
already in config.xml

More so, the platform JSON contains PACKAGE_NAME that references to the 
config.xml widget id. Why? Its not like we can have multiple app IDs specified.

I propose to get rid of those files and make `cordova prepare` actually 
updating the VARIABLES defined in config.xml plugins. Because at the moment the 
only way to CHANGE a var in config.xml and see this change being reflected in 
the built app is to remove the platform and re-add it.
This is so error prone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1


[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551110#comment-15551110
 ] 

ASF GitHub Bot commented on CB-3232:


GitHub user asapping99 opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/160

When "Content-Type" has "multipart/form-data", should not contain a 
"Content-Length" in the boundary area.



### Platforms affected
platform : ios

### What does this PR do?
"https://www.w3.org/Protocols/rfc1341/7_2_Multipart.html; in the article 
"Multipart Form" of the site, there is no content that ey included the 
"Content-Length" to the "boundary" region, "boundary "in the region," 
Content-Type "," Content-Disposition "and it has been seen to have put," 
Content-Transfer-Encoding "only. Therefore, it is unnecessary source, there is 
a possibility that the bug occurs, it is assumed that the suit is to delete.

### What testing has been done on this change?
Bug you do not check the "Content-Length" of the boundary in the area 
occurred in the services currently under development. Once you apply the 
source, it was Mashi normal operation.

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

…Content-Length" in the boundary area.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/asapping99/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #160


commit 217c1a5ef96caae8ffe7e03f22086a7bc416164a
Author: asapping99 
Date:   2016-10-06T06:39:39Z

When "Content-Type" has "multipart/form-data", should not contain a 
"Content-Length" in the boundary area.




> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -
>
> Key: CB-3232
> URL: https://issues.apache.org/jira/browse/CB-3232
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: BlackBerry, CLI
>Affects Versions: 2.7.0
>Reporter: Michael Brooks
>Assignee: Michael Brooks
> Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11962) NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets reset to empty whenever the app is built. This improves the process of adding the plugin so tha