[jira] [Updated] (CB-13917) Windows 10 Min Version Must Be Configured Twice in Config.xml
[
https://issues.apache.org/jira/browse/CB-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terence Bandoian updated CB-13917:
--
Description:
In config.xml, the minimum Windows 10 version preference must be set with both:
{{ uap-target-min-version}}
{{ Windows.Universal-MinVersion}}
Setting {{uap-target-min-version}} results in the value being copied to
CordovaApp.Windows10.jsproj.
Setting {{Windows.Universal-MinVersion}} results in the value being copied to
package.windows10.appxmanifest.
If {{uap-target-min-version}} is not set, the minimum version of the app in the
Microsoft Store is incorrect.
Development of Windows 10 apps would be simplified by only having to set the
minimum version in one place.
was:
In config.xml, the minimum Windows 10 version preference must be set with both:
{{ uap-target-min-version}}
{{ Windows.Universal-MinVersion}}{{}}
Setting {{uap-target-min-version}} results in the value being copied to
CordovaApp.Windows10.jsproj.
Setting {{Windows.Universal-MinVersion}} results in the value being copied to
package.windows10.appxmanifest.
If {{uap-target-min-version}} is not set, the minimum version of the app in the
Microsoft Store is incorrect.
Development of Windows 10 apps would be simplified by only having to set the
minimum version in one place.
> Windows 10 Min Version Must Be Configured Twice in Config.xml
> -
>
> Key: CB-13917
> URL: https://issues.apache.org/jira/browse/CB-13917
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-windows
>Affects Versions: cordova@7.0.0
> Environment: Windows 10
> Cordova 7.1.0
>Reporter: Terence Bandoian
>Assignee: Jesse MacFadyen
>Priority: Major
> Labels: usability, windows
>
> In config.xml, the minimum Windows 10 version preference must be set with
> both:
> {{ uap-target-min-version}}
> {{ Windows.Universal-MinVersion}}
> Setting {{uap-target-min-version}} results in the value being copied to
> CordovaApp.Windows10.jsproj.
> Setting {{Windows.Universal-MinVersion}} results in the value being copied to
> package.windows10.appxmanifest.
> If {{uap-target-min-version}} is not set, the minimum version of the app in
> the Microsoft Store is incorrect.
> Development of Windows 10 apps would be simplified by only having to set the
> minimum version in one place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[
https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373718#comment-16373718
]
ASF GitHub Bot commented on CB-13828:
-
stevengill commented on a change in pull request #170: CB-13828: Improve
cordova-coho/docs
URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170132668
##
File path: docs/platforms-release-process.md
##
@@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have
Apache-compatible licenses.
coho check-license -r android
## Prepare Release
-Increase the version within package.json using SemVer, and remove the `-dev`
suffix.
+
+### Remove the `-dev` suffix from version
+
+This command removes `-dev` from the `version` entry in `package.json`:
for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json |
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json;
fi) ; done
-In `cordova-android`, also remember to bump the version in
`framework/build.gradle`.
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13809). You can also replace
`-dev` manually of course.
-If the changes merit it, manually bump the major / minor/ patch version in
`package.json`. View the changes via:
+Note: In `cordova-android`, also remember to handle the version in
`framework/build.gradle`.
Review comment:
The remove dev part is split from the other version stuff because we use the
version you set in package.json when writing to releasenotes. After you remove
dev you may manually change the versionwhen reviewing commits in case you want
a patch/minor/major release. This happens right before we run the update
releasenotes command
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve cordova-coho/docs
> -
>
> Key: CB-13828
> URL: https://issues.apache.org/jira/browse/CB-13828
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> /docs in the `cordova-coho` repo is effectively the contributor documentation
> of Cordova. It could use some improvements right now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13835) iOS InAppBrowser changing toolbar position to top doesn't alter position webpage
[ https://issues.apache.org/jira/browse/CB-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373695#comment-16373695 ] Tom Saul commented on CB-13835: --- The problem exists for the plugin in the phoneGap Build NPM and when pulling the master (2.0.3) from GIT. I see it on both IOS 9 and 11. It works fine when the bar is on the bottom (page is shrunk to proper size), but no resizing is done when it is on the top. > iOS InAppBrowser changing toolbar position to top doesn't alter position > webpage > > > Key: CB-13835 > URL: https://issues.apache.org/jira/browse/CB-13835 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Reporter: Corneel den Hartogh >Priority: Major > Attachments: Screenshot 2018-01-26 11.25.02.jpg, Screenshot > 2018-01-26 11.28.24.jpg > > > Within the InAppBrowser you can set for iOS the toolbarposition on bottom or > top (bottom is default). When I make it top, the position of the loaded url > (a map in my case) isn't changed. The result is that the toolbar is in front > of the url (where the search box is blocked out of view as can be seen in the > screenshots). > I updated Ionic / Cordova / InAppBrowser but it didn't change anything. > I tried some workaround myself but I was unable to figure it out. Any > suggestions here? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13916) Notification.java uses or overrides a deprecated API.
[
https://issues.apache.org/jira/browse/CB-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373675#comment-16373675
]
jcesarmobile commented on CB-13916:
---
The plugin shows this 4 deprecated warnings
{quote}
'THEME_DEVICE_DEFAULT_LIGHT' is deprecated as of API 23: Android 6.0
(Marshmallow)
'android.app.ProgressDialog' is deprecated as of API 26: Android 8.0 (Oreo)
'THEME_DEVICE_DEFAULT_LIGHT' is deprecated as of API 23: Android 6.0
(Marshmallow)
'android.app.ProgressDialog' is deprecated as of API 26: Android 8.0 (Oreo)
{quote}
This shouldn't prevent your project from building, you must have some setting
that prevents from building when warnings are present.
Keeping the issue open to fix the warnings.
> Notification.java uses or overrides a deprecated API.
> -
>
> Key: CB-13916
> URL: https://issues.apache.org/jira/browse/CB-13916
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-dialogs
>Affects Versions: cordova-android-7.0.0
> Environment: * "cordova-android": "^7.0.0",
> * "cordova-ios": "^4.5.4",
> * "cordova-plugin-dialogs": "^2.0.1",
> * "cordova-plugin-whitelist": "^1.3.3"
> Cordova version: 8.0.0
>Reporter: Lenin Meza
>Priority: Major
>
> When i tried to execute:
> {code:java}
> cordova run android --verbose{code}
>
> It gives me the next error:
> {code:java}
> :app:compileDebugJavaWithJavacNote:
> my-app\platforms\android\app\src\main\java\org\apache\cordova\dialogs\Notification.java
> uses or overrides a deprecated API.{code}
>
> The screen is White and on the Chrome Console(_Developer tools_) it shows the
> next error:
> {code:java}
> Uncaught Error: Java exception was raised during method invocation{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[
https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373449#comment-16373449
]
ASF GitHub Bot commented on CB-13828:
-
janpio commented on a change in pull request #170: CB-13828: Improve
cordova-coho/docs
URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170092765
##
File path: docs/platforms-release-process.md
##
@@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have
Apache-compatible licenses.
coho check-license -r android
## Prepare Release
-Increase the version within package.json using SemVer, and remove the `-dev`
suffix.
+
+### Remove the `-dev` suffix from version
+
+This command removes `-dev` from the `version` entry in `package.json`:
for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json |
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json;
fi) ; done
-In `cordova-android`, also remember to bump the version in
`framework/build.gradle`.
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13809). You can also replace
`-dev` manually of course.
-If the changes merit it, manually bump the major / minor/ patch version in
`package.json`. View the changes via:
+Note: In `cordova-android`, also remember to handle the version in
`framework/build.gradle`.
+
+### Increase version
+
+If the changes merit it, **manually** bump the major / minor/ patch version in
`package.json`.
+
+To decide if this release merits it, view the changes via:
( cd cordova-android && git log --pretty=format:'* %s' --topo-order
--no-merges $(git describe --tags $(git rev-list --tags --max-count=1))..master
)
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13901). You can also check out
the changes manually (or via the next step).
Review comment:
Indeed, it works in WSL. Will update the text.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve cordova-coho/docs
> -
>
> Key: CB-13828
> URL: https://issues.apache.org/jira/browse/CB-13828
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> /docs in the `cordova-coho` repo is effectively the contributor documentation
> of Cordova. It could use some improvements right now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13901) Platform Release: "View the changes via" doesn't work on Windows
[
https://issues.apache.org/jira/browse/CB-13901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373447#comment-16373447
]
Jan Piotrowski (Sujan) commented on CB-13901:
-
Noticed that I only ran this in Windows command line. Running it in
WSL/bash/Ubuntu, this actually does work:
{code}
sujan@LenovoX1:/mnt/c/Projects/Cordova/cordova-windows$ git log
--pretty=format:'* %s' --topo-order --no-merges $(git describe --tags $(git
rev-list --tags --max-count=1))..master
* Update JS snapshot to version 6.1.0-dev (via coho)
* Set VERSION to 6.1.0-dev (via coho)
{code}
That means that the format of Windows `git` is just different than the one for
Linux and macOS :/
> Platform Release: "View the changes via" doesn't work on Windows
>
>
> Key: CB-13901
> URL: https://issues.apache.org/jira/browse/CB-13901
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#prepare-release
> has "View the changes via" as a second step. Executing that command gives
> me this though:
> {code}
> λ git log --pretty=format:'* %s' --topo-order --no-merges $(git describe
> --tags $(git rev-list --tags --max-count=1))..master
> fatal: ambiguous argument '%s'': unknown revision or path not in the working
> tree.
> Use '--' to separate paths from revisions, like this:
> 'git [...] -- [...]'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[
https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373445#comment-16373445
]
ASF GitHub Bot commented on CB-13828:
-
janpio commented on a change in pull request #170: CB-13828: Improve
cordova-coho/docs
URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170092319
##
File path: docs/platforms-release-process.md
##
@@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have
Apache-compatible licenses.
coho check-license -r android
## Prepare Release
-Increase the version within package.json using SemVer, and remove the `-dev`
suffix.
+
+### Remove the `-dev` suffix from version
+
+This command removes `-dev` from the `version` entry in `package.json`:
for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json |
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json;
fi) ; done
-In `cordova-android`, also remember to bump the version in
`framework/build.gradle`.
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13809). You can also replace
`-dev` manually of course.
-If the changes merit it, manually bump the major / minor/ patch version in
`package.json`. View the changes via:
+Note: In `cordova-android`, also remember to handle the version in
`framework/build.gradle`.
+
+### Increase version
+
+If the changes merit it, **manually** bump the major / minor/ patch version in
`package.json`.
+
+To decide if this release merits it, view the changes via:
( cd cordova-android && git log --pretty=format:'* %s' --topo-order
--no-merges $(git describe --tags $(git rev-list --tags --max-count=1))..master
)
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13901). You can also check out
the changes manually (or via the next step).
Review comment:
Just noticed that I only ran this on Windows shell, not WSL/bash so this one
might actually be just a different in the params of `git` on Windows.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve cordova-coho/docs
> -
>
> Key: CB-13828
> URL: https://issues.apache.org/jira/browse/CB-13828
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> /docs in the `cordova-coho` repo is effectively the contributor documentation
> of Cordova. It could use some improvements right now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13901) Platform Release: "View the changes via" doesn't work on Windows
[
https://issues.apache.org/jira/browse/CB-13901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) updated CB-13901:
Summary: Platform Release: "View the changes via" doesn't work on Windows
(was: Platform Release: "View the changes via" doesn't work)
> Platform Release: "View the changes via" doesn't work on Windows
>
>
> Key: CB-13901
> URL: https://issues.apache.org/jira/browse/CB-13901
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#prepare-release
> has "View the changes via" as a second step. Executing that command gives
> me this though:
> {code}
> λ git log --pretty=format:'* %s' --topo-order --no-merges $(git describe
> --tags $(git rev-list --tags --max-count=1))..master
> fatal: ambiguous argument '%s'': unknown revision or path not in the working
> tree.
> Use '--' to separate paths from revisions, like this:
> 'git [...] -- [...]'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[
https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373440#comment-16373440
]
ASF GitHub Bot commented on CB-13828:
-
janpio commented on a change in pull request #170: CB-13828: Improve
cordova-coho/docs
URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170091703
##
File path: docs/platforms-release-process.md
##
@@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have
Apache-compatible licenses.
coho check-license -r android
## Prepare Release
-Increase the version within package.json using SemVer, and remove the `-dev`
suffix.
+
+### Remove the `-dev` suffix from version
+
+This command removes `-dev` from the `version` entry in `package.json`:
for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json |
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json;
fi) ; done
-In `cordova-android`, also remember to bump the version in
`framework/build.gradle`.
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13809). You can also replace
`-dev` manually of course.
Review comment:
Yeah, I also felt this was strange as I assumes these were used quite often.
You can take a look at the linked issues.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve cordova-coho/docs
> -
>
> Key: CB-13828
> URL: https://issues.apache.org/jira/browse/CB-13828
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> /docs in the `cordova-coho` repo is effectively the contributor documentation
> of Cordova. It could use some improvements right now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[ https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373439#comment-16373439 ] ASF GitHub Bot commented on CB-13828: - janpio commented on a change in pull request #170: CB-13828: Improve cordova-coho/docs URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170091489 ## File path: docs/platforms-release-process.md ## @@ -118,114 +205,147 @@ If you have prepared the release notes in your release branch for a patch releas For iOS, you may have to cherry-pick the commit for `Added X.Y.Z to CDVAvailability.h (via coho)` into the master branch as well. +### Special Case 2: releasing new commits from an already-existing release branch If you are releasing new commits from an already-existing release branch, remember to merge in or cherry-pick relevant commits from master into the release branch! -After, prepare your release branch by using `coho prepare-release-branch` command, which handles the following steps: - * Updating `cordova.js` snapshot - * Creating a release branch (if it doesn't already exist) - * Updating version numbers (`VERSION` file & package.json). On `master`, it gives version a minor bump and adds `-dev` +### Create Release Branch + +Create and prepare your release branch by using `coho prepare-release-branch` command, which handles the following steps: +1. Creates a release branch `5.0.x` (if it doesn't already exist) +2. Updates `cordova.js` snapshot on both `5.0.x` and `master` +3. Updates version numbers (`VERSION` files) on `5.0.x` Review comment: Reworded that and added your example. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve cordova-coho/docs > - > > Key: CB-13828 > URL: https://issues.apache.org/jira/browse/CB-13828 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-coho >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > /docs in the `cordova-coho` repo is effectively the contributor documentation > of Cordova. It could use some improvements right now. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[
https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373434#comment-16373434
]
ASF GitHub Bot commented on CB-13828:
-
janpio commented on a change in pull request #170: CB-13828: Improve
cordova-coho/docs
URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170090965
##
File path: docs/platforms-release-process.md
##
@@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have
Apache-compatible licenses.
coho check-license -r android
## Prepare Release
-Increase the version within package.json using SemVer, and remove the `-dev`
suffix.
+
+### Remove the `-dev` suffix from version
+
+This command removes `-dev` from the `version` entry in `package.json`:
for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json |
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json;
fi) ; done
-In `cordova-android`, also remember to bump the version in
`framework/build.gradle`.
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13809). You can also replace
`-dev` manually of course.
-If the changes merit it, manually bump the major / minor/ patch version in
`package.json`. View the changes via:
+Note: In `cordova-android`, also remember to handle the version in
`framework/build.gradle`.
Review comment:
Is this good enough? I was somehow thinking there was a reason that "remove
-dev" and the other version stuff later is split in 2 parts?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve cordova-coho/docs
> -
>
> Key: CB-13828
> URL: https://issues.apache.org/jira/browse/CB-13828
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> /docs in the `cordova-coho` repo is effectively the contributor documentation
> of Cordova. It could use some improvements right now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[ https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373426#comment-16373426 ] ASF GitHub Bot commented on CB-13828: - stevengill commented on a change in pull request #170: CB-13828: Improve cordova-coho/docs URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170088073 ## File path: docs/platforms-release-process.md ## @@ -118,114 +205,147 @@ If you have prepared the release notes in your release branch for a patch releas For iOS, you may have to cherry-pick the commit for `Added X.Y.Z to CDVAvailability.h (via coho)` into the master branch as well. +### Special Case 2: releasing new commits from an already-existing release branch If you are releasing new commits from an already-existing release branch, remember to merge in or cherry-pick relevant commits from master into the release branch! -After, prepare your release branch by using `coho prepare-release-branch` command, which handles the following steps: - * Updating `cordova.js` snapshot - * Creating a release branch (if it doesn't already exist) - * Updating version numbers (`VERSION` file & package.json). On `master`, it gives version a minor bump and adds `-dev` +### Create Release Branch + +Create and prepare your release branch by using `coho prepare-release-branch` command, which handles the following steps: +1. Creates a release branch `5.0.x` (if it doesn't already exist) +2. Updates `cordova.js` snapshot on both `5.0.x` and `master` +3. Updates version numbers (`VERSION` files) on `5.0.x` Review comment: It also updates in other files but that is platform specific. For example, it updates build.gradle version for android. It does similar stuff for iOS. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve cordova-coho/docs > - > > Key: CB-13828 > URL: https://issues.apache.org/jira/browse/CB-13828 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-coho >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > /docs in the `cordova-coho` repo is effectively the contributor documentation > of Cordova. It could use some improvements right now. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[ https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373425#comment-16373425 ] ASF GitHub Bot commented on CB-13828: - stevengill commented on a change in pull request #170: CB-13828: Improve cordova-coho/docs URL: https://github.com/apache/cordova-coho/pull/170#discussion_r169823843 ## File path: docs/platforms-release-process.md ## @@ -19,43 +19,113 @@ # --> -# Release Process for ''Platforms Releases'' - -Before cutting any releases, read the Apache's [Releases Policy](http://www.apache.org/dev/release) - -This page describes the technical steps for releasing a `Platforms Release` (see: [versioning-and-release-strategy.md](versioning-and-release-strategy.md)). - -TODO: We may want to be using [signed tags](http://git-scm.com/book/en/Git-Basics-Tagging), or at least annotated tags. - -Replace `Android` with the platform you are releasing. - -## Get Buy-in +# Release Process for Cordova Platforms + +This page describes the technical steps for doing a `Platforms Release`. + +It describes the following steps: + +- [General instructions](#general-instructions) + * [Repository setup](#repository-setup) +- [Before you start](#before-you-start) + * [Get Buy-in](#get-buy-in) + * [Create JIRA issue](#create-jira-issue) +- [Before Release](#before-release) + * [Update and Pin Dependencies](#update-and-pin-dependencies) + * [License Check](#license-check) +- [Prepare Release](#prepare-release) + * [Remove the `-dev` suffix from version](#remove-the--dev-suffix-from-version) + * [Increase version](#increase-version) + * [Create Release Notes](#create-release-notes) + * [Commit Version and Release Notes](#commit-version-and-release-notes) + * [Special Case 1: Release notes in release branch for patch release](#special-case-1-release-notes-in-release-branch-for-patch-release) + * [Special Case 2: releasing new commits from an already-existing release branch](#special-case-2-releasing-new-commits-from-an-already-existing-release-branch) + * [Create Release Branch](#create-release-branch) +- [Testing](#testing) + * [1) Plugin tests with `cordova-mobile-spec` project](#1-plugin-tests-with-cordova-mobile-spec-project) + * [2) hello world app with `cordova` CLI](#2-hello-world-app-with-cordova-cli) + * [3) `/bin` scripts](#3-bin-scripts) + * [4) `cordova-lib` tests](#4-cordova-lib-tests) + * [5) Clean up](#5-clean-up) + * [Android Extras](#android-extras) + * [iOS Extras](#ios-extras) + * [When a regression is found](#when-a-regression-is-found) + * [To submit a fix](#to-submit-a-fix) +- [Push Changes](#push-changes) + * [Push commits](#push-commits) + * [Tag and push tag](#tag-and-push-tag) +- [Publish Release Candidate to `dist/dev`](#publish-release-candidate-to-distdev) +- [Documentation and Communication](#documentation-and-communication) + * [Documentation To Update](#documentation-to-update) + * [Prepare Blog Post](#prepare-blog-post) +- [Voting and Release](#voting-and-release) + * [Start VOTE Thread](#start-vote-thread) + * [Email the result of the vote](#email-the-result-of-the-vote) + * [If the Vote does *not* Pass](#if-the-vote-does-not-pass) + * [Otherwise: Publish real release to `dist/` & npm](#otherwise-publish-real-release-to-dist--npm) + * [(Android only) Uploading to Bintray](#android-only-uploading-to-bintray) + * [Add permanent Apache release tag to repository](#add-permanent-apache-release-tag-to-repository) +- [Follow up steps](#follow-up-steps) + * [Tell Apache about Release](#tell-apache-about-release) + * [Email a release announcement to the mailing list](#email-a-release-announcement-to-the-mailing-list) + * [Announce It!](#announce-it) + * [Close JIRA issue](#close-jira-issue) + * [Finally](#finally) +- [Other stuff that should be reviewed and moved up to the appropriate places](#other-stuff-that-should-be-reviewed-and-moved-up-to-the-appropriate-places) + * [Update the Docs](#update-the-docs) + * [Moving Tags](#moving-tags) + + + +(Yes this list is long and scary, but represents the content below) + +## General instructions + +- See: [versioning-and-release-strategy.md](versioning-and-release-strategy.md) for general versioning information +- Before cutting any releases, read the Apache's [Releases Policy](http://www.apache.org/dev/release) +- Replace `Android` with the platform you are releasing in the instructions below. + +### Repository setup + +You should have your platform repository checked out in a folder where you als ohave checked out all/most/some of the other Cordova repositories. If you followed the [Cloning/Updating Cordova repositories Review comment: spelling: also have* This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[
https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373424#comment-16373424
]
ASF GitHub Bot commented on CB-13828:
-
stevengill commented on a change in pull request #170: CB-13828: Improve
cordova-coho/docs
URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170087557
##
File path: docs/platforms-release-process.md
##
@@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have
Apache-compatible licenses.
coho check-license -r android
## Prepare Release
-Increase the version within package.json using SemVer, and remove the `-dev`
suffix.
+
+### Remove the `-dev` suffix from version
+
+This command removes `-dev` from the `version` entry in `package.json`:
for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json |
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json;
fi) ; done
-In `cordova-android`, also remember to bump the version in
`framework/build.gradle`.
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13809). You can also replace
`-dev` manually of course.
-If the changes merit it, manually bump the major / minor/ patch version in
`package.json`. View the changes via:
+Note: In `cordova-android`, also remember to handle the version in
`framework/build.gradle`.
+
+### Increase version
+
+If the changes merit it, **manually** bump the major / minor/ patch version in
`package.json`.
+
+To decide if this release merits it, view the changes via:
( cd cordova-android && git log --pretty=format:'* %s' --topo-order
--no-merges $(git describe --tags $(git rev-list --tags --max-count=1))..master
)
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13901). You can also check out
the changes manually (or via the next step).
Review comment:
once again, worked fine for me for latest android release. A pre-requisite
to running this command is making sure you have the latest tags. I had to run
`git fetch --tags` in cordova-android repo to grab the tags I was missing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve cordova-coho/docs
> -
>
> Key: CB-13828
> URL: https://issues.apache.org/jira/browse/CB-13828
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> /docs in the `cordova-coho` repo is effectively the contributor documentation
> of Cordova. It could use some improvements right now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[
https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373423#comment-16373423
]
ASF GitHub Bot commented on CB-13828:
-
stevengill commented on a change in pull request #170: CB-13828: Improve
cordova-coho/docs
URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170086993
##
File path: docs/platforms-release-process.md
##
@@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have
Apache-compatible licenses.
coho check-license -r android
## Prepare Release
-Increase the version within package.json using SemVer, and remove the `-dev`
suffix.
+
+### Remove the `-dev` suffix from version
+
+This command removes `-dev` from the `version` entry in `package.json`:
for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json |
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json;
fi) ; done
-In `cordova-android`, also remember to bump the version in
`framework/build.gradle`.
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13809). You can also replace
`-dev` manually of course.
-If the changes merit it, manually bump the major / minor/ patch version in
`package.json`. View the changes via:
+Note: In `cordova-android`, also remember to handle the version in
`framework/build.gradle`.
Review comment:
169 can actually be removed. `coho prepare-release-branch` command that is
run later will update build.gradle
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve cordova-coho/docs
> -
>
> Key: CB-13828
> URL: https://issues.apache.org/jira/browse/CB-13828
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> /docs in the `cordova-coho` repo is effectively the contributor documentation
> of Cordova. It could use some improvements right now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13828) Improve cordova-coho/docs
[
https://issues.apache.org/jira/browse/CB-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373422#comment-16373422
]
ASF GitHub Bot commented on CB-13828:
-
stevengill commented on a change in pull request #170: CB-13828: Improve
cordova-coho/docs
URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170087317
##
File path: docs/platforms-release-process.md
##
@@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have
Apache-compatible licenses.
coho check-license -r android
## Prepare Release
-Increase the version within package.json using SemVer, and remove the `-dev`
suffix.
+
+### Remove the `-dev` suffix from version
+
+This command removes `-dev` from the `version` entry in `package.json`:
for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json |
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json;
fi) ; done
-In `cordova-android`, also remember to bump the version in
`framework/build.gradle`.
+Note: This command [doesn't actually
work](https://issues.apache.org/jira/browse/CB-13809). You can also replace
`-dev` manually of course.
Review comment:
Strange, it worked fine for me on this latest android release.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve cordova-coho/docs
> -
>
> Key: CB-13828
> URL: https://issues.apache.org/jira/browse/CB-13828
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-coho
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> /docs in the `cordova-coho` repo is effectively the contributor documentation
> of Cordova. It could use some improvements right now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13865) Making CameraPopover for imagePicker bigger on Ipad
[
https://issues.apache.org/jira/browse/CB-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372957#comment-16372957
]
Ams commented on CB-13865:
--
Hi,
I am trying to implement the change and I need to figure out how to run the
test cases.
For tests/ios: I figured it out using the commands below:
cd tests/ios && npm install && npm test
However, there is a file called tests.js: (tests/tests.js) this file has the
javascript tests for the function I need such as window.onorientationchange.
However, I do not know how to run those tests. I tried the commands below but
they do nothing.
cd tests && npm install && npm test
Output: Error: no test specified
> Making CameraPopover for imagePicker bigger on Ipad
> ---
>
> Key: CB-13865
> URL: https://issues.apache.org/jira/browse/CB-13865
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-camera
>Reporter: Ams
>Priority: Major
> Fix For: Master
>
>
> The popover for imagePicker from gallery is way too small and people complain
> about not being able to see images before selecting them.
>
> The fix is simple:
>
> Adding this line to willShowViewController method will set it to 960 by 960
> or as big as the screen widht/height
> [viewController setPreferredContentSize:CGSizeMake(960,960)];
> It should be added right in the if statement:
> if([navigationController isKindOfClass:[UIImagePickerController class]]){
>
> HOW CAN I COMMIT THIS CHANGE?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile resolved CB-10645. --- Resolution: Fixed Fixed in 2.0.2-dev > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372891#comment-16372891 ] ASF subversion and git services commented on CB-10645: -- Commit c2a526e673a793f07a5a5341bcc1b03c0121f476 in cordova-plugin-battery-status's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=c2a526e ] Merge pull request #31 from Geotab/CB-10645cordova-plugin-battery-status CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload() > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372889#comment-16372889 ] ASF subversion and git services commented on CB-10645: -- Commit 7d04d6dbaa0b67686facd460458f42a991b66ffb in cordova-plugin-battery-status's branch refs/heads/master from [~aaront] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=7d04d6d ] CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload(). Instead of throwing an error, rather remove the status handler and re-initialize. > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[ https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372890#comment-16372890 ] ASF subversion and git services commented on CB-10645: -- Commit c2a526e673a793f07a5a5341bcc1b03c0121f476 in cordova-plugin-battery-status's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=c2a526e ] Merge pull request #31 from Geotab/CB-10645cordova-plugin-battery-status CB-10645 The battery status handler doesn't reinitialize on Android after window.location.reload() > The battery status handler doesn't reinitialize on Android after > window.location.reload() > - > > Key: CB-10645 > URL: https://issues.apache.org/jira/browse/CB-10645 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-battery-status > Environment: Android >Reporter: Aaron Toth >Priority: Minor > Labels: android, reload, triaged > Original Estimate: 24h > Remaining Estimate: 24h > > Instead of throwing an error, rather remove the status handler and > re-initialize. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()
[
https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372888#comment-16372888
]
ASF GitHub Bot commented on CB-10645:
-
jcesarmobile closed pull request #31: CB-10645 The battery status handler
doesn't reinitialize on Android after window.location.reload()
URL: https://github.com/apache/cordova-plugin-battery-status/pull/31
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/android/BatteryListener.java b/src/android/BatteryListener.java
index 740a92e..8814d9e 100755
--- a/src/android/BatteryListener.java
+++ b/src/android/BatteryListener.java
@@ -57,8 +57,7 @@ public BatteryListener() {
public boolean execute(String action, JSONArray args, CallbackContext
callbackContext) {
if (action.equals("start")) {
if (this.batteryCallbackContext != null) {
-callbackContext.error( "Battery listener already running.");
-return true;
+removeBatteryListener();
}
this.batteryCallbackContext = callbackContext;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The battery status handler doesn't reinitialize on Android after
> window.location.reload()
> -
>
> Key: CB-10645
> URL: https://issues.apache.org/jira/browse/CB-10645
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-battery-status
> Environment: Android
>Reporter: Aaron Toth
>Priority: Minor
> Labels: android, reload, triaged
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Instead of throwing an error, rather remove the status handler and
> re-initialize.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13074) Do a final release of deprecated cordova-plugin-device-motion plugin
[ https://issues.apache.org/jira/browse/CB-13074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372836#comment-16372836 ] jcesarmobile commented on CB-13074: --- We screwed up with the Cordova dependencies, so this latest version can't be installed. Should we do a patch release? > Do a final release of deprecated cordova-plugin-device-motion plugin > > > Key: CB-13074 > URL: https://issues.apache.org/jira/browse/CB-13074 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-device-motion (DEPRECATED) >Reporter: Filip Maj >Priority: Major > Labels: plugins-next > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-12604) Improve Android Frequency
[ https://issues.apache.org/jira/browse/CB-12604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-12604. - Resolution: Won't Fix This plugin is deprecated, so it won't be fixed. See https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed for the recommended alternative > Improve Android Frequency > -- > > Key: CB-12604 > URL: https://issues.apache.org/jira/browse/CB-12604 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-device-motion (DEPRECATED) >Reporter: Jon Coupée >Priority: Minor > Labels: performance > Original Estimate: 10m > Remaining Estimate: 10m > > Currently Android is set to SENSOR_DELAY_UI which is restricted to 16Hz. I > think this can be increased to SENSOR_DELAY_GAME which increases the > frequency to 50Hz. I've created and tested a fork on a Samsung S4 and S6, and > the devices both report unique timestamps at this speed. This increase in > speed would improve usability of the plugin for gaming, and also scientific > data capture apps. > Increasing Android to SENSOR_DELAY_FASTEST would perhaps bring it inline with > iOS - but I appreciate there are an incredible range of devices beyond the > Samsung devices. > I've also looked more closely at the docs iOS quirk and cannot see anything > within the plugin which restricts the iOS device to 40ms (25Hz). I think I've > also noticed that the iOS defaults to 100Hz. > "The API calls the success callback function at the interval requested, but > restricts the range of requests to the device between 40ms and 1000ms. For > example, if you request an interval of 3 seconds, (3000ms), the API requests > data from the device every 1 second, but only executes the success callback > every 3 seconds." -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11291) Update capped to 1Hz when in background
[ https://issues.apache.org/jira/browse/CB-11291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-11291. - Resolution: Won't Fix This plugin is deprecated, so it won't be fixed. See https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed for the recommended alternative > Update capped to 1Hz when in background > --- > > Key: CB-11291 > URL: https://issues.apache.org/jira/browse/CB-11291 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-device-motion (DEPRECATED) >Reporter: Zeph Davies >Priority: Minor > > Due to the way Android's WebBrowser handles setInterval, when the "tab" is in > the background (ie when used in conjunction with backgroundMode plugin), > setInterval (used to send the latest value to the application) is capped to > 1Hz (once per second). > This makes the plugin update at a completely different interval to that set > by the application. > One solution is to use a WebWorker to hold the setInterval timer, as it is > not limited by the browser. > The tricky bit is loading the script into the WebWorker, as it requires the > "Content-Security-Policy" to allow local files or blobs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-9082) Accelerometer not working on moto G 2
[ https://issues.apache.org/jira/browse/CB-9082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-9082. Resolution: Won't Fix This plugin is deprecated, so it won't be fixed. See https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed for the recommended alternative > Accelerometer not working on moto G 2 > - > > Key: CB-9082 > URL: https://issues.apache.org/jira/browse/CB-9082 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-device-motion (DEPRECATED) > Environment: Android >Reporter: thiago ramires kairala >Priority: Major > > Accelerometer doesn't work on moto g 2 but works on any other device -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-8648) HTC One Accelerometer Not Working
[ https://issues.apache.org/jira/browse/CB-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jcesarmobile closed CB-8648. Resolution: Won't Fix This plugin is deprecated, so it won't be fixed. See https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed for the recommended alternative > HTC One Accelerometer Not Working > - > > Key: CB-8648 > URL: https://issues.apache.org/jira/browse/CB-8648 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-device-motion (DEPRECATED) >Affects Versions: 3.5.0 > Environment: HTC One with Android Lollipop >Reporter: Jon Knight >Priority: Minor > > I have a working application using the accelerometer that works on other > devices. On the HTC One, the watchAccelerometer call does not fire either the > success or error callbacks. It just fails silently. > To eliminate the possibility of coding error, I have taken demo projects from > online tutorials - which again work on other devices, but not the HTC One. > Other non-phonegap apps are still working. The phone successfully re-orients. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372812#comment-16372812 ] ASF GitHub Bot commented on CB-13415: - alpesh12 commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-367682737 @jcesarmobile Any updates for merge please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13913) Default Splash Screen Not changing
[
https://issues.apache.org/jira/browse/CB-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372692#comment-16372692
]
jcesarmobile commented on CB-13913:
---
You said you are using both and I explained that in developer app it's not
going to work, and in PGB you are probably doing something wrong because I
tested and it works, so create a thread on the PGB forums (link on my previous
message) and provide your app id, config.xml and code there.
> Default Splash Screen Not changing
> --
>
> Key: CB-13913
> URL: https://issues.apache.org/jira/browse/CB-13913
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
>Affects Versions: cordova-android-7.0.0
> Environment: * Creating a simple Hello world app using Phone Gap
> Desktop App
> * Testing over Phong Gap Developer App
> * Icons reflects as I replace with custom images
> * Splash Screen shows default Cordova icons
>Reporter: Manoj
>Priority: Major
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> I am trying to display custom Splash Screen but it shows default *CORDOVA
> ICON WITH GREY BACKGROUND* before app launches.
>
> {code:java}
> // document.addEventListener("deviceready", onDeviceReady, false);
> function onDeviceReady() {
> window.open = cordova.InAppBrowser.open;
>
> var ref =
> cordova.InAppBrowser.open('https://cordova.apache.org/', '_blank',
> 'location=no');
>
> navigator.splashscreen.show();
> window.setTimeout(function () {
> navigator.splashscreen.hide();
> }, 6000);
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13913) Default Splash Screen Not changing
[
https://issues.apache.org/jira/browse/CB-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372666#comment-16372666
]
Manoj commented on CB-13913:
I am not setting for Developer App , I am saying its not working either with
app or with PGB
> Default Splash Screen Not changing
> --
>
> Key: CB-13913
> URL: https://issues.apache.org/jira/browse/CB-13913
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
>Affects Versions: cordova-android-7.0.0
> Environment: * Creating a simple Hello world app using Phone Gap
> Desktop App
> * Testing over Phong Gap Developer App
> * Icons reflects as I replace with custom images
> * Splash Screen shows default Cordova icons
>Reporter: Manoj
>Priority: Major
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> I am trying to display custom Splash Screen but it shows default *CORDOVA
> ICON WITH GREY BACKGROUND* before app launches.
>
> {code:java}
> // document.addEventListener("deviceready", onDeviceReady, false);
> function onDeviceReady() {
> window.open = cordova.InAppBrowser.open;
>
> var ref =
> cordova.InAppBrowser.open('https://cordova.apache.org/', '_blank',
> 'location=no');
>
> navigator.splashscreen.show();
> window.setTimeout(function () {
> navigator.splashscreen.hide();
> }, 6000);
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13913) Default Splash Screen Not changing
[
https://issues.apache.org/jira/browse/CB-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile closed CB-13913.
-
Resolution: Cannot Reproduce
You can't set the icons or splash for the Phonegap Developer app, as it's an
app that is already compiled.
About PGB, I've tested and it works fine, so you are probably doing something
wrong, better ask on the PGB forums
https://forums.adobe.com/community/phonegap/build
> Default Splash Screen Not changing
> --
>
> Key: CB-13913
> URL: https://issues.apache.org/jira/browse/CB-13913
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
>Affects Versions: cordova-android-7.0.0
> Environment: * Creating a simple Hello world app using Phone Gap
> Desktop App
> * Testing over Phong Gap Developer App
> * Icons reflects as I replace with custom images
> * Splash Screen shows default Cordova icons
>Reporter: Manoj
>Priority: Major
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> I am trying to display custom Splash Screen but it shows default *CORDOVA
> ICON WITH GREY BACKGROUND* before app launches.
>
> {code:java}
> // document.addEventListener("deviceready", onDeviceReady, false);
> function onDeviceReady() {
> window.open = cordova.InAppBrowser.open;
>
> var ref =
> cordova.InAppBrowser.open('https://cordova.apache.org/', '_blank',
> 'location=no');
>
> navigator.splashscreen.show();
> window.setTimeout(function () {
> navigator.splashscreen.hide();
> }, 6000);
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
