[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524853#comment-16524853
 ] 

ASF GitHub Bot commented on CB-10893:
-

goinnn commented on issue #124: CB-10893: (android) Allow setting status bar 
color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-400614963
 
 
   I have improved it a little with color in navigation bar too: 
https://github.com/goinnn/cordova-plugin-splashscreen/commit/7e5bafd628ebe0478c51800171f72ce4b84d325a


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455475#comment-16455475
 ] 

ASF GitHub Bot commented on CB-10893:
-

gjdownes commented on issue #124: CB-10893: (android) Allow setting status bar 
color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-384807122
 
 
   Any timeline for this being merged and released?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356843#comment-16356843
 ] 

ASF GitHub Bot commented on CB-10893:
-

janpio commented on issue #124: CB-10893: (android) Allow setting status bar 
color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-364088680
 
 
   Ok thanks @TimothyFehr. Some minor code fixes (indentation) and maybe some 
documentation and this should be good to merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356840#comment-16356840
 ] 

ASF GitHub Bot commented on CB-10893:
-

janpio commented on a change in pull request #124: CB-10893: (android) Allow 
setting status bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r166910844
 
 

 ##
 File path: src/android/SplashScreen.java
 ##
 @@ -283,7 +286,7 @@ public void run() {
 // Get reference to display
 Display display = 
cordova.getActivity().getWindowManager().getDefaultDisplay();
 Context context = webView.getContext();
-
+   Window splashWindow;
 
 Review comment:
   indentation


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356841#comment-16356841
 ] 

ASF GitHub Bot commented on CB-10893:
-

janpio commented on a change in pull request #124: CB-10893: (android) Allow 
setting status bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r166910928
 
 

 ##
 File path: src/android/SplashScreen.java
 ##
 @@ -307,12 +310,29 @@ public void run() {
 
 // Create and show the dialog
 splashDialog = new Dialog(context, 
android.R.style.Theme_Translucent_NoTitleBar);
-// check to see if the splash screen should be full screen
+splashWindow = splashDialog.getWindow();
+   // check to see if the splash screen should be full screen
 if ((cordova.getActivity().getWindow().getAttributes().flags & 
WindowManager.LayoutParams.FLAG_FULLSCREEN)
 == WindowManager.LayoutParams.FLAG_FULLSCREEN) {
-
splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
+
splashWindow.setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
 WindowManager.LayoutParams.FLAG_FULLSCREEN);
 }
+
+// Status bar color just like cordova-plugin.statusbar
+String statusBarColor = 
preferences.getString("StatusBarBackgroundColor", "#00");
 
 Review comment:
   This should probably be added to the README as well, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356839#comment-16356839
 ] 

ASF GitHub Bot commented on CB-10893:
-

janpio commented on a change in pull request #124: CB-10893: (android) Allow 
setting status bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r166910720
 
 

 ##
 File path: src/android/SplashScreen.java
 ##
 @@ -307,12 +310,29 @@ public void run() {
 
 // Create and show the dialog
 splashDialog = new Dialog(context, 
android.R.style.Theme_Translucent_NoTitleBar);
-// check to see if the splash screen should be full screen
+splashWindow = splashDialog.getWindow();
+   // check to see if the splash screen should be full screen
 
 Review comment:
   fix indentation here please (space instead of tabs)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356733#comment-16356733
 ] 

ASF GitHub Bot commented on CB-10893:
-

TimothyFehr commented on issue #124: CB-10893: (android) Allow setting status 
bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-364056358
 
 
   I can confirm that it works as intended by the author and that the code 
quality is ok (i can see no big issue there)
   
   It is in our production app implemented like the author suggests and we have 
no issues so far.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356731#comment-16356731
 ] 

ASF GitHub Bot commented on CB-10893:
-

TimothyFehr commented on issue #124: CB-10893: (android) Allow setting status 
bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-364056358
 
 
   I can confirm that it works as intended by the author and that the code 
quality is ok (i can see no big issue there)
   
   It is in our production app implemented like in the author suggests and we 
have no issues so far.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292838#comment-16292838
 ] 

ASF GitHub Bot commented on CB-10893:
-

janpio commented on issue #124: CB-10893: (android) Allow setting status bar 
color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-352061341
 
 
   Old, 10 , no full review, "I tested it locally and works fine!" or "code 
looks great" yet, not merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292765#comment-16292765
 ] 

ASF GitHub Bot commented on CB-10893:
-

DevNIX commented on issue #124: CB-10893: (android) Allow setting status bar 
color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-352049711
 
 
   What's the status of this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945224#comment-15945224
 ] 

ASF GitHub Bot commented on CB-10893:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/124
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-splashscreen/pull/124/commits/aa3fb6055941b9b57b54dc28cc97b9c14ffae643)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/45//PLATFORM=android-5.1/artifact/)
 |
 



> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin SplashScreen
> Environment: Android
>Reporter: Martin Buchalik
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945199#comment-15945199
 ] 

ASF GitHub Bot commented on CB-10893:
-

Github user psbarrales commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r108424985
  
--- Diff: src/android/SplashScreen.java ---
@@ -313,6 +315,22 @@ public void run() {
 
splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
--- End diff --

Done, thanks!


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin SplashScreen
> Environment: Android
>Reporter: Martin Buchalik
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931877#comment-15931877
 ] 

ASF GitHub Bot commented on CB-10893:
-

Github user duchuyctlk commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r106814440
  
--- Diff: src/android/SplashScreen.java ---
@@ -313,6 +315,22 @@ public void run() {
 
splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
--- End diff --

`splashDialog.getWindow()` is repeatedly used, so i think it could be 
extracted into a variable to avoid multiple method calls.


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin SplashScreen
> Environment: Android
>Reporter: Martin Buchalik
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931606#comment-15931606
 ] 

ASF GitHub Bot commented on CB-10893:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/124
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-splashscreen/pull/124/commits/135bb76329b24453021d70c01715f6353821d105)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=windows-10-store/artifact/)
 |
| [iOS 9.3]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=ios-9.3/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=ios-9.3/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=ios-9.3/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=ios-9.3/artifact/)
 |
| [iOS 10.0]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=ios-10.0/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=ios-10.0/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=ios-10.0/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=ios-10.0/artifact/)
 |
| [Android 4.4]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=android-4.4/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=android-4.4/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=android-4.4/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=android-4.4/artifact/)
 |
| [Android 5.1]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=android-5.1/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=android-5.1/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=android-5.1/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-splashscreen-pr/44//PLATFORM=android-5.1/artifact/)
 |
 



> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin SplashScreen
> Environment: Android
>Reporter: Martin Buchalik
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931602#comment-15931602
 ] 

ASF GitHub Bot commented on CB-10893:
-

GitHub user psbarrales opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/124

CB-10893: (android) Allow setting status bar color on Android splashscreen

Just like 
[cordova-plugin-statusBar](https://github.com/apache/cordova-plugin-statusbar), 
use the settings "StatusBarBackgroundColor" on config.xml for setting up the 
color.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/psbarrales/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #124


commit 135bb76329b24453021d70c01715f6353821d105
Author: Pablo Barrales 
Date:   2017-03-19T05:18:48Z

backgroundStatusBar to change color of status bar by settings




> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin SplashScreen
> Environment: Android
>Reporter: Martin Buchalik
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org