[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726654#comment-14726654 ] ASF GitHub Bot commented on FLINK-2480: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...

2015-09-01 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1073#issuecomment-136918945 @mxm @StephanEwen Hi, I fix the PrintStream. And if I use the ByteArrayOutputStream baos = new ByteArrayOutputStream();, it will append "\r\n" in the end of p

[GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...

2015-09-01 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1073#issuecomment-136916269 @mxm Much thanks! I`ll take a fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726621#comment-14726621 ] ASF GitHub Bot commented on FLINK-2480: --- Github user HuangWHWHW commented on the pul

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726554#comment-14726554 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-09-01 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-136910004 @mxm @StephanEwen Hi, I just update one commit yesterday. And I found that a few PRs got the same trouble yesterday. Is there any issue in CI? --- If your

[jira] [Created] (FLINK-2605) Unclosed RandomAccessFile may leak resource in StaticFileServerHandler

2015-09-01 Thread Ted Yu (JIRA)
Ted Yu created FLINK-2605: - Summary: Unclosed RandomAccessFile may leak resource in StaticFileServerHandler Key: FLINK-2605 URL: https://issues.apache.org/jira/browse/FLINK-2605 Project: Flink Issue

[jira] [Created] (FLINK-2604) Access to SessionID without holding lock in ZooKeeperLeaderElectionService

2015-09-01 Thread Ted Yu (JIRA)
Ted Yu created FLINK-2604: - Summary: Access to SessionID without holding lock in ZooKeeperLeaderElectionService Key: FLINK-2604 URL: https://issues.apache.org/jira/browse/FLINK-2604 Project: Flink I

[jira] [Commented] (FLINK-2603) Flink hangs before starting execution

2015-09-01 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725942#comment-14725942 ] Ufuk Celebi commented on FLINK-2603: In this case, you should be able to work around t

[jira] [Updated] (FLINK-2348) Instable (failing) Test

2015-09-01 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated FLINK-2348: --- Labels: test-stability (was: ) > Instable (failing) Test > --- > >

[jira] [Updated] (FLINK-2348) Instable (failing) Test

2015-09-01 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated FLINK-2348: --- Priority: Critical (was: Major) > Instable (failing) Test > --- > >

[jira] [Updated] (FLINK-2392) Instable test in flink-yarn-tests

2015-09-01 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated FLINK-2392: --- Labels: test-stability (was: ) > Instable test in flink-yarn-tests >

[jira] [Updated] (FLINK-2392) Instable test in flink-yarn-tests

2015-09-01 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated FLINK-2392: --- Priority: Critical (was: Minor) > Instable test in flink-yarn-tests > ---

[GitHub] flink pull request: [FLINK-2373] Add configuration parameter to cr...

2015-09-01 Thread akunft
Github user akunft commented on the pull request: https://github.com/apache/flink/pull/1066#issuecomment-136829682 Added tests + behavior described above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725899#comment-14725899 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...

2015-09-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/750#discussion_r38458556 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -411,6 +411,23 @@ class TaskManager( log.d

[jira] [Commented] (FLINK-2373) Add configuration parameter to createRemoteEnvironment method

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725895#comment-14725895 ] ASF GitHub Bot commented on FLINK-2373: --- Github user akunft commented on the pull re

[GitHub] flink pull request: [FLINK-2125][streaming] Delimiter change from ...

2015-09-01 Thread ogokal
Github user ogokal commented on the pull request: https://github.com/apache/flink/pull/1077#issuecomment-136828049 I changed static port and added assertions for full content --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725885#comment-14725885 ] ASF GitHub Bot commented on FLINK-2125: --- Github user ogokal commented on the pull re

[GitHub] flink pull request: [FLINK-2525]Add configuration support in Storm...

2015-09-01 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1046#discussion_r38456958 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/AbstractStormSpoutWrappe

[jira] [Commented] (FLINK-2525) Add configuration support in Storm-compatibility

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725881#comment-14725881 ] ASF GitHub Bot commented on FLINK-2525: --- Github user mjsax commented on a diff in th

[jira] [Commented] (FLINK-2603) Flink hangs before starting execution

2015-09-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725870#comment-14725870 ] Stephan Ewen commented on FLINK-2603: - You stumbled upon a limitation from our use of

[jira] [Created] (FLINK-2603) Flink hangs before starting execution

2015-09-01 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-2603: - Summary: Flink hangs before starting execution Key: FLINK-2603 URL: https://issues.apache.org/jira/browse/FLINK-2603 Project: Flink Issue Type: Bug Compo

[jira] [Commented] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725674#comment-14725674 ] ASF GitHub Bot commented on FLINK-2030: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-01 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-136791499 Okay. Sure. :) No problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-01 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-136790993 Ah, Sorry for late. Currently, I'm busy. Maybe I need 1-2 days to review. I'll try to review asap. --- If your project is set up for it, you can reply to this email a

[jira] [Commented] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725673#comment-14725673 ] ASF GitHub Bot commented on FLINK-2030: --- Github user chiwanpark commented on the pul

[jira] [Commented] (FLINK-2030) Implement an online histogram with Merging and equalization features

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725664#comment-14725664 ] ASF GitHub Bot commented on FLINK-2030: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-2030][FLINK-2274][core][utils]Histogram...

2015-09-01 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-136789371 @chiwanpark , can you review this again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136782152 @mxm Sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136781645 @kl0u That's fine. We'll be preparing a new milestone release based on the master. I think it makes sense to merge your changes afterwards for the 0.10 release. --- If your

[jira] [Commented] (FLINK-2448) registerCacheFile fails with MultipleProgramsTestbase

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725643#comment-14725643 ] ASF GitHub Bot commented on FLINK-2448: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-2448]Create new Test environments on ge...

2015-09-01 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1031#issuecomment-136780181 Okay. Great. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136775729 Thanks @mxm. Although I don't think I will have time to fix it right now. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136774275 `git merge-base master framesize_fix` should show you the commit the branches diverged. Depending on the outcome, you might have to go back to an earlier version of your chan

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136771159 When I did the latest rebase it was saying that the two branches were ready to be merged. Is there a way to see where they have diverged? --- If your project is set up

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-01 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1084#discussion_r38435351 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-hdfs/pom.xml --- @@ -0,0 +1,107 @@ + + +http://maven.apache.o

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136767221 From the GitHub UI it looks like your pull request branch and the Flink master branch have diverged, i.e. your changes are no longer based on a commit from the master branch.

[jira] [Commented] (FLINK-2583) Add Stream Sink For Rolling HDFS Files

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725605#comment-14725605 ] ASF GitHub Bot commented on FLINK-2583: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-2602) Gelly algorithms obtain new execution environments.

2015-09-01 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725603#comment-14725603 ] Aljoscha Krettek commented on FLINK-2602: - I assigned the issue to you. :D > Gell

[jira] [Updated] (FLINK-2602) Gelly algorithms obtain new execution environments.

2015-09-01 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-2602: Assignee: Martin Junghanns > Gelly algorithms obtain new execution environments. > -

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136765583 Hi @mxm. What do you mean? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136765025 Hi @kl0u. I think something went wrong during rebasing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Commented] (FLINK-2583) Add Stream Sink For Rolling HDFS Files

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725568#comment-14725568 ] ASF GitHub Bot commented on FLINK-2583: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request: [FLINK-2583] Add Stream Sink For Rolling HDFS ...

2015-09-01 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1084 [FLINK-2583] Add Stream Sink For Rolling HDFS Files Note: The rolling sink is not yet integrated with checkpointing/fault-tolerance. You can merge this pull request into a Git repository by runni

[jira] [Updated] (FLINK-1723) Add cross validation for model evaluation

2015-09-01 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis updated FLINK-1723: --- Fix Version/s: 0.10 > Add cross validation for model evaluation >

[jira] [Updated] (FLINK-2260) Have a complete model evaluation and selection framework for FlinkML

2015-09-01 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis updated FLINK-2260: --- Fix Version/s: (was: 0.10) > Have a complete model evaluation and selection framew

[jira] [Updated] (FLINK-2260) Have a complete model evaluation and selection framework for FlinkML

2015-09-01 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis updated FLINK-2260: --- Fix Version/s: 0.10 > Have a complete model evaluation and selection framework for Fli

[jira] [Updated] (FLINK-2186) Rework CSV import to support very wide files

2015-09-01 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis updated FLINK-2186: --- Fix Version/s: (was: 0.10) > Rework CSV import to support very wide files > --

[GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...

2015-09-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1073#issuecomment-136758616 @HuangWHWHW Stephan is talking about something like this instead of the PrintStreamMock: ```java ByteArrayOutputStream baos = new ByteArrayOutputStream(); Pr

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725551#comment-14725551 ] ASF GitHub Bot commented on FLINK-2480: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-09-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-136754340 @HuangWHWHW Thank you for addressing my comments. Could you please squash your commits and force push to this branch again? --- If your project is set up for it, you can rep

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725520#comment-14725520 ] ASF GitHub Bot commented on FLINK-2490: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725469#comment-14725469 ] ASF GitHub Bot commented on FLINK-2490: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-09-01 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/992#issuecomment-136739055 I am not sure why the CI is not retesting this. Can you try to squash your commits into one commit and force-push this branch? This always triggers CI for me.

[jira] [Commented] (FLINK-2602) Gelly algorithms obtain new execution environments.

2015-09-01 Thread Martin Junghanns (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725457#comment-14725457 ] Martin Junghanns commented on FLINK-2602: - I could work on that, good way to scan

[GitHub] flink pull request: [FLINK-1730]Persist operator on Data Sets

2015-09-01 Thread sachingoel0101
GitHub user sachingoel0101 opened a pull request: https://github.com/apache/flink/pull/1083 [FLINK-1730]Persist operator on Data Sets This PR introduces a `persist` operation on `DataSet` which allows persisting the data set in memory, allowing for direct access if this data set is

[jira] [Commented] (FLINK-1730) Add a FlinkTools.persist style method to the Data Set.

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725427#comment-14725427 ] ASF GitHub Bot commented on FLINK-1730: --- GitHub user sachingoel0101 opened a pull re

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-09-01 Thread HuangWHWHW
Github user HuangWHWHW commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r38414236 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java ---

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725336#comment-14725336 ] ASF GitHub Bot commented on FLINK-2490: --- Github user HuangWHWHW commented on a diff

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725331#comment-14725331 ] ASF GitHub Bot commented on FLINK-2536: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-01 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1030#issuecomment-136702507 @StephanEwen Hi, I take changes for your comments but the synchronized (lock) in SocketClientSink.java. Need I change this to Thread.sleep()? --- If your pr

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725308#comment-14725308 ] ASF GitHub Bot commented on FLINK-2480: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...

2015-09-01 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1073#issuecomment-136694516 @StephanEwen Hi, I take changes for all of your comments but this following: "The mock print stream overwrites only one println() function, which makes i

[jira] [Commented] (FLINK-2161) Flink Scala Shell does not support external jars (e.g. Gelly, FlinkML)

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725291#comment-14725291 ] ASF GitHub Bot commented on FLINK-2161: --- Github user nikste commented on the pull re

[GitHub] flink pull request: [FLINK-2161] modified Scala shell start script...

2015-09-01 Thread nikste
Github user nikste commented on the pull request: https://github.com/apache/flink/pull/805#issuecomment-136689479 Could someone please check this, it has been here for a while and I've got some other stuff building on top of this! --- If your project is set up for it, you can reply t

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725280#comment-14725280 ] ASF GitHub Bot commented on FLINK-2536: --- Github user HuangWHWHW commented on a diff

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-01 Thread HuangWHWHW
Github user HuangWHWHW commented on a diff in the pull request: https://github.com/apache/flink/pull/1030#discussion_r38410820 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/sink/SocketClientSink.java --- @@ -73,

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725277#comment-14725277 ] ASF GitHub Bot commented on FLINK-2536: --- Github user HuangWHWHW commented on a diff

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-01 Thread HuangWHWHW
Github user HuangWHWHW commented on a diff in the pull request: https://github.com/apache/flink/pull/1030#discussion_r38410780 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/sink/SocketClientSink.java --- @@ -73,

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725275#comment-14725275 ] ASF GitHub Bot commented on FLINK-2536: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-01 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1030#discussion_r38410693 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/sink/SocketClientSink.java --- @@ -7

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725273#comment-14725273 ] ASF GitHub Bot commented on FLINK-2480: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...

2015-09-01 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1073#issuecomment-136686857 ·The mock print stream overwrites only one println() function, which makes it susceptible to changes in the sink. It is better to use a regular PrintStream that prin

[jira] [Resolved] (FLINK-2590) DataSetUtils.zipWithUniqueID creates duplicate IDs

2015-09-01 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-2590. -- Resolution: Fixed Fixed via ab14f90142fd69426bb695cbdb641f0a5a0c46f7 > DataSetUtils.zipWithUniq

[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725242#comment-14725242 ] ASF GitHub Bot commented on FLINK-2490: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2490][FIX]Remove the retryForever check...

2015-09-01 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/992#discussion_r38409485 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java ---

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725223#comment-14725223 ] ASF GitHub Bot commented on FLINK-2536: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-01 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1030#discussion_r38408757 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/sink/SocketClientSink.java --- @@ -73

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725221#comment-14725221 ] ASF GitHub Bot commented on FLINK-2536: --- Github user StephanEwen commented on a diff

[jira] [Commented] (FLINK-2536) Add a retry for SocketClientSink

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725220#comment-14725220 ] ASF GitHub Bot commented on FLINK-2536: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-01 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1030#discussion_r38408571 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/sink/SocketClientSink.java --- @@ -73

[GitHub] flink pull request: [FLINK-2536][streaming]add a re-connect for so...

2015-09-01 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1030#discussion_r38408542 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/sink/SocketClientSink.java --- @@ -73

[jira] [Commented] (FLINK-2580) HadoopDataOutputStream does not expose enough methods of org.apache.hadoop.fs.FSDataOutputStream

2015-09-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725207#comment-14725207 ] Stephan Ewen commented on FLINK-2580: - I am testing a patch that adds more of the {{hs

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725208#comment-14725208 ] ASF GitHub Bot commented on FLINK-2480: --- Github user HuangWHWHW commented on the pul

[GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...

2015-09-01 Thread HuangWHWHW
Github user HuangWHWHW commented on the pull request: https://github.com/apache/flink/pull/1073#issuecomment-136677416 @StephanEwen Yes, thank you for the comments very much. I`ll take the fix. BTW:There are two PRs of mine that need someone to give some comments: https

[jira] [Commented] (FLINK-2580) HadoopDataOutputStream does not expose enough methods of org.apache.hadoop.fs.FSDataOutputStream

2015-09-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725176#comment-14725176 ] Stephan Ewen commented on FLINK-2580: - I'll add a temporary solution that allows you t

[jira] [Commented] (FLINK-2066) Make delay between execution retries configurable

2015-09-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725169#comment-14725169 ] Stephan Ewen commented on FLINK-2066: - I anything happening here? Someone else is int

[jira] [Commented] (FLINK-2372) Update KafkaSink to use new Producer API

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725164#comment-14725164 ] ASF GitHub Bot commented on FLINK-2372: --- Github user rmetzger commented on the pull

[jira] [Commented] (FLINK-2448) registerCacheFile fails with MultipleProgramsTestbase

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725162#comment-14725162 ] ASF GitHub Bot commented on FLINK-2448: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2448]Create new Test environments on ge...

2015-09-01 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1031#issuecomment-136669559 I think this looks good. Will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] flink pull request: [FLINK-2372] Add new FlinkKafkaProducer

2015-09-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1082#issuecomment-136669637 I updated the PR and rebased to master (which is adding some commits from the future (at least from GitHubs perspective) ) --- If your project is set up for it, you ca

[jira] [Created] (FLINK-2602) Gelly algorithms obtain new execution environments.

2015-09-01 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-2602: --- Summary: Gelly algorithms obtain new execution environments. Key: FLINK-2602 URL: https://issues.apache.org/jira/browse/FLINK-2602 Project: Flink Issue Type: B

[jira] [Resolved] (FLINK-2575) Don't activate hash table bloom filter optimisation by default

2015-09-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-2575. - Resolution: Done Done in ced6a1993815fc61fc0c4b68370d9af76de68c71 > Don't activate hash table blo

[jira] [Closed] (FLINK-2575) Don't activate hash table bloom filter optimisation by default

2015-09-01 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-2575. --- > Don't activate hash table bloom filter optimisation by default > ---

[jira] [Commented] (FLINK-2545) NegativeArraySizeException while creating hash table bloom filters

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725153#comment-14725153 ] ASF GitHub Bot commented on FLINK-2545: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2545] add bucket member count verificat...

2015-09-01 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1067#issuecomment-136667661 Looks good, I'll merge this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-2480) Improving tests coverage for org.apache.flink.streaming.api

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725151#comment-14725151 ] ASF GitHub Bot commented on FLINK-2480: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2480][test]add a test for Print Sink wi...

2015-09-01 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1073#issuecomment-136667496 @HuangWHWHW I think this test and also the class `PrintSinkFunctionTest` needs some more improvement. Here are a few comments: - Exception during

[jira] [Commented] (FLINK-2310) Add an Adamic-Adar Similarity example

2015-09-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725147#comment-14725147 ] ASF GitHub Bot commented on FLINK-2310: --- Github user shghatge commented on the pull

  1   2   >