[
https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144281#comment-15144281
]
ASF GitHub Bot commented on FLINK-2021:
---
Github user fhueske commented on the pull request:
GitHub user mliesenberg opened a pull request:
https://github.com/apache/flink/pull/1628
[FLINK-2444] add tests for HadoopInputFormats
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mliesenberg/flink
GitHub user gyfora opened a pull request:
https://github.com/apache/flink/pull/1627
[WIP] [streaming] OutOfCoreKvState added + major improvements to
DbStateBackend
This PR has 2 main parts:
1. A new abstract class for encapsulating functionality for OutOfCore lazy
states
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144312#comment-15144312
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on the pull request:
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-183251312
Hi, I thought about using POJOs as native types within Table/SQL operators.
IMO, the gains are very little compared to the added code complexity. Given a
POJO input, we
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-183240236
Hi @stefanobaghino, that looks good! Maybe print the usage string (`"Usage:
KMeans --points --centroids --output --iterations "`)
always at the beginning of the
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1553#issuecomment-183230276
@ramkrish86, no worries :-)
I guess the issue description lacked a bit of detail. Flink's optimizer
checks, if the partitioning produced by the explicit partitioning
[
https://issues.apache.org/jira/browse/FLINK-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144274#comment-15144274
]
ASF GitHub Bot commented on FLINK-3179:
---
Github user fhueske commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144405#comment-15144405
]
ASF GitHub Bot commented on FLINK-3187:
---
Github user uce commented on the pull request:
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-183271832
Thank you very much! Behaviour is as I would expect it.
Last minor comment: can you add a comment in the deprecated methods (both
Java and Scala) with a reference
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144480#comment-15144480
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on the pull request:
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-183287252
Ah, OK :-)
I have to admit that I didn't look at the changes in detail but noticed
that they go into several places of the code gen. Hence, I was wondering if it
[
https://issues.apache.org/jira/browse/FLINK-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144495#comment-15144495
]
Martin Liesenberg commented on FLINK-2032:
--
good to know, thanks. I will look into that in the
[
https://issues.apache.org/jira/browse/FLINK-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144452#comment-15144452
]
Robert Metzger commented on FLINK-3260:
---
Is this failure related?
[
https://issues.apache.org/jira/browse/FLINK-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144476#comment-15144476
]
Fabian Hueske commented on FLINK-2032:
--
Yes, this issue is still valid. There are still a few tests
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144489#comment-15144489
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52731697
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/TableEnvironment.scala
---
@@ -75,5 +75,15 @@ class TableEnvironment {
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144558#comment-15144558
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52740335
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -231,29 +252,40 @@ class CodeGenerator(
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/1609
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/1620
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52739425
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -42,13 +42,30 @@ import
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144563#comment-15144563
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144574#comment-15144574
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144401#comment-15144401
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user twalthr commented on the pull request:
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-183268932
Alright, I've reintroduced the old execution attempts and delay
configuration values and the API calls at the `ExecutionEnvironment`.
The behaviour is now
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-183268426
Hi @fhueske,
I completely share your opinion. This PR does exactly what you described.
As you can read in `DataSetSource`: "It ensures that types without
[
https://issues.apache.org/jira/browse/FLINK-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144418#comment-15144418
]
Aljoscha Krettek commented on FLINK-3360:
-
I'm not so sure. The {{StateBackend}} needs to be aware
[
https://issues.apache.org/jira/browse/FLINK-3212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144417#comment-15144417
]
Robert Metzger commented on FLINK-3212:
---
Another case:
[
https://issues.apache.org/jira/browse/FLINK-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144455#comment-15144455
]
Martin Liesenberg commented on FLINK-2032:
--
Is there still work to do here? If so I'd love any
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-183314810
Once this PR has been merged (I expect that some adoptions might still be
required) I can try and see if its straightforward to backport. Are you
planning to stick to
[
https://issues.apache.org/jira/browse/FLINK-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144548#comment-15144548
]
ASF GitHub Bot commented on FLINK-3377:
---
Github user zentol closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144549#comment-15144549
]
ASF GitHub Bot commented on FLINK-3332:
---
Github user zentol closed the pull request at:
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52739054
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -150,7 +151,11 @@ object CodeGenUtils {
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1629
[FLINK-3359] Make RocksDB File Copies Asynchronous
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink state-async-kv
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52739359
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -42,13 +42,30 @@ import
[
https://issues.apache.org/jira/browse/FLINK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144562#comment-15144562
]
ASF GitHub Bot commented on FLINK-3359:
---
GitHub user aljoscha opened a pull request:
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1513#issuecomment-183326898
Any more comments? Ideas? I think we should merge this soon because it
should go into the 1.0 release.
---
If your project is set up for it, you can reply to this
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1470#issuecomment-183272439
Sure, will do. Thanks for the review :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144406#comment-15144406
]
ASF GitHub Bot commented on FLINK-3187:
---
Github user tillrohrmann commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144468#comment-15144468
]
Martin Liesenberg commented on FLINK-2719:
--
[again |
[
https://issues.apache.org/jira/browse/FLINK-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144483#comment-15144483
]
ASF GitHub Bot commented on FLINK-2380:
---
Github user rmetzger commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144484#comment-15144484
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52731336
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/TableEnvironment.scala
---
@@ -75,5 +75,15 @@ class TableEnvironment {
[
https://issues.apache.org/jira/browse/FLINK-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144481#comment-15144481
]
ASF GitHub Bot commented on FLINK-3340:
---
Github user ggevay commented on the pull request:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-183288223
Thank you.
- ` ./bin/yarn-session.sh -tm 1024 -n 7 -s 2 -Dfs.default-scheme=hdfs:///`
is now working
- Setting the fs.default-scheme to `thisIsWrong` and
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1629#issuecomment-183325582
@uce This also moves the determination of the state size in
`StreamTaskStateList` from the constructor to the method `getSize()`. I had to
do this because the size of
[
https://issues.apache.org/jira/browse/FLINK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144567#comment-15144567
]
ASF GitHub Bot commented on FLINK-3359:
---
Github user aljoscha commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144564#comment-15144564
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144402#comment-15144402
]
ASF GitHub Bot commented on FLINK-3187:
---
Github user tillrohrmann commented on the pull request:
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183287868
So, if I understand correctly, this is aiming to fix the problem that was
brought up by [1], but in a different way then proposed there.
I still have the same
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1628#issuecomment-183291368
3 builds failed:
- one due to [FLINK-2719](https://issues.apache.org/jira/browse/FLINK-2719)
[
https://issues.apache.org/jira/browse/FLINK-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144493#comment-15144493
]
ASF GitHub Bot commented on FLINK-2444:
---
Github user mliesenberg commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144544#comment-15144544
]
ASF GitHub Bot commented on FLINK-3368:
---
Github user rmetzger commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144571#comment-15144571
]
ASF GitHub Bot commented on FLINK-3243:
---
Github user aljoscha commented on the pull request:
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-183330257
Thanks for the comment @rmetzger. I changed the error message. Please
review and let me know.
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/FLINK-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144576#comment-15144576
]
ASF GitHub Bot commented on FLINK-2380:
---
Github user kl0u commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Trevor Grant reassigned FLINK-2259:
---
Assignee: Trevor Grant
> Support training Estimators using a (train, validation, test) split
[
https://issues.apache.org/jira/browse/FLINK-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-3270.
---
Resolution: Fixed
Fix Version/s: 1.0.0
Resolved in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52744266
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -749,4 +867,23 @@ class CodeGenerator(
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144611#comment-15144611
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144609#comment-15144609
]
ASF GitHub Bot commented on FLINK-3270:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144619#comment-15144619
]
ASF GitHub Bot commented on FLINK-3340:
---
Github user greghogan commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan updated FLINK-3393:
--
Component/s: Core
> ExternalProcessRunner wait to finish copying error stream
>
[
https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144606#comment-15144606
]
Trevor Grant commented on FLINK-2259:
-
In the spirit of sci-kit, and just data stuff in general:
The
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1624#issuecomment-183349741
Thanks @twalthr, the PR looks pretty good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144622#comment-15144622
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144584#comment-15144584
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144585#comment-15144585
]
ASF GitHub Bot commented on FLINK-3367:
---
Github user rmetzger commented on the pull request:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1606#issuecomment-183332749
Except for two questions, the PR looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183348625
Hi, @ggevay, these fixes to the reduce drivers are independent of changes
to `MutableObjectIterator`. This patch is intended to fix the bug you reported
in
[
https://issues.apache.org/jira/browse/FLINK-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144642#comment-15144642
]
ASF GitHub Bot commented on FLINK-3296:
---
Github user rmetzger commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144654#comment-15144654
]
Stephan Ewen edited comment on FLINK-3291 at 2/12/16 2:51 PM:
--
Thanks,
[
https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144654#comment-15144654
]
Stephan Ewen commented on FLINK-3291:
-
Thanks, @Greg and [~ggevay] for looking into this. It's good
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1624#discussion_r52741150
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -150,7 +151,11 @@ object CodeGenUtils {
Greg Hogan created FLINK-3393:
-
Summary: ExternalProcessRunner wait to finish copying error stream
Key: FLINK-3393
URL: https://issues.apache.org/jira/browse/FLINK-3393
Project: Flink
Issue
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1533
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144579#comment-15144579
]
Trevor Grant commented on FLINK-2259:
-
I need this functionality now, and I'm fairly certain I can
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1563#issuecomment-183356403
Thank you for the review. I've addressed the comments and rebased the
change.
Once travis has passed, I'll merge it!
---
If your project is set up for it,
[
https://issues.apache.org/jira/browse/FLINK-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144311#comment-15144311
]
ASF GitHub Bot commented on FLINK-2444:
---
GitHub user mliesenberg opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144847#comment-15144847
]
ASF GitHub Bot commented on FLINK-3352:
---
GitHub user aljoscha opened a pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1631#issuecomment-183414679
Does it make sense to write the config once in the
`RocksDBStateBackend.initializeForJob()` rather than in every state?
---
If your project is set up for it, you
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1631#issuecomment-183414734
Otherwise, looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1563#issuecomment-183414977
I think the `writeOutputFormat` method name could be misleading. To me it
implies writing the `OutputFormat` not writing something by using the
`OutputFormat`.
---
[
https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144866#comment-15144866
]
ASF GitHub Bot commented on FLINK-3352:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144906#comment-15144906
]
ASF GitHub Bot commented on FLINK-3368:
---
Github user ndimiduk commented on the pull request:
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1631#issuecomment-183422654
The two jobs have separate directories, so the would not interfere, correct?
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144815#comment-15144815
]
Stephan Ewen commented on FLINK-3291:
-
What I quoted there was the initial contract. It may actually
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1631
[FLINK-3352] Use HDFS Config in RocksDB Copy Utilities
This also moves the utilities (HDFSCopyFromLocal and HDFSCopyToLocal) to
the RocksDB package because we would need a HDFS dependency in
[
https://issues.apache.org/jira/browse/FLINK-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144868#comment-15144868
]
ASF GitHub Bot commented on FLINK-3296:
---
Github user aljoscha commented on the pull request:
Github user ndimiduk commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-183421908
My timeline for adopting Flink 1.0 depends heavily on the amount of code
change required to adopt. I haven't looked closely at my exposure to API
and dependency
[
https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144911#comment-15144911
]
ASF GitHub Bot commented on FLINK-3352:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144865#comment-15144865
]
ASF GitHub Bot commented on FLINK-3352:
---
Github user StephanEwen commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144884#comment-15144884
]
ASF GitHub Bot commented on FLINK-3352:
---
Github user aljoscha commented on the pull request:
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1631#issuecomment-183418609
We could write it only once, but is it worth it? It would require piping
another parameter through all the rocksdb related classes and I would assume
there is only one
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183375884
Sorry, but I don't think it is independent, because the bug in the reduce
drivers could alternatively be fixed by saying that the bug is actually not in
the reduce
[
https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144732#comment-15144732
]
Greg Hogan edited comment on FLINK-3291 at 2/12/16 3:48 PM:
I started looking
[
https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144732#comment-15144732
]
Greg Hogan commented on FLINK-3291:
---
I started looking at `MergeIterator` last year since I had object
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-183389629
Let us squash them, once we merge the PR. Otherwise changes are hard to
track.
---
If your project is set up for it, you can reply to this email and have your
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1626#issuecomment-183389185
`MergeIterator.next(reuse)` should allow object swapping. The source code
documentation should be improved to make this clearer, but this contract is
necessary to
1 - 100 of 149 matches
Mail list logo
