[GitHub] flink pull request: FLINK-3327: ExecutionConfig to JobGraph.

2016-03-11 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1583#issuecomment-195605736 Thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: FLINK-3327: ExecutionConfig to JobGraph.

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1583 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3327) Attach the ExecutionConfig to the JobGraph and make it accessible to the AbstractInvocable.

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191474#comment-15191474 ] ASF GitHub Bot commented on FLINK-3327: --- Github user zentol commented on the pull request:

[GitHub] flink pull request: FLINK-3327: ExecutionConfig to JobGraph.

2016-03-11 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1583#issuecomment-195540338 merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-1932) Add L-BFGS to the optimization framework

2016-03-11 Thread Soila Kavulya (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191404#comment-15191404 ] Soila Kavulya commented on FLINK-1932: -- Hi [~tvas]. I can pick it up. What things did you have in

[jira] [Commented] (FLINK-3109) Join two streams with two different buffer time

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191368#comment-15191368 ] ASF GitHub Bot commented on FLINK-3109: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3109]Join two streams with two differen...

2016-03-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1527#issuecomment-195495184 I just saw that you updated this pull request (actually a few weeks ago already) A lot of it looks very good, some things we need to check a bit deeper

[jira] [Commented] (FLINK-3467) Remove superfluous objects from DataSourceTask.invoke

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191350#comment-15191350 ] ASF GitHub Bot commented on FLINK-3467: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191349#comment-15191349 ] ASF GitHub Bot commented on FLINK-1159: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3467] Remove superfluous objects from D...

2016-03-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1691#issuecomment-195491683 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-03-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1704#issuecomment-195491606 This pull request adds a lot of tests (which is actually good), but all tests fire up a cluster to execute many programs. But need to somehow get this down, as

[jira] [Commented] (FLINK-3595) Kafka09 consumer thread does not interrupt when stuck in record emission

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191347#comment-15191347 ] ASF GitHub Bot commented on FLINK-3595: --- Github user uce commented on the pull request:

[GitHub] flink pull request: [FLINK-3595] [runtime] Eagerly destroy buffer ...

2016-03-11 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1780#issuecomment-195491044 Regarding the stack trace of the Kafka test: the log shows two failures. - The stack trace you posted is part of a test time out (that's why you have the interruption of

[jira] [Commented] (FLINK-3519) Subclasses of Tuples don't work if the declared type of a DataSet is not the descendant

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191343#comment-15191343 ] ASF GitHub Bot commented on FLINK-3519: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3519] [core] Add warning about subclass...

2016-03-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1724#issuecomment-195490545 What kind of exception do you get? Also, subclasses of tuples that do not have additional fields can need not be Pojos (even though Tuples by themselves

[GitHub] flink pull request: FLINK-3428: Adds a fixed time trailing waterma...

2016-03-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1764#issuecomment-195489648 I think this is a useful tool. Few comments, though: - You can still have a negative underflow (wrap around, positive) in the watermark generation.

[jira] [Commented] (FLINK-3428) Add fixed time trailing timestamp/watermark extractor

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191338#comment-15191338 ] ASF GitHub Bot commented on FLINK-3428: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3472] Better exception if jdbc field is...

2016-03-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1772#issuecomment-195485790 Good addition, merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-3472) JDBCInputFormat.nextRecord(..) has misleading message on NPE

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191321#comment-15191321 ] ASF GitHub Bot commented on FLINK-3472: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3590) JDBC Format tests don't hide derby logs

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191318#comment-15191318 ] ASF GitHub Bot commented on FLINK-3590: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3590] Hide derby log in JDBC tests

2016-03-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1773#issuecomment-195484645 Looks good, merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-3595) Kafka09 consumer thread does not interrupt when stuck in record emission

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191316#comment-15191316 ] ASF GitHub Bot commented on FLINK-3595: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3595] [runtime] Eagerly destroy buffer ...

2016-03-11 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1780#issuecomment-195483345 Test failures - CheckpointNotifierITCase (2x) - known instability - Kafka08 test This seems to be the relevant failure ``` 03/11/2016

[jira] [Commented] (FLINK-3595) Kafka09 consumer thread does not interrupt when stuck in record emission

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191312#comment-15191312 ] ASF GitHub Bot commented on FLINK-3595: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3595] [runtime] Eagerly destroy buffer ...

2016-03-11 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1780#discussion_r55864951 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerTest.java --- @@ -0,0 +1,309 @@ +/* +

[jira] [Commented] (FLINK-3207) Add a Pregel iteration abstraction to Gelly

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191288#comment-15191288 ] ASF GitHub Bot commented on FLINK-3207: --- Github user vasia commented on the pull request:

[GitHub] flink pull request: [FLINK-3207] [gelly] adds the vertex-centric i...

2016-03-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1575#issuecomment-195477642 Anyone else wants to take a look at this PR or shall I go ahead and merge? --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-3579) Improve String concatenation

2016-03-11 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191247#comment-15191247 ] ramkrishna.s.vasudevan commented on FLINK-3579: --- Ping [~twalthr]. > Improve String

[jira] [Assigned] (FLINK-3602) Recursive Types are not supported / crash TypeExtractor

2016-03-11 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-3602: --- Assignee: Timo Walther > Recursive Types are not supported / crash TypeExtractor >

[jira] [Commented] (FLINK-3602) Recursive Types are not supported / crash TypeExtractor

2016-03-11 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191069#comment-15191069 ] Timo Walther commented on FLINK-3602: - I will look into this issue... > Recursive Types are not

[GitHub] flink pull request: [streaming] Fast calculation of medians of win...

2016-03-11 Thread ggevay
Github user ggevay commented on the pull request: https://github.com/apache/flink/pull/684#issuecomment-195402038 This is dead. Everything has totally changed that this was based on. The fundamental problem is that this is based on the assumption of the old 0.9 windowing code that

[GitHub] flink pull request: [streaming] Fast calculation of medians of win...

2016-03-11 Thread ggevay
Github user ggevay closed the pull request at: https://github.com/apache/flink/pull/684 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3607) Decrease default forkCount for tests

2016-03-11 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191031#comment-15191031 ] Maximilian Michels commented on FLINK-3607: --- Sure, you can set {{-Dflik.forkCount=1C}} but I

[jira] [Commented] (FLINK-1984) Integrate Flink with Apache Mesos

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191027#comment-15191027 ] ASF GitHub Bot commented on FLINK-1984: --- Github user uce commented on the pull request:

[GitHub] flink pull request: [FLINK-1984] Integrate Flink with Apache Mesos

2016-03-11 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/948#issuecomment-195398349 With the recently introduced changes to the resource management in order to better be in line with Mesos' model, I think we can close this PR. Sorry! --- If your project

[GitHub] flink pull request: Enable and fix ignored Table API tests

2016-03-11 Thread fhueske
Github user fhueske closed the pull request at: https://github.com/apache/flink/pull/1782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3607) Decrease default forkCount for tests

2016-03-11 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191019#comment-15191019 ] Robert Metzger commented on FLINK-3607: --- I think you can pass a custom fork count using maven

[GitHub] flink pull request: Enable and fix ignored Table API tests

2016-03-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1782#issuecomment-195396056 Merged. You can close it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [streaming] Fast calculation of medians of win...

2016-03-11 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/684#issuecomment-195395736 Is this still a relevant PR with all the changes to the runtime in recent months? If not, can we close this? --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: Netcat arguments for Mac OS X

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1781 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191007#comment-15191007 ] ASF GitHub Bot commented on FLINK-3544: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1741#issuecomment-195393237 I didn't test the change on a physical, real distributed cluster. Only on a virtual machine from cloudera. We should test the code on a real setup as well before

[jira] [Commented] (FLINK-1932) Add L-BFGS to the optimization framework

2016-03-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191004#comment-15191004 ] Fabian Hueske commented on FLINK-1932: -- Hi, just in case you copy code from Spark to Flink, please

[jira] [Comment Edited] (FLINK-1932) Add L-BFGS to the optimization framework

2016-03-11 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190999#comment-15190999 ] Theodore Vasiloudis edited comment on FLINK-1932 at 3/11/16 2:37 PM: -

[jira] [Commented] (FLINK-1932) Add L-BFGS to the optimization framework

2016-03-11 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190999#comment-15190999 ] Theodore Vasiloudis commented on FLINK-1932: Hello [~spkavulya], thanks that sounds great.

[GitHub] flink pull request: Netcat arguments for Mac OS X

2016-03-11 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1781#issuecomment-195391861 Going to merge w/o the distinction between Linux and OS X. Thanks for noticing this. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: Enable and fix ignored Table API tests

2016-03-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1782#issuecomment-195390029 Yes, on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-3333) Documentation about object reuse should be improved

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190973#comment-15190973 ] ASF GitHub Bot commented on FLINK-: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3333] [Documentation][DataSet] Improve ...

2016-03-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1721#issuecomment-195383343 Any objections to merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190967#comment-15190967 ] ASF GitHub Bot commented on FLINK-3544: --- Github user mxm commented on the pull request:

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1741#issuecomment-195382194 Thank you for checking out the PR @rmetzger! Great to see it working in a cluster environment with Task Manager failures. I didn't add anything to the documentation (apart

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190962#comment-15190962 ] ASF GitHub Bot commented on FLINK-3544: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190953#comment-15190953 ] ASF GitHub Bot commented on FLINK-3544: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55832478 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190950#comment-15190950 ] ASF GitHub Bot commented on FLINK-3544: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request: Enable and fix ignored Table API tests

2016-03-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1782#issuecomment-195377212 Changes look good to me! I only found 2 unused imports, but I can remove them before merging :) --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55831803 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -240,6 +246,37 @@ */ public static final String

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190949#comment-15190949 ] ASF GitHub Bot commented on FLINK-3544: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55831616 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -682,27 +729,27 @@ */ public static final int

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55831570 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java --- @@ -0,0 +1,344 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190946#comment-15190946 ] ASF GitHub Bot commented on FLINK-3544: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55831451 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala --- @@ -366,6 +428,28 @@ abstract class FlinkMiniCluster(

[jira] [Commented] (FLINK-3398) Flink Kafka consumer should support auto-commit opt-outs

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190944#comment-15190944 ] ASF GitHub Bot commented on FLINK-3398: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: FLINK-3398: Allow for opting-out from Kafka of...

2016-03-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1690#issuecomment-195374583 Thank you for working on this. I've been very busy with the 1.0 release, vacation and some talks, but now I'm back for my regular work. I try to review the PR today

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190942#comment-15190942 ] ASF GitHub Bot commented on FLINK-3544: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1741#issuecomment-195374162 Overall, the change looks good. I'm happy to see that the YARN tests haven't been touched much. As long as these tests are present, most of the features users need

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190922#comment-15190922 ] ASF GitHub Bot commented on FLINK-3544: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1741#issuecomment-195362473 I tested the change on a secured CDH 5.3 setup and it worked, also across TaskManager failures: ``` 2016-03-11 05:27:34,732 INFO

[GitHub] flink pull request: Enable Table API explain and add descriptive o...

2016-03-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1783#issuecomment-195361515 Tests are failing. I'll update the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Created] (FLINK-3609) Revisit selection of Calcite rules

2016-03-11 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-3609: Summary: Revisit selection of Calcite rules Key: FLINK-3609 URL: https://issues.apache.org/jira/browse/FLINK-3609 Project: Flink Issue Type: Task

[GitHub] flink pull request: [build] Consolidate scala checkstyle usage and...

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1753 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: Enable Table API explain and add descriptive o...

2016-03-11 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/1783 Enable Table API explain and add descriptive operator names Both issues are related so I put the fixes in one PR. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190824#comment-15190824 ] ASF GitHub Bot commented on FLINK-3544: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: Enable and fix ignored Table API tests

2016-03-11 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/1782 Enable and fix ignored Table API tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/fhueske/flink tableTests Alternatively you can review

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1741#issuecomment-195332293 I tried finding updates to the documentation, but I couldn't find any (maybe its because of the PR size). We should at least add the new configuration parameters.

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190812#comment-15190812 ] ASF GitHub Bot commented on FLINK-3544: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55817803 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala --- @@ -366,6 +428,28 @@ abstract class

[jira] [Commented] (FLINK-3608) ImmutableSettings error in ElasticsearchSink

2016-03-11 Thread Carlos Gonzalez de Zarate (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190810#comment-15190810 ] Carlos Gonzalez de Zarate commented on FLINK-3608: -- I'm using the transport client >

[jira] [Created] (FLINK-3608) ImmutableSettings error in ElasticsearchSink

2016-03-11 Thread Carlos Gonzalez de Zarate (JIRA)
Carlos Gonzalez de Zarate created FLINK-3608: Summary: ImmutableSettings error in ElasticsearchSink Key: FLINK-3608 URL: https://issues.apache.org/jira/browse/FLINK-3608 Project: Flink

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190802#comment-15190802 ] ASF GitHub Bot commented on FLINK-3544: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55816596 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java --- @@ -0,0 +1,344 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190795#comment-15190795 ] ASF GitHub Bot commented on FLINK-3544: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55816122 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -682,27 +729,27 @@ */ public static final int

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190793#comment-15190793 ] ASF GitHub Bot commented on FLINK-3544: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190790#comment-15190790 ] ASF GitHub Bot commented on FLINK-3544: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1741#discussion_r55815961 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -240,6 +246,37 @@ */ public static final

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1741#issuecomment-195317257 I'll review the PR now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Created] (FLINK-3607) Decrease default forkCount for tests

2016-03-11 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3607: - Summary: Decrease default forkCount for tests Key: FLINK-3607 URL: https://issues.apache.org/jira/browse/FLINK-3607 Project: Flink Issue Type:

[jira] [Commented] (FLINK-3547) Add support for streaming projection, selection, and union

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190740#comment-15190740 ] ASF GitHub Bot commented on FLINK-3547: --- Github user vasia commented on the pull request:

[GitHub] flink pull request: [FLINK-3547] add support for streaming filter,...

2016-03-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1770#issuecomment-195302939 Rebased on current `tableOnCalcite`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Created] (FLINK-3606) Expose Configuration from RichFunctions

2016-03-11 Thread JIRA
Márton Balassi created FLINK-3606: - Summary: Expose Configuration from RichFunctions Key: FLINK-3606 URL: https://issues.apache.org/jira/browse/FLINK-3606 Project: Flink Issue Type:

[jira] [Assigned] (FLINK-2732) Add access to the TaskManagers' log file and out file in the web dashboard.

2016-03-11 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-2732: --- Assignee: Chesnay Schepler > Add access to the TaskManagers' log file and out file

[jira] [Commented] (FLINK-3579) Improve String concatenation

2016-03-11 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190715#comment-15190715 ] ramkrishna.s.vasudevan commented on FLINK-3579: --- When we have f0 (VARCHAR) and f1(INTEGER),

[jira] [Commented] (FLINK-3489) Refactor Table API before merging into master

2016-03-11 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190716#comment-15190716 ] Vasia Kalavri commented on FLINK-3489: -- [~twalthr] have you started working on this or can I pick it

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-03-11 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1704#issuecomment-195290267 @tillrohrmann The tests failure seem to be flaky, I've re-run them all on our fork and they're all green now (after a couple of retries). --- If your project is

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190712#comment-15190712 ] ASF GitHub Bot commented on FLINK-1159: --- Github user stefanobaghino commented on the pull request:

[GitHub] flink pull request: [FLINK-3569] fix test cases that expect a diff...

2016-03-11 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1767#issuecomment-195282751 Sure. Thanks for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-3569) Test cases fail due to Maven Shade plugin

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190691#comment-15190691 ] ASF GitHub Bot commented on FLINK-3569: --- Github user mxm closed the pull request at:

[jira] [Commented] (FLINK-3569) Test cases fail due to Maven Shade plugin

2016-03-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190690#comment-15190690 ] ASF GitHub Bot commented on FLINK-3569: --- Github user mxm commented on the pull request:

[GitHub] flink pull request: [FLINK-3569] fix test cases that expect a diff...

2016-03-11 Thread mxm
Github user mxm closed the pull request at: https://github.com/apache/flink/pull/1767 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   >