[jira] [Commented] (FLINK-2445) Add tests for HadoopOutputFormats

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210737#comment-15210737 ] ASF GitHub Bot commented on FLINK-2445: --- Github user mliesenberg closed the pull request at:

[GitHub] flink pull request: [FLINK-2445] Add tests for HadoopOutputFormats

2016-03-24 Thread mliesenberg
Github user mliesenberg closed the pull request at: https://github.com/apache/flink/pull/1625 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-2445) Add tests for HadoopOutputFormats

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210724#comment-15210724 ] ASF GitHub Bot commented on FLINK-2445: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-2445] Add tests for HadoopOutputFormats

2016-03-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1625#issuecomment-200961463 Hi @mliesenberg, I merged this PR but it wasn't correctly closed. Can you do it? Thanks --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200951040 Thanks for describing this. This has quite some big implications, as far as I can see it. The state in the connected stream is now a "broadcast state" not

[jira] [Commented] (FLINK-3659) Allow ConnectedStreams to Be Keyed on Only One Side

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210655#comment-15210655 ] ASF GitHub Bot commented on FLINK-3659: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3659) Allow ConnectedStreams to Be Keyed on Only One Side

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210628#comment-15210628 ] ASF GitHub Bot commented on FLINK-3659: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200945681 I like @aljoscha's idea to separate more explicitly the user state access and it's implementation. Having an accessor would also allow us to get rid of the

[jira] [Commented] (FLINK-3547) Add support for streaming projection, selection, and union

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210612#comment-15210612 ] ASF GitHub Bot commented on FLINK-3547: --- Github user vasia commented on the pull request:

[GitHub] flink pull request: [FLINK-3547] add support for streaming filter,...

2016-03-24 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1820#issuecomment-200942437 I've rebased on master and will merge once travis turns green :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-3667) Generalize client<->cluster communication

2016-03-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210591#comment-15210591 ] Till Rohrmann commented on FLINK-3667: -- Sounds like a good idea. +1 :-) > Generalize

[jira] [Commented] (FLINK-3659) Allow ConnectedStreams to Be Keyed on Only One Side

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210586#comment-15210586 ] ASF GitHub Bot commented on FLINK-3659: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200933436 To elaborate on this. State right now works well if you stick to the (admittedly somewhat hidden) rules. That is, you should only access state if there is a key

[jira] [Resolved] (FLINK-3639) Add methods and utilities to register DataSets and Tables in the TableEnvironment

2016-03-24 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3639. -- Resolution: Implemented Fix Version/s: 1.1.0 > Add methods and utilities to register

[jira] [Commented] (FLINK-3639) Add methods and utilities to register DataSets and Tables in the TableEnvironment

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210528#comment-15210528 ] ASF GitHub Bot commented on FLINK-3639: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3639] add methods for registering datas...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1827 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3257) Add Exactly-Once Processing Guarantees in Iterative DataStream Jobs

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210494#comment-15210494 ] ASF GitHub Bot commented on FLINK-3257: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3257] Add Exactly-Once Processing Guara...

2016-03-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1668#issuecomment-200909639 The core idea of this is very good, also the illustration is very nice. After an offline chat with @senorcarbone, we concluded that a remaining problem in

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200907475 @StephanEwen This PR does not change the behaviour of any existing Flink applications. It now allows though that users only specify key of one input of

[jira] [Commented] (FLINK-3659) Allow ConnectedStreams to Be Keyed on Only One Side

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210480#comment-15210480 ] ASF GitHub Bot commented on FLINK-3659: --- Github user gyfora commented on the pull request:

[jira] [Commented] (FLINK-3659) Allow ConnectedStreams to Be Keyed on Only One Side

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210412#comment-15210412 ] ASF GitHub Bot commented on FLINK-3659: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-3664) Create a method to easily Summarize a DataSet

2016-03-24 Thread Todd Lisonbee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210409#comment-15210409 ] Todd Lisonbee commented on FLINK-3664: -- Hi Fabian, thanks for the feedback. Your first 3 comments

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200887743 Can someone elaborate on the semantics? I am against merging something that changes semantics and has zero description. --- If your project is set up for

[jira] [Commented] (FLINK-3659) Allow ConnectedStreams to Be Keyed on Only One Side

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210406#comment-15210406 ] ASF GitHub Bot commented on FLINK-3659: --- Github user gyfora commented on the pull request:

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread gyfora
Github user gyfora commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200886203 I think you can go ahead merging this if no-one has any objections :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-200888107 For example, how does keyed state work for the input side that is not key partitioned? How is the key found? How is partitioning guaranteed? --- If your project is

[jira] [Commented] (FLINK-3659) Allow ConnectedStreams to Be Keyed on Only One Side

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210413#comment-15210413 ] ASF GitHub Bot commented on FLINK-3659: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3257] Add Exactly-Once Processing Guara...

2016-03-24 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1668#discussion_r57327419 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamIterationHead.java --- @@ -17,43 +17,80 @@ package

[jira] [Commented] (FLINK-3613) Add standard deviation, mean, variance to list of Aggregations

2016-03-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210344#comment-15210344 ] Fabian Hueske commented on FLINK-3613: -- Hi [~tlisonbee], thanks for the detailed design doc! I'll

[jira] [Commented] (FLINK-3664) Create a method to easily Summarize a DataSet

2016-03-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210343#comment-15210343 ] Fabian Hueske commented on FLINK-3664: -- Hi [~tlisonbee], I like this proposal a lot. It would be a

[jira] [Commented] (FLINK-3257) Add Exactly-Once Processing Guarantees in Iterative DataStream Jobs

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210328#comment-15210328 ] ASF GitHub Bot commented on FLINK-3257: --- Github user uce commented on a diff in the pull request:

[jira] [Created] (FLINK-3667) Generalize client<->cluster communication

2016-03-24 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3667: - Summary: Generalize client<->cluster communication Key: FLINK-3667 URL: https://issues.apache.org/jira/browse/FLINK-3667 Project: Flink Issue

[jira] [Commented] (FLINK-3633) Job submission silently fails when using user code types

2016-03-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210320#comment-15210320 ] Till Rohrmann commented on FLINK-3633: -- Yes that should work. Will try to update the PR. Thanks for

[GitHub] flink pull request: [FLINK-3639] add methods for registering datas...

2016-03-24 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1827#issuecomment-200864343 Merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-3651) Fix faulty RollingSink Restore

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210309#comment-15210309 ] ASF GitHub Bot commented on FLINK-3651: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3651] Fix faulty RollingSink Restore

2016-03-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1830#issuecomment-200863307 Yes, what @rmetzger said is correct. Without the fix and the increase of parallelism it will be a flaky test that still succeeds sometimes. --- If your project is

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210282#comment-15210282 ] ASF GitHub Bot commented on FLINK-1745: --- Github user danielblazevski commented on the pull request:

[GitHub] flink pull request: [FLINK-1745] Add exact k-nearest-neighbours al...

2016-03-24 Thread danielblazevski
Github user danielblazevski commented on the pull request: https://github.com/apache/flink/pull/1220#issuecomment-200854252 @tillrohrmann @chiwanpark done, polished up KNN.scala and some minor changes -- e.g. expanding the description of the parameters in the beginning of KNN.scala.

[jira] [Commented] (FLINK-3257) Add Exactly-Once Processing Guarantees in Iterative DataStream Jobs

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210279#comment-15210279 ] ASF GitHub Bot commented on FLINK-3257: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3257] Add Exactly-Once Processing Guara...

2016-03-24 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1668#discussion_r57321347 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java --- @@ -450,112 +450,121 @@ else if (operator != null) {

[jira] [Created] (FLINK-3666) Remove Nephele references

2016-03-24 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-3666: --- Summary: Remove Nephele references Key: FLINK-3666 URL: https://issues.apache.org/jira/browse/FLINK-3666 Project: Flink Issue Type: Improvement

[GitHub] flink pull request: [FLINK-3257] Add Exactly-Once Processing Guara...

2016-03-24 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1668#discussion_r57320231 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java --- @@ -450,112 +450,121 @@ else if (operator != null) {

[jira] [Commented] (FLINK-3257) Add Exactly-Once Processing Guarantees in Iterative DataStream Jobs

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210270#comment-15210270 ] ASF GitHub Bot commented on FLINK-3257: --- Github user uce commented on a diff in the pull request:

[jira] [Commented] (FLINK-3257) Add Exactly-Once Processing Guarantees in Iterative DataStream Jobs

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210263#comment-15210263 ] ASF GitHub Bot commented on FLINK-3257: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3257] Add Exactly-Once Processing Guara...

2016-03-24 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1668#discussion_r57319737 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java --- @@ -450,112 +450,121 @@ else if (operator != null) {

[jira] [Commented] (FLINK-3657) Change access of DataSetUtils.countElements() to 'public'

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210261#comment-15210261 ] ASF GitHub Bot commented on FLINK-3657: --- Github user smarthi commented on the pull request:

[GitHub] flink pull request: FLINK-3657: Change access of DataSetUtils.coun...

2016-03-24 Thread smarthi
Github user smarthi commented on the pull request: https://github.com/apache/flink/pull/1829#issuecomment-200848523 @uce @fhueske to add more context to this PR, we r in the final stretch of a planned 0.12.0 Mahout release that adds Flink as a distributed engine for Samsara linear

[GitHub] flink pull request: [FLINK-3633] Fix user code de/serialization in...

2016-03-24 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1818#issuecomment-200830880 The other programs that are executed in `ClassLoaderITCase` are contained in the `org.apache.flink.test.classloading.jar` package (search for `KMeansForTest` for example).

[jira] [Commented] (FLINK-3633) Job submission silently fails when using user code types

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210201#comment-15210201 ] ASF GitHub Bot commented on FLINK-3633: --- Github user uce commented on the pull request:

[jira] [Commented] (FLINK-3633) Job submission silently fails when using user code types

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210180#comment-15210180 ] ASF GitHub Bot commented on FLINK-3633: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-3633] Fix user code de/serialization in...

2016-03-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1818#issuecomment-200821794 I agree that having a dedicated class loading test would be nicer. However, we would need to build a jar containing the test job before executing the test, right?

[jira] [Closed] (FLINK-2935) Allow scala shell to read yarn properties

2016-03-24 Thread Chiwan Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chiwan Park closed FLINK-2935. -- Resolution: Implemented Fix Version/s: 1.1.0 Implemented via

[jira] [Commented] (FLINK-2935) Allow scala shell to read yarn properties

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210165#comment-15210165 ] ASF GitHub Bot commented on FLINK-2935: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-2935] [scala-shell] Allow Scala shell t...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-2935) Allow scala shell to read yarn properties

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210134#comment-15210134 ] ASF GitHub Bot commented on FLINK-2935: --- Github user chiwanpark commented on the pull request:

[jira] [Commented] (FLINK-3657) Change access of DataSetUtils.countElements() to 'public'

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210133#comment-15210133 ] ASF GitHub Bot commented on FLINK-3657: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-2935] [scala-shell] Allow Scala shell t...

2016-03-24 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1500#issuecomment-200804302 Oh, thanks for pointing it @mxm. Then I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: FLINK-3657: Change access of DataSetUtils.coun...

2016-03-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1829#issuecomment-200804264 @uce, API stability is not an issue. The method was `private` before and part of the accessible API. IMO, the question is rather whether we want to add new features in

[jira] [Commented] (FLINK-3639) Add methods and utilities to register DataSets and Tables in the TableEnvironment

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210129#comment-15210129 ] ASF GitHub Bot commented on FLINK-3639: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-3639] add methods for registering datas...

2016-03-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1827#issuecomment-200803230 Changes look good! +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: FLINK-3657: Change access of DataSetUtils.coun...

2016-03-24 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1829#issuecomment-200803091 As a side note (I didn't look at the code changes): We can't rename the method name for `1.0.1` as `DataSetUtils` is annotated with `PublicEvolving`, meaning that we are

[jira] [Commented] (FLINK-3657) Change access of DataSetUtils.countElements() to 'public'

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210127#comment-15210127 ] ASF GitHub Bot commented on FLINK-3657: --- Github user uce commented on the pull request:

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1741#issuecomment-200803051 Continuing my review now, but don't block this on me. If I find anything crucial, I will open a pull request against master if it is merged by then.. --- If your

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210126#comment-15210126 ] ASF GitHub Bot commented on FLINK-3544: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3547] add support for streaming filter,...

2016-03-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1820#issuecomment-200802410 Thanks for the update! +1 to merge :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-3547) Add support for streaming projection, selection, and union

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210123#comment-15210123 ] ASF GitHub Bot commented on FLINK-3547: --- Github user fhueske commented on the pull request:

[jira] [Commented] (FLINK-3633) Job submission silently fails when using user code types

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210119#comment-15210119 ] ASF GitHub Bot commented on FLINK-3633: --- Github user uce commented on the pull request:

[GitHub] flink pull request: [FLINK-3633] Fix user code de/serialization in...

2016-03-24 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1818#issuecomment-200802077 The changes look good and make parts where user code is serialized very clear. :+1: I've verified that the `ScalaShellITCase` with the change in this PR fails for

[jira] [Commented] (FLINK-2946) Add orderBy() to Table API

2016-03-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210118#comment-15210118 ] Fabian Hueske commented on FLINK-2946: -- Hi [~dawidwys], thanks a lot for working on this issue! I had

[jira] [Created] (FLINK-3665) Range partitioning lacks support to define sort orders

2016-03-24 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-3665: Summary: Range partitioning lacks support to define sort orders Key: FLINK-3665 URL: https://issues.apache.org/jira/browse/FLINK-3665 Project: Flink Issue

[jira] [Updated] (FLINK-2821) Change Akka configuration to allow accessing actors from different URLs

2016-03-24 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-2821: -- Fix Version/s: 1.1.0 > Change Akka configuration to allow accessing actors from

[jira] [Commented] (FLINK-3651) Fix faulty RollingSink Restore

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210100#comment-15210100 ] ASF GitHub Bot commented on FLINK-3651: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3651] Fix faulty RollingSink Restore

2016-03-24 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1830#issuecomment-200796710 I think the test fails only sporadically, depending on the speed at which tasks are deleting the files. If you are lucky, everything is correct. --- If your

[jira] [Commented] (FLINK-3651) Fix faulty RollingSink Restore

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210096#comment-15210096 ] ASF GitHub Bot commented on FLINK-3651: --- Github user uce commented on the pull request:

[GitHub] flink pull request: [FLINK-3651] Fix faulty RollingSink Restore

2016-03-24 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1830#issuecomment-200795802 Good catch! The changes look good to me. I tried running the adjusted `RollingSinkFaultToleranceITCase` and `RollingSinkFaultTolerance2ITCase` w/o the fix in

[jira] [Commented] (FLINK-3524) Provide a JSONDeserialisationSchema in the kafka connector package

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210093#comment-15210093 ] ASF GitHub Bot commented on FLINK-3524: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3524] [kafka] Add JSONDeserializationSc...

2016-03-24 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1834#issuecomment-200795303 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-3658) Allow the FlinkKafkaProducer to send data to multiple topics

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210088#comment-15210088 ] ASF GitHub Bot commented on FLINK-3658: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (FLINK-3658) Allow the FlinkKafkaProducer to send data to multiple topics

2016-03-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-3658. --- Resolution: Fixed Fix Version/s: 1.1.0 Resolved in master for 1.1.0

[GitHub] flink pull request: [FLINK-3658][Kafka] Allow producing into multi...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1832 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2609] [streaming] auto-register types

2016-03-24 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1833#issuecomment-200793560 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-2609) Automatic type registration is only called from the batch execution environment

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210086#comment-15210086 ] ASF GitHub Bot commented on FLINK-2609: --- Github user rmetzger commented on the pull request:

[jira] [Commented] (FLINK-3655) Allow comma-separated or multiple directories to be specified for FileInputFormat

2016-03-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210081#comment-15210081 ] Robert Metzger commented on FLINK-3655: --- Thank you for opening a JIRA for this feature request. I

[jira] [Updated] (FLINK-3655) Allow comma-separated or multiple directories to be specified for FileInputFormat

2016-03-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-3655: -- Labels: starter (was: ) > Allow comma-separated or multiple directories to be specified for >

[jira] [Closed] (FLINK-3663) FlinkKafkaConsumerBase.logPartitionInfo is missing a log marker

2016-03-24 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-3663. -- Resolution: Fixed Fix Version/s: 1.0.1 1.1.0 Fixed in f0b6ba4 (master),

[jira] [Commented] (FLINK-3663) FlinkKafkaConsumerBase.logPartitionInfo is missing a log marker

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210074#comment-15210074 ] ASF GitHub Bot commented on FLINK-3663: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: FLINK-3663: FlinkKafkaConsumerBase.logPartitio...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1835 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3663) FlinkKafkaConsumerBase.logPartitionInfo is missing a log marker

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210072#comment-15210072 ] ASF GitHub Bot commented on FLINK-3663: --- Github user uce commented on the pull request:

[jira] [Closed] (FLINK-3653) recovery.zookeeper.storageDir is not documented on the configuration page

2016-03-24 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-3653. -- Resolution: Fixed Fix Version/s: 1.0.1 Fixed in 5357ebe (release-1.0), 27dfd86 (master). >

[jira] [Commented] (FLINK-3653) recovery.zookeeper.storageDir is not documented on the configuration page

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210070#comment-15210070 ] ASF GitHub Bot commented on FLINK-3653: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3653] recovery.zookeeper.storageDir is ...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1828 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3653) recovery.zookeeper.storageDir is not documented on the configuration page

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210068#comment-15210068 ] ASF GitHub Bot commented on FLINK-3653: --- Github user uce commented on the pull request:

[GitHub] flink pull request: [FLINK-3653] recovery.zookeeper.storageDir is ...

2016-03-24 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1828#issuecomment-200786158 Thanks! I'm merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-3547] add support for streaming filter,...

2016-03-24 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1820#issuecomment-200784086 Thanks. I've addressed you comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-3547) Add support for streaming projection, selection, and union

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210065#comment-15210065 ] ASF GitHub Bot commented on FLINK-3547: --- Github user vasia commented on the pull request:

[jira] [Commented] (FLINK-2935) Allow scala shell to read yarn properties

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210043#comment-15210043 ] ASF GitHub Bot commented on FLINK-2935: --- Github user mxm commented on the pull request:

[GitHub] flink pull request: [FLINK-2935] [scala-shell] Allow Scala shell t...

2016-03-24 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1500#issuecomment-200770572 Thanks @chiwanpark! As far as I can see, there are no overlapping classes between the two pull requests. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-3544] Introduce ResourceManager compone...

2016-03-24 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1741#issuecomment-200769986 I've incorporated the changes and the tests pass. I would like to merge the pull request. Please let me know if there are still pending code reviews. --- If your project

[jira] [Commented] (FLINK-3639) Add methods and utilities to register DataSets and Tables in the TableEnvironment

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210039#comment-15210039 ] ASF GitHub Bot commented on FLINK-3639: --- Github user vasia commented on the pull request:

[jira] [Commented] (FLINK-3544) ResourceManager runtime components

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210037#comment-15210037 ] ASF GitHub Bot commented on FLINK-3544: --- Github user mxm commented on a diff in the pull request:

  1   2   >