[GitHub] flink pull request: [FLINK-3444] env.fromElements relies on the fi...

2016-04-11 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1857#issuecomment-208716571 The error of CI build failure is not relevant with this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-3444) env.fromElements relies on the first input element for determining the DataSet/DataStream type

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236628#comment-15236628 ] ASF GitHub Bot commented on FLINK-3444: --- Github user gallenvara commented on the pull request:

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236619#comment-15236619 ] ASF GitHub Bot commented on FLINK-2998: --- Github user gallenvara commented on the pull request:

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread gallenvara
Github user gallenvara commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-208712697 @fhueske Thanks a lot for your advice. PR updated. Please forgive my limited understand about the logic of `GlobalProperties`. I added tests to

[jira] [Commented] (FLINK-3736) Move toRexNode and toAggCall logic into Expressions

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236441#comment-15236441 ] ASF GitHub Bot commented on FLINK-3736: --- Github user yjshen commented on the pull request:

[GitHub] flink pull request: [FLINK-3736][TableAPI]Move toRexNode & toAggCa...

2016-04-11 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/flink/pull/1870#issuecomment-208663670 @fhueske, thanks :). Please let me know your thoughts when you give another pass. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-3736) Move toRexNode and toAggCall logic into Expressions

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236425#comment-15236425 ] ASF GitHub Bot commented on FLINK-3736: --- Github user yjshen commented on the pull request:

[GitHub] flink pull request: [FLINK-3736][TableAPI]Move toRexNode & toAggCa...

2016-04-11 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/flink/pull/1870#issuecomment-208661457 The build failure seems unrelated to this PR: ``` [INFO] Compiling 43 source files to /home/travis/build/apache/flink/flink-libraries/flink-ml/target/classes at

[jira] [Commented] (FLINK-3737) WikipediaEditsSourceTest.testWikipediaEditsSource() fails locally

2016-04-11 Thread Todd Lisonbee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236140#comment-15236140 ] Todd Lisonbee commented on FLINK-3737: -- Submitted two pull requests, one to the website and one to

[jira] [Commented] (FLINK-3737) WikipediaEditsSourceTest.testWikipediaEditsSource() fails locally

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236136#comment-15236136 ] ASF GitHub Bot commented on FLINK-3737: --- GitHub user tlisonbee opened a pull request:

[GitHub] flink pull request: [FLINK-3737] testWikipediaEditsSource() adding...

2016-04-11 Thread tlisonbee
GitHub user tlisonbee opened a pull request: https://github.com/apache/flink/pull/1872 [FLINK-3737] testWikipediaEditsSource() adding comment about SOCKS proxy server WikipediaEditsSourceTest.testWikipediaEditsSource() fails without SOCKS proxy when developer is behind firewall.

[jira] [Commented] (FLINK-3737) WikipediaEditsSourceTest.testWikipediaEditsSource() fails locally

2016-04-11 Thread Todd Lisonbee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236093#comment-15236093 ] Todd Lisonbee commented on FLINK-3737: -- Yes, this was a proxy issue. I'll document how to fix. >

[jira] [Commented] (FLINK-3700) Replace Guava Preconditions class with Flink Preconditions

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236058#comment-15236058 ] ASF GitHub Bot commented on FLINK-3700: --- Github user ZackPierce commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3700] [core] Add 'Preconditions' utilit...

2016-04-11 Thread ZackPierce
Github user ZackPierce commented on a diff in the pull request: https://github.com/apache/flink/pull/1853#discussion_r59289246 --- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java --- @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [FLINK-3736][TableAPI]Move toRexNode & toAggCa...

2016-04-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1870#issuecomment-208542966 Hi @yjshen, thanks for the PR! I agree, moving the `RexNode` translation to the individual `Expression` makes a lot of sense. I only skimmed the PR and did not have a

[jira] [Commented] (FLINK-3736) Move toRexNode and toAggCall logic into Expressions

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235910#comment-15235910 ] ASF GitHub Bot commented on FLINK-3736: --- Github user fhueske commented on the pull request:

[jira] [Created] (FLINK-3738) Refactor TableEnvironment and TranslationContext

2016-04-11 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-3738: Summary: Refactor TableEnvironment and TranslationContext Key: FLINK-3738 URL: https://issues.apache.org/jira/browse/FLINK-3738 Project: Flink Issue Type:

[jira] [Commented] (FLINK-3731) Embedded SQL outer joins should fail during translation

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235876#comment-15235876 ] ASF GitHub Bot commented on FLINK-3731: --- Github user fhueske commented on the pull request:

[jira] [Commented] (FLINK-2909) Gelly Graph Generators

2016-04-11 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235873#comment-15235873 ] Greg Hogan commented on FLINK-2909: --- I'll merge this after [FLINK-3589] is resolved. > Gelly Graph

[GitHub] flink pull request: [FLINK-3731] make embedded SQL outer joins fai...

2016-04-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1869#issuecomment-208532037 Thanks for the fix! +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Updated] (FLINK-3737) WikipediaEditsSourceTest.testWikipediaEditsSource() fails locally

2016-04-11 Thread Todd Lisonbee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lisonbee updated FLINK-3737: - Description: This test fails for me locally from both Maven command line and IntelliJ. This is

[jira] [Created] (FLINK-3737) WikipediaEditsSourceTest.testWikipediaEditsSource() fails locally

2016-04-11 Thread Todd Lisonbee (JIRA)
Todd Lisonbee created FLINK-3737: Summary: WikipediaEditsSourceTest.testWikipediaEditsSource() fails locally Key: FLINK-3737 URL: https://issues.apache.org/jira/browse/FLINK-3737 Project: Flink

[GitHub] flink pull request: [FLINK-3736][TableAPI]Move toRexNode & toAggCa...

2016-04-11 Thread yjshen
GitHub user yjshen opened a pull request: https://github.com/apache/flink/pull/1870 [FLINK-3736][TableAPI]Move toRexNode & toAggCall logic into each expression's implementation Since we have a one-to-one mapping from Flink `Expression` to Calcite `RexNode`, I think it's a good

[jira] [Commented] (FLINK-3736) Move toRexNode and toAggCall logic into Expressions

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235618#comment-15235618 ] ASF GitHub Bot commented on FLINK-3736: --- GitHub user yjshen opened a pull request:

[GitHub] flink pull request: [FLINK-3732] [Core] Potential null deference i...

2016-04-11 Thread skyahead
GitHub user skyahead opened a pull request: https://github.com/apache/flink/pull/1871 [FLINK-3732] [Core] Potential null deference in ExecutionConfig#equals() Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Commented] (FLINK-3732) Potential null deference in ExecutionConfig#equals()

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235619#comment-15235619 ] ASF GitHub Bot commented on FLINK-3732: --- GitHub user skyahead opened a pull request:

[jira] [Updated] (FLINK-3736) Move toRexNode and toAggCall logic into Expressions

2016-04-11 Thread Yijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yijie Shen updated FLINK-3736: -- Description: Since we have a one-to-one mapping from Flink {{Expression}} to Calcite {{RexNode}}, and

[jira] [Commented] (FLINK-3731) Embedded SQL outer joins should fail during translation

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235608#comment-15235608 ] ASF GitHub Bot commented on FLINK-3731: --- GitHub user vasia opened a pull request:

[jira] [Created] (FLINK-3736) Move toRexNode and toAggCall logic into Expressions

2016-04-11 Thread Yijie Shen (JIRA)
Yijie Shen created FLINK-3736: - Summary: Move toRexNode and toAggCall logic into Expressions Key: FLINK-3736 URL: https://issues.apache.org/jira/browse/FLINK-3736 Project: Flink Issue Type:

[jira] [Updated] (FLINK-3736) Move toRexNode and toAggCall logic into Expressions

2016-04-11 Thread Yijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yijie Shen updated FLINK-3736: -- Description: Since we have a one-to-one mapping from Flink {{Expression}} to Calcite {{RexNode}}, and

[GitHub] flink pull request: [FLINK-3731] make embedded SQL outer joins fai...

2016-04-11 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1869 [FLINK-3731] make embedded SQL outer joins fail during translation The `DataSetJoinRule` only matches for inner joins. Outer joins will throw a `PlanGenException`. You can merge this pull request

[jira] [Created] (FLINK-3735) Embedded SQL union should fail during translation

2016-04-11 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-3735: Summary: Embedded SQL union should fail during translation Key: FLINK-3735 URL: https://issues.apache.org/jira/browse/FLINK-3735 Project: Flink Issue Type:

[jira] [Commented] (FLINK-3530) Kafka09ITCase.testBigRecordJob fails on Travis

2016-04-11 Thread Todd Lisonbee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235602#comment-15235602 ] Todd Lisonbee commented on FLINK-3530: -- This test failed for me too but with a different error,

[jira] [Created] (FLINK-3734) Unclosed DataInputView in AbstractAlignedProcessingTimeWindowOperator#restoreState()

2016-04-11 Thread Ted Yu (JIRA)
Ted Yu created FLINK-3734: - Summary: Unclosed DataInputView in AbstractAlignedProcessingTimeWindowOperator#restoreState() Key: FLINK-3734 URL: https://issues.apache.org/jira/browse/FLINK-3734 Project: Flink

[jira] [Created] (FLINK-3733) registeredTypesWithKryoSerializers is not assigned in ExecutionConfig#deserializeUserCode()

2016-04-11 Thread Ted Yu (JIRA)
Ted Yu created FLINK-3733: - Summary: registeredTypesWithKryoSerializers is not assigned in ExecutionConfig#deserializeUserCode() Key: FLINK-3733 URL: https://issues.apache.org/jira/browse/FLINK-3733 Project:

[GitHub] flink pull request: FLINK-3126 : Remove accumulator type from "val...

2016-04-11 Thread ZackPierce
GitHub user ZackPierce opened a pull request: https://github.com/apache/flink/pull/1868 FLINK-3126 : Remove accumulator type from "value" in web frontend The `value` field in `StringifiedAccumulatorResult` populated by `stringifyAccumulatorResults` previously was filled by the

[jira] [Commented] (FLINK-3126) Remove accumulator type from "value" in web frontend

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235575#comment-15235575 ] ASF GitHub Bot commented on FLINK-3126: --- GitHub user ZackPierce opened a pull request:

[jira] [Created] (FLINK-3732) Potential null deference in ExecutionConfig#equals()

2016-04-11 Thread Ted Yu (JIRA)
Ted Yu created FLINK-3732: - Summary: Potential null deference in ExecutionConfig#equals() Key: FLINK-3732 URL: https://issues.apache.org/jira/browse/FLINK-3732 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-3589) Allow setting Operator parallelism to default value

2016-04-11 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235553#comment-15235553 ] Greg Hogan commented on FLINK-3589: --- [~mxm] or [~Zentol], would you be able to review the last update

[jira] [Commented] (FLINK-3723) Aggregate Functions and scalar expressions shouldn't be mixed in select

2016-04-11 Thread Yijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235530#comment-15235530 ] Yijie Shen commented on FLINK-3723: --- Ah, I see, thanks. it is implicitly checked by referring to the

[jira] [Created] (FLINK-3731) Embedded SQL outer joins should fail during translation

2016-04-11 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-3731: Summary: Embedded SQL outer joins should fail during translation Key: FLINK-3731 URL: https://issues.apache.org/jira/browse/FLINK-3731 Project: Flink Issue

[jira] [Created] (FLINK-3730) Fix RocksDB Local Directory Initialization

2016-04-11 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-3730: --- Summary: Fix RocksDB Local Directory Initialization Key: FLINK-3730 URL: https://issues.apache.org/jira/browse/FLINK-3730 Project: Flink Issue Type:

[jira] [Commented] (FLINK-3723) Aggregate Functions and scalar expressions shouldn't be mixed in select

2016-04-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235450#comment-15235450 ] Fabian Hueske commented on FLINK-3723: -- Yes, you are right. The Java docs are not correct and should

[jira] [Commented] (FLINK-3723) Aggregate Functions and scalar expressions shouldn't be mixed in select

2016-04-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235448#comment-15235448 ] Fabian Hueske commented on FLINK-3723: -- Yes, you are right {{extractAggCalls}} is definitely not

[jira] [Commented] (FLINK-3492) Allow users to define a min pause between checkpoints

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235443#comment-15235443 ] ASF GitHub Bot commented on FLINK-3492: --- Github user zentol closed the pull request at:

[jira] [Commented] (FLINK-3492) Allow users to define a min pause between checkpoints

2016-04-11 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235444#comment-15235444 ] Chesnay Schepler commented on FLINK-3492: - Implemented in 2e63d1afb2358760109ba0c90011ef565eaae0ff

[jira] [Closed] (FLINK-3492) Allow users to define a min pause between checkpoints

2016-04-11 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-3492. --- Resolution: Fixed > Allow users to define a min pause between checkpoints >

[jira] [Commented] (FLINK-3492) Allow users to define a min pause between checkpoints

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235442#comment-15235442 ] ASF GitHub Bot commented on FLINK-3492: --- Github user zentol commented on the pull request:

[GitHub] flink pull request: [FLINK-3492] Configurable interval between Che...

2016-04-11 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/1794 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3492] Configurable interval between Che...

2016-04-11 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1794#issuecomment-208438856 merged in 2e63d1afb2358760109ba0c90011ef565eaae0ff --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-3729) Several SQL tests fail on Windows OS

2016-04-11 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235432#comment-15235432 ] Chesnay Schepler commented on FLINK-3729: - no. the explain() method is already using different

[jira] [Comment Edited] (FLINK-3723) Aggregate Functions and scalar expressions shouldn't be mixed in select

2016-04-11 Thread Yijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235398#comment-15235398 ] Yijie Shen edited comment on FLINK-3723 at 4/11/16 4:24 PM: btw, I was misled

[jira] [Commented] (FLINK-3723) Aggregate Functions and scalar expressions shouldn't be mixed in select

2016-04-11 Thread Yijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235398#comment-15235398 ] Yijie Shen commented on FLINK-3723: --- btw, I was mislead by the javadoc first {code} Example:

[jira] [Commented] (FLINK-3729) Several SQL tests fail on Windows OS

2016-04-11 Thread Stefano Baghino (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235391#comment-15235391 ] Stefano Baghino commented on FLINK-3729: Perhaps the {{Table.explain(boolean)}} method could use

[jira] [Commented] (FLINK-3723) Aggregate Functions and scalar expressions shouldn't be mixed in select

2016-04-11 Thread Yijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235390#comment-15235390 ] Yijie Shen commented on FLINK-3723: --- ??Or do you assume that these will be implicitly added because they

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235383#comment-15235383 ] ASF GitHub Bot commented on FLINK-2998: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59233583 --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/CoGroupGlobalPropertiesCompatibilityTest.java --- @@ -93,7 +95,34 @@ public int

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235380#comment-15235380 ] ASF GitHub Bot commented on FLINK-2998: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235379#comment-15235379 ] ASF GitHub Bot commented on FLINK-2998: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59233074 --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/CoGroupGlobalPropertiesCompatibilityTest.java --- @@ -35,7 +37,7 @@ public void

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235376#comment-15235376 ] ASF GitHub Bot commented on FLINK-2998: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59232978 --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/JoinGlobalPropertiesCompatibilityTest.java --- @@ -93,7 +95,34 @@ public int

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59232837 --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/JoinGlobalPropertiesCompatibilityTest.java --- @@ -35,7 +37,7 @@ public void

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59232583 --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/TestDistribution.java --- @@ -0,0 +1,87 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235375#comment-15235375 ] ASF GitHub Bot commented on FLINK-2998: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3579) Improve String concatenation

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235364#comment-15235364 ] ASF GitHub Bot commented on FLINK-3579: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: FLINK-3579 Improve String concatenation (Ram)

2016-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1821 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (FLINK-3729) Several SQL tests fail on Windows OS

2016-04-11 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-3729: --- Summary: Several SQL tests fail on Windows OS Key: FLINK-3729 URL: https://issues.apache.org/jira/browse/FLINK-3729 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235368#comment-15235368 ] ASF GitHub Bot commented on FLINK-2998: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59231845 --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/JoinWithDistribution.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the

[jira] [Resolved] (FLINK-3579) Improve String concatenation

2016-04-11 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3579. -- Resolution: Fixed Fix Version/s: 1.1.0 > Improve String concatenation >

[jira] [Resolved] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-04-11 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vasia Kalavri resolved FLINK-3640. -- Resolution: Implemented Fix Version/s: 1.1.0 > Add support for SQL queries in DataSet

[jira] [Commented] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235365#comment-15235365 ] ASF GitHub Bot commented on FLINK-3640: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3640] [docs] extend the Table API docs ...

2016-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235356#comment-15235356 ] ASF GitHub Bot commented on FLINK-2998: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1838#issuecomment-208421293 `GlobalProperties` must copy the `distribution` itself. There are three places where this must be added: 1) `filterBySemanticProperties()`, line 314:

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59229736 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dataproperties/GlobalProperties.java --- @@ -83,6 +83,10 @@ public void

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235344#comment-15235344 ] ASF GitHub Bot commented on FLINK-2998: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235343#comment-15235343 ] ASF GitHub Bot commented on FLINK-2998: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59229638 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/TwoInputNode.java --- @@ -427,6 +428,14 @@ public void

[jira] [Commented] (FLINK-2998) Support range partition comparison for multi input nodes.

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235342#comment-15235342 ] ASF GitHub Bot commented on FLINK-2998: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2998] Support range partition compariso...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1838#discussion_r59229663 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/TwoInputNode.java --- @@ -454,6 +463,14 @@ public void

[jira] [Commented] (FLINK-3723) Aggregate Functions and scalar expressions shouldn't be mixed in select

2016-04-11 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235335#comment-15235335 ] Fabian Hueske commented on FLINK-3723: -- Hi [~yijieshen], welcome to the Flink community. Great that

[jira] [Commented] (FLINK-3721) Min and max accumulators

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235321#comment-15235321 ] ASF GitHub Bot commented on FLINK-3721: --- Github user greghogan commented on the pull request:

[GitHub] flink pull request: [FLINK-3721] Min and max accumulators

2016-04-11 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1866#issuecomment-208409014 @StephanEwen thanks for the links. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235319#comment-15235319 ] ASF GitHub Bot commented on FLINK-3640: --- Github user vasia commented on the pull request:

[GitHub] flink pull request: [FLINK-3640] [docs] extend the Table API docs ...

2016-04-11 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1867#issuecomment-208408620 Thanks for the comments! I've made the changes and will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-3640] [docs] extend the Table API docs ...

2016-04-11 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1867#issuecomment-208402682 Thanks for updating the Table API documentation! I added a few comments. Looks good otherwise. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235299#comment-15235299 ] ASF GitHub Bot commented on FLINK-3640: --- Github user fhueske commented on the pull request:

[jira] [Commented] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235293#comment-15235293 ] ASF GitHub Bot commented on FLINK-3640: --- Github user vasia commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3640] [docs] extend the Table API docs ...

2016-04-11 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1867#discussion_r59225146 --- Diff: docs/apis/batch/libs/table.md --- @@ -408,3 +428,132 @@ Here, `literal` is a valid Java literal and `field reference` specifies a column column

[jira] [Commented] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235289#comment-15235289 ] ASF GitHub Bot commented on FLINK-3640: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3640] [docs] extend the Table API docs ...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1867#discussion_r59224953 --- Diff: docs/apis/batch/libs/table.md --- @@ -408,3 +428,132 @@ Here, `literal` is a valid Java literal and `field reference` specifies a column

[GitHub] flink pull request: [FLINK-3640] [docs] extend the Table API docs ...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1867#discussion_r59224646 --- Diff: docs/apis/batch/libs/table.md --- @@ -408,3 +428,132 @@ Here, `literal` is a valid Java literal and `field reference` specifies a column

[jira] [Commented] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235285#comment-15235285 ] ASF GitHub Bot commented on FLINK-3640: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235279#comment-15235279 ] ASF GitHub Bot commented on FLINK-3640: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3640] [docs] extend the Table API docs ...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1867#discussion_r59224299 --- Diff: docs/apis/batch/libs/table.md --- @@ -408,3 +428,132 @@ Here, `literal` is a valid Java literal and `field reference` specifies a column

[jira] [Commented] (FLINK-3640) Add support for SQL queries in DataSet programs

2016-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235273#comment-15235273 ] ASF GitHub Bot commented on FLINK-3640: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3640] [docs] extend the Table API docs ...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1867#discussion_r59223134 --- Diff: docs/apis/batch/libs/table.md --- @@ -30,13 +30,21 @@ specific language governing permissions and limitations under the License. -->

[GitHub] flink pull request: [FLINK-3640] [docs] extend the Table API docs ...

2016-04-11 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1867#discussion_r59222873 --- Diff: docs/apis/batch/libs/table.md --- @@ -30,13 +30,21 @@ specific language governing permissions and limitations under the License. -->

  1   2   >