[jira] [Commented] (FLINK-3857) Add reconnect attempt to Elasticsearch host

[ https://issues.apache.org/jira/browse/FLINK-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339016#comment-15339016 ] ASF GitHub Bot commented on FLINK-3857: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #1962: [FLINK-3857][Streaming Connectors]Add reconnect at...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1962#discussion_r67637714 --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java

[jira] [Commented] (FLINK-3857) Add reconnect attempt to Elasticsearch host

[ https://issues.apache.org/jira/browse/FLINK-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339014#comment-15339014 ] ASF GitHub Bot commented on FLINK-3857: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #1962: [FLINK-3857][Streaming Connectors]Add reconnect attempt t...

Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/1962 Hi @sbcd90, I think to address "add reconnect attempt" alone, checking whether or not the transport client is connected to nodes and retry connect if lost connection in `invoke()` before

[jira] [Commented] (FLINK-3857) Add reconnect attempt to Elasticsearch host

[ https://issues.apache.org/jira/browse/FLINK-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339005#comment-15339005 ] ASF GitHub Bot commented on FLINK-3857: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #1962: [FLINK-3857][Streaming Connectors]Add reconnect at...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1962#discussion_r67636398 --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java

[jira] [Commented] (FLINK-3857) Add reconnect attempt to Elasticsearch host

[ https://issues.apache.org/jira/browse/FLINK-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339006#comment-15339006 ] ASF GitHub Bot commented on FLINK-3857: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #1962: [FLINK-3857][Streaming Connectors]Add reconnect at...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1962#discussion_r67636370 --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java

[jira] [Commented] (FLINK-3857) Add reconnect attempt to Elasticsearch host

[ https://issues.apache.org/jira/browse/FLINK-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339004#comment-15339004 ] ASF GitHub Bot commented on FLINK-3857: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #1962: [FLINK-3857][Streaming Connectors]Add reconnect at...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1962#discussion_r67636257 --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java

[jira] [Commented] (FLINK-3857) Add reconnect attempt to Elasticsearch host

[ https://issues.apache.org/jira/browse/FLINK-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339003#comment-15339003 ] ASF GitHub Bot commented on FLINK-3857: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #1962: [FLINK-3857][Streaming Connectors]Add reconnect at...

Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/1962#discussion_r67636217 --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java

[jira] [Commented] (FLINK-4090) Close of OutputStream should be in finally clause in FlinkYarnSessionCli#writeYarnProperties()

[ https://issues.apache.org/jira/browse/FLINK-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338891#comment-15338891 ] ASF GitHub Bot commented on FLINK-4090: --- GitHub user f7753 opened a pull request:

[GitHub] flink pull request #2132: [FLINK-4090] Close of OutputStream should be in fi...

GitHub user f7753 opened a pull request: https://github.com/apache/flink/pull/2132 [FLINK-4090] Close of OutputStream should be in finally clause in Fli… `try { OutputStream out = new FileOutputStream(propertiesFile); properties.store(out, "Generated YARN

[GitHub] flink issue #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on the issue: https://github.com/apache/flink/pull/1813 Most comments are nit or minor. Please fix. Otherwise, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338767#comment-15338767 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on the issue:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338764#comment-15338764 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338760#comment-15338760 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338762#comment-15338762 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338763#comment-15338763 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622740 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -0,0 +1,221 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338761#comment-15338761 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622731 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -0,0 +1,221 @@

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622738 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -0,0 +1,221 @@

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622734 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -0,0 +1,221 @@

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622724 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -0,0 +1,221 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338759#comment-15338759 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338758#comment-15338758 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622681 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,235 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338756#comment-15338756 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622668 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisMapper.java --- @@

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622673 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisMapper.java --- @@

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622678 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,235 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338757#comment-15338757 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338755#comment-15338755 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338754#comment-15338754 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622660 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -0,0 +1,221 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338753#comment-15338753 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622665 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkPublishTest.java --- @@ -0,0

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338751#comment-15338751 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622663 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkPublishTest.java --- @@ -0,0

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338752#comment-15338752 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622657 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -0,0 +1,221 @@

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622655 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java --- @@ -0,0 +1,221 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338750#comment-15338750 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622605 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkPublishTest.java --- @@ -0,0

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338749#comment-15338749 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338748#comment-15338748 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622604 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkPublishTest.java --- @@ -0,0

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338745#comment-15338745 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622590 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkPublishTest.java --- @@ -0,0

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622557 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisMapper.java --- @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338742#comment-15338742 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622555 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisMapper.java --- @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338739#comment-15338739 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622548 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisMapper.java --- @@

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622529 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataTypeDescription.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338738#comment-15338738 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338737#comment-15338737 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622515 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataTypeDescription.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338733#comment-15338733 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338732#comment-15338732 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622479 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataTypeDescription.java

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622482 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataTypeDescription.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338730#comment-15338730 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622473 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataTypeDescription.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338731#comment-15338731 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622464 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataTypeDescription.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338728#comment-15338728 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622440 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataType.java --- @@

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622392 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java ---

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338723#comment-15338723 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338722#comment-15338722 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622383 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisCommandsContainer.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338719#comment-15338719 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622377 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,235 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338718#comment-15338718 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622350 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java ---

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622319 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java ---

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338717#comment-15338717 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338715#comment-15338715 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622293 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java ---

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338716#comment-15338716 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622280 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java ---

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338713#comment-15338713 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622261 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338712#comment-15338712 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622255 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338709#comment-15338709 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r6769 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338707#comment-15338707 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622177 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338706#comment-15338706 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338704#comment-15338704 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622149 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338705#comment-15338705 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622134 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisSentinelConfig.java ---

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338703#comment-15338703 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67622131 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisSentinelConfig.java ---

[jira] [Commented] (FLINK-3034) Redis SInk Connector

[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338702#comment-15338702 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

  1   2   >