[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343708#comment-15343708 ] ASF GitHub Bot commented on FLINK-3034: --- Github user subhankarb commented on a diff in the pull

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

2016-06-21 Thread subhankarb
Github user subhankarb commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67994813 --- Diff:

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread joseprupi
Github user joseprupi commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67957847 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342801#comment-15342801 ] ASF GitHub Bot commented on FLINK-1707: --- Github user joseprupi commented on a diff in the pull

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342797#comment-15342797 ] ASF GitHub Bot commented on FLINK-1707: --- Github user joseprupi commented on a diff in the pull

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread joseprupi
Github user joseprupi commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67957755 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed

[jira] [Commented] (FLINK-2313) Change Streaming Driver Execution Model

2016-06-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342789#comment-15342789 ] Robert Metzger commented on FLINK-2313: --- Another important feature here would be to make the job id,

[jira] [Updated] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-3675: -- Priority: Critical (was: Major) > YARN ship folder incosistent behavior >

[jira] [Updated] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-3675: -- Fix Version/s: 1.1.0 > YARN ship folder incosistent behavior >

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342704#comment-15342704 ] ASF GitHub Bot commented on FLINK-1707: --- Github user joseprupi commented on a diff in the pull

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342684#comment-15342684 ] ASF GitHub Bot commented on FLINK-1707: --- Github user joseprupi commented on a diff in the pull

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread joseprupi
Github user joseprupi commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67952276 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread joseprupi
Github user joseprupi commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67951222 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed

[GitHub] flink issue #2115: [FLINK-4017] [py] Add Aggregation support to Python API

2016-06-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2115 Looks good overall. I found 1 big issue, the rest are minor things. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-4017) [py] Add Aggregation support to Python API

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342677#comment-15342677 ] ASF GitHub Bot commented on FLINK-4017: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-4017) [py] Add Aggregation support to Python API

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342669#comment-15342669 ] ASF GitHub Bot commented on FLINK-4017: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2115: [FLINK-4017] [py] Add Aggregation support to Pytho...

2016-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2115#discussion_r67950293 --- Diff: flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/DataSet.py --- @@ -192,6 +193,30 @@ def reduce(self, operator):

[jira] [Commented] (FLINK-4017) [py] Add Aggregation support to Python API

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342550#comment-15342550 ] ASF GitHub Bot commented on FLINK-4017: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4017) [py] Add Aggregation support to Python API

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342552#comment-15342552 ] ASF GitHub Bot commented on FLINK-4017: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2115: [FLINK-4017] [py] Add Aggregation support to Pytho...

2016-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2115#discussion_r67941010 --- Diff: flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/DataSet.py --- @@ -192,6 +193,30 @@ def reduce(self, operator):

[GitHub] flink pull request #2115: [FLINK-4017] [py] Add Aggregation support to Pytho...

2016-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2115#discussion_r67940988 --- Diff: flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/DataSet.py --- @@ -192,6 +193,30 @@ def reduce(self, operator):

[GitHub] flink pull request #2115: [FLINK-4017] [py] Add Aggregation support to Pytho...

2016-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2115#discussion_r67940565 --- Diff: flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/DataSet.py --- @@ -192,6 +193,30 @@ def reduce(self, operator):

[jira] [Commented] (FLINK-4017) [py] Add Aggregation support to Python API

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342547#comment-15342547 ] ASF GitHub Bot commented on FLINK-4017: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4017) [py] Add Aggregation support to Python API

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342543#comment-15342543 ] ASF GitHub Bot commented on FLINK-4017: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2115: [FLINK-4017] [py] Add Aggregation support to Pytho...

2016-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2115#discussion_r67940433 --- Diff: flink-libraries/flink-python/src/main/python/org/apache/flink/python/api/flink/plan/DataSet.py --- @@ -192,6 +193,30 @@ def reduce(self, operator):

[jira] [Commented] (FLINK-3872) Add Kafka TableSource with JSON serialization

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342209#comment-15342209 ] ASF GitHub Bot commented on FLINK-3872: --- Github user uce commented on the issue:

[GitHub] flink issue #2069: [FLINK-3872] [table, connector-kafka] Add KafkaJsonTableS...

2016-06-21 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2069 Thanks for the suggestion Fabian. I've added the table to the docs and added an example about the Kafka JSON source. Furthermore, I've added the configuration flag for the missing field failure

[jira] [Resolved] (FLINK-4082) Add Setting for LargeRecordHandler

2016-06-21 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-4082. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed in

[jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342206#comment-15342206 ] ASF GitHub Bot commented on FLINK-4082: --- Github user aljoscha closed the pull request at:

[GitHub] flink pull request #2113: [FLINK-4082] Add Setting for enabling/disabling La...

2016-06-21 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/2113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342172#comment-15342172 ] ASF GitHub Bot commented on FLINK-3951: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2112#discussion_r67908195 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/HistogramStatistics.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342171#comment-15342171 ] ASF GitHub Bot commented on FLINK-3951: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2112#discussion_r67908088 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/HistogramStatistics.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342139#comment-15342139 ] ASF GitHub Bot commented on FLINK-3034: --- Github user subhankarb commented on a diff in the pull

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

2016-06-21 Thread subhankarb
Github user subhankarb commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67905768 --- Diff:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342111#comment-15342111 ] ASF GitHub Bot commented on FLINK-3034: --- Github user subhankarb commented on a diff in the pull

[GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector

2016-06-21 Thread subhankarb
Github user subhankarb commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r67904127 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisClusterConfig.java

[jira] [Commented] (FLINK-4034) Dependency convergence on com.101tec:zkclient and com.esotericsoftware.kryo:kryo

2016-06-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342103#comment-15342103 ] Robert Metzger commented on FLINK-4034: --- I don't think always updating to the biggest version is a

[jira] [Assigned] (FLINK-4097) Cassandra Sink throws NPE on closing if server is not available

2016-06-21 Thread Andrea Sella (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Sella reassigned FLINK-4097: --- Assignee: Andrea Sella > Cassandra Sink throws NPE on closing if server is not available >

[jira] [Commented] (FLINK-4097) Cassandra Sink throws NPE on closing if server is not available

2016-06-21 Thread Andrea Sella (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342073#comment-15342073 ] Andrea Sella commented on FLINK-4097: - In the close() of Sink's lifecycle session should be

[jira] [Commented] (FLINK-3647) Change StreamSource to use Processing-Time Clock Service

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342069#comment-15342069 ] ASF GitHub Bot commented on FLINK-3647: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #2124: [FLINK-3647] Change StreamSource to use Processing-Time C...

2016-06-21 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2124 This looks very good! I just have a few minor comments: * It's very good that you fixed typos and added comments/Javadoc to previously undocumented code. I would like to see them as a

[jira] [Commented] (FLINK-3859) Add BigDecimal/BigInteger support to Table API

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342053#comment-15342053 ] ASF GitHub Bot commented on FLINK-3859: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2088: [FLINK-3859] [table] Add BigDecimal/BigInteger support to...

2016-06-21 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2088 @fhueske I have changed the `ExpressionTestBase`. Now one unit tests only needs one compilation step. The runtime is still not perfect but could be reduced by about 75 % (at least on my PC). ---

[jira] [Commented] (FLINK-4097) Cassandra Sink throws NPE on closing if server is not available

2016-06-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342052#comment-15342052 ] Robert Metzger commented on FLINK-4097: --- Why are you not a fan of it? > Cassandra Sink throws NPE

[jira] [Commented] (FLINK-4097) Cassandra Sink throws NPE on closing if server is not available

2016-06-21 Thread Andrea Sella (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342042#comment-15342042 ] Andrea Sella commented on FLINK-4097: - I am not a huge fan of null-checking in these cases, but it

[jira] [Commented] (FLINK-4039) G1 garbage collector only set if no custom jvm arguments

2016-06-21 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342033#comment-15342033 ] Gyula Fora commented on FLINK-4039: --- I think the only reasonable solution I see would be to try to

[jira] [Commented] (FLINK-4040) Same env.java.opts is applied for TM , JM and ZK

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342024#comment-15342024 ] ASF GitHub Bot commented on FLINK-4040: --- Github user gyfora commented on the issue:

[GitHub] flink issue #2143: [FLINK-4040] [dist] Allow JobManager/TaskManager-specific...

2016-06-21 Thread gyfora
Github user gyfora commented on the issue: https://github.com/apache/flink/pull/2143 Looks good, this addresses the issue 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Updated] (FLINK-3222) Incorrect shift amount in OperatorCheckpointStats#hashCode()

2016-06-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-3222: -- Description: Here is related code: {code} result = 31 * result + (int) (subTaskStats.length ^

[jira] [Commented] (FLINK-4097) Cassandra Sink throws NPE on closing if server is not available

2016-06-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342007#comment-15342007 ] Robert Metzger commented on FLINK-4097: --- Oh yes. You are right. Maybe it would make sense to add a

[jira] [Commented] (FLINK-4039) G1 garbage collector only set if no custom jvm arguments

2016-06-21 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342004#comment-15342004 ] Ufuk Celebi commented on FLINK-4039: Just noticed while working on FLINK-4040, that specifying

[jira] [Commented] (FLINK-4040) Same env.java.opts is applied for TM , JM and ZK

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341999#comment-15341999 ] ASF GitHub Bot commented on FLINK-4040: --- GitHub user uce opened a pull request:

[jira] [Commented] (FLINK-4097) Cassandra Sink throws NPE on closing if server is not available

2016-06-21 Thread Andrea Sella (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342001#comment-15342001 ] Andrea Sella commented on FLINK-4097: - I think it is correct to log the NullPointerException. The line

[GitHub] flink pull request #2143: [FLINK-4040] [dist] Allow JobManager/TaskManager-s...

2016-06-21 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2143 [FLINK-4040] [dist] Allow JobManager/TaskManager-specific JVM args - Adds two new config keys for the start up scripts: * `env.java.opts.jobmanager` * `env.java.opts.taskmanager` -

[jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341982#comment-15341982 ] ASF GitHub Bot commented on FLINK-4082: --- Github user uce commented on the issue:

[GitHub] flink issue #2113: [FLINK-4082] Add Setting for enabling/disabling LargeReco...

2016-06-21 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2113 Thanks! Looks good to merge. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Created] (FLINK-4098) Iteration support in Python API

2016-06-21 Thread Geoffrey Mon (JIRA)
Geoffrey Mon created FLINK-4098: --- Summary: Iteration support in Python API Key: FLINK-4098 URL: https://issues.apache.org/jira/browse/FLINK-4098 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341952#comment-15341952 ] ASF GitHub Bot commented on FLINK-4082: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #2113: [FLINK-4082] Add Setting for enabling/disabling LargeReco...

2016-06-21 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2113 @uce I addressed the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Assigned] (FLINK-4040) Same env.java.opts is applied for TM , JM and ZK

2016-06-21 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-4040: -- Assignee: Ufuk Celebi > Same env.java.opts is applied for TM , JM and ZK >

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341900#comment-15341900 ] ASF GitHub Bot commented on FLINK-1707: --- Github user vasia commented on the issue:

[GitHub] flink issue #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread vasia
Github user vasia commented on the issue: https://github.com/apache/flink/pull/2053 Hi @joseprupi, thanks a lot for this PR. I have looked through the code and I'm quite worried about its performance and scalability. Have you tried it out with any big inputs? We will

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341828#comment-15341828 ] ASF GitHub Bot commented on FLINK-3951: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2112#discussion_r67874799 --- Diff: flink-metrics/flink-metrics-dropwizard/src/test/java/org/apache/flink/dropwizard/metrics/DropwizardHistogramWrapperTest.java --- @@ -0,0

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341823#comment-15341823 ] ASF GitHub Bot commented on FLINK-1707: --- Github user vasia commented on a diff in the pull request:

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67873916 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341820#comment-15341820 ] ASF GitHub Bot commented on FLINK-1707: --- Github user vasia commented on a diff in the pull request:

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67873432 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341817#comment-15341817 ] ASF GitHub Bot commented on FLINK-1707: --- Github user vasia commented on a diff in the pull request:

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67873061 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341808#comment-15341808 ] ASF GitHub Bot commented on FLINK-4082: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #2113: [FLINK-4082] Add Setting for enabling/disabling LargeReco...

2016-06-21 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2113 Nope, I forgot that. Thanks for spotting! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341794#comment-15341794 ] ASF GitHub Bot commented on FLINK-3951: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67871432 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341795#comment-15341795 ] ASF GitHub Bot commented on FLINK-1707: --- Github user vasia commented on a diff in the pull request:

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2112#discussion_r67871338 --- Diff: flink-metrics/flink-metrics-dropwizard/src/test/java/org/apache/flink/dropwizard/metrics/DropwizardHistogramWrapperTest.java --- @@ -0,0

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341788#comment-15341788 ] ASF GitHub Bot commented on FLINK-3951: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341790#comment-15341790 ] ASF GitHub Bot commented on FLINK-3951: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2112#discussion_r67870807 --- Diff: flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/metrics/HistogramWrapper.java --- @@ -0,0 +1,52 @@ +/*

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2112#discussion_r67870675 --- Diff: flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java --- @@ -51,4 +69,106 @@ public void testGenerateName() {

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341772#comment-15341772 ] ASF GitHub Bot commented on FLINK-1707: --- Github user vasia commented on a diff in the pull request:

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67869049 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed to

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67868962 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed to

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67868917 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341768#comment-15341768 ] ASF GitHub Bot commented on FLINK-1707: --- Github user vasia commented on a diff in the pull request:

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341769#comment-15341769 ] ASF GitHub Bot commented on FLINK-1707: --- Github user vasia commented on a diff in the pull request:

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341770#comment-15341770 ] ASF GitHub Bot commented on FLINK-1707: --- Github user vasia commented on a diff in the pull request:

[GitHub] flink pull request #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2053#discussion_r67868911 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java --- @@ -0,0 +1,535 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341761#comment-15341761 ] ASF GitHub Bot commented on FLINK-3951: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2112#discussion_r67868105 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java --- @@ -99,8 +100,11 @@ public void notifyOfAddedMetric(Metric

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341758#comment-15341758 ] ASF GitHub Bot commented on FLINK-3951: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2112#discussion_r67867614 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/reporter/AbstractReporter.java --- @@ -32,9 +35,11 @@ */ @PublicEvolving

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341756#comment-15341756 ] ASF GitHub Bot commented on FLINK-3951: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2112#discussion_r67867222 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/groups/UnregisteredMetricsGroup.java --- @@ -60,7 +61,17 @@ public Counter counter(String

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2112#discussion_r67866757 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/HistogramStatistics.java --- @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341749#comment-15341749 ] ASF GitHub Bot commented on FLINK-3951: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341748#comment-15341748 ] ASF GitHub Bot commented on FLINK-1707: --- Github user vasia commented on the issue:

[GitHub] flink issue #2053: [FLINK-1707] Affinity Propagation

2016-06-21 Thread vasia
Github user vasia commented on the issue: https://github.com/apache/flink/pull/2053 I'll shepherd this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

  1   2   >