[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419763#comment-15419763
]
Renkai Ge commented on FLINK-4282:
--
Thanks,[~aljoscha].It's a brilliant idea,but the result might be
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419392#comment-15419392
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on the issue:
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
@twalthr I've updated the PR according to your comments. Could you please
review it again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/FLINK-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhenzhong Xu reassigned FLINK-4335:
---
Assignee: Zhenzhong Xu
> Add jar id, and job parameters information to job status rest call
[
https://issues.apache.org/jira/browse/FLINK-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhenzhong Xu reassigned FLINK-4336:
---
Assignee: Zhenzhong Xu
> Expose ability to take a savepoint from job manager
>
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419227#comment-15419227
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419226#comment-15419226
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on a diff in the pull
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74634350
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74634369
--- Diff:
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74633115
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/Row.scala
---
@@ -31,6 +31,10 @@ class Row(arity: Int) extends Product {
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419223#comment-15419223
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on a diff in the pull
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74633822
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/TypeUtil.java
---
@@ -0,0 +1,38 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419218#comment-15419218
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419222#comment-15419222
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on a diff in the pull
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74633954
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419221#comment-15419221
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on a diff in the pull
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74633921
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74633786
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419217#comment-15419217
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on a diff in the pull
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74633765
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/sink/CsvTableSinkTest.scala
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74633804
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSink.java
---
@@ -0,0
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419220#comment-15419220
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on a diff in the pull
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74633704
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/sink/CsvTableSinkTest.scala
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419208#comment-15419208
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418988#comment-15418988
]
Stephan Ewen commented on FLINK-4388:
-
I think I assigned it immediately upon creation. Stumbled over
[
https://issues.apache.org/jira/browse/FLINK-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418952#comment-15418952
]
ASF GitHub Bot commented on FLINK-4322:
---
GitHub user uce opened a pull request:
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2366
[FLINK-4322] Unify CheckpointCoordinator and SavepointCoordinator
The CheckpointCoordinator now also takes over the role of the
SavepointCoordinator. Savepoints are just like other checkpoints - they
[
https://issues.apache.org/jira/browse/FLINK-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu reassigned FLINK-4281:
--
Assignee: Jark Wu
> Wrap all Calcite Exceptions in Flink Exceptions
>
Till Rohrmann created FLINK-4390:
Summary: Add throws clause verification to RpcCompletenessTest
Key: FLINK-4390
URL: https://issues.apache.org/jira/browse/FLINK-4390
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-4386:
-
Assignee: Stephan Ewen
> Add as way to assert that code runs in the RpcEndpoint's Main Thread
>
[
https://issues.apache.org/jira/browse/FLINK-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418851#comment-15418851
]
Till Rohrmann commented on FLINK-4386:
--
That will be a really useful feature :-)
> Add as way to
[
https://issues.apache.org/jira/browse/FLINK-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418849#comment-15418849
]
ASF GitHub Bot commented on FLINK-4383:
---
GitHub user tillrohrmann opened a pull request:
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2365
[FLINK-4383] [rpc] Eagerly serialize remote rpc invocation messages
This PR introduces an eager serialization for remote rpc invocation
messages.
That way it is possible to check whether
[
https://issues.apache.org/jira/browse/FLINK-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418838#comment-15418838
]
ASF GitHub Bot commented on FLINK-4378:
---
Github user wenlong88 commented on the issue:
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/2356
the change is a little bigger than expected. because {{FileSystem}} will be
cached once created ,to make sure the user defined configuration work,
{{fs.%s.impl.disable.cache}} need to be set
[
https://issues.apache.org/jira/browse/FLINK-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-4236:
Assignee: Maximilian Michels
> Flink Dashboard stops showing list of uploaded jars if main
[
https://issues.apache.org/jira/browse/FLINK-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-4310:
Assignee: Stephan Ewen
> Move BinaryCompatibility Check plugin to relevant projects
>
[
https://issues.apache.org/jira/browse/FLINK-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-4310.
---
Resolution: Fixed
Fix Version/s: 1.2.0
Implemented in
[
https://issues.apache.org/jira/browse/FLINK-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418825#comment-15418825
]
Chesnay Schepler commented on FLINK-4048:
-
isn't this issue contained by FLINK-4315?
> Remove
[
https://issues.apache.org/jira/browse/FLINK-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418820#comment-15418820
]
Chesnay Schepler commented on FLINK-4302:
-
PR can be found here:
[
https://issues.apache.org/jira/browse/FLINK-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler reassigned FLINK-4302:
---
Assignee: Chesnay Schepler
> Add JavaDocs to MetricConfig
>
[
https://issues.apache.org/jira/browse/FLINK-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-4365.
---
Resolution: Duplicate
> [metrics] MetricConfig has no documentation
>
[
https://issues.apache.org/jira/browse/FLINK-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418811#comment-15418811
]
ASF GitHub Bot commented on FLINK-4293:
---
GitHub user zentol opened a pull request:
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2364
[FLINK-4293] Fix malformatted license headers
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes
[
https://issues.apache.org/jira/browse/FLINK-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler reassigned FLINK-4293:
---
Assignee: Chesnay Schepler
> Malformatted Apache Headers
>
[
https://issues.apache.org/jira/browse/FLINK-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418779#comment-15418779
]
Chesnay Schepler commented on FLINK-4177:
-
I don't think this will fix the issue. While this
[
https://issues.apache.org/jira/browse/FLINK-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418777#comment-15418777
]
ramkrishna.s.vasudevan commented on FLINK-4388:
---
When I commented there I saw it as
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418767#comment-15418767
]
ASF GitHub Bot commented on FLINK-4389:
---
GitHub user zentol opened a pull request:
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2363
[FLINK-4389] Expose metrics to WebFrontend
This PR exposes metrics to the Webfrontend, as proposed in
[
https://issues.apache.org/jira/browse/FLINK-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418763#comment-15418763
]
Stephan Ewen commented on FLINK-4388:
-
Hey, thanks for offering this, but the issue is already
[
https://issues.apache.org/jira/browse/FLINK-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418762#comment-15418762
]
Ufuk Celebi commented on FLINK-4387:
This could be related: https://github.com/netty/netty/issues/4357
[
https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418758#comment-15418758
]
ASF GitHub Bot commented on FLINK-4253:
---
Github user ramkrish86 commented on the issue:
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/2342
Updated PR request. Handles all other configs and renames them from
'recovery.* to 'high-availability.*'.
Also added test case and suitably modified code to ensure that if there are
both old
[
https://issues.apache.org/jira/browse/FLINK-4387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi reassigned FLINK-4387:
--
Assignee: Ufuk Celebi
> Instability in KvStateClientTest.testClientServerIntegration()
>
[
https://issues.apache.org/jira/browse/FLINK-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418752#comment-15418752
]
ramkrishna.s.vasudevan commented on FLINK-4388:
---
I can take this up and come up with a patch
[
https://issues.apache.org/jira/browse/FLINK-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418743#comment-15418743
]
Stephan Ewen commented on FLINK-4177:
-
I am also seeing failures:
[
https://issues.apache.org/jira/browse/FLINK-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418745#comment-15418745
]
Stephan Ewen commented on FLINK-4177:
-
[~Zentol] What is your take on this?
>
[
https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418738#comment-15418738
]
ASF GitHub Bot commented on FLINK-3318:
---
Github user mushketyk commented on the issue:
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2361
@tillrohrmann , could you please take a look at this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418734#comment-15418734
]
Greg Hogan commented on FLINK-4326:
---
Logging is configured through log4j / logback.
> Flink start-up
Chesnay Schepler created FLINK-4389:
---
Summary: Expose metrics to Webfrontend
Key: FLINK-4389
URL: https://issues.apache.org/jira/browse/FLINK-4389
Project: Flink
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/FLINK-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418714#comment-15418714
]
Till Rohrmann commented on FLINK-4072:
--
{{testTumblingWindow}} failed this time:
[
https://issues.apache.org/jira/browse/FLINK-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-4384:
-
Assignee: Stephan Ewen (was: Till Rohrmann)
> Add a "scheduleRunAsync()" feature to the
[
https://issues.apache.org/jira/browse/FLINK-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-4384:
-
Assignee: Stephan Ewen
> Add a "scheduleRunAsync()" feature to the RpcEndpoint
>
[
https://issues.apache.org/jira/browse/FLINK-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-4362.
--
Resolution: Done
Added via 4cde59141688dc12713cd0f41e21b27cd6fa3657
> Auto generate message
[
https://issues.apache.org/jira/browse/FLINK-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418715#comment-15418715
]
ASF GitHub Bot commented on FLINK-4362:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-4221:
Assignee: (was: Chesnay Schepler)
> Show metrics in WebFrontend
>
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2362
[FLINK-4385] [table] Union on Timestamp fields does not work
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
[
https://issues.apache.org/jira/browse/FLINK-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418670#comment-15418670
]
ASF GitHub Bot commented on FLINK-4385:
---
GitHub user wuchong opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418626#comment-15418626
]
Sajeev Ramakrishnan commented on FLINK-4377:
Thanks Stephan. It worked.
>
[
https://issues.apache.org/jira/browse/FLINK-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418614#comment-15418614
]
ASF GitHub Bot commented on FLINK-4384:
---
Github user StephanEwen commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418615#comment-15418615
]
ASF GitHub Bot commented on FLINK-4384:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2360#discussion_r74568505
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AsyncCallsTest.java
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2360
Will address the comments and merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2354
Yes, this is good, thanks!
+1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418612#comment-15418612
]
ASF GitHub Bot commented on FLINK-4366:
---
Github user StephanEwen commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418609#comment-15418609
]
Aljoscha Krettek commented on FLINK-4282:
-
[~RenkaiGe] yes, this is more or less what I had in
Stephan Ewen created FLINK-4388:
---
Summary: Race condition during initialization of
MemorySegmentFactory
Key: FLINK-4388
URL: https://issues.apache.org/jira/browse/FLINK-4388
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418581#comment-15418581
]
Robert Metzger commented on FLINK-4336:
---
[~zhenzhongxu]: I gave you "Contributor" permissions in our
[
https://issues.apache.org/jira/browse/FLINK-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu reassigned FLINK-4385:
--
Assignee: Jark Wu
> Union on Timestamp fields does not work
> ---
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2354
IMHO this looks good to merge now. ð
@StephanEwen what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
[
https://issues.apache.org/jira/browse/FLINK-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418576#comment-15418576
]
ASF GitHub Bot commented on FLINK-4366:
---
Github user aljoscha commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418570#comment-15418570
]
ASF GitHub Bot commented on FLINK-4384:
---
Github user tillrohrmann commented on a diff in the pull
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74549599
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java
---
@@ -0,0
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2360#discussion_r74563211
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/MainThreadExecutor.java
---
@@ -52,4 +52,13 @@
* @return Future of the
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2358
Dropping is also a solution. I think this will also happen implicitly if
the mailbox grows too big.
Stashing has the advantage that we try (on a best effort basis) to answer
early
[
https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418455#comment-15418455
]
ASF GitHub Bot commented on FLINK-2055:
---
Github user ramkrish86 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418567#comment-15418567
]
ASF GitHub Bot commented on FLINK-4384:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2360
Great addition @StephanEwen. +1 for merging.
Things are getting in shape :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418566#comment-15418566
]
ASF GitHub Bot commented on FLINK-4384:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2360#discussion_r74562696
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AsyncCallsTest.java
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418563#comment-15418563
]
ASF GitHub Bot commented on FLINK-4384:
---
Github user StephanEwen commented on a diff in the pull
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2360#discussion_r74562511
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/MainThreadExecutor.java
---
@@ -52,4 +52,13 @@
* @return Future of the
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/2342
Just a query,
If there are both old and new configs available - we should give priority
to the new one right? Even if the value for the old and new configs are
different?
---
If your
[
https://issues.apache.org/jira/browse/FLINK-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418562#comment-15418562
]
ASF GitHub Bot commented on FLINK-4384:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2360#discussion_r74561951
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/MainThreadExecutor.java
---
@@ -52,4 +52,13 @@
* @return Future of the
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74551046
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseClient.java
---
@@ -0,0 +1,69
Github user wenlong88 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2353#discussion_r74533793
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutorToResourceManagerConnection.java
---
@@ -0,0 +1,80 @@
+/*
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/2342
> Can you add such a test?
Sure I can. The existing test cases helped to ensure that if there are no
old configs we are able to fetch from the new config. I can add a test case to
ensure
1 - 100 of 137 matches
Mail list logo
