[GitHub] flink pull request #2673: [FLINK-4864] [table] Shade Calcite dependency in f...

2016-10-20 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/2673 [FLINK-4864] [table] Shade Calcite dependency in flink-table Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15594176#comment-15594176 ] ASF GitHub Bot commented on FLINK-4864: --- GitHub user wuchong opened a pull request:

[jira] [Commented] (FLINK-4866) Make Trigger.clear() Abstract to Enforce Implementation

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15594169#comment-15594169 ] ASF GitHub Bot commented on FLINK-4866: --- GitHub user wuchong opened a pull request:

[GitHub] flink pull request #2672: [FLINK-4866] [streaming] Make Trigger.clear() Abst...

2016-10-20 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/2672 [FLINK-4866] [streaming] Make Trigger.clear() Abstract to Enforce Implementation Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[jira] [Assigned] (FLINK-4864) Shade Calcite dependency in flink-table

2016-10-20 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-4864: -- Assignee: Jark Wu > Shade Calcite dependency in flink-table > ---

[jira] [Assigned] (FLINK-4866) Make Trigger.clear() Abstract to Enforce Implementation

2016-10-20 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-4866: -- Assignee: Jark Wu > Make Trigger.clear() Abstract to Enforce Implementation >

[jira] [Commented] (FLINK-4862) NPE on EventTimeSessionWindows with ContinuousEventTimeTrigger

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15594036#comment-15594036 ] ASF GitHub Bot commented on FLINK-4862: --- GitHub user manuzhang opened a pull request:

[GitHub] flink pull request #2671: [FLINK-4862] fix Timer register in ContinuousEvent...

2016-10-20 Thread manuzhang
GitHub user manuzhang opened a pull request: https://github.com/apache/flink/pull/2671 [FLINK-4862] fix Timer register in ContinuousEventTimeTrigger Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[jira] [Closed] (FLINK-4863) states of merging window and trigger are set to different TimeWindows on merge

2016-10-20 Thread Manu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manu Zhang closed FLINK-4863. - Resolution: Duplicate > states of merging window and trigger are set to different TimeWindows on merge >

[jira] [Commented] (FLINK-4863) states of merging window and trigger are set to different TimeWindows on merge

2016-10-20 Thread Manu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593811#comment-15593811 ] Manu Zhang commented on FLINK-4863: --- Found this is related to FLINK-4862.

[jira] [Commented] (FLINK-4863) states of merging window and trigger are set to different TimeWindows on merge

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593797#comment-15593797 ] ASF GitHub Bot commented on FLINK-4863: --- Github user manuzhang closed the pull request at:

[GitHub] flink pull request #2666: [FLINK-4863] fix trigger context window on merge

2016-10-20 Thread manuzhang
Github user manuzhang closed the pull request at: https://github.com/apache/flink/pull/2666 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2617: [FLINK-4705] Instrument FixedLengthRecordSorter

2016-10-20 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2617 I have started like to take a look at this... The `FixLegthRecordSorter` and its interactions with the serializers / comparators was not very well tested before, hence not activated. I

[GitHub] flink issue #2618: Refactoring the Continuous File Monitoring Function.

2016-10-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2618 Thanks for the comments @mxm ! I integrated them and waiting for Travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-4204) Clean up gelly-examples

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593069#comment-15593069 ] ASF GitHub Bot commented on FLINK-4204: --- GitHub user greghogan opened a pull request:

[GitHub] flink pull request #2670: [FLINK-4204] [gelly] Clean up gelly-examples

2016-10-20 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/2670 [FLINK-4204] [gelly] Clean up gelly-examples Moves drivers into separate package. Adds default main class to print usage listing included classes. Includes documentation for running Gelly

[GitHub] flink issue #2506: [FLINK-4581] [table] Table API throws "No suitable driver...

2016-10-20 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2506 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink pull request #2669: [FLINK-4871] [mini cluster] Add memory calculation...

2016-10-20 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2669 [FLINK-4871] [mini cluster] Add memory calculation for TaskManagers to MiniCluster This PR is based on #2651, #2655 and #2657. If the managed memory size for the task manager has not

[jira] [Commented] (FLINK-4581) Table API throws "No suitable driver found for jdbc:calcite"

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592877#comment-15592877 ] ASF GitHub Bot commented on FLINK-4581: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-4867) Investigate code generation for improving sort performance

2016-10-20 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592866#comment-15592866 ] Stefan Richter commented on FLINK-4867: --- I have already pushed my code into

[jira] [Commented] (FLINK-4705) Instrument FixedLengthRecordSorter

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592853#comment-15592853 ] ASF GitHub Bot commented on FLINK-4705: --- Github user StephanEwen commented on the issue:

[jira] [Created] (FLINK-4873) Add config option to specify "home directory" for YARN client resource sharing

2016-10-20 Thread Gyula Fora (JIRA)
Gyula Fora created FLINK-4873: - Summary: Add config option to specify "home directory" for YARN client resource sharing Key: FLINK-4873 URL: https://issues.apache.org/jira/browse/FLINK-4873 Project:

[GitHub] flink pull request #2659: [FLINK-4857] Remove throws clause from ZooKeeperUt...

2016-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2659 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2570: [FLINK-3674] Add an interface for Time aware User Functio...

2016-10-20 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/2570 Rebased version looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2657: [FLINK-4853] [rm] Harden job manager registration at the ...

2016-10-20 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2657 Sorry @mxm. The compilation problem were introduced due to an incomplete rebasing. Should be fixed now. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-2491) Operators are not participating in state checkpointing in some cases

2016-10-20 Thread Eryn Dahlstedt (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592479#comment-15592479 ] Eryn Dahlstedt commented on FLINK-2491: --- We have been running into this problem as well. Do you have

[jira] [Commented] (FLINK-4857) ZooKeeperUtils have a throws exception clause without throwing exceptions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592476#comment-15592476 ] ASF GitHub Bot commented on FLINK-4857: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-4857) ZooKeeperUtils have a throws exception clause without throwing exceptions

2016-10-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4857. Resolution: Fixed Fixed via 6f0faf9bb35e7cac3a38ed792cdabd6400fc4c79 > ZooKeeperUtils have a

[GitHub] flink issue #2659: [FLINK-4857] Remove throws clause from ZooKeeperUtils fun...

2016-10-20 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2659 Thanks for the review @mxm. Will merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2628: [FLINK-3722] [runtime] Don't / and % when sorting

2016-10-20 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/2628 > I transcribed Quicksort so as to remove considerations of Java performance and inlining. It was not clear to me that if we encapsulated the index, page number, and page offset into an object that

[jira] [Commented] (FLINK-4857) ZooKeeperUtils have a throws exception clause without throwing exceptions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592452#comment-15592452 ] ASF GitHub Bot commented on FLINK-4857: --- Github user tillrohrmann commented on the issue:

[jira] [Created] (FLINK-4872) Type erasure problem exclusively on cluster execution

2016-10-20 Thread Martin Junghanns (JIRA)
Martin Junghanns created FLINK-4872: --- Summary: Type erasure problem exclusively on cluster execution Key: FLINK-4872 URL: https://issues.apache.org/jira/browse/FLINK-4872 Project: Flink

[jira] [Commented] (FLINK-4853) Clean up JobManager registration at the ResourceManager

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592447#comment-15592447 ] ASF GitHub Bot commented on FLINK-4853: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-4871) Add memory calculation for TaskManagers and forward MetricRegistry

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592437#comment-15592437 ] ASF GitHub Bot commented on FLINK-4871: --- GitHub user tillrohrmann opened a pull request:

[jira] [Created] (FLINK-4871) Add memory calculation for TaskManagers and forward MetricRegistry

2016-10-20 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4871: Summary: Add memory calculation for TaskManagers and forward MetricRegistry Key: FLINK-4871 URL: https://issues.apache.org/jira/browse/FLINK-4871 Project: Flink

[GitHub] flink pull request #2668: Add EvaluateDataSetOperation for LabeledVector. Th...

2016-10-20 Thread tfournier314
GitHub user tfournier314 opened a pull request: https://github.com/apache/flink/pull/2668 Add EvaluateDataSetOperation for LabeledVector. This closes #4865 Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Commented] (FLINK-4867) Investigate code generation for improving sort performance

2016-10-20 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592359#comment-15592359 ] Gabor Gevay commented on FLINK-4867: Hm, this sounds quite interesting. Could you please share the

[jira] [Assigned] (FLINK-4867) Investigate code generation for improving sort performance

2016-10-20 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay reassigned FLINK-4867: -- Assignee: Gabor Gevay > Investigate code generation for improving sort performance >

[jira] [Commented] (FLINK-4867) Investigate code generation for improving sort performance

2016-10-20 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592367#comment-15592367 ] Gabor Gevay commented on FLINK-4867: That's nice, thanks! > Investigate code generation for improving

[jira] [Commented] (FLINK-2821) Change Akka configuration to allow accessing actors from different URLs

2016-10-20 Thread Philipp von dem Bussche (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592357#comment-15592357 ] Philipp von dem Bussche commented on FLINK-2821: Thank you for all your effort [~mxm]. I

[jira] [Created] (FLINK-4870) ContinuousFileMonitoringFunction does not properly handle absolut Windows paths

2016-10-20 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-4870: --- Summary: ContinuousFileMonitoringFunction does not properly handle absolut Windows paths Key: FLINK-4870 URL: https://issues.apache.org/jira/browse/FLINK-4870

[jira] [Updated] (FLINK-4869) Store record pointer after record keys

2016-10-20 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay updated FLINK-4869: --- Labels: performance (was: ) > Store record pointer after record keys >

[jira] [Updated] (FLINK-4860) Sort performance

2016-10-20 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay updated FLINK-4860: --- Component/s: Local Runtime > Sort performance > > > Key: FLINK-4860

[jira] [Updated] (FLINK-4860) Sort performance

2016-10-20 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay updated FLINK-4860: --- Labels: performance (was: ) > Sort performance > > > Key:

[jira] [Created] (FLINK-4869) Store record pointer after record keys

2016-10-20 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-4869: - Summary: Store record pointer after record keys Key: FLINK-4869 URL: https://issues.apache.org/jira/browse/FLINK-4869 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-4867) Investigate code generation for improving sort performance

2016-10-20 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592292#comment-15592292 ] Stefan Richter commented on FLINK-4867: --- If you sort performance is crucial to you, I wrote some

[jira] [Comment Edited] (FLINK-4867) Investigate code generation for improving sort performance

2016-10-20 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592292#comment-15592292 ] Stefan Richter edited comment on FLINK-4867 at 10/20/16 4:32 PM: - If sort

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592246#comment-15592246 ] ASF GitHub Bot commented on FLINK-3674: --- Github user StefanRRichter commented on the issue:

[jira] [Commented] (FLINK-4867) Investigate code generation for improving sort performance

2016-10-20 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592239#comment-15592239 ] Greg Hogan commented on FLINK-4867: --- It will be very interesting to see the results of this project.

[jira] [Updated] (FLINK-4868) Insertion sort could avoid the swaps

2016-10-20 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gevay updated FLINK-4868: --- Description: This is about the fallback to insertion sort at the beginning of

[jira] [Created] (FLINK-4868) Insertion sort could avoid the swaps

2016-10-20 Thread Gabor Gevay (JIRA)
Gabor Gevay created FLINK-4868: -- Summary: Insertion sort could avoid the swaps Key: FLINK-4868 URL: https://issues.apache.org/jira/browse/FLINK-4868 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592186#comment-15592186 ] ASF GitHub Bot commented on FLINK-3722: --- Github user ggevay commented on the issue:

[jira] [Created] (FLINK-4867) Investigate code generation for improving sort performance

2016-10-20 Thread Gabor Gevay (JIRA)
Gabor Gevay created FLINK-4867: -- Summary: Investigate code generation for improving sort performance Key: FLINK-4867 URL: https://issues.apache.org/jira/browse/FLINK-4867 Project: Flink Issue

[GitHub] flink issue #2570: [FLINK-3674] Add an interface for Time aware User Functio...

2016-10-20 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2570 I updated this on top of the latest master with @StefanRRichter's state changes. Please take another look, @StefanRRichter. --- If your project is set up for it, you can reply to this

[jira] [Closed] (FLINK-4844) Partitionable Raw Keyed/Operator State

2016-10-20 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-4844. - Resolution: Implemented Fix Version/s: 1.2.0 > Partitionable Raw Keyed/Operator State >

[jira] [Closed] (FLINK-4842) Introduce test to enforce order of operator / udf lifecycles

2016-10-20 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-4842. - Resolution: Implemented Fix Version/s: 1.2.0 > Introduce test to enforce order of operator

[GitHub] flink issue #2662: [FLINK-4824] [client] CliFrontend shows misleading error ...

2016-10-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2662 @mxm thanks for the review. I added a second commit which I think satisfies your request. When no job is executed then the message is printed to stderr without a stacktrace. --- If your project

[jira] [Commented] (FLINK-4844) Partitionable Raw Keyed/Operator State

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592051#comment-15592051 ] ASF GitHub Bot commented on FLINK-4844: --- Github user StefanRRichter closed the pull request at:

[GitHub] flink pull request #2648: [FLINK-4844] Partitionable Raw Keyed/Operator Stat...

2016-10-20 Thread StefanRRichter
Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/2648 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-3674) Add an interface for Time aware User Functions

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592052#comment-15592052 ] ASF GitHub Bot commented on FLINK-3674: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-4824) CliFrontend shows misleading error message when main() method returns before env.execute()

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592027#comment-15592027 ] ASF GitHub Bot commented on FLINK-4824: --- Github user greghogan commented on the issue:

[jira] [Comment Edited] (FLINK-4832) Count/Sum 0 elements

2016-10-20 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591955#comment-15591955 ] Anton Mushin edited comment on FLINK-4832 at 10/20/16 2:31 PM: --- Hello I

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84276796 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java --- @@ -43,16 +41,18 @@

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84288975 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java --- @@ -347,34 +328,17 @@ public

[jira] [Commented] (FLINK-4832) Count/Sum 0 elements

2016-10-20 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591955#comment-15591955 ] Anton Mushin commented on FLINK-4832: - Hello I think that it needs to change

[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84290827 --- Diff: flink-contrib/docker-flink/docker-compose.yml --- @@ -20,16 +20,20 @@ version: "2" services: jobmanager: image: flink +

[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…

2016-10-20 Thread sedgewickmm18
Github user sedgewickmm18 commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84291047 --- Diff: flink-contrib/docker-flink/docker-compose.sh --- @@ -0,0 +1,4 @@ +#!/bin/sh --- End diff -- that's fine --- If your project

[GitHub] flink issue #2628: [FLINK-3722] [runtime] Don't / and % when sorting

2016-10-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2628 Thanks @ggevay for reviewing. I added a commit with additional comments. I transcribed `Quicksort` so as to remove considerations of Java performance and inlining. It was not clear to me

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84279968 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java --- @@ -189,7 +186,7 @@ public

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84281147 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java --- @@ -0,0 +1,153 @@ +/* + *

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84284953 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/RichFileInputSplitTest.java --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84288776 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java --- @@ -0,0 +1,153 @@ +/* + *

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84288567 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java --- @@ -0,0 +1,153 @@ +/* + *

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84285924 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java --- @@ -0,0 +1,153 @@ +/* + *

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84288480 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java --- @@ -0,0 +1,153 @@ +/* + *

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84285533 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java --- @@ -0,0 +1,153 @@ +/* + *

[GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2618#discussion_r84280372 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java --- @@ -199,44 +196,39 @@ public

[jira] [Commented] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591881#comment-15591881 ] ASF GitHub Bot commented on FLINK-3722: --- Github user greghogan commented on the issue:

[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…

2016-10-20 Thread sedgewickmm18
Github user sedgewickmm18 commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84287069 --- Diff: flink-contrib/docker-flink/docker-compose.yml --- @@ -20,16 +20,20 @@ version: "2" services: jobmanager: image: flink

[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…

2016-10-20 Thread sedgewickmm18
Github user sedgewickmm18 commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84286390 --- Diff: flink-contrib/docker-flink/docker-entrypoint.sh --- @@ -20,11 +20,19 @@ if [ "$1" = "jobmanager" ]; then echo "Starting

[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84242539 --- Diff: flink-contrib/docker-flink/docker-compose.yml --- @@ -20,16 +20,20 @@ version: "2" services: jobmanager: image: flink +

[jira] [Comment Edited] (FLINK-3902) Discarded FileSystem checkpoints are lingering around

2016-10-20 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591808#comment-15591808 ] Jan Zajíc edited comment on FLINK-3902 at 10/20/16 1:24 PM: WE have same issue

[jira] [Comment Edited] (FLINK-3902) Discarded FileSystem checkpoints are lingering around

2016-10-20 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591808#comment-15591808 ] Jan Zajíc edited comment on FLINK-3902 at 10/20/16 1:24 PM: We have same issue

[jira] [Commented] (FLINK-3902) Discarded FileSystem checkpoints are lingering around

2016-10-20 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591808#comment-15591808 ] Jan Zajíc commented on FLINK-3902: -- WE have same issue on Linux in docker, but *both* ! RocksDBBackend

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-10-20 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2570#discussion_r84255151 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultProcessingTimeService.java --- @@ -35,10 +34,10 @@ import

[GitHub] flink pull request #2628: [FLINK-3722] [runtime] Don't / and % when sorting

2016-10-20 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/2628#discussion_r84248344 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/QuickSort.java --- @@ -49,20 +49,40 @@ protected static int getMaxDepth(int x)

[GitHub] flink issue #2618: Refactoring the Continuous File Monitoring Function.

2016-10-20 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2618 Thanks a lot @mxm ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink issue #2618: Refactoring the Continuous File Monitoring Function.

2016-10-20 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2618 Thanks for updating the description. Let take a look at the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #2657: [FLINK-4853] [rm] Harden job manager registration at the ...

2016-10-20 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2657 This doesn't compile currently. Do you prefer if I review the PRs individually or review the commits in this PR? --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-4853) Clean up JobManager registration at the ResourceManager

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591741#comment-15591741 ] ASF GitHub Bot commented on FLINK-4853: --- Github user mxm commented on the issue:

[jira] [Commented] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591734#comment-15591734 ] ASF GitHub Bot commented on FLINK-3722: --- Github user ggevay commented on a diff in the pull request:

[jira] [Created] (FLINK-4866) Make Trigger.clear() Abstract to Enforce Implementation

2016-10-20 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-4866: --- Summary: Make Trigger.clear() Abstract to Enforce Implementation Key: FLINK-4866 URL: https://issues.apache.org/jira/browse/FLINK-4866 Project: Flink

[jira] [Updated] (FLINK-4865) FlinkML - Add EvaluateDataSet operation for LabeledVector

2016-10-20 Thread Thomas FOURNIER (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas FOURNIER updated FLINK-4865: --- Description: We can only call "evaluate" method on a DataSet[(Vector,Double)]. Eg: If our

[jira] [Updated] (FLINK-4865) FlinkML - Add EvaluateDataSet operation for LabeledVector

2016-10-20 Thread Thomas FOURNIER (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas FOURNIER updated FLINK-4865: --- Description: We can only call "evaluate" method on a DataSet[(Double,Vector)]. Eg: If our

[jira] [Created] (FLINK-4865) FlinkML - Add EvaluateDataSet operation for LabeledVector

2016-10-20 Thread Thomas FOURNIER (JIRA)
Thomas FOURNIER created FLINK-4865: -- Summary: FlinkML - Add EvaluateDataSet operation for LabeledVector Key: FLINK-4865 URL: https://issues.apache.org/jira/browse/FLINK-4865 Project: Flink

[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84242735 --- Diff: flink-contrib/docker-flink/docker-compose.sh --- @@ -0,0 +1,4 @@ +#!/bin/sh --- End diff -- Could we name this file

[GitHub] flink pull request #2667: README.md - Description of the bluemix specif…

2016-10-20 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2667#discussion_r84242416 --- Diff: flink-contrib/docker-flink/docker-compose.yml --- @@ -20,16 +20,20 @@ version: "2" services: jobmanager: image: flink +

[jira] [Created] (FLINK-4864) Shade Calcite dependency in flink-table

2016-10-20 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-4864: Summary: Shade Calcite dependency in flink-table Key: FLINK-4864 URL: https://issues.apache.org/jira/browse/FLINK-4864 Project: Flink Issue Type:

[jira] [Commented] (FLINK-4850) FlinkML - SVM predict Operation for Vector and not LaveledVector

2016-10-20 Thread Thomas FOURNIER (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591644#comment-15591644 ] Thomas FOURNIER commented on FLINK-4850: Ok I'm creating a specific JIRA issue related to adding

[jira] [Updated] (FLINK-4850) FlinkML - SVM predict Operation for Vector and not LaveledVector

2016-10-20 Thread Thomas FOURNIER (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas FOURNIER updated FLINK-4850: --- Description: It seems that evaluate operation is defined for Vector and not LabeledVector. It

  1   2   >