[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827691#comment-15827691 ] ASF GitHub Bot commented on FLINK-2168: --- GitHub user ramkrish86 opened a pull request:

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3149 And one more thing is that other than the BasicTypeInfo what other types should we support. I was not sure on that so added a TODO there. --- If your project is set up for it, you can reply to

[GitHub] flink pull request #3149: FLINK-2168 Add HBaseTableSource

2017-01-18 Thread ramkrish86
GitHub user ramkrish86 opened a pull request: https://github.com/apache/flink/pull/3149 FLINK-2168 Add HBaseTableSource Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all

[jira] [Created] (FLINK-5546) When multiple users run test, /tmp/cacheFile conflicts

2017-01-18 Thread Syinchwun Leo (JIRA)
Syinchwun Leo created FLINK-5546: Summary: When multiple users run test, /tmp/cacheFile conflicts Key: FLINK-5546 URL: https://issues.apache.org/jira/browse/FLINK-5546 Project: Flink Issue

[jira] [Commented] (FLINK-5508) Remove Mesos dynamic class loading

2017-01-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827685#comment-15827685 ] Till Rohrmann commented on FLINK-5508: -- As a temporary fix, we'll introduce a

[jira] [Assigned] (FLINK-5508) Remove Mesos dynamic class loading

2017-01-18 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-5508: Assignee: Till Rohrmann > Remove Mesos dynamic class loading >

[jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827665#comment-15827665 ] ASF GitHub Bot commented on FLINK-5256: --- Github user ex00 commented on a diff in the pull request:

[GitHub] flink pull request #3033: [FLINK-5256] Extend DataSetSingleRowJoin to suppor...

2017-01-18 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/3033#discussion_r96588722 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala --- @@ -46,6 +47,7 @@ class

[jira] [Commented] (FLINK-5386) Refactoring Window Clause

2017-01-18 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827654#comment-15827654 ] Fabian Hueske commented on FLINK-5386: -- I think it would be good to get a fix for this soon to

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2017-01-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2836 I let it run overnight but a test failure caused the build to lockup :( Will disable the test and try again this evening. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827642#comment-15827642 ] ASF GitHub Bot commented on FLINK-5092: --- Github user zentol commented on the issue:

[GitHub] flink issue #3138: #Flink-5522 Storm Local Cluster can't work with powermock

2017-01-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3138 I played around a bit with ignore pattern but couldn't get it to work. However, moving WrapperSetupHelperTest into a separate class and replacing the StreamingRuntimeContext mocking (which in

[jira] [Comment Edited] (FLINK-5501) Determine whether the job starts from last JobManager failure

2017-01-18 Thread Zhijiang Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827361#comment-15827361 ] Zhijiang Wang edited comment on FLINK-5501 at 1/18/17 8:42 AM: ---

[jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827626#comment-15827626 ] ASF GitHub Bot commented on FLINK-5256: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3033: [FLINK-5256] Extend DataSetSingleRowJoin to suppor...

2017-01-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3033#discussion_r96586208 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala --- @@ -46,6 +47,7 @@ class

[GitHub] flink pull request #3132: [FLINK-5519] [build] scala-maven-plugin version al...

2017-01-18 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/3132#discussion_r96585227 --- Diff: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml --- @@ -313,7 +313,6 @@ under the License.

[GitHub] flink issue #3138: #Flink-5522 Storm Local Cluster can't work with powermock

2017-01-18 Thread liuyuzhong7
Github user liuyuzhong7 commented on the issue: https://github.com/apache/flink/pull/3138 @StephanEwen Only LocalCluster in storm can't workwith powermock. And it fail to init if ignore LocalCluster by powermock in WrapperSetupHelperTest. So I think delete or give a

[GitHub] flink pull request #3146: Insert necessary closing parentheses into the "Bas...

2017-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827612#comment-15827612 ] ASF GitHub Bot commented on FLINK-5256: --- Github user ex00 commented on a diff in the pull request:

[GitHub] flink pull request #3148: Remove one of duplicate "their" on the "Basic API ...

2017-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3147: Fix an invalid return type of sample code on the "...

2017-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3145: Fix a wrong function name `groupBy()` to `keyBy()`...

2017-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5519) scala-maven-plugin version all change to 3.2.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827611#comment-15827611 ] ASF GitHub Bot commented on FLINK-5519: --- Github user shijinkui commented on a diff in the pull

[GitHub] flink pull request #3033: [FLINK-5256] Extend DataSetSingleRowJoin to suppor...

2017-01-18 Thread ex00
Github user ex00 commented on a diff in the pull request: https://github.com/apache/flink/pull/3033#discussion_r96585254 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala --- @@ -46,6 +47,7 @@ class

[GitHub] flink issue #3145: Fix a wrong function name `groupBy()` to `keyBy()` on the...

2017-01-18 Thread keijiyoshida
Github user keijiyoshida commented on the issue: https://github.com/apache/flink/pull/3145 @fhueske Thanks for your checking this PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #3148: Remove one of duplicate "their" on the "Basic API Concept...

2017-01-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3148 Thanks for reviewing and improving the docs, @keijiyoshida! I'll squash your commits and and merge the fixes. Best, Fabian --- If your project is set up for it, you can reply to this

[GitHub] flink issue #3147: Fix an invalid return type of sample code on the "Basic A...

2017-01-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3147 Looks good, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] flink issue #3146: Insert necessary closing parentheses into the "Basic API ...

2017-01-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3146 Thanks for the PR @keijiyoshida! +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #3145: Fix a wrong function name `groupBy()` to `keyBy()` on the...

2017-01-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3145 Thanks for the PR @keijiyoshida! +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827586#comment-15827586 ] ASF GitHub Bot commented on FLINK-5256: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3033: [FLINK-5256] Extend DataSetSingleRowJoin to suppor...

2017-01-18 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3033#discussion_r96583281 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSingleRowJoin.scala --- @@ -46,6 +47,7 @@ class

[jira] [Commented] (FLINK-5520) Disable outer joins with non-equality predicates

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827579#comment-15827579 ] ASF GitHub Bot commented on FLINK-5520: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-5519) scala-maven-plugin version all change to 3.2.2

2017-01-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827582#comment-15827582 ] ASF GitHub Bot commented on FLINK-5519: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #3132: [FLINK-5519] [build] scala-maven-plugin version al...

2017-01-18 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/3132#discussion_r96582962 --- Diff: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml --- @@ -313,7 +313,6 @@ under the License.

[GitHub] flink issue #3141: [FLINK-5520] [table] Disable outer joins with non-equalit...

2017-01-18 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3141 I agree with @lincoln-lil and @shaoxuan-wang, this fix should go into the `1.1-release`, `1.2-release`, and `master` branches. We will later add support for non-equality predicate on left/right

<    1   2   3   4