[GitHub] flink pull request #3358: [FLINK-5487] [elasticsearch] At-least-once Elastic...

2017-02-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3358#discussion_r102400283 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java ---

[jira] [Commented] (FLINK-5487) Proper at-least-once support for ElasticsearchSink

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877698#comment-15877698 ] ASF GitHub Bot commented on FLINK-5487: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-4520) Integrate Siddhi as a lightweight CEP Library

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877693#comment-15877693 ] ASF GitHub Bot commented on FLINK-4520: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-02-21 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2487 Cool, than you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (FLINK-4520) Integrate Siddhi as a lightweight CEP Library

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877680#comment-15877680 ] ASF GitHub Bot commented on FLINK-4520: --- Github user haoch commented on the issue:

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-02-21 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 @uce sure, will fix it and resend PR to Bahir. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-5818) change checkpoint dir permission to 700 for security reason

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877656#comment-15877656 ] ASF GitHub Bot commented on FLINK-5818: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3335: [FLINK-5818][Security]change checkpoint dir permission to...

2017-02-21 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3335 @greghogan I think it's more like an improvement rather than a new feature. Anyway I'll post to mailling list for discussion. Thanks all guys :) --- If your project is set up for

[jira] [Commented] (FLINK-5501) Determine whether the job starts from last JobManager failure

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877569#comment-15877569 ] ASF GitHub Bot commented on FLINK-5501: --- GitHub user shuai-xu opened a pull request:

[GitHub] flink pull request #3385: [FLINK-5501] JM use running job registry to determ...

2017-02-21 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/3385 [FLINK-5501] JM use running job registry to determine whether is the first running This pr if for jira-#[5501](https://issues.apache.org/jira/browse/FLINK-5501). The main changes are:

[GitHub] flink issue #3370: [FLINK-5710] Add ProcTime() function to indicate StreamSQ...

2017-02-21 Thread huawei-flink
Github user huawei-flink commented on the issue: https://github.com/apache/flink/pull/3370 @haohui thanks for the contribution. I merged your code, I will push it later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-5710) Add ProcTime() function to indicate StreamSQL

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877548#comment-15877548 ] ASF GitHub Bot commented on FLINK-5710: --- Github user huawei-flink commented on the issue:

[GitHub] flink issue #3302: [FLINK-5710] Add ProcTime() function to indicate StreamSQ...

2017-02-21 Thread huawei-flink
Github user huawei-flink commented on the issue: https://github.com/apache/flink/pull/3302 I managed to merge the changes from PR #3370 into my branch after rebase, and the test works. I will push the code later today. sorry if I am a little latent, but I am travelling and

[jira] [Commented] (FLINK-5710) Add ProcTime() function to indicate StreamSQL

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877546#comment-15877546 ] ASF GitHub Bot commented on FLINK-5710: --- Github user huawei-flink commented on the issue:

[jira] [Commented] (FLINK-5701) FlinkKafkaProducer should check asyncException on checkpoints

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877497#comment-15877497 ] ASF GitHub Bot commented on FLINK-5701: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3278: [FLINK-5701] [kafka] FlinkKafkaProducer should check asyn...

2017-02-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3278 Addressed waiting for flushing to start with a latch instead of sleeping. Will merge this to `master` and `release-1.2` once Travis turns green (running also locally due to the timeouts). ---

[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877486#comment-15877486 ] ASF GitHub Bot commented on FLINK-4562: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2460: [FLINK-4562] table examples make an divided module in fli...

2017-02-21 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2460 Hi @shijinkui , sorry for the delay, the change looks very good to me. Regarding to your questions, >1. all the example code moved in flink-examples module, as a sub-module. Yes or No?

[jira] [Closed] (FLINK-5569) Migrate current table registration to in-memory catalog

2017-02-21 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-5569. - > Migrate current table registration to in-memory catalog >

[jira] [Updated] (FLINK-5376) Misleading log statements in UnorderedStreamElementQueue

2017-02-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5376: -- Description: The following are two examples where ordered stream element queue is mentioned: {code}

[jira] [Commented] (FLINK-4856) Add MapState for keyed streams

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877444#comment-15877444 ] ASF GitHub Bot commented on FLINK-4856: --- Github user wenlong88 commented on a diff in the pull

[GitHub] flink pull request #3336: [FLINK-4856][state] Add MapState in KeyedState

2017-02-21 Thread wenlong88
Github user wenlong88 commented on a diff in the pull request: https://github.com/apache/flink/pull/3336#discussion_r102381085 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/MapStateDescriptor.java --- @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache

[jira] [Closed] (FLINK-4443) Add support in RpcCompletenessTest for inheritance of RpcGateway and RpcEndpoint

2017-02-21 Thread Wenlong Lyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenlong Lyu closed FLINK-4443. -- fixed > Add support in RpcCompletenessTest for inheritance of RpcGateway and > RpcEndpoint >

[jira] [Closed] (FLINK-4378) Enable RollingSink to custom HDFS client configuration

2017-02-21 Thread Wenlong Lyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenlong Lyu closed FLINK-4378. -- fixed > Enable RollingSink to custom HDFS client configuration >

[jira] [Updated] (FLINK-5541) Missing null check for localJar in FlinkSubmitter#submitTopology()

2017-02-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5541: -- Description: {code} if (localJar == null) { try { for (final URL url :

[jira] [Comment Edited] (FLINK-5656) Add processing time OVER ROWS BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-21 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877380#comment-15877380 ] Jark Wu edited comment on FLINK-5656 at 2/22/17 3:17 AM: - [~sunjincheng121] I'm

[jira] [Commented] (FLINK-5656) Add processing time OVER ROWS BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-21 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877380#comment-15877380 ] Jark Wu commented on FLINK-5656: [~sunjingcheng] I'm fine with this as I haven't start this issue. If you

[jira] [Comment Edited] (FLINK-5656) Add processing time OVER ROWS BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-21 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877370#comment-15877370 ] sunjincheng edited comment on FLINK-5656 at 2/22/17 3:08 AM: - HI, [~fhueske] @

[jira] [Comment Edited] (FLINK-5656) Add processing time OVER ROWS BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-21 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877370#comment-15877370 ] sunjincheng edited comment on FLINK-5656 at 2/22/17 3:09 AM: - HI, [~fhueske]

[jira] [Commented] (FLINK-5656) Add processing time OVER ROWS BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-02-21 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877370#comment-15877370 ] sunjincheng commented on FLINK-5656: HI, [~fhueske] [~jack], IMO,In the case of `BETWEEN UNBOUNDED

[GitHub] flink issue #3360: [FLINK-5830][Distributed Coordination] Handle OutOfMemory...

2017-02-21 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/3360 Hi @tillrohrmann , thank you for reviews and positive suggestions! I try to explain the root case of this issue first: From JobMaster side, it sends the cancel rpc message and gets

[jira] [Commented] (FLINK-5830) OutOfMemoryError during notify final state in TaskExecutor may cause job stuck

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877368#comment-15877368 ] ASF GitHub Bot commented on FLINK-5830: --- Github user zhijiangW commented on the issue:

[jira] [Commented] (FLINK-4326) Flink start-up scripts should optionally start services on the foreground

2017-02-21 Thread Michi Mutsuzaki (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877364#comment-15877364 ] Michi Mutsuzaki commented on FLINK-4326: thanks [~greghogan], lgtm! > Flink start-up scripts

[jira] [Commented] (FLINK-5710) Add ProcTime() function to indicate StreamSQL

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877331#comment-15877331 ] ASF GitHub Bot commented on FLINK-5710: --- Github user huawei-flink commented on the issue:

[GitHub] flink issue #3302: [FLINK-5710] Add ProcTime() function to indicate StreamSQ...

2017-02-21 Thread huawei-flink
Github user huawei-flink commented on the issue: https://github.com/apache/flink/pull/3302 Hi Fabian, I will follow up in the next days, probably early next week. is it ok? Stefano --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877294#comment-15877294 ] ASF GitHub Bot commented on FLINK-4562: --- Github user shijinkui commented on the issue:

[GitHub] flink issue #2460: [FLINK-4562] table examples make an divided module in fli...

2017-02-21 Thread shijinkui
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/2460 @wuchong @StephanEwen can you review this pull request. Generating independent example runnable jar will increase the size of flink distribution. This table example jar is 13Mb or so.

[jira] [Closed] (FLINK-5795) Improve UDF to support constructor with parameter

2017-02-21 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-5795. -- Resolution: Fixed Fix Version/s: 1.3.0 Fixed in 1.3.0: 45e01cf2321dda58f572d8b9dbe64947c6725ad1 >

[jira] [Commented] (FLINK-5795) Improve UDF to support constructor with parameter

2017-02-21 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877288#comment-15877288 ] Jark Wu commented on FLINK-5795: Fixed in 1.3.0: 45e01cf2321dda58f572d8b9dbe64947c6725ad1 > Improve UDF

[jira] [Commented] (FLINK-1526) Add Minimum Spanning Tree library method and example

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877287#comment-15877287 ] ASF GitHub Bot commented on FLINK-1526: --- Github user xccui commented on the issue:

[GitHub] flink issue #3284: [FLINK-1526] [Gelly] Add Minimum Spanning Tree library me...

2017-02-21 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/3284 With the present situation (for gelly), shall I close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-5795) Improve UDF to support constructor with parameter

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877285#comment-15877285 ] ASF GitHub Bot commented on FLINK-5795: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3330: [FLINK-5795][TableAPI] Improve UDTF to support...

2017-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (FLINK-5795) Improve UDF to support constructor with parameter

2017-02-21 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-5795: --- Summary: Improve UDF to support constructor with parameter (was: Improve “UDTF" to support constructor with

[jira] [Closed] (FLINK-5546) java.io.tmpdir setted as project build directory in surefire plugin

2017-02-21 Thread shijinkui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shijinkui closed FLINK-5546. Resolution: Duplicate resolved in FLINK-5817 > java.io.tmpdir setted as project build directory in

[jira] [Commented] (FLINK-4754) Make number of retained checkpoints user configurable

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877248#comment-15877248 ] ASF GitHub Bot commented on FLINK-4754: --- Github user tony810430 commented on the issue:

[GitHub] flink issue #3374: [FLINK-4754] [checkpoints] Make number of retained checkp...

2017-02-21 Thread tony810430
Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/3374 Hi @StephanEwen thanks for your feedback. I totally agree your opinion. I will make this setting be configured in `FlinkConfiguration` and be passed to `CheckpointRecoveryFactory`.

[jira] [Created] (FLINK-5878) Add stream-stream inner join on TableAPI

2017-02-21 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-5878: Summary: Add stream-stream inner join on TableAPI Key: FLINK-5878 URL: https://issues.apache.org/jira/browse/FLINK-5878 Project: Flink Issue Type: New

[jira] [Commented] (FLINK-5524) Support early out for code generated conjunctive conditions

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877175#comment-15877175 ] ASF GitHub Bot commented on FLINK-5524: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3372: [FLINK-5524] [table] Support early out for code ge...

2017-02-21 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3372#discussion_r102361046 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/CalcITCase.scala --- @@ -217,6 +218,65 @@ class

[jira] [Commented] (FLINK-4422) Convert all time interval measurements to System.nanoTime()

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876990#comment-15876990 ] ASF GitHub Bot commented on FLINK-4422: --- GitHub user jinmingjian opened a pull request:

[GitHub] flink pull request #3384: [FLINK-4422] Convert all time interval measurement...

2017-02-21 Thread jinmingjian
GitHub user jinmingjian opened a pull request: https://github.com/apache/flink/pull/3384 [FLINK-4422] Convert all time interval measurements to System.nanoTime() - flink-clients Thanks for contributing to Apache Flink. Before you open your pull request, please take the following

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-21 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876695#comment-15876695 ] Dawid Wysakowicz commented on FLINK-5824: - I've fixed all direct String <> bytes conversions as

[GitHub] flink pull request #3383: [FLINK-5877] [docs] Fix Scala snippet in Async I/O...

2017-02-21 Thread alkagin
GitHub user alkagin opened a pull request: https://github.com/apache/flink/pull/3383 [FLINK-5877] [docs] Fix Scala snippet in Async I/O API doc Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[jira] [Commented] (FLINK-5877) Fix Scala snippet in Async I/O API doc

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876630#comment-15876630 ] ASF GitHub Bot commented on FLINK-5877: --- GitHub user alkagin opened a pull request:

[jira] [Created] (FLINK-5877) Fix Scala snippet in Async I/O API doc

2017-02-21 Thread Andrea Sella (JIRA)
Andrea Sella created FLINK-5877: --- Summary: Fix Scala snippet in Async I/O API doc Key: FLINK-5877 URL: https://issues.apache.org/jira/browse/FLINK-5877 Project: Flink Issue Type: Improvement

[GitHub] flink pull request #3314: [FLINK-3679] DeserializationSchema should handle z...

2017-02-21 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/3314#discussion_r102299038 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java --- @@

[jira] [Commented] (FLINK-3679) DeserializationSchema should handle zero or more outputs for every input

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876573#comment-15876573 ] ASF GitHub Bot commented on FLINK-3679: --- Github user haohui commented on a diff in the pull request:

[jira] [Commented] (FLINK-4754) Make number of retained checkpoints user configurable

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876543#comment-15876543 ] ASF GitHub Bot commented on FLINK-4754: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3374: [FLINK-4754] [checkpoints] Make number of retained checkp...

2017-02-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3374 Hi @tony810430 thank you for the pull request! The code looks good. My feeling is, though, that the number of checkpoints to retain is something that we want rather in the

[jira] [Commented] (FLINK-5801) Queryable State from Scala job/client fails with key of type Long

2017-02-21 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876416#comment-15876416 ] Ufuk Celebi commented on FLINK-5801: The root cause of this a mismatch in the key serializers. The

[jira] [Created] (FLINK-5876) Mention Scala type fallacies for queryable state client serializers

2017-02-21 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-5876: -- Summary: Mention Scala type fallacies for queryable state client serializers Key: FLINK-5876 URL: https://issues.apache.org/jira/browse/FLINK-5876 Project: Flink

[jira] [Updated] (FLINK-3695) ValueArray types

2017-02-21 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-3695: -- Fix Version/s: 1.3.0 > ValueArray types > > > Key: FLINK-3695 >

[jira] [Commented] (FLINK-3695) ValueArray types

2017-02-21 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876400#comment-15876400 ] Greg Hogan commented on FLINK-3695: --- [~StephanEwen]

[jira] [Commented] (FLINK-3695) ValueArray types

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876394#comment-15876394 ] ASF GitHub Bot commented on FLINK-3695: --- GitHub user greghogan opened a pull request:

[GitHub] flink pull request #3382: [FLINK-3695] [gelly] ValueArray types

2017-02-21 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3382 [FLINK-3695] [gelly] ValueArray types Provide compact and efficiently serializable and comparable array implementations for Flink mutable Value types and Java primitives. You can merge this pull

[jira] [Created] (FLINK-5875) Use TypeComparator.hash instead of Object.hashCode() for keying in DataStream API

2017-02-21 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-5875: - Summary: Use TypeComparator.hash instead of Object.hashCode() for keying in DataStream API Key: FLINK-5875 URL: https://issues.apache.org/jira/browse/FLINK-5875

[jira] [Updated] (FLINK-5875) Use TypeComparator.hash() instead of Object.hashCode() for keying in DataStream API

2017-02-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-5875: -- Summary: Use TypeComparator.hash() instead of Object.hashCode() for keying in DataStream API

[jira] [Commented] (FLINK-4326) Flink start-up scripts should optionally start services on the foreground

2017-02-21 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876351#comment-15876351 ] Greg Hogan commented on FLINK-4326: --- [~michim] thank you for reporting the issue. This should now be

[jira] [Created] (FLINK-5874) Reject arrays as keys in DataStream API to avoid inconsistent hashing

2017-02-21 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-5874: - Summary: Reject arrays as keys in DataStream API to avoid inconsistent hashing Key: FLINK-5874 URL: https://issues.apache.org/jira/browse/FLINK-5874 Project: Flink

[jira] [Commented] (FLINK-5871) Enforce uniqueness of pattern names in CEP.

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876329#comment-15876329 ] ASF GitHub Bot commented on FLINK-5871: --- GitHub user kl0u opened a pull request:

[GitHub] flink pull request #3381: [FLINK-5871] [cep] Enforce uniqueness of pattern n...

2017-02-21 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3381 [FLINK-5871] [cep] Enforce uniqueness of pattern names in CEP. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cep-uniq-pattern-name

[jira] [Closed] (FLINK-3163) Configure Flink for NUMA systems

2017-02-21 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-3163. - Resolution: Implemented Implemented in 11c868f91db773af626ac6ac4dcba9820c13fa8a > Configure Flink for

[jira] [Commented] (FLINK-3163) Configure Flink for NUMA systems

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876282#comment-15876282 ] ASF GitHub Bot commented on FLINK-3163: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3249: [FLINK-3163] [scripts] Configure Flink for NUMA sy...

2017-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (FLINK-5865) Throw original exception in states

2017-02-21 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaogang Shi updated FLINK-5865: Summary: Throw original exception in states (was: Throw original exception in RocksDB states) >

[jira] [Commented] (FLINK-5865) Throw original exception in RocksDB states

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876239#comment-15876239 ] ASF GitHub Bot commented on FLINK-5865: --- GitHub user shixiaogang opened a pull request:

[GitHub] flink pull request #3380: [FLINK-5865][state] Throw original exception in th...

2017-02-21 Thread shixiaogang
GitHub user shixiaogang opened a pull request: https://github.com/apache/flink/pull/3380 [FLINK-5865][state] Throw original exception in the states The wrapping of `RuntimeException` is removed so that we can avoid redundant stack printed in the log. You can merge this pull

[jira] [Commented] (FLINK-5824) Fix String/byte conversions without explicit encoding

2017-02-21 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876215#comment-15876215 ] Dawid Wysakowicz commented on FLINK-5824: - Right now such a regex will match also for

[jira] [Commented] (FLINK-5498) Add support for left/right outer joins with non-equality predicates (and 1+ equality predicates)

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876190#comment-15876190 ] ASF GitHub Bot commented on FLINK-5498: --- GitHub user lincoln-lil opened a pull request:

[GitHub] flink pull request #3379: [FLINK-5498] [table] Add support for left/right ou...

2017-02-21 Thread lincoln-lil
GitHub user lincoln-lil opened a pull request: https://github.com/apache/flink/pull/3379 [FLINK-5498] [table] Add support for left/right outer joins with non-… …equality predicates (and 1+ equality predicates) Support left/right outer joins with non-equi-join conditions

[jira] [Commented] (FLINK-5812) Clean up FileSystem

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876174#comment-15876174 ] ASF GitHub Bot commented on FLINK-5812: --- Github user StephanEwen closed the pull request at:

[jira] [Commented] (FLINK-5812) Clean up FileSystem

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876173#comment-15876173 ] ASF GitHub Bot commented on FLINK-5812: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #3328: [FLINK-5812] [core] Cleanups in the FileSystem cla...

2017-02-21 Thread StephanEwen
Github user StephanEwen closed the pull request at: https://github.com/apache/flink/pull/3328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #3328: [FLINK-5812] [core] Cleanups in the FileSystem class

2017-02-21 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3328 Yes, it was accidentally merged together with another PR. Since the changes were mostly comments and annotations, it should not be a problem. Closing... --- If your project is set

[GitHub] flink pull request #3378: [FLINK-5849] [kafka] Move FlinkKafkaConsumer start...

2017-02-21 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/3378 [FLINK-5849] [kafka] Move FlinkKafkaConsumer start offset determination to open() This PR fixes a regression due to the recently merged #2509 (FLINK-4280). The new start position feature added

[jira] [Commented] (FLINK-3123) Allow setting custom start-offsets for the Kafka consumer

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876154#comment-15876154 ] ASF GitHub Bot commented on FLINK-3123: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #2687: [FLINK-3123] [kafka] Allow custom specific start offsets ...

2017-02-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2687 I recommend reviewing this after #3378 is merged, as it touches a lot of code related to the new start position features. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-5487) Proper at-least-once support for ElasticsearchSink

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876150#comment-15876150 ] ASF GitHub Bot commented on FLINK-5487: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3358: [FLINK-5487] [elasticsearch] At-least-once ElasticsearchS...

2017-02-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3358 Yes, I overlooked adding tests for this. Thanks a lot for the reviews @rmetzger! I'll address your comments and tests for the additional features. Will ping you once it's ready for

[jira] [Commented] (FLINK-5487) Proper at-least-once support for ElasticsearchSink

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876148#comment-15876148 ] ASF GitHub Bot commented on FLINK-5487: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3358: [FLINK-5487] [elasticsearch] At-least-once Elastic...

2017-02-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3358#discussion_r102233292 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java ---

[jira] [Commented] (FLINK-5849) Kafka Consumer checkpointed state may contain undefined offsets

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876139#comment-15876139 ] ASF GitHub Bot commented on FLINK-5849: --- GitHub user tzulitai opened a pull request:

[jira] [Commented] (FLINK-5090) Expose optionally detailed metrics about network queue lengths

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876124#comment-15876124 ] ASF GitHub Bot commented on FLINK-5090: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3348: [FLINK-5090] [network] Add metrics for details abo...

2017-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3348#discussion_r102227821 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -227,6 +227,14 @@ public static final String

[GitHub] flink pull request #3323: [hotfix] [core] Add missing stability annotations ...

2017-02-21 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3323#discussion_r102227190 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/Archiveable.java --- @@ -17,8 +17,11 @@ */ package org.apache.flink.api.common;

[jira] [Commented] (FLINK-5812) Clean up FileSystem

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876116#comment-15876116 ] ASF GitHub Bot commented on FLINK-5812: --- Github user zentol commented on the issue:

[GitHub] flink issue #3336: [FLINK-4856][state] Add MapState in KeyedState

2017-02-21 Thread shixiaogang
Github user shixiaogang commented on the issue: https://github.com/apache/flink/pull/3336 @StefanRRichter Very thanks for your work. I have rebased the pull request and resolved the conflicts. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #3328: [FLINK-5812] [core] Cleanups in the FileSystem class

2017-02-21 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3328 @StephanEwen Can this PR be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-4856) Add MapState for keyed streams

2017-02-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876117#comment-15876117 ] ASF GitHub Bot commented on FLINK-4856: --- Github user shixiaogang commented on the issue:

  1   2   3   4   >