[jira] [Commented] (FLINK-7174) Bump dependency of Kafka 0.10.x to the latest one

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092619#comment-16092619 ] ASF GitHub Bot commented on FLINK-7174: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4321: [FLINK-7174] Bump Kafka 0.10 dependency to 0.10.2.1

2017-07-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4321 One other question: I need a bit more context on why the version bump requires that change in the `KafkaConsumerThread`. From what I perceive, that should be an separate issue to fix hot looping,

[GitHub] flink issue #4321: [FLINK-7174] Bump Kafka 0.10 dependency to 0.10.2.1

2017-07-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4321 @pnowojski we can't just drop that test, IMO. It's crucial that those tests exist to guard against incorrect reassignment logic in the `KafkaConsumerThread`. Breaking that would mess up the

[jira] [Commented] (FLINK-7174) Bump dependency of Kafka 0.10.x to the latest one

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092616#comment-16092616 ] ASF GitHub Bot commented on FLINK-7174: --- Github user tzulitai commented on the issue:

[jira] [Commented] (FLINK-7222) Kafka010ITCase fails on windows

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092608#comment-16092608 ] ASF GitHub Bot commented on FLINK-7222: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4361: [FLINK-7222] fix Kafka010ITCase fails on windows

2017-07-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4361 Thanks for the pull request @zjureel. While you're on this, could you also fix this for Kafka 08 and 09? --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Created] (FLINK-7223) Increase DEFAULT_SHARD_DISCOVERY_INTERVAL_MILLIS for Flink-kinesis-connector

2017-07-18 Thread Bowen Li (JIRA)
Bowen Li created FLINK-7223: --- Summary: Increase DEFAULT_SHARD_DISCOVERY_INTERVAL_MILLIS for Flink-kinesis-connector Key: FLINK-7223 URL: https://issues.apache.org/jira/browse/FLINK-7223 Project: Flink

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092533#comment-16092533 ] ASF GitHub Bot commented on FLINK-7143: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection ...

2017-07-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4357#discussion_r128147490 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -517,16

[GitHub] flink pull request #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection ...

2017-07-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4357#discussion_r128147542 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -517,16

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092535#comment-16092535 ] ASF GitHub Bot commented on FLINK-7143: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092528#comment-16092528 ] ASF GitHub Bot commented on FLINK-7143: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection ...

2017-07-18 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4357#discussion_r128147294 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -517,16

[jira] [Commented] (FLINK-5541) Missing null check for localJar in FlinkSubmitter#submitTopology()

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092494#comment-16092494 ] ASF GitHub Bot commented on FLINK-5541: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...

2017-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4315 PR had been updated. Please helps to check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-5541) Missing null check for localJar in FlinkSubmitter#submitTopology()

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092492#comment-16092492 ] ASF GitHub Bot commented on FLINK-5541: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...

2017-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4315 Oh my gosh, The newest checkstyle is very awesome, it can detect this kinda message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092482#comment-16092482 ] ASF GitHub Bot commented on FLINK-7134: --- GitHub user zhangminglei opened a pull request:

[GitHub] flink pull request #4362: [FLINK-7134] Remove hadoop1.x code in mapreduce.ut...

2017-07-18 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4362 [FLINK-7134] Remove hadoop1.x code in mapreduce.utils.HadoopUtils You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092481#comment-16092481 ] ASF GitHub Bot commented on FLINK-6075: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4263: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-07-18 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4263 Hi @fhueske , I left this comment under the JIRA. To make sure you know our situation, I post it here: >I think the most useful feature is PR3 "ORDER BY OFFSET FETCH" (i.e. TopN). It is

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092476#comment-16092476 ] Jark Wu commented on FLINK-7194: [~fhueske], even if we change {{ScalarFunction.getResultType()}} to

[jira] [Commented] (FLINK-7222) Kafka010ITCase fails on windows

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092466#comment-16092466 ] ASF GitHub Bot commented on FLINK-7222: --- GitHub user zjureel opened a pull request:

[GitHub] flink pull request #4361: [FLINK-7222] fix Kafka010ITCase fails on windows

2017-07-18 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4361 [FLINK-7222] fix Kafka010ITCase fails on windows Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[jira] [Commented] (FLINK-7134) Remove hadoop1.x code in mapreduce.utils.HadoopUtils

2017-07-18 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092465#comment-16092465 ] mingleizhang commented on FLINK-7134: - I will work on this soon enough. > Remove hadoop1.x code in

[jira] [Assigned] (FLINK-7222) Kafka010ITCase fails on windows

2017-07-18 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong reassigned FLINK-7222: Assignee: Fang Yong > Kafka010ITCase fails on windows > --- > >

[jira] [Updated] (FLINK-7222) Kafka010ITCase fails on windows

2017-07-18 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong updated FLINK-7222: - Description: Kafka010ITCase fails on windows for the following resions {code} java.lang.AssertionError:

[jira] [Created] (FLINK-7222) Kafka010ITCase fails on windows

2017-07-18 Thread Fang Yong (JIRA)
Fang Yong created FLINK-7222: Summary: Kafka010ITCase fails on windows Key: FLINK-7222 URL: https://issues.apache.org/jira/browse/FLINK-7222 Project: Flink Issue Type: Bug Components:

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-07-18 Thread hongyuhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092438#comment-16092438 ] hongyuhong commented on FLINK-6233: --- Hi [~fhueske], [~xccui] is now working on this issue, i will assign

[jira] [Assigned] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-07-18 Thread hongyuhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hongyuhong reassigned FLINK-6233: - Assignee: Xingcan Cui (was: hongyuhong) > Support rowtime inner equi-join between two streams

[jira] [Commented] (FLINK-7197) Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092415#comment-16092415 ] ASF GitHub Bot commented on FLINK-7197: --- Github user tedyu commented on the issue:

[GitHub] flink issue #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappi...

2017-07-18 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/4345 Fine by me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-7108) Implement Session cluster entry point

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092413#comment-16092413 ] ASF GitHub Bot commented on FLINK-7108: --- Github user EronWright commented on a diff in the pull

[GitHub] flink pull request #4281: [FLINK-7108] [yarn] Add YARN entry points based on...

2017-07-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4281#discussion_r128130195 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnJobClusterEntrypoint.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to the

[GitHub] flink issue #4345: [FLINK-7197] [gelly] Missing call to GraphAlgorithmWrappi...

2017-07-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4345 @tedyu does this look right to you now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-7197) Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092408#comment-16092408 ] ASF GitHub Bot commented on FLINK-7197: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-7140) include a UUID/random name into the BlobKey

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092407#comment-16092407 ] ASF GitHub Bot commented on FLINK-7140: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #4359: [FLINK-7140][blob] add an additional random compon...

2017-07-18 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4359#discussion_r128129730 --- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractID.java --- @@ -46,7 +46,7 @@ /** The lower part of the actual ID */

[jira] [Commented] (FLINK-7108) Implement Session cluster entry point

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092404#comment-16092404 ] ASF GitHub Bot commented on FLINK-7108: --- Github user EronWright commented on a diff in the pull

[GitHub] flink pull request #4281: [FLINK-7108] [yarn] Add YARN entry points based on...

2017-07-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4281#discussion_r128129505 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7108) Implement Session cluster entry point

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092400#comment-16092400 ] ASF GitHub Bot commented on FLINK-7108: --- Github user EronWright commented on a diff in the pull

[GitHub] flink pull request #4281: [FLINK-7108] [yarn] Add YARN entry points based on...

2017-07-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4281#discussion_r128129161 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7220) Update RocksDB dependency to 5.5.1

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092397#comment-16092397 ] ASF GitHub Bot commented on FLINK-7220: --- Github user greghogan commented on the issue:

[GitHub] flink issue #4360: [FLINK-7220] [checkpoints] Update RocksDB dependency to 5...

2017-07-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4360 RocksDB 5.5.5 looks to include the desired licensing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-7204) CombineHint.NONE

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092384#comment-16092384 ] ASF GitHub Bot commented on FLINK-7204: --- Github user greghogan commented on the issue:

[GitHub] flink issue #4350: [FLINK-7204] [core] CombineHint.NONE

2017-07-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4350 @fhueske updated and manually verified. I had misinterpreted `DriverStrategy` to imply that `SORTED_REDUCE` would not use a combiner. --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-7082) Flip-6: Generic entry point for Flink sessions

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092347#comment-16092347 ] ASF GitHub Bot commented on FLINK-7082: --- Github user EronWright commented on the issue:

[GitHub] flink issue #4261: [FLINK-7082] Add generic entry point for session and per-...

2017-07-18 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/4261 Looking at the various diagrams of FLIP-6, there's quite a few possible arrangements of the 'building blocks'. I wonder if composition over inheritance would be preferable as we develop the

[jira] [Commented] (FLINK-7143) Partition assignment for Kafka consumer is not stable

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092282#comment-16092282 ] ASF GitHub Bot commented on FLINK-7143: --- Github user stevenzwu commented on a diff in the pull

[GitHub] flink pull request #4357: (release-1.3) [FLINK-7143, FLINK-7195] Collection ...

2017-07-18 Thread stevenzwu
Github user stevenzwu commented on a diff in the pull request: https://github.com/apache/flink/pull/4357#discussion_r128113797 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@

[jira] [Commented] (FLINK-7082) Flip-6: Generic entry point for Flink sessions

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092263#comment-16092263 ] ASF GitHub Bot commented on FLINK-7082: --- Github user EronWright commented on a diff in the pull

[GitHub] flink pull request #4261: [FLINK-7082] Add generic entry point for session a...

2017-07-18 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4261#discussion_r128109508 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java --- @@ -0,0 +1,247 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-6998) Kafka connector needs to expose metrics for failed/successful offset commits in the Kafka Consumer callback

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092084#comment-16092084 ] ASF GitHub Bot commented on FLINK-6998: --- Github user zhenzhongxu commented on a diff in the pull

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-18 Thread zhenzhongxu
Github user zhenzhongxu commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r128078950 --- Diff: docs/monitoring/metrics.md --- @@ -896,6 +896,28 @@ Thus, in order to infer the metric identifier: + Connector:

[jira] [Commented] (FLINK-7220) Update RocksDB dependency to 5.5.1

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092016#comment-16092016 ] ASF GitHub Bot commented on FLINK-7220: --- Github user zentol commented on the issue:

[GitHub] flink issue #4360: [FLINK-7220] [checkpoints] Update RocksDB dependency to 5...

2017-07-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4360 We should still be able to switch back to the original RocksDB dependency. The licensing issue should also apply to frocksdb. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092012#comment-16092012 ] Chesnay Schepler commented on FLINK-7058: - 1.4: 8b59b4fcafba331dc03ef661919b497d845193aa >

[jira] [Closed] (FLINK-7162) Tests should not write outside 'target' directory.

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7162. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: 8a43b9c0b7b0272cd5076f206d3b42d14396d9d6

[jira] [Closed] (FLINK-7184) Activate checkstyle flink-java/hadoop

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7184. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: 0fd492caf9da900eb5edbc3c040b3337a19a75f3

[jira] [Closed] (FLINK-7183) Activate checkstyle flink-java/aggregation

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7183. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: afb85f5f15bf734163b88c3558851f24f50da2f6

[jira] [Closed] (FLINK-7189) Activate checkstyle flink-java/utils

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7189. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: 137463cd6651dd63fbc3d45796208cb359680d73

[jira] [Closed] (FLINK-6550) Calling ctx.collect with a null OutputTag should log a warning or throw an exception

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6550. --- Resolution: Fixed Assignee: Chesnay Schepler Fix Version/s: 1.4.0 1.4:

[jira] [Closed] (FLINK-7182) Activate checkstyle flink-java/functions

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7182. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: ec1044d985f24b9c1e45d1d25ef060a504e1695d

[jira] [Commented] (FLINK-7189) Activate checkstyle flink-java/utils

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091998#comment-16091998 ] ASF GitHub Bot commented on FLINK-7189: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-7186) Activate checkstyle flink-java/sampling

2017-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7186. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: 72678f1407fd24088edae3c96d33b90b43e21a0f

[jira] [Commented] (FLINK-7182) Activate checkstyle flink-java/functions

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091999#comment-16091999 ] ASF GitHub Bot commented on FLINK-7182: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7183) Activate checkstyle flink-java/aggregation

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091996#comment-16091996 ] ASF GitHub Bot commented on FLINK-7183: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7058) flink-scala-shell unintended dependencies for scala 2.11

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092001#comment-16092001 ] ASF GitHub Bot commented on FLINK-7058: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-6550) Calling ctx.collect with a null OutputTag should log a warning or throw an exception

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091997#comment-16091997 ] ASF GitHub Bot commented on FLINK-6550: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7184) Activate checkstyle flink-java/hadoop

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092000#comment-16092000 ] ASF GitHub Bot commented on FLINK-7184: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7162) Tests should not write outside 'target' directory.

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092002#comment-16092002 ] ASF GitHub Bot commented on FLINK-7162: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4240: [FLINK-7058] Fix scala-2.10 dependencies

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4311: [FLINK-7162] [test] Tests should not write outside...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4311 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4341: [FLINK-7184] Activate checkstyle flink-java/hadoop

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4339: [FLINK-7186] Activate checkstyle flink-java/sampli...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4336: [FLINK-7189] Activate checkstyle flink-java/utils

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4336 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4312: [FLINK-6550] Reject null OutputTags in Context#col...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7186) Activate checkstyle flink-java/sampling

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091995#comment-16091995 ] ASF GitHub Bot commented on FLINK-7186: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4333: [FLINK-7182] Activate checkstyle flink-java/functi...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4333 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4332: [FLINK-7183] Activate checkstyle flink-java/aggreg...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4332 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7103) Implement skeletal structure of dispatcher component

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091916#comment-16091916 ] ASF GitHub Bot commented on FLINK-7103: --- Github user EronWright commented on the issue:

[GitHub] flink issue #4260: [FLINK-7103] [dispatcher] Add skeletal structure of Dispa...

2017-07-18 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/4260 My take on this skeleton is that the `Dispatcher` should not use the `JobManagerRunner` directly. My rationale is: 1. The dispatcher should never execute user code, otherwise it cannot

[jira] [Updated] (FLINK-7209) Support DataView in Java and Scala Tuples and case classes or as the accumulator of AggregateFunction itself

2017-07-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7209: -- Component/s: (was: State Backends, Checkpointing) Table API & SQL >

[jira] [Updated] (FLINK-7208) Refactor build-in agg(MaxWithRetractAccumulator and MinWithRetractAccumulator) using the DataView

2017-07-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7208: -- Component/s: Table API & SQL > Refactor build-in agg(MaxWithRetractAccumulator and >

[jira] [Updated] (FLINK-7210) Add TwoPhaseCommitSinkFunction (implementing exactly-once semantic in generic way)

2017-07-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7210: -- Component/s: Streaming Connectors > Add TwoPhaseCommitSinkFunction (implementing exactly-once

[jira] [Updated] (FLINK-7197) Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith()

2017-07-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7197: -- Component/s: Gelly > Missing call to GraphAlgorithmWrappingBase#canMergeConfigurationWith() >

[jira] [Updated] (FLINK-7209) Support DataView in Java and Scala Tuples and case classes or as the accumulator of AggregateFunction itself

2017-07-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7209: -- Component/s: State Backends, Checkpointing > Support DataView in Java and Scala Tuples and case

[jira] [Updated] (FLINK-7220) Update RocksDB dependency to 5.5.1

2017-07-18 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7220: -- Component/s: State Backends, Checkpointing > Update RocksDB dependency to 5.5.1 >

[jira] [Created] (FLINK-7221) JDBCOutputFormat swallows errors on last batch

2017-07-18 Thread Ken Geis (JIRA)
Ken Geis created FLINK-7221: --- Summary: JDBCOutputFormat swallows errors on last batch Key: FLINK-7221 URL: https://issues.apache.org/jira/browse/FLINK-7221 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-7102) improve ClassLoaderITCase

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091780#comment-16091780 ] ASF GitHub Bot commented on FLINK-7102: --- Github user NicoK commented on the issue:

[GitHub] flink issue #4255: [FLINK-7102] improve ClassLoaderITCase

2017-07-18 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4255 you're right - wasn't looking thoroughly enough (and only recently learned about `ExpectedException`). Additionally, I found out that this ignored exception was actually required to be thrown

[jira] [Commented] (FLINK-7220) Update RocksDB dependency to 5.5.1

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091727#comment-16091727 ] ASF GitHub Bot commented on FLINK-7220: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #4360: [FLINK-7220] [checkpoints] Update RocksDB dependency to 5...

2017-07-18 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4360 Just noticed that the license is not updated in the 5.5.1 branch, but only in master. So I guess this means we have to wait for a release that has the updated Apache compatible license? ---

[jira] [Commented] (FLINK-7162) Tests should not write outside 'target' directory.

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091720#comment-16091720 ] ASF GitHub Bot commented on FLINK-7162: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #4311: [FLINK-7162] [test] Tests should not write outside 'targe...

2017-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4311 Thanks to zentol. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (FLINK-7118) Remove hadoop1.x code in HadoopUtils

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091713#comment-16091713 ] ASF GitHub Bot commented on FLINK-7118: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #4285: [FLINK-7118] [hadoop] Remove hadoop1.x code in Had...

2017-07-18 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4285#discussion_r128009928 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/hadoop/mapred/HadoopOutputFormatBase.java --- @@ -126,18 +128,18 @@ public void open(int

[jira] [Commented] (FLINK-7141) enable travis cache again

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091699#comment-16091699 ] ASF GitHub Bot commented on FLINK-7141: --- Github user zentol commented on the issue:

[GitHub] flink issue #4360: [FLINK-7220] [checkpoints] Update RocksDB dependency to 5...

2017-07-18 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4360 CC @aljoscha - suggesting to add this change also to the 1.3.2 release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-7220) Update RocksDB dependency to 5.5.1

2017-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091702#comment-16091702 ] ASF GitHub Bot commented on FLINK-7220: --- Github user StefanRRichter commented on the issue:

  1   2   3   >