[jira] [Commented] (FLINK-7366) Upgrade kinesis producer library, kinesis client library, and AWS SDK in flink-connector-kinesis

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124822#comment-16124822 ] ASF GitHub Bot commented on FLINK-7366: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4522: [FLINK-7366][kinesis connector] Upgrade kinesis producer ...

2017-08-12 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4522 @tzulitai OK, I only upgraded KPL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-7367) Parameterize more configs for FlinkKinesisProducer (RecordMaxBufferedTime, MaxConnections, RequestTimeout, etc)

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124821#comment-16124821 ] ASF GitHub Bot commented on FLINK-7367: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4473: [FLINK-7367][kinesis connector] Parameterize more configs...

2017-08-12 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4473 @tzulitai Let me know what you think about this PR now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-7423) Always reuse an instance to get elements from the inputFormat

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124791#comment-16124791 ] ASF GitHub Bot commented on FLINK-7423: --- Github user XuPingyong commented on the issue:

[GitHub] flink issue #4525: [FLINK-7423] Always reuse an instance to get elements fro...

2017-08-12 Thread XuPingyong
Github user XuPingyong commented on the issue: https://github.com/apache/flink/pull/4525 @greghogan, if the object passed to nextRecord may be reused internally by the InputFormat, do the similar cases need to be re-considered? In `DataSourceTask.java`:

[jira] [Created] (FLINK-7438) Some classes are eclipsed by classes in package scala

2017-08-12 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7438: - Summary: Some classes are eclipsed by classes in package scala Key: FLINK-7438 URL: https://issues.apache.org/jira/browse/FLINK-7438 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124639#comment-16124639 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4532: [FLINK-7337] [table] Refactor internal handling of...

2017-08-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4532#discussion_r132822158 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -667,30 +719,62 @@ abstract class

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124631#comment-16124631 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on the issue:

[GitHub] flink issue #4488: [FLINK-7337] [table] Refactor internal handling of time i...

2017-08-12 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4488 @wuchong could you take a look at #4532 as well? It is based on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Closed] (FLINK-7437) Upgrade calcite to calcite 1.14

2017-08-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-7437. --- Resolution: Duplicate This is a duplicate of FLINK-7051. > Upgrade calcite to calcite 1.14 >

[jira] [Commented] (FLINK-7169) Support AFTER MATCH SKIP function in CEP library API

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124622#comment-16124622 ] ASF GitHub Bot commented on FLINK-7169: --- Github user yestinchen commented on the issue:

[GitHub] flink issue #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP function in CE...

2017-08-12 Thread yestinchen
Github user yestinchen commented on the issue: https://github.com/apache/flink/pull/4331 Thanks for your reviews @dawidwys ! I'll update the doc in the following commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Created] (FLINK-7437) Upgrade calcite to calcite 1.14

2017-08-12 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7437: - Summary: Upgrade calcite to calcite 1.14 Key: FLINK-7437 URL: https://issues.apache.org/jira/browse/FLINK-7437 Project: Flink Issue Type: Task Reporter: Ted

[jira] [Commented] (FLINK-7410) Add getName method to UserDefinedFunction

2017-08-12 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124621#comment-16124621 ] Jark Wu commented on FLINK-7410: How about using the `toString()` method to return the custom display

[jira] [Commented] (FLINK-6738) HBaseConnectorITCase is flaky

2017-08-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124619#comment-16124619 ] Ted Yu commented on FLINK-6738: --- With CALCITE-1859 fixed, let's see if the test passes when Calcite 1.14

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124611#comment-16124611 ] ASF GitHub Bot commented on FLINK-7337: --- Github user xccui commented on a diff in the pull request:

[GitHub] flink pull request #4532: [FLINK-7337] [table] Refactor internal handling of...

2017-08-12 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4532#discussion_r132820853 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -667,30 +719,62 @@ abstract class

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124604#comment-16124604 ] ASF GitHub Bot commented on FLINK-7416: --- GitHub user zhijiangW opened a pull request:

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-08-12 Thread zhijiangW
GitHub user zhijiangW opened a pull request: https://github.com/apache/flink/pull/4533 [FLINK-7416][network] Implement Netty receiver outgoing pipeline for credit-based ## What is the purpose of the change The receiver notifies the available buffers called unannounced

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-12 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r132819009 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/CRowInputTupleOutputMapRunner.scala --- @@ -19,7 +19,9 @@ package

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-12 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r132817997 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1247,27 +1258,32 @@ abstract class

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124601#comment-16124601 ] ASF GitHub Bot commented on FLINK-7337: --- Github user wuchong commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124600#comment-16124600 ] ASF GitHub Bot commented on FLINK-7337: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-12 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r132818559 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamTableSourceScan.scala --- @@ -46,29 +47,29 @@ class

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-12 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4488#discussion_r132819122 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/WrappingTimestampSetterProcessFunction.scala --- @@ -0,0 +1,61 @@

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124599#comment-16124599 ] ASF GitHub Bot commented on FLINK-7337: --- Github user wuchong commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124602#comment-16124602 ] ASF GitHub Bot commented on FLINK-7337: --- Github user wuchong commented on a diff in the pull

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124588#comment-16124588 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4532: [FLINK-7337] [table] Refactor internal handling of...

2017-08-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4532#discussion_r132819240 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -667,30 +719,62 @@ abstract class

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124586#comment-16124586 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4532: [FLINK-7337] [table] Refactor internal handling of...

2017-08-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4532#discussion_r132819174 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -667,30 +719,62 @@ abstract class

[jira] [Created] (FLINK-7435) FsStateBackend with incremental backup enable does not work with Keyed CEP

2017-08-12 Thread daiqing (JIRA)
daiqing created FLINK-7435: -- Summary: FsStateBackend with incremental backup enable does not work with Keyed CEP Key: FLINK-7435 URL: https://issues.apache.org/jira/browse/FLINK-7435 Project: Flink

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124556#comment-16124556 ] ASF GitHub Bot commented on FLINK-7337: --- Github user xccui commented on a diff in the pull request:

[GitHub] flink pull request #4532: [FLINK-7337] [table] Refactor internal handling of...

2017-08-12 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4532#discussion_r132817252 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -667,30 +719,62 @@ abstract class

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124548#comment-16124548 ] ASF GitHub Bot commented on FLINK-7337: --- GitHub user twalthr opened a pull request:

[GitHub] flink pull request #4532: [FLINK-7337] [table] Refactor internal handling of...

2017-08-12 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/4532 [FLINK-7337] [table] Refactor internal handling of time indicator attributes and efficiency ## What is the purpose of the change *This PR is an improvement of @fhueske's PR #4488. For an

[GitHub] flink issue #4525: [FLINK-7423] Always reuse an instance to get elements fro...

2017-08-12 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4525 As I understand Flink does not allow `null` records since what does it mean to partition or window a null record? `null` fields are sometimes allowed but `null` records are meaningless.

[jira] [Commented] (FLINK-7423) Always reuse an instance to get elements from the inputFormat

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124538#comment-16124538 ] ASF GitHub Bot commented on FLINK-7423: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-7434) Scafolding of a scala project should rely on "sbt new"

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124533#comment-16124533 ] ASF GitHub Bot commented on FLINK-7434: --- GitHub user sv3nd opened a pull request:

[GitHub] flink pull request #4531: [FLINK-7434][doc] scafolding with "sbt new"

2017-08-12 Thread sv3nd
GitHub user sv3nd opened a pull request: https://github.com/apache/flink/pull/4531 [FLINK-7434][doc] scafolding with "sbt new" ## What is the purpose of the change Current [documentation for scala project scafolding from

[jira] [Updated] (FLINK-7434) Scafolding of a scala project should rely on "sbt new"

2017-08-12 Thread Svend Vanderveken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Svend Vanderveken updated FLINK-7434: - Summary: Scafolding of a scala project should rely on "sbt new" (was: Scafolding of an

[jira] [Created] (FLINK-7434) Scafolding of an scala project should rely on "sbt new"

2017-08-12 Thread Svend Vanderveken (JIRA)
Svend Vanderveken created FLINK-7434: Summary: Scafolding of an scala project should rely on "sbt new" Key: FLINK-7434 URL: https://issues.apache.org/jira/browse/FLINK-7434 Project: Flink

[jira] [Commented] (FLINK-7426) Table API does not support null values in keys

2017-08-12 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124525#comment-16124525 ] Jark Wu commented on FLINK-7426: Shouldn't this be pushed into DataStream component? I'm just worry about

[jira] [Commented] (FLINK-7423) Always reuse an instance to get elements from the inputFormat

2017-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124497#comment-16124497 ] ASF GitHub Bot commented on FLINK-7423: --- Github user XuPingyong commented on the issue:

[GitHub] flink issue #4525: [FLINK-7423] Always reuse an instance to get elements fro...

2017-08-12 Thread XuPingyong
Github user XuPingyong commented on the issue: https://github.com/apache/flink/pull/4525 Thanks @greghogan. I think the InputFormat can return anything, may be null or other immutable objects that cannot be passed to nextRecord. And I am also not clear why

[jira] [Commented] (FLINK-4500) Cassandra sink can lose messages

2017-08-12 Thread Michael Fong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124486#comment-16124486 ] Michael Fong commented on FLINK-4500: - Hi, I would like to help implement Checkpointed in