[GitHub] flink pull request #5171: [FLINK-8271][Kinesis connector] upgrade deprecated...

2018-01-02 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5171#discussion_r159362925 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/AWSUtil.java --- @@ -30,37 +30,44 @@

[jira] [Commented] (FLINK-8271) upgrade from deprecated classes to AmazonKinesis

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309184#comment-16309184 ] ASF GitHub Bot commented on FLINK-8271: --- Github user bowenli86 commented on a diff in the pull

[jira] [Commented] (FLINK-8271) upgrade from deprecated classes to AmazonKinesis

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309185#comment-16309185 ] ASF GitHub Bot commented on FLINK-8271: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #5171: [FLINK-8271][Kinesis connector] upgrade deprecated...

2018-01-02 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5171#discussion_r159363827 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/AWSUtil.java --- @@ -30,37 +30,44 @@

[jira] [Commented] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309169#comment-16309169 ] ASF GitHub Bot commented on FLINK-8175: --- Github user bowenli86 commented on the issue:

[jira] [Commented] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309170#comment-16309170 ] ASF GitHub Bot commented on FLINK-8175: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5112: [FLINK-8175] [DataStream API java/scala] remove flink-str...

2018-01-02 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5112 @StephanEwen @tillrohrmann let me know if you have more concerns ---

[jira] [Commented] (FLINK-8217) Properly annotate APIs of flink-connector-kinesis

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309168#comment-16309168 ] ASF GitHub Bot commented on FLINK-8217: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5112: [FLINK-8175] [DataStream API java/scala] remove flink-str...

2018-01-02 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5112 @StephanEwen let me know if you have more concerns ---

[jira] [Commented] (FLINK-7475) support update() in ListState

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309167#comment-16309167 ] ASF GitHub Bot commented on FLINK-7475: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5138: [FLINK-8217] [Kinesis connector] Properly annotate APIs o...

2018-01-02 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5138 @tzulitai The PR has been updated ---

[GitHub] flink issue #4963: [FLINK-7475] [core][DataStream API] support update() in L...

2018-01-02 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4963 @yunfan123 @aljoscha @StefanRRichter feedbacks are appreciated ---

[jira] [Commented] (FLINK-7935) Metrics with user supplied scope variables

2018-01-02 Thread Wei-Che Wei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309048#comment-16309048 ] Wei-Che Wei commented on FLINK-7935: Hi [~elevy] Since FLINK-7692 was solved, user can use

[jira] [Created] (FLINK-8352) Flink UI Reports No Error on Job Submission Failures

2018-01-02 Thread Elias Levy (JIRA)
Elias Levy created FLINK-8352: - Summary: Flink UI Reports No Error on Job Submission Failures Key: FLINK-8352 URL: https://issues.apache.org/jira/browse/FLINK-8352 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-8351) Canonical way to extract FoldingState QueryableStateStream

2018-01-02 Thread Raymond Tay (JIRA)
Raymond Tay created FLINK-8351: -- Summary: Canonical way to extract FoldingState QueryableStateStream Key: FLINK-8351 URL: https://issues.apache.org/jira/browse/FLINK-8351 Project: Flink Issue

[jira] [Commented] (FLINK-8327) ClassLoader resolution of child-first does not appear to work

2018-01-02 Thread Raymond Tay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308983#comment-16308983 ] Raymond Tay commented on FLINK-8327: Yes, the fat-jar does contain Akka classes and like yourself, i

[jira] [Updated] (FLINK-8322) support getting number of existing timers in TimerService

2018-01-02 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8322: Fix Version/s: 1.5.0 > support getting number of existing timers in TimerService >

[jira] [Commented] (FLINK-8265) Missing jackson dependency for flink-mesos

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308673#comment-16308673 ] ASF GitHub Bot commented on FLINK-8265: --- Github user EronWright commented on the issue:

[GitHub] flink issue #5208: [FLINK-8265] [Mesos] Missing jackson dependency for flink...

2018-01-02 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/5208 @aljoscha please review ---

[jira] [Commented] (FLINK-8314) Add support for Kinesis Firehose

2018-01-02 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308524#comment-16308524 ] Bowen Li commented on FLINK-8314: - [~aljoscha] I believe this is unnecessary. First, Firehose (FH) is

[jira] [Commented] (FLINK-8305) Docker port mapping doesn't work for JobManager RPC port on Official Flink image

2018-01-02 Thread Thomas Wozniakowski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308452#comment-16308452 ] Thomas Wozniakowski commented on FLINK-8305: Hi Aljoscha, Thanks for responding! I actually

[jira] [Commented] (FLINK-8279) Use Mesos/YARN temp directories as fallback for BlobServer/Cache temp directories

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308448#comment-16308448 ] ASF GitHub Bot commented on FLINK-8279: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5176: [FLINK-8279][blob] fall back to TaskManager temp director...

2018-01-02 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5176 For the change regarding the JobManager use of a TaskManager configuration parameter, I created a separate issue and included the appropriate commits here (FLINK-8250) as this commit probably does not

[jira] [Created] (FLINK-8350) replace "taskmanager.tmp.dirs" with "env.io.tmp.dirs" for all components

2018-01-02 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-8350: -- Summary: replace "taskmanager.tmp.dirs" with "env.io.tmp.dirs" for all components Key: FLINK-8350 URL: https://issues.apache.org/jira/browse/FLINK-8350 Project: Flink

[jira] [Comment Edited] (FLINK-8334) Elasticsearch Connector throwing java.lang.ClassNotFoundException: org.jboss.netty.channel.socket.nio.SocketSendBufferPool$GatheringSendBuffer

2018-01-02 Thread Bhaskar Divya (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308330#comment-16308330 ] Bhaskar Divya edited comment on FLINK-8334 at 1/2/18 4:37 PM: -- Thanks

[jira] [Commented] (FLINK-8334) Elasticsearch Connector throwing java.lang.ClassNotFoundException: org.jboss.netty.channel.socket.nio.SocketSendBufferPool$GatheringSendBuffer

2018-01-02 Thread Bhaskar Divya (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308330#comment-16308330 ] Bhaskar Divya commented on FLINK-8334: -- Thanks [~aljoscha]. I think I got it working now.(no more

[jira] [Commented] (FLINK-8265) Missing jackson dependency for flink-mesos

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308328#comment-16308328 ] ASF GitHub Bot commented on FLINK-8265: --- Github user jaredstehler commented on the issue:

[GitHub] flink issue #5208: [FLINK-8265] [Mesos] Missing jackson dependency for flink...

2018-01-02 Thread jaredstehler
Github user jaredstehler commented on the issue: https://github.com/apache/flink/pull/5208 looks good to me, thanks! ---

[jira] [Commented] (FLINK-6206) As an Engineer, I want task state transition log to be warn/error for FAILURE scenarios

2018-01-02 Thread Dan Bress (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308303#comment-16308303 ] Dan Bress commented on FLINK-6206: -- This is definitely relevant in 1.2.0, without this is very hard to

[jira] [Closed] (FLINK-8272) 1.4 & Scala: Exception when querying the state

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-8272. --- Resolution: Not A Problem Fix Version/s: (was: 1.4.0) > 1.4 & Scala: Exception

[jira] [Reopened] (FLINK-8272) 1.4 & Scala: Exception when querying the state

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reopened FLINK-8272: - Reopen to change resolution. > 1.4 & Scala: Exception when querying the state >

[jira] [Commented] (FLINK-8282) Transformation with TwoInputStreamOperator fails

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308293#comment-16308293 ] Aljoscha Krettek commented on FLINK-8282: - In my opinion, there is no good separation of concerns

[jira] [Commented] (FLINK-8284) Custom metrics not being exposed for Prometheus

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308280#comment-16308280 ] Aljoscha Krettek commented on FLINK-8284: - [~Zentol] Could you please have a look at this? >

[jira] [Commented] (FLINK-8305) Docker port mapping doesn't work for JobManager RPC port on Official Flink image

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308269#comment-16308269 ] Aljoscha Krettek commented on FLINK-8305: - This is a known issue based on a "feature" of Akka:

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308243#comment-16308243 ] ASF GitHub Bot commented on FLINK-8332: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5219#discussion_r159249258 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -659,128 +655,107 @@ protected int savepoint(String[] args) {

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308233#comment-16308233 ] ASF GitHub Bot commented on FLINK-8332: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5219#discussion_r159248959 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -659,128 +655,107 @@ protected int savepoint(String[] args) {

[jira] [Commented] (FLINK-8314) Add support for Kinesis Firehose

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308230#comment-16308230 ] Aljoscha Krettek commented on FLINK-8314: - So this would essentially be another connector that is

[jira] [Commented] (FLINK-8315) Use AWSCredentialsProvider to get AWS credentials

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308225#comment-16308225 ] Aljoscha Krettek commented on FLINK-8315: - I think this makes sense, but I'm not too familiar with

[GitHub] flink pull request #5192: [FLINK-8257] [conf] Unify the value checks for set...

2018-01-02 Thread xccui
Github user xccui closed the pull request at: https://github.com/apache/flink/pull/5192 ---

[jira] [Commented] (FLINK-8257) Unify the value checks for setParallelism()

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308219#comment-16308219 ] ASF GitHub Bot commented on FLINK-8257: --- Github user xccui closed the pull request at:

[jira] [Comment Edited] (FLINK-8318) Conflict jackson library with ElasticSearch connector

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308217#comment-16308217 ] Aljoscha Krettek edited comment on FLINK-8318 at 1/2/18 3:28 PM: - Do you

[jira] [Commented] (FLINK-8257) Unify the value checks for setParallelism()

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308218#comment-16308218 ] ASF GitHub Bot commented on FLINK-8257: --- Github user xccui commented on the issue:

[jira] [Commented] (FLINK-8318) Conflict jackson library with ElasticSearch connector

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308217#comment-16308217 ] Aljoscha Krettek commented on FLINK-8318: - Do you have a specific reason for using `parent-first`.

[GitHub] flink issue #5192: [FLINK-8257] [conf] Unify the value checks for setParalle...

2018-01-02 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5192 Thanks for the review, @aljoscha 😄 . I'll close this PR. ---

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308212#comment-16308212 ] ASF GitHub Bot commented on FLINK-8317: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r159247245 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java --- @@ -27,11 +27,16 @@ import java.util.concurrent.TimeoutException;

[jira] [Commented] (FLINK-8322) support getting number of existing timers in TimerService

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308201#comment-16308201 ] Aljoscha Krettek commented on FLINK-8322: - Yes, I think one (maybe the best) solution is to keep

[jira] [Commented] (FLINK-8326) CheckpointCoordinatorTest#testRestoreLatestCheckpointedStateScaleOut() didn't use the correct parameter to trigger test function

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308198#comment-16308198 ] ASF GitHub Bot commented on FLINK-8326: --- Github user tony810430 closed the pull request at:

[jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308196#comment-16308196 ] ASF GitHub Bot commented on FLINK-8332: --- Github user GJL commented on the issue:

[GitHub] flink pull request #5211: [FLINK-8326] [checkpoints] CheckpointCoordinatorTe...

2018-01-02 Thread tony810430
Github user tony810430 closed the pull request at: https://github.com/apache/flink/pull/5211 ---

[GitHub] flink issue #5219: [FLINK-8332] [flip6] Move savepoint dispose into ClusterC...

2018-01-02 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5219 This PR is based on #5216 ---

[jira] [Commented] (FLINK-8326) CheckpointCoordinatorTest#testRestoreLatestCheckpointedStateScaleOut() didn't use the correct parameter to trigger test function

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308191#comment-16308191 ] ASF GitHub Bot commented on FLINK-8326: --- Github user aljoscha commented on the issue:

[jira] [Closed] (FLINK-8326) CheckpointCoordinatorTest#testRestoreLatestCheckpointedStateScaleOut() didn't use the correct parameter to trigger test function

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-8326. --- Resolution: Fixed Fix Version/s: 1.5.0 Fixed on master in

[GitHub] flink issue #5211: [FLINK-8326] [checkpoints] CheckpointCoordinatorTest#test...

2018-01-02 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5211 Thanks a lot for catching this! 👍 I merged, could you please close this PR? ---

[jira] [Commented] (FLINK-8329) Move YarnClient out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308185#comment-16308185 ] ASF GitHub Bot commented on FLINK-8329: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8329) Move YarnClient out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308184#comment-16308184 ] ASF GitHub Bot commented on FLINK-8329: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8329) Move YarnClient out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308186#comment-16308186 ] ASF GitHub Bot commented on FLINK-8329: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5216: [FLINK-8329] [flip6] Move YarnClient to AbstractYa...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5216#discussion_r159243077 --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java --- @@ -272,6 +275,7 @@ public void testJavaAPI() throws Exception {

[GitHub] flink pull request #5216: [FLINK-8329] [flip6] Move YarnClient to AbstractYa...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5216#discussion_r159243765 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -143,31 +138,48 @@ private

[GitHub] flink pull request #5216: [FLINK-8329] [flip6] Move YarnClient to AbstractYa...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5216#discussion_r159242946 --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java --- @@ -78,6 +83,9 @@ public void testPerJobMode() {

[jira] [Commented] (FLINK-8327) ClassLoader resolution of child-first does not appear to work

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308180#comment-16308180 ] Aljoscha Krettek commented on FLINK-8327: - So the fat-jar contains the Akka classes? I think the

[jira] [Commented] (FLINK-8334) Elasticsearch Connector throwing java.lang.ClassNotFoundException: org.jboss.netty.channel.socket.nio.SocketSendBufferPool$GatheringSendBuffer

2018-01-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308168#comment-16308168 ] Aljoscha Krettek commented on FLINK-8334: - Could you check if your jar files contain any netty

[jira] [Created] (FLINK-8349) Remove Yarn specific commands from YarnClusterClient

2018-01-02 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8349: Summary: Remove Yarn specific commands from YarnClusterClient Key: FLINK-8349 URL: https://issues.apache.org/jira/browse/FLINK-8349 Project: Flink Issue

[GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability

2018-01-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5193#discussion_r159238089 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java --- @@ -98,7 +99,13 @@

[jira] [Commented] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308151#comment-16308151 ] ASF GitHub Bot commented on FLINK-8268: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8119) Cannot submit jobs to YARN Session in FLIP-6 mode

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308146#comment-16308146 ] ASF GitHub Bot commented on FLINK-8119: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5234: [FLINK-8119] [flip6] Wire correct Flip6 components...

2018-01-02 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5234 [FLINK-8119] [flip6] Wire correct Flip6 components in Flip6YarnClusterDescriptor ## What is the purpose of the change Let the Flip6YarnClusterDescriptor create a RestClusterClient as

[jira] [Commented] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308134#comment-16308134 ] ASF GitHub Bot commented on FLINK-8268: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability

2018-01-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5193#discussion_r159229650 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/AbstractStreamOperatorTestHarness.java --- @@ -492,6 +503,10 @@ public void

[GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability

2018-01-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5193#discussion_r159235730 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/SourceFunctionUtil.java --- @@ -42,22 +41,32 @@ public class

[jira] [Commented] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308135#comment-16308135 ] ASF GitHub Bot commented on FLINK-8268: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308132#comment-16308132 ] ASF GitHub Bot commented on FLINK-8268: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308137#comment-16308137 ] ASF GitHub Bot commented on FLINK-8268: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308133#comment-16308133 ] ASF GitHub Bot commented on FLINK-8268: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability

2018-01-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5193#discussion_r159220879 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/ContentDump.java --- @@ -0,0 +1,134 @@ +/* + *

[jira] [Commented] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308136#comment-16308136 ] ASF GitHub Bot commented on FLINK-8268: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308131#comment-16308131 ] ASF GitHub Bot commented on FLINK-8268: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability

2018-01-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5193#discussion_r15950 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/TaskTestBase.java --- @@ -145,19 +145,7 @@ public MemoryManager

[GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability

2018-01-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5193#discussion_r159221102 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/ContentDump.java --- @@ -0,0 +1,134 @@ +/* + *

[GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability

2018-01-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5193#discussion_r159221837 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/ContentDump.java --- @@ -0,0 +1,134 @@ +/* + *

[GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability

2018-01-02 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5193#discussion_r159224671 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -179,9 +179,6 @@

[jira] [Updated] (FLINK-8119) Cannot submit jobs to YARN Session in FLIP-6 mode

2018-01-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-8119: - Issue Type: Sub-task (was: Bug) Parent: FLINK-4352 > Cannot submit jobs to YARN Session

[jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308116#comment-16308116 ] ASF GitHub Bot commented on FLINK-8328: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308122#comment-16308122 ] ASF GitHub Bot commented on FLINK-8328: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5215#discussion_r159227619 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -717,7 +645,26 @@ public int run(

[jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308120#comment-16308120 ] ASF GitHub Bot commented on FLINK-8328: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5215#discussion_r159226314 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -660,7 +570,25 @@ public int run(

[jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308118#comment-16308118 ] ASF GitHub Bot commented on FLINK-8328: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308119#comment-16308119 ] ASF GitHub Bot commented on FLINK-8328: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308121#comment-16308121 ] ASF GitHub Bot commented on FLINK-8328: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5215#discussion_r159224695 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -743,6 +690,142 @@ private void logAndSysout(String message) {

[GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5215#discussion_r159225871 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/YarnApplicationStatusMonitor.java --- @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5215#discussion_r159227955 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -660,7 +570,25 @@ public int run(

[jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308115#comment-16308115 ] ASF GitHub Bot commented on FLINK-8328: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5215#discussion_r159228367 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -717,7 +645,26 @@ public int run(

[jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308117#comment-16308117 ] ASF GitHub Bot commented on FLINK-8328: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...

2018-01-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5215#discussion_r159230885 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -743,6 +690,142 @@ private void logAndSysout(String message) {

[jira] [Commented] (FLINK-8348) Print help for DefaultCLI

2018-01-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308113#comment-16308113 ] ASF GitHub Bot commented on FLINK-8348: --- GitHub user tillrohrmann opened a pull request:

  1   2   >