[jira] [Commented] (FLINK-7641) Loss of JobManager in HA mode should not cause jobs to fail

2018-02-22 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374050#comment-16374050 ] vinoyang commented on FLINK-7641: - Hi [~elevy] , I think what your meaning is  standalone HA mode "Job

[jira] [Commented] (FLINK-8745) Reduce travis usage

2018-02-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374049#comment-16374049 ] Stephan Ewen commented on FLINK-8745: - +1 for moving the Hadoop / Scala Matrix to Cron builds and I

[jira] [Created] (FLINK-8754) TaskManagerInfo is not serializable

2018-02-22 Thread Gary Yao (JIRA)
Gary Yao created FLINK-8754: --- Summary: TaskManagerInfo is not serializable Key: FLINK-8754 URL: https://issues.apache.org/jira/browse/FLINK-8754 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-8754) TaskManagerInfo is not serializable

2018-02-22 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8754: Labels: flip-6 (was: ) > TaskManagerInfo is not serializable > --- > >

[jira] [Assigned] (FLINK-7641) Loss of JobManager in HA mode should not cause jobs to fail

2018-02-22 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-7641: --- Assignee: vinoyang > Loss of JobManager in HA mode should not cause jobs to fail >

[jira] [Commented] (FLINK-8753) Introduce Incremental savepoint

2018-02-22 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374039#comment-16374039 ] Gyula Fora commented on FLINK-8753: --- Alternatively we could expose the external triggering of

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374018#comment-16374018 ] ASF GitHub Bot commented on FLINK-8656: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5487#discussion_r170179361 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -447,6 +453,165 @@ public void postStop() throws Exception {

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5487#discussion_r170179289 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/RescaleParallelismQueryParameter.java --- @@ -0,0 +1,41 @@ +/* + *

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374017#comment-16374017 ] ASF GitHub Bot commented on FLINK-8656: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374016#comment-16374016 ] ASF GitHub Bot commented on FLINK-8656: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-22 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5487#discussion_r170179272 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -447,6 +453,165 @@ public void postStop() throws Exception {

[jira] [Commented] (FLINK-8459) Implement cancelWithSavepoint in RestClusterClient

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374012#comment-16374012 ] ASF GitHub Bot commented on FLINK-8459: --- GitHub user yanghua opened a pull request:

[GitHub] flink pull request #5565: [FLINK-8459][flip6] Implement cancelWithSavepoint ...

2018-02-22 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/5565 [FLINK-8459][flip6] Implement cancelWithSavepoint in RestClusterClient ## What is the purpose of the change This pull request implements cancelWithSavepoint in RestClusterClient for flip6.

[jira] [Assigned] (FLINK-7219) Current allocate strategy cann‘t achieve the optimal effect with input's location

2018-02-22 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou reassigned FLINK-7219: - Assignee: (was: Sihua Zhou) > Current allocate strategy cann‘t achieve the optimal effect

[jira] [Commented] (FLINK-8601) Introduce PartitionedBloomFilter for Approximate calculation and other situations of performance optimization

2018-02-22 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373978#comment-16373978 ] Sihua Zhou commented on FLINK-8601: --- [~aljoscha] Do you have any advice on this? How about I submit a PR

[jira] [Commented] (FLINK-8602) Accelerate recover from failover when use incremental checkpoint

2018-02-22 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373970#comment-16373970 ] Sihua Zhou commented on FLINK-8602: --- [~stefanrichte...@gmail.com] Could you please have a look at this?

[jira] [Updated] (FLINK-8602) Accelerate recover from failover when use incremental checkpoint

2018-02-22 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou updated FLINK-8602: -- Description: Currently, when enable incremental checkpoint, if user change the parallelism then

[jira] [Commented] (FLINK-8753) Introduce Incremental savepoint

2018-02-22 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373962#comment-16373962 ] Sihua Zhou commented on FLINK-8753: --- [~stefanrichte...@gmail.com] What do you think? > Introduce

[jira] [Updated] (FLINK-8753) Introduce Incremental savepoint

2018-02-22 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou updated FLINK-8753: -- Description: Right now, savepoint goes through the full checkpoint path, take a savepoint could be

[jira] [Created] (FLINK-8753) Introduce Incremental savepoint

2018-02-22 Thread Sihua Zhou (JIRA)
Sihua Zhou created FLINK-8753: - Summary: Introduce Incremental savepoint Key: FLINK-8753 URL: https://issues.apache.org/jira/browse/FLINK-8753 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-8667) expose key in KeyedBroadcastProcessFunction#onTimer()

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373953#comment-16373953 ] ASF GitHub Bot commented on FLINK-8667: --- Github user bowenli86 commented on the issue:

[jira] [Commented] (FLINK-8752) ClassNotFoundException when using the user code class loader

2018-02-22 Thread Elias Levy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373954#comment-16373954 ] Elias Levy commented on FLINK-8752: --- Some other information:  Cluster is configured in HA mode with S3

[GitHub] flink issue #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFunction#...

2018-02-22 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5500 Hi @aljoscha , can you take a look? ---

[jira] [Created] (FLINK-8752) ClassNotFoundException when using the user code class loader

2018-02-22 Thread Elias Levy (JIRA)
Elias Levy created FLINK-8752: - Summary: ClassNotFoundException when using the user code class loader Key: FLINK-8752 URL: https://issues.apache.org/jira/browse/FLINK-8752 Project: Flink Issue

[jira] [Created] (FLINK-8751) Canceling a job results in a InterruptedException in the JM

2018-02-22 Thread Elias Levy (JIRA)
Elias Levy created FLINK-8751: - Summary: Canceling a job results in a InterruptedException in the JM Key: FLINK-8751 URL: https://issues.apache.org/jira/browse/FLINK-8751 Project: Flink Issue

[jira] [Commented] (FLINK-8458) Add the switch for keeping both the old mode and the new credit-based mode

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373865#comment-16373865 ] ASF GitHub Bot commented on FLINK-8458: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #5317: [FLINK-8458] Add the switch for keeping both the old mode...

2018-02-22 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/5317 @pnowojski , thanks for your messages and I already updated the commit as you suggested. ---

[jira] [Commented] (FLINK-8747) The tag of waiting for floating buffers in RemoteInputChannel should be updated properly

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373816#comment-16373816 ] ASF GitHub Bot commented on FLINK-8747: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #5558: [FLINK-8747][bugfix] The tag of waiting for floating buff...

2018-02-22 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/5558 Thanks for your reviews! I already addressed above comments in a separate commit. Regarding the tests I also think the same with you. :) ---

[GitHub] flink pull request #5558: [FLINK-8747][bugfix] The tag of waiting for floati...

2018-02-22 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/5558#discussion_r170148337 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -396,32 +399,49 @@ public

[jira] [Commented] (FLINK-8747) The tag of waiting for floating buffers in RemoteInputChannel should be updated properly

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373811#comment-16373811 ] ASF GitHub Bot commented on FLINK-8747: --- Github user zhijiangW commented on a diff in the pull

[jira] [Commented] (FLINK-8747) The tag of waiting for floating buffers in RemoteInputChannel should be updated properly

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373809#comment-16373809 ] ASF GitHub Bot commented on FLINK-8747: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #5558: [FLINK-8747][bugfix] The tag of waiting for floati...

2018-02-22 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/5558#discussion_r170148132 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -337,6 +337,11 @@ public int

[jira] [Updated] (FLINK-8690) Update logical rule set to generate FlinkLogicalAggregate explicitly allow distinct agg on DataStream

2018-02-22 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-8690: - Description: **Currently, *FlinkLogicalAggregate* does not allow distinct aggregate. We are proposing to

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373484#comment-16373484 ] ASF GitHub Bot commented on FLINK-8656: --- Github user GJL commented on the issue:

[GitHub] flink issue #5487: [FLINK-8656] [flip6] Add modify CLI command to rescale Fl...

2018-02-22 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5487 I had these comments as well that were hidden: ![image](https://user-images.githubusercontent.com/1681921/36565125-d2dd1d52-181f-11e8-8dd7-ea25de6cacad.png) ---

[jira] [Comment Edited] (FLINK-8707) Excessive amount of files opened by flink task manager

2018-02-22 Thread Alexander Gardner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373384#comment-16373384 ] Alexander Gardner edited comment on FLINK-8707 at 2/22/18 8:43 PM: ---

[jira] [Updated] (FLINK-8707) Excessive amount of files opened by flink task manager

2018-02-22 Thread Alexander Gardner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Gardner updated FLINK-8707: - Attachment: AfterRunning-3-jobs-TM-FDs-BOX2.jpg

[jira] [Updated] (FLINK-8707) Excessive amount of files opened by flink task manager

2018-02-22 Thread Alexander Gardner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Gardner updated FLINK-8707: - Attachment: AfterRunning-3-jobs-lsof.box2-TM

[jira] [Commented] (FLINK-8707) Excessive amount of files opened by flink task manager

2018-02-22 Thread Alexander Gardner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373384#comment-16373384 ] Alexander Gardner commented on FLINK-8707: -- Summary of above detail is that: lsof | grep TM_PID

[jira] [Commented] (FLINK-8707) Excessive amount of files opened by flink task manager

2018-02-22 Thread Alexander Gardner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373377#comment-16373377 ] Alexander Gardner commented on FLINK-8707: -- Hi Stephan, Piotr & Nico Just some notes from the

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373147#comment-16373147 ] ASF GitHub Bot commented on FLINK-8360: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r170039184 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TestLocalDirectoryProvider.java --- @@ -0,0 +1,40 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373145#comment-16373145 ] ASF GitHub Bot commented on FLINK-8360: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r170038982 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskLocalStateStoreImplTest.java --- @@ -59,12 +59,18 @@ public void before()

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373142#comment-16373142 ] ASF GitHub Bot commented on FLINK-8360: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r170038223 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskExecutorLocalStateStoresManagerTest.java --- @@ -46,9 +48,15 @@ public void

[jira] [Commented] (FLINK-8750) InputGate may contain data after an EndOfPartitionEvent

2018-02-22 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373141#comment-16373141 ] Nico Kruber commented on FLINK-8750: actually, the problem may be with the value only:

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373135#comment-16373135 ] ASF GitHub Bot commented on FLINK-8360: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r170037177 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java --- @@ -0,0 +1,120 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-8736) Memory segment offsets for slices of slices are wrong

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373130#comment-16373130 ] ASF GitHub Bot commented on FLINK-8736: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5551: [FLINK-8736][network] fix memory segment offsets for slic...

2018-02-22 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5551 Honestly, there is no way, the tests' deadlocks are related to the changes of this PR. ---

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373127#comment-16373127 ] ASF GitHub Bot commented on FLINK-8360: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r170035520 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java --- @@ -0,0 +1,120 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-8734) SpillableSubpartition does not update byte statistics when spilled by a SpillableSubpartitionView

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373126#comment-16373126 ] ASF GitHub Bot commented on FLINK-8734: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5550: [FLINK-8734][network] fix partition bytes counting and re...

2018-02-22 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5550 Since the tests go through various different scenarios, that's the natural place to also verify statistics which should be aligned with the real world despite the overhead during changes. The

[jira] [Created] (FLINK-8750) InputGate may contain data after an EndOfPartitionEvent

2018-02-22 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-8750: -- Summary: InputGate may contain data after an EndOfPartitionEvent Key: FLINK-8750 URL: https://issues.apache.org/jira/browse/FLINK-8750 Project: Flink Issue

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373112#comment-16373112 ] ASF GitHub Bot commented on FLINK-8360: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r170034046 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -1629,9

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373109#comment-16373109 ] ASF GitHub Bot commented on FLINK-8360: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r170033424 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java --- @@ -193,7 +193,12 @@ public

[jira] [Commented] (FLINK-8733) SpillableSubpartition#spillFinishedBufferConsumers() does not count spilled bytes anymore

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373103#comment-16373103 ] ASF GitHub Bot commented on FLINK-8733: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5549: [FLINK-8733][network] fix SpillableSubpartition#spillFini...

2018-02-22 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5549 I would actually like to not implement a test since the value itself is only printed to the log anyway and not exposed in any other way. ---

[jira] [Commented] (FLINK-8694) Make notifyDataAvailable call reliable

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373101#comment-16373101 ] ASF GitHub Bot commented on FLINK-8694: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5557: [FLINK-8694][runtime] Workaround notifyDataAvailable race...

2018-02-22 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5557 We can still merge bug fixes after feature freeze. The original cause is also bug but only influencing latency except for the always-flush case. ---

[jira] [Commented] (FLINK-8747) The tag of waiting for floating buffers in RemoteInputChannel should be updated properly

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373092#comment-16373092 ] ASF GitHub Bot commented on FLINK-8747: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8747) The tag of waiting for floating buffers in RemoteInputChannel should be updated properly

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373093#comment-16373093 ] ASF GitHub Bot commented on FLINK-8747: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #5558: [FLINK-8747][bugfix] The tag of waiting for floati...

2018-02-22 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5558#discussion_r170027206 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -337,6 +337,11 @@ public int

[GitHub] flink pull request #5558: [FLINK-8747][bugfix] The tag of waiting for floati...

2018-02-22 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5558#discussion_r170028724 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -396,32 +399,49 @@ public

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373073#comment-16373073 ] ASF GitHub Bot commented on FLINK-8360: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r170026181 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskExecutorLocalStateStoresManager.java --- @@ -89,6 +90,22 @@ public

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373044#comment-16373044 ] ASF GitHub Bot commented on FLINK-8538: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5564: [FLINK-8538] [table] Add a Kafka table source factory wit...

2018-02-22 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5564 What do you think @xccui @fhueske? ---

[jira] [Commented] (FLINK-8628) BucketingSink does not work with S3

2018-02-22 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373040#comment-16373040 ] Aljoscha Krettek commented on FLINK-8628: - Probably related to FLINK-8720. > BucketingSink does

[jira] [Commented] (FLINK-8538) Add a Kafka table source factory with JSON format support

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373037#comment-16373037 ] ASF GitHub Bot commented on FLINK-8538: --- GitHub user twalthr opened a pull request:

[GitHub] flink pull request #5564: [FLINK-8538] [table] Add a Kafka table source fact...

2018-02-22 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/5564 [FLINK-8538] [table] Add a Kafka table source factory with JSON format ## What is the purpose of the change This PR is a continuation of #5505. Since this is the first connector with

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373034#comment-16373034 ] ASF GitHub Bot commented on FLINK-8656: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5487: [FLINK-8656] [flip6] Add modify CLI command to rescale Fl...

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5487 Thanks for the review @GJL. I've addressed your comments and rebased onto the latest master. ---

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373033#comment-16373033 ] ASF GitHub Bot commented on FLINK-8656: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5487#discussion_r170016414 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/RescalingStatusMessageParameters.java --- @@ -0,0 +1,39 @@ +/*

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373029#comment-16373029 ] ASF GitHub Bot commented on FLINK-8656: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5487#discussion_r170015457 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/RescaleParallelismQueryParameter.java --- @@ -0,0 +1,41 @@ +/* +

[jira] [Commented] (FLINK-8543) Output Stream closed at org.apache.hadoop.fs.s3a.S3AOutputStream.checkOpen

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373026#comment-16373026 ] ASF GitHub Bot commented on FLINK-8543: --- Github user aljoscha commented on the issue:

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5487#discussion_r170014907 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -447,6 +453,165 @@ public void postStop() throws

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373025#comment-16373025 ] ASF GitHub Bot commented on FLINK-8656: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink issue #5563: [FLINK-8543] Don't call super.close() in AvroKeyValueSink...

2018-02-22 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5563 @IgorBerman Do you have an idea whether this change could cause problems? As the original implementer. ---

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373024#comment-16373024 ] ASF GitHub Bot commented on FLINK-8656: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373021#comment-16373021 ] ASF GitHub Bot commented on FLINK-8656: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8543) Output Stream closed at org.apache.hadoop.fs.s3a.S3AOutputStream.checkOpen

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373022#comment-16373022 ] ASF GitHub Bot commented on FLINK-8543: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5487#discussion_r170014666 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -963,6 +1120,36 @@ private Acknowledge

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5487#discussion_r170014483 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -447,6 +453,165 @@ public void postStop() throws

[GitHub] flink pull request #5563: [FLINK-8543] Don't call super.close() in AvroKeyVa...

2018-02-22 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/5563 [FLINK-8543] Don't call super.close() in AvroKeyValueSinkWriter The call to keyValueWriter.close() in AvroKeyValueSinkWriter.close() will eventually call flush() on the wrapped stream which

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373020#comment-16373020 ] ASF GitHub Bot commented on FLINK-8656: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8732) Cancel scheduling operation when cancelling the ExecutionGraph

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373019#comment-16373019 ] ASF GitHub Bot commented on FLINK-8732: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5487#discussion_r170014030 --- Diff: flink-core/src/main/java/org/apache/flink/util/function/BiConsumerWithException.java --- @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] flink pull request #5548: [FLINK-8732] [flip6] Cancel ongoing scheduling ope...

2018-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5548 ---

[jira] [Commented] (FLINK-8656) Add CLI command for rescaling

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373017#comment-16373017 ] ASF GitHub Bot commented on FLINK-8656: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5487: [FLINK-8656] [flip6] Add modify CLI command to res...

2018-02-22 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5487#discussion_r170013389 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/RescalingBehaviour.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to the

[jira] [Closed] (FLINK-8732) Cancel scheduling operation when cancelling the ExecutionGraph

2018-02-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8732. Resolution: Fixed Fixed via 519639c64039563ac4f2a875a8cfa630b25e4e8b > Cancel scheduling operation

  1   2   3   4   >