[
https://issues.apache.org/jira/browse/FLINK-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559681#comment-16559681
]
ASF GitHub Bot commented on FLINK-9958:
---
yanghua commented on a change in pull requ
yanghua commented on a change in pull request #6426: [FLINK-9958][DataSet] Fix
potential NPE for delta iteration of DataSet
URL: https://github.com/apache/flink/pull/6426#discussion_r205757315
##
File path:
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobG
[
https://issues.apache.org/jira/browse/FLINK-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559678#comment-16559678
]
ASF GitHub Bot commented on FLINK-9958:
---
yanghua commented on a change in pull requ
[
https://issues.apache.org/jira/browse/FLINK-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559679#comment-16559679
]
ASF GitHub Bot commented on FLINK-9958:
---
yanghua commented on a change in pull requ
yanghua commented on a change in pull request #6426: [FLINK-9958][DataSet] Fix
potential NPE for delta iteration of DataSet
URL: https://github.com/apache/flink/pull/6426#discussion_r205757372
##
File path:
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobG
yanghua commented on a change in pull request #6426: [FLINK-9958][DataSet] Fix
potential NPE for delta iteration of DataSet
URL: https://github.com/apache/flink/pull/6426#discussion_r205757372
##
File path:
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobG
yanghua commented on a change in pull request #6426: [FLINK-9958][DataSet] Fix
potential NPE for delta iteration of DataSet
URL: https://github.com/apache/flink/pull/6426#discussion_r205757315
##
File path:
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobG
yanghua commented on a change in pull request #6430: [FLINK-8058][Queryable
State]Queryable state should check types
URL: https://github.com/apache/flink/pull/6430#discussion_r205753939
##
File path:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/f
yanghua commented on a change in pull request #6430: [FLINK-8058][Queryable
State]Queryable state should check types
URL: https://github.com/apache/flink/pull/6430#discussion_r205752940
##
File path:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink
yanghua commented on a change in pull request #6430: [FLINK-8058][Queryable
State]Queryable state should check types
URL: https://github.com/apache/flink/pull/6430#discussion_r205751973
##
File path:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink
[
https://issues.apache.org/jira/browse/FLINK-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559662#comment-16559662
]
ASF GitHub Bot commented on FLINK-8058:
---
yanghua commented on a change in pull requ
yanghua commented on a change in pull request #6430: [FLINK-8058][Queryable
State]Queryable state should check types
URL: https://github.com/apache/flink/pull/6430#discussion_r205752047
##
File path:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink
yanghua commented on a change in pull request #6430: [FLINK-8058][Queryable
State]Queryable state should check types
URL: https://github.com/apache/flink/pull/6430#discussion_r205753578
##
File path:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/f
yanghua commented on a change in pull request #6430: [FLINK-8058][Queryable
State]Queryable state should check types
URL: https://github.com/apache/flink/pull/6430#discussion_r205753009
##
File path:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink
[
https://issues.apache.org/jira/browse/FLINK-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559661#comment-16559661
]
ASF GitHub Bot commented on FLINK-8058:
---
yanghua commented on a change in pull requ
[
https://issues.apache.org/jira/browse/FLINK-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559663#comment-16559663
]
ASF GitHub Bot commented on FLINK-8058:
---
yanghua commented on a change in pull requ
Aljoscha Krettek created FLINK-9983:
---
Summary: Savepoints should count as checkpoints when recovering
Key: FLINK-9983
URL: https://issues.apache.org/jira/browse/FLINK-9983
Project: Flink
Is
aljoscha commented on issue #6439: Couple of naming and package fixes for new
file sink
URL: https://github.com/apache/flink/pull/6439#issuecomment-408398727
Now that we're on the file sink ... 😅
This is an automated message
aljoscha opened a new pull request #6439: Couple of naming and package fixes
for new file sink
URL: https://github.com/apache/flink/pull/6439
This is an automated message from the Apache Git Service.
To respond to the messag
[
https://issues.apache.org/jira/browse/FLINK-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Yao updated FLINK-9936:
Priority: Blocker (was: Major)
> Mesos resource manager unable to connect to master after failover
> -
[
https://issues.apache.org/jira/browse/FLINK-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Yao updated FLINK-9936:
Fix Version/s: 1.5.2
> Mesos resource manager unable to connect to master after failover
>
[
https://issues.apache.org/jira/browse/FLINK-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Yao updated FLINK-9936:
Affects Version/s: 1.6.0
> Mesos resource manager unable to connect to master after failover
>
[
https://issues.apache.org/jira/browse/FLINK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559640#comment-16559640
]
ASF GitHub Bot commented on FLINK-9976:
---
yanghua commented on issue #6437: [FLINK-9
yanghua commented on issue #6437: [FLINK-9976][streaming] Remove unnecessary
generic parameters
URL: https://github.com/apache/flink/pull/6437#issuecomment-408397923
Shall we also change the PR's title?
This is an automated m
[
https://issues.apache.org/jira/browse/FLINK-9940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559639#comment-16559639
]
Huyen Levan commented on FLINK-9940:
I'm currently working on a fix for this bug. How
[
https://issues.apache.org/jira/browse/FLINK-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559634#comment-16559634
]
ASF GitHub Bot commented on FLINK-9978:
---
yanghua commented on issue #6436: [FLINK-9
yanghua commented on issue #6436: [FLINK-9978][release] Include relative path
in source release sha file
URL: https://github.com/apache/flink/pull/6436#issuecomment-408397541
+1
This is an automated message from the Apache Gi
[
https://issues.apache.org/jira/browse/FLINK-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-8439.
---
Resolution: Fixed
Fix Version/s: (was: 1.5.3)
(was: 1.4.3)
[
https://issues.apache.org/jira/browse/FLINK-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559627#comment-16559627
]
ASF GitHub Bot commented on FLINK-8439:
---
aljoscha closed pull request #6405: [FLINK
aljoscha closed pull request #6405: [FLINK-8439] Add Flink shading to AWS
credential provider s3 hadoop c…
URL: https://github.com/apache/flink/pull/6405
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provena
[
https://issues.apache.org/jira/browse/FLINK-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-8439:
Summary: Add Flink shading to AWS credential provider s3 hadoop config
(was: Document usin
[
https://issues.apache.org/jira/browse/FLINK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559609#comment-16559609
]
ASF GitHub Bot commented on FLINK-9976:
---
aljoscha commented on issue #6437: [FLINK-
aljoscha commented on issue #6437: [FLINK-9976][streaming] Remove unnecessary
generic parameters
URL: https://github.com/apache/flink/pull/6437#issuecomment-408393364
👍 that's better now
This is an automated message from the
[
https://issues.apache.org/jira/browse/FLINK-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559601#comment-16559601
]
vinoyang commented on FLINK-9982:
-
hi [~mingleizhang] can you provide more description ab
[
https://issues.apache.org/jira/browse/FLINK-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559576#comment-16559576
]
Piotr Nowojski commented on FLINK-9969:
---
Strangely, problem disappears when {{taskm
[
https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559564#comment-16559564
]
ASF GitHub Bot commented on FLINK-9576:
---
zentol commented on a change in pull reque
[
https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559565#comment-16559565
]
ASF GitHub Bot commented on FLINK-9576:
---
zentol commented on a change in pull reque
[
https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559563#comment-16559563
]
ASF GitHub Bot commented on FLINK-9576:
---
zentol commented on a change in pull reque
zentol commented on a change in pull request #6268: [FLINK-9576] Fixed
documentation for contiguity within looping pattern.
URL: https://github.com/apache/flink/pull/6268#discussion_r205737666
##
File path: docs/dev/libs/cep.md
##
@@ -250,21 +250,10 @@ For a pattern named
[
https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559566#comment-16559566
]
ASF GitHub Bot commented on FLINK-9576:
---
zentol commented on a change in pull reque
[
https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559562#comment-16559562
]
ASF GitHub Bot commented on FLINK-9576:
---
zentol commented on a change in pull reque
zentol commented on a change in pull request #6268: [FLINK-9576] Fixed
documentation for contiguity within looping pattern.
URL: https://github.com/apache/flink/pull/6268#discussion_r205736518
##
File path: docs/dev/libs/cep.md
##
@@ -919,6 +774,164 @@ next.within(Time.sec
zentol commented on a change in pull request #6268: [FLINK-9576] Fixed
documentation for contiguity within looping pattern.
URL: https://github.com/apache/flink/pull/6268#discussion_r205736198
##
File path: docs/dev/libs/cep.md
##
@@ -919,6 +774,164 @@ next.within(Time.sec
zentol commented on a change in pull request #6268: [FLINK-9576] Fixed
documentation for contiguity within looping pattern.
URL: https://github.com/apache/flink/pull/6268#discussion_r205735274
##
File path: docs/dev/libs/cep.md
##
@@ -250,21 +250,10 @@ For a pattern named
zentol commented on a change in pull request #6268: [FLINK-9576] Fixed
documentation for contiguity within looping pattern.
URL: https://github.com/apache/flink/pull/6268#discussion_r205735489
##
File path: docs/dev/libs/cep.md
##
@@ -250,21 +250,10 @@ For a pattern named
[
https://issues.apache.org/jira/browse/FLINK-9942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559552#comment-16559552
]
ASF GitHub Bot commented on FLINK-9942:
---
zentol closed pull request #6416: [FLINK-9
zentol closed pull request #6416: [FLINK-9942][rest] Guard handlers against
null fields
URL: https://github.com/apache/flink/pull/6416
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
[
https://issues.apache.org/jira/browse/FLINK-9942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-9942.
---
Resolution: Fixed
Fix Version/s: 1.6.0
1.5.3
master: 22b9a8d785b753
zhangminglei created FLINK-9982:
---
Summary: NPE in EnumValueSerializer#copy
Key: FLINK-9982
URL: https://issues.apache.org/jira/browse/FLINK-9982
Project: Flink
Issue Type: Bug
Repor
[
https://issues.apache.org/jira/browse/FLINK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559528#comment-16559528
]
ASF GitHub Bot commented on FLINK-9976:
---
zentol commented on issue #6437: [FLINK-99
zentol commented on issue #6437: [FLINK-9976][streaming] Remove unnecessary
generic parameters
URL: https://github.com/apache/flink/pull/6437#issuecomment-408375710
@aljoscha I've reworked the builders. This introduced a small gotcha for
tests; if you set the `bucketFactory`, and afterward
[
https://issues.apache.org/jira/browse/FLINK-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559502#comment-16559502
]
buptljy edited comment on FLINK-9964 at 7/27/18 9:50 AM:
-
[~twalt
[
https://issues.apache.org/jira/browse/FLINK-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Anderson updated FLINK-9980:
--
Priority: Major (was: Minor)
> wiki-edits quickstart docs aren't clear enough
> --
[
https://issues.apache.org/jira/browse/FLINK-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Anderson updated FLINK-9980:
--
Priority: Minor (was: Major)
> wiki-edits quickstart docs aren't clear enough
> --
[
https://issues.apache.org/jira/browse/FLINK-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559502#comment-16559502
]
buptljy commented on FLINK-9964:
[~twalthr] I've tried some tests on the Jackson library,
[
https://issues.apache.org/jira/browse/FLINK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559503#comment-16559503
]
ASF GitHub Bot commented on FLINK-9976:
---
zentol commented on issue #6437: [FLINK-99
[
https://issues.apache.org/jira/browse/FLINK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559501#comment-16559501
]
ASF GitHub Bot commented on FLINK-9885:
---
tzulitai edited a comment on issue #6391:
zentol commented on issue #6437: [FLINK-9976][streaming] Remove unnecessary
generic parameters
URL: https://github.com/apache/flink/pull/6437#issuecomment-408370024
I think that would be a nicer approach. The fact that this compiles _and
runs without error_ is rather disgusting:
```
tzulitai commented on issue #6391: [FLINK-9885] [FLINK-8101] Finalize
Elasticsearch 6.x
URL: https://github.com/apache/flink/pull/6391#issuecomment-408369668
Hi @cjolif, @twalthr, this PR is ready for a second pass now.
- End-to-end tests now pass stably.
- Addresses all of @twalt
tzulitai edited a comment on issue #6391: [FLINK-9885] [FLINK-8101] Finalize
Elasticsearch 6.x
URL: https://github.com/apache/flink/pull/6391#issuecomment-408369668
Hi @cjolif, @twalthr, this PR is ready for a second pass now.
- End-to-end tests now pass stably.
- Addressed all of
[
https://issues.apache.org/jira/browse/FLINK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559500#comment-16559500
]
ASF GitHub Bot commented on FLINK-9885:
---
tzulitai commented on issue #6391: [FLINK-
[
https://issues.apache.org/jira/browse/FLINK-9900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559495#comment-16559495
]
ASF GitHub Bot commented on FLINK-9900:
---
StefanRRichter commented on a change in pu
StefanRRichter commented on a change in pull request #6395: [FLINK-9900][tests]
Harden ZooKeeperHighAvailabilityITCase
URL: https://github.com/apache/flink/pull/6395#discussion_r205721646
##
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ZooKeeperHighAvail
[
https://issues.apache.org/jira/browse/FLINK-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Richter closed FLINK-9918.
-
Resolution: Workaround
Fix Version/s: 1.6.0
We currently no longer need the dependency aft
[
https://issues.apache.org/jira/browse/FLINK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559490#comment-16559490
]
ASF GitHub Bot commented on FLINK-9976:
---
aljoscha commented on issue #6437: [FLINK-
aljoscha commented on issue #6437: [FLINK-9976][streaming] Remove unnecessary
generic parameters
URL: https://github.com/apache/flink/pull/6437#issuecomment-408367621
I think the Builders are done wrong. Instead of reusing the builder, the
builder should be immutable and each call should r
[
https://issues.apache.org/jira/browse/FLINK-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559487#comment-16559487
]
ASF GitHub Bot commented on FLINK-9981:
---
StefanRRichter commented on issue #6438: [
StefanRRichter commented on issue #6438: [FLINK-9981] Tune performance of
RocksDB implementation
URL: https://github.com/apache/flink/pull/6438#issuecomment-408366961
CC @azagrebin
This is an automated message from the Apach
[
https://issues.apache.org/jira/browse/FLINK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559484#comment-16559484
]
ASF GitHub Bot commented on FLINK-9976:
---
zentol commented on issue #6437: [FLINK-99
[
https://issues.apache.org/jira/browse/FLINK-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559482#comment-16559482
]
ASF GitHub Bot commented on FLINK-9981:
---
StefanRRichter opened a new pull request #
zentol commented on issue #6437: [FLINK-9976][streaming] Remove unnecessary
generic parameters
URL: https://github.com/apache/flink/pull/6437#issuecomment-408365850
but the bucket ID type is already defined in the constructor. you can't just
change that.
--
[
https://issues.apache.org/jira/browse/FLINK-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-9981:
--
Labels: pull-request-available (was: )
> Tune performance of RocksDB implementation
>
StefanRRichter opened a new pull request #6438: [FLINK-9981] Tune performance
of RocksDB implementation
URL: https://github.com/apache/flink/pull/6438
## What is the purpose of the change
This PR does some general performance tuning for the RocksDB based
implementation of timer stat
[
https://issues.apache.org/jira/browse/FLINK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559478#comment-16559478
]
ASF GitHub Bot commented on FLINK-9976:
---
aljoscha commented on issue #6437: [FLINK-
aljoscha commented on issue #6437: [FLINK-9976][streaming] Remove unnecessary
generic parameters
URL: https://github.com/apache/flink/pull/6437#issuecomment-408365021
Isn't this meant for the case where you want to change the `BucketID`, so
you actually need the reinterpretation?
[
https://issues.apache.org/jira/browse/FLINK-9961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559474#comment-16559474
]
ASF GitHub Bot commented on FLINK-9961:
---
yanghua commented on issue #6428: [FLINK-9
[
https://issues.apache.org/jira/browse/FLINK-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Anderson updated FLINK-9980:
--
Description: The docs wiki-edit quickstart example should emphasize the
need to remove the prov
[
https://issues.apache.org/jira/browse/FLINK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-9976:
--
Labels: pull-request-available (was: )
> Odd signatures for streaming file sink format builder
yanghua commented on issue #6428: [FLINK-9961] Add CHR function for table/sql
API
URL: https://github.com/apache/flink/pull/6428#issuecomment-408363890
cc @sihuazhou @suez1224 can you review this PR?
This is an automated mess
zentol opened a new pull request #6437: [FLINK-9976][streaming] Remove
unnecessary generic parameters
URL: https://github.com/apache/flink/pull/6437
## What is the purpose of the change
This PR removes unnecessary generic parameter from format builder methods of
the `StreamingFileSi
[
https://issues.apache.org/jira/browse/FLINK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559473#comment-16559473
]
ASF GitHub Bot commented on FLINK-9976:
---
zentol opened a new pull request #6437: [F
Stefan Richter created FLINK-9981:
-
Summary: Tune performance of RocksDB implementation
Key: FLINK-9981
URL: https://issues.apache.org/jira/browse/FLINK-9981
Project: Flink
Issue Type: Sub-ta
[
https://issues.apache.org/jira/browse/FLINK-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559461#comment-16559461
]
David Anderson commented on FLINK-9980:
---
Thanks, [~Zentol]. I've updated this ticke
[
https://issues.apache.org/jira/browse/FLINK-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Anderson updated FLINK-9980:
--
Description: The docs wiki-edit quickstart example should emphasize the
need to remove the prov
[
https://issues.apache.org/jira/browse/FLINK-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-9975:
Fix Version/s: 1.6.0
> Netty dependency of Hadoop >= 2.7 is not shaded away
> -
[
https://issues.apache.org/jira/browse/FLINK-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559457#comment-16559457
]
Aljoscha Krettek commented on FLINK-9976:
-
[~Zentol] If we want to change this we
[
https://issues.apache.org/jira/browse/FLINK-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559452#comment-16559452
]
ASF GitHub Bot commented on FLINK-8439:
---
aljoscha commented on issue #6405: [FLINK-
aljoscha commented on issue #6405: [FLINK-8439] Add Flink shading to AWS
credential provider s3 hadoop c…
URL: https://github.com/apache/flink/pull/6405#issuecomment-408360780
Thanks! This looks good now. I'll merge once Travis is green. 👌
-
azagrebin commented on a change in pull request #6405: [FLINK-8439] Add Flink
shading to AWS credential provider s3 hadoop c…
URL: https://github.com/apache/flink/pull/6405#discussion_r205712754
##
File path:
flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/
[
https://issues.apache.org/jira/browse/FLINK-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559449#comment-16559449
]
ASF GitHub Bot commented on FLINK-8439:
---
azagrebin commented on a change in pull re
[
https://issues.apache.org/jira/browse/FLINK-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559446#comment-16559446
]
ASF GitHub Bot commented on FLINK-8439:
---
azagrebin commented on issue #6405: [FLINK
azagrebin commented on issue #6405: [FLINK-8439] Add Flink shading to AWS
credential provider s3 hadoop c…
URL: https://github.com/apache/flink/pull/6405#issuecomment-408360092
Thanks for the review @aljoscha, I removed s3 specifics from the base class
-
[
https://issues.apache.org/jira/browse/FLINK-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559444#comment-16559444
]
ASF GitHub Bot commented on FLINK-9970:
---
yanghua commented on issue #6432: [FLINK-9
[
https://issues.apache.org/jira/browse/FLINK-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559445#comment-16559445
]
Aljoscha Krettek commented on FLINK-9959:
-
This would be a good change, but unfor
yanghua commented on issue #6432: [FLINK-9970] Add ASCII function for table/sql
API
URL: https://github.com/apache/flink/pull/6432#issuecomment-408359848
@suez1224 Will fix the checkstyle, for CHAR, there is a single PR #6428 ,
Shall I merge it into this?
-
[
https://issues.apache.org/jira/browse/FLINK-8439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559442#comment-16559442
]
ASF GitHub Bot commented on FLINK-8439:
---
azagrebin commented on a change in pull re
azagrebin commented on a change in pull request #6405: [FLINK-8439] Add Flink
shading to AWS credential provider s3 hadoop c…
URL: https://github.com/apache/flink/pull/6405#discussion_r205711773
##
File path:
flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/
[
https://issues.apache.org/jira/browse/FLINK-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559433#comment-16559433
]
Timo Walther commented on FLINK-9977:
-
I would also be in favor of just one unified p
[
https://issues.apache.org/jira/browse/FLINK-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559425#comment-16559425
]
Chesnay Schepler commented on FLINK-9980:
-
The docs are a bit misleading. They sa
[
https://issues.apache.org/jira/browse/FLINK-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559423#comment-16559423
]
Xingcan Cui commented on FLINK-9977:
[~twalthr], I also think of that since we've alr
101 - 200 of 205 matches
Mail list logo
