[jira] [Commented] (FLINK-9438) Add documentation for (Registry)AvroDeserializationSchema

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572696#comment-16572696 ] ASF GitHub Bot commented on FLINK-9438: --- tzulitai commented on issue #6078: [FLINK-9438] Add

[GitHub] tzulitai commented on issue #6078: [FLINK-9438] Add documentation for AvroDeserializationSchema

2018-08-07 Thread GitBox
tzulitai commented on issue #6078: [FLINK-9438] Add documentation for AvroDeserializationSchema URL: https://github.com/apache/flink/pull/6078#issuecomment-411288894 +1, LGTM This is an automated message from the Apache Git

[jira] [Commented] (FLINK-8290) Modify clientId to groupId in flink-connector-kafka-0.8

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572627#comment-16572627 ] ASF GitHub Bot commented on FLINK-8290: --- maqingxiang commented on a change in pull request #5304:

[GitHub] maqingxiang commented on a change in pull request #5304: [FLINK-8290]Modify clientId to groupId in flink-connector-kafka-0.8

2018-08-07 Thread GitBox
maqingxiang commented on a change in pull request #5304: [FLINK-8290]Modify clientId to groupId in flink-connector-kafka-0.8 URL: https://github.com/apache/flink/pull/5304#discussion_r208448741 ## File path:

[jira] [Commented] (FLINK-8290) Modify clientId to groupId in flink-connector-kafka-0.8

2018-08-07 Thread xymaqingxiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572626#comment-16572626 ] xymaqingxiang commented on FLINK-8290: -- Hi, *all*   [group.id|http://group.id/] is a concept of

[jira] [Commented] (FLINK-10099) Rework YarnResourceManagerTest

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572620#comment-16572620 ] ASF GitHub Bot commented on FLINK-10099: TisonKun commented on issue #6499: [FLINK-10099] [test]

[jira] [Updated] (FLINK-10099) Rework YarnResourceManagerTest

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10099: --- Labels: pull-request-available (was: ) > Rework YarnResourceManagerTest >

[GitHub] TisonKun commented on issue #6499: [FLINK-10099] [test] Rework YarnResourceManagerTest

2018-08-07 Thread GitBox
TisonKun commented on issue #6499: [FLINK-10099] [test] Rework YarnResourceManagerTest URL: https://github.com/apache/flink/pull/6499#issuecomment-411273545 @tillrohrmann @GJL thanks for your reviews! I revert the change replacing mocks, but gather them so that we can replace it once

[GitHub] maqingxiang commented on issue #6303: [hotfix][JobManageOptions]modify annotation of EXECUTION_FAILOVER_STRATEGY in JobManageOptions

2018-08-07 Thread GitBox
maqingxiang commented on issue #6303: [hotfix][JobManageOptions]modify annotation of EXECUTION_FAILOVER_STRATEGY in JobManageOptions URL: https://github.com/apache/flink/pull/6303#issuecomment-411270804 I'm very sorry for the late reply. Thank you @zentol and @dawidwys

[jira] [Created] (FLINK-10099) Rework YarnResourceManagerTest

2018-08-07 Thread JIRA
陈梓立 created FLINK-10099: --- Summary: Rework YarnResourceManagerTest Key: FLINK-10099 URL: https://issues.apache.org/jira/browse/FLINK-10099 Project: Flink Issue Type: Improvement Components:

[jira] [Updated] (FLINK-9824) Support IPv6 literal

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-9824: -- Description: Currently we use colon as separator when parsing host and port. We should support the usage of

[GitHub] tragicjun commented on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

2018-08-07 Thread GitBox
tragicjun commented on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs URL: https://github.com/apache/flink/pull/6508#issuecomment-411243850 @zentol already fixed, thanks. This is

[jira] [Comment Edited] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

2018-08-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307281#comment-16307281 ] Ted Yu edited comment on FLINK-6105 at 8/7/18 10:33 PM: In

[jira] [Created] (FLINK-10098) Programmatically select timer storage backend

2018-08-07 Thread Elias Levy (JIRA)
Elias Levy created FLINK-10098: -- Summary: Programmatically select timer storage backend Key: FLINK-10098 URL: https://issues.apache.org/jira/browse/FLINK-10098 Project: Flink Issue Type:

[jira] [Updated] (FLINK-5315) Support distinct aggregations in table api

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-5315: -- Labels: pull-request-available (was: ) > Support distinct aggregations in table api >

[jira] [Commented] (FLINK-5315) Support distinct aggregations in table api

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572373#comment-16572373 ] ASF GitHub Bot commented on FLINK-5315: --- walterddr opened a new pull request #6521:

[GitHub] walterddr opened a new pull request #6521: [FLINK-5315][table] Adding support for distinct operation for table API on DataStream

2018-08-07 Thread GitBox
walterddr opened a new pull request #6521: [FLINK-5315][table] Adding support for distinct operation for table API on DataStream URL: https://github.com/apache/flink/pull/6521 ## What is the purpose of the change * Adding `distinct` aggregation support for Table API. Example usages

[GitHub] suez1224 commented on issue #6483: [Flink-7243][flink-formats] Add parquet input format

2018-08-07 Thread GitBox
suez1224 commented on issue #6483: [Flink-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-411180238 Thanks a lot for the PR. Please fix the minor check-style issue first. I'll take a look in the next few days.

[jira] [Comment Edited] (FLINK-7243) Add ParquetInputFormat

2018-08-07 Thread Zhenqiu Huang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567824#comment-16567824 ] Zhenqiu Huang edited comment on FLINK-7243 at 8/7/18 7:45 PM: -- [~najman]

[jira] [Updated] (FLINK-10097) More tests to increase StreamingFileSink test coverage

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10097: --- Labels: pull-request-available (was: ) > More tests to increase StreamingFileSink test

[jira] [Commented] (FLINK-10097) More tests to increase StreamingFileSink test coverage

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571957#comment-16571957 ] ASF GitHub Bot commented on FLINK-10097: kl0u opened a new pull request #6520:

[GitHub] kl0u opened a new pull request #6520: [FLINK-10097][DataStream API] Additional tests for StreamingFileSink

2018-08-07 Thread GitBox
kl0u opened a new pull request #6520: [FLINK-10097][DataStream API] Additional tests for StreamingFileSink URL: https://github.com/apache/flink/pull/6520 ## What is the purpose of the change Adds more tests and partially refactors existing ones to decrease running time and increase

[jira] [Created] (FLINK-10097) More tests to increase StreamingFileSink test coverage

2018-08-07 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-10097: -- Summary: More tests to increase StreamingFileSink test coverage Key: FLINK-10097 URL: https://issues.apache.org/jira/browse/FLINK-10097 Project: Flink

[jira] [Commented] (FLINK-10074) Allowable number of checkpoint failures

2018-08-07 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571890#comment-16571890 ] vinoyang commented on FLINK-10074: -- Hi [~thw] and [~till.rohrmann] :  I think it depends on our

[jira] [Commented] (FLINK-10074) Allowable number of checkpoint failures

2018-08-07 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571889#comment-16571889 ] vinoyang commented on FLINK-10074: -- Hi [~thw] and [~till.rohrmann] :  I think it depends on our

[jira] [Commented] (FLINK-9933) Simplify taskmanager memory default values

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571857#comment-16571857 ] ASF GitHub Bot commented on FLINK-9933: --- dawidwys edited a comment on issue #6444: [FLINK-9933]

[GitHub] dawidwys edited a comment on issue #6444: [FLINK-9933] Simplify taskmanager memory default values

2018-08-07 Thread GitBox
dawidwys edited a comment on issue #6444: [FLINK-9933] Simplify taskmanager memory default values URL: https://github.com/apache/flink/pull/6444#issuecomment-411073638 Thanks for the PR @yanghua . Let's do the same for `MEMORY_SEGMENT_SIZE`. I would be in favor of removing space between

[jira] [Commented] (FLINK-9933) Simplify taskmanager memory default values

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571853#comment-16571853 ] ASF GitHub Bot commented on FLINK-9933: --- yanghua commented on issue #6444: [FLINK-9933] Simplify

[GitHub] yanghua commented on issue #6444: [FLINK-9933] Simplify taskmanager memory default values

2018-08-07 Thread GitBox
yanghua commented on issue #6444: [FLINK-9933] Simplify taskmanager memory default values URL: https://github.com/apache/flink/pull/6444#issuecomment-411101828 @dawidwys thanks for your suggestion, will process these issues you mentioned.

[jira] [Commented] (FLINK-8482) Implement and expose option to use min / max / left / right timestamp for joined streamrecords

2018-08-07 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571848#comment-16571848 ] Fabian Hueske commented on FLINK-8482: -- In my opinion this is a necessary feature to be able to

[jira] [Updated] (FLINK-7964) Add Apache Kafka 1.0/1.1 connectors

2018-08-07 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7964: Summary: Add Apache Kafka 1.0/1.1 connectors (was: Add Apache Kafka 1.0/1.1 connector) >

[jira] [Closed] (FLINK-8152) Add Kafka 1.0.0 connector

2018-08-07 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-8152. --- Resolution: Duplicate > Add Kafka 1.0.0 connector > - > >

[jira] [Closed] (FLINK-10067) Add Kafka 1.0.0/1.1.0 connectors

2018-08-07 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-10067. Resolution: Duplicate Fix Version/s: (was: 1.7.0) > Add Kafka 1.0.0/1.1.0

[jira] [Updated] (FLINK-7964) Add Apache Kafka 1.0/1.1 connector

2018-08-07 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7964: Summary: Add Apache Kafka 1.0/1.1 connector (was: Add Apache Kafka 1.0 connector) > Add

[jira] [Commented] (FLINK-9997) Improve Expression Reduce

2018-08-07 Thread Ruidong Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571818#comment-16571818 ] Ruidong Li commented on FLINK-9997: --- Adding the Calc normalization to the logical optimization rules

[jira] [Updated] (FLINK-9559) The type of a union of CHAR columns of different lengths should be VARCHAR

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9559: -- Labels: pull-request-available (was: ) > The type of a union of CHAR columns of different

[jira] [Commented] (FLINK-9559) The type of a union of CHAR columns of different lengths should be VARCHAR

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571814#comment-16571814 ] ASF GitHub Bot commented on FLINK-9559: --- hequn8128 opened a new pull request #6519: [FLINK-9559]

[GitHub] hequn8128 opened a new pull request #6519: [FLINK-9559] [table] The type of a union of CHAR columns of different lengths should be VARCHAR

2018-08-07 Thread GitBox
hequn8128 opened a new pull request #6519: [FLINK-9559] [table] The type of a union of CHAR columns of different lengths should be VARCHAR URL: https://github.com/apache/flink/pull/6519 ## What is the purpose of the change Currently, if the case-when expression has two branches

[GitHub] dawidwys closed pull request #6110: [hotfix] fix EXECUTION_FAILOVER_STRATEGY's comments error and its inf…

2018-08-07 Thread GitBox
dawidwys closed pull request #6110: [hotfix] fix EXECUTION_FAILOVER_STRATEGY's comments error and its inf… URL: https://github.com/apache/flink/pull/6110 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] dawidwys commented on issue #6110: [hotfix] fix EXECUTION_FAILOVER_STRATEGY's comments error and its inf…

2018-08-07 Thread GitBox
dawidwys commented on issue #6110: [hotfix] fix EXECUTION_FAILOVER_STRATEGY's comments error and its inf… URL: https://github.com/apache/flink/pull/6110#issuecomment-411090559 This is duplicate of #6303. Therefore I will close this PR. Feel free to reopen it if you disagree @makeyang

[jira] [Commented] (FLINK-10073) Allow setting a restart strategy in SQL Client

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571808#comment-16571808 ] ASF GitHub Bot commented on FLINK-10073: dawidwys commented on issue #6506: [FLINK-10073]

[GitHub] dawidwys commented on issue #6506: [FLINK-10073] [sql-client] Allow setting a restart strategy in SQL Client

2018-08-07 Thread GitBox
dawidwys commented on issue #6506: [FLINK-10073] [sql-client] Allow setting a restart strategy in SQL Client URL: https://github.com/apache/flink/pull/6506#issuecomment-411089108 You are right it is not supported in the DataStream API, but is supported from flink-conf.yaml via reflection

[jira] [Commented] (FLINK-10073) Allow setting a restart strategy in SQL Client

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571790#comment-16571790 ] ASF GitHub Bot commented on FLINK-10073: twalthr commented on issue #6506: [FLINK-10073]

[GitHub] twalthr commented on issue #6506: [FLINK-10073] [sql-client] Allow setting a restart strategy in SQL Client

2018-08-07 Thread GitBox
twalthr commented on issue #6506: [FLINK-10073] [sql-client] Allow setting a restart strategy in SQL Client URL: https://github.com/apache/flink/pull/6506#issuecomment-411086611 Thanks @dawidwys. Does Flink currently support user-defined restart strategies? As far as I know, users can not

[jira] [Updated] (FLINK-8482) Implement and expose option to use min / max / left / right timestamp for joined streamrecords

2018-08-07 Thread Florian Schmidt (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florian Schmidt updated FLINK-8482: --- Description: The idea: Expose the option of which timestamp to use for the result of a join.

[jira] [Updated] (FLINK-8482) Implement and expose option to use min / max / left / right timestamp for joined streamrecords

2018-08-07 Thread Florian Schmidt (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florian Schmidt updated FLINK-8482: --- Description: The idea: Expose the option of which timestamp to use for the result of a join.

[GitHub] GJL commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
GJL commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208256964 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19 +318,149 @@

[jira] [Commented] (FLINK-10073) Allow setting a restart strategy in SQL Client

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571759#comment-16571759 ] ASF GitHub Bot commented on FLINK-10073: dawidwys commented on issue #6506: [FLINK-10073]

[GitHub] dawidwys commented on issue #6506: [FLINK-10073] [sql-client] Allow setting a restart strategy in SQL Client

2018-08-07 Thread GitBox
dawidwys commented on issue #6506: [FLINK-10073] [sql-client] Allow setting a restart strategy in SQL Client URL: https://github.com/apache/flink/pull/6506#issuecomment-411080017 @twalthr Do you think we should also support user defined restart strategies? If not, which truth be told I

[GitHub] GJL commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
GJL commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208256964 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19 +318,149 @@

[jira] [Commented] (FLINK-10065) InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571746#comment-16571746 ] ASF GitHub Bot commented on FLINK-10065: klion26 commented on issue #6498: [FLINK-10065]

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208246223 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19

[GitHub] klion26 commented on issue #6498: [FLINK-10065] InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream

2018-08-07 Thread GitBox
klion26 commented on issue #6498: [FLINK-10065] InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream URL: https://github.com/apache/flink/pull/6498#issuecomment-411075093 @StephanEwen I tracked all the routes, except the

[jira] [Commented] (FLINK-9240) Avoid deprecated akka methods

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571742#comment-16571742 ] ASF GitHub Bot commented on FLINK-9240: --- Bhashit commented on issue #6446: [FLINK-9240] Avoid

[jira] [Commented] (FLINK-9933) Simplify taskmanager memory default values

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571740#comment-16571740 ] ASF GitHub Bot commented on FLINK-9933: --- dawidwys commented on issue #6444: [FLINK-9933] Simplify

[GitHub] Bhashit commented on issue #6446: [FLINK-9240] Avoid deprecated Akka methods

2018-08-07 Thread GitBox
Bhashit commented on issue #6446: [FLINK-9240] Avoid deprecated Akka methods URL: https://github.com/apache/flink/pull/6446#issuecomment-411073751 If this gets merged, this would solve a huge problem for us. :+1: Thanks for doing this.

[GitHub] dawidwys commented on issue #6444: [FLINK-9933] Simplify taskmanager memory default values

2018-08-07 Thread GitBox
dawidwys commented on issue #6444: [FLINK-9933] Simplify taskmanager memory default values URL: https://github.com/apache/flink/pull/6444#issuecomment-411073638 Thanks for the PR @yanghua . Let's do the same for `MEMORY_SEGMENT_SIZE`. I would be in favor of removing space between number

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208243880 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -258,7

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208245907 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208245855 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208248174 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -415,13

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208246008 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208244325 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208244570 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208246152 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208246194 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19

[GitHub] tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6499: [hotfix] loose dependency to mockito URL: https://github.com/apache/flink/pull/6499#discussion_r208244394 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java ## @@ -304,19

[jira] [Commented] (FLINK-9576) Wrong contiguity documentation

2018-08-07 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571710#comment-16571710 ] Dawid Wysakowicz commented on FLINK-9576: - Fixed in 1.6 via:

[jira] [Resolved] (FLINK-9576) Wrong contiguity documentation

2018-08-07 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-9576. - Resolution: Fixed > Wrong contiguity documentation > -- > >

[jira] [Commented] (FLINK-10096) Metrics report incorrect subtask ids

2018-08-07 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571703#comment-16571703 ] Chesnay Schepler commented on FLINK-10096: -- Classic indexing conundrum. The metric system uses

[jira] [Commented] (FLINK-9859) Distinguish TM akka config with JM config

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571707#comment-16571707 ] ASF GitHub Bot commented on FLINK-9859: --- tillrohrmann commented on a change in pull request #6339:

[jira] [Commented] (FLINK-9859) Distinguish TM akka config with JM config

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571709#comment-16571709 ] ASF GitHub Bot commented on FLINK-9859: --- tillrohrmann commented on a change in pull request #6339:

[jira] [Commented] (FLINK-9859) Distinguish TM akka config with JM config

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571705#comment-16571705 ] ASF GitHub Bot commented on FLINK-9859: --- tillrohrmann commented on a change in pull request #6339:

[jira] [Commented] (FLINK-9859) Distinguish TM akka config with JM config

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571706#comment-16571706 ] ASF GitHub Bot commented on FLINK-9859: --- tillrohrmann commented on a change in pull request #6339:

[jira] [Commented] (FLINK-9859) Distinguish TM akka config with JM config

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571708#comment-16571708 ] ASF GitHub Bot commented on FLINK-9859: --- tillrohrmann commented on a change in pull request #6339:

[GitHub] tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config URL: https://github.com/apache/flink/pull/6339#discussion_r208240285 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java

[GitHub] tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config URL: https://github.com/apache/flink/pull/6339#discussion_r208240548 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java

[GitHub] tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config URL: https://github.com/apache/flink/pull/6339#discussion_r208239960 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config URL: https://github.com/apache/flink/pull/6339#discussion_r208240414 ## File path: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala

[GitHub] tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config

2018-08-07 Thread GitBox
tillrohrmann commented on a change in pull request #6339: [FLINK-9859] [runtime] distinguish JM akka config URL: https://github.com/apache/flink/pull/6339#discussion_r208241572 ## File path: flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ## @@

[jira] [Commented] (FLINK-9576) Wrong contiguity documentation

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571699#comment-16571699 ] ASF GitHub Bot commented on FLINK-9576: --- dawidwys closed pull request #6268: [FLINK-9576] Fixed

[GitHub] dawidwys closed pull request #6268: [FLINK-9576] Fixed documentation for contiguity within looping pattern.

2018-08-07 Thread GitBox
dawidwys closed pull request #6268: [FLINK-9576] Fixed documentation for contiguity within looping pattern. URL: https://github.com/apache/flink/pull/6268 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] azagrebin commented on issue #6379: [FLINK-9637] Add public user documentation for state TTL feature

2018-08-07 Thread GitBox
azagrebin commented on issue #6379: [FLINK-9637] Add public user documentation for state TTL feature URL: https://github.com/apache/flink/pull/6379#issuecomment-411065564 Thank you for the review @twalthr, I updated the PR.

[jira] [Commented] (FLINK-9637) Add public user documentation for TTL feature

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571691#comment-16571691 ] ASF GitHub Bot commented on FLINK-9637: --- azagrebin commented on issue #6379: [FLINK-9637] Add

[jira] [Commented] (FLINK-10094) Always backup default config for end-to-end tests

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571684#comment-16571684 ] ASF GitHub Bot commented on FLINK-10094: florianschmidt1994 edited a comment on issue #6518:

[GitHub] dawidwys commented on a change in pull request #6303: [hotfix][JobManageOptions]modify annotation of EXECUTION_FAILOVER_STRATEGY in JobManageOptions

2018-08-07 Thread GitBox
dawidwys commented on a change in pull request #6303: [hotfix][JobManageOptions]modify annotation of EXECUTION_FAILOVER_STRATEGY in JobManageOptions URL: https://github.com/apache/flink/pull/6303#discussion_r208237925 ## File path:

[GitHub] florianschmidt1994 edited a comment on issue #6518: [FLINK-10094][tests] Always backup config before running test

2018-08-07 Thread GitBox
florianschmidt1994 edited a comment on issue #6518: [FLINK-10094][tests] Always backup config before running test URL: https://github.com/apache/flink/pull/6518#issuecomment-411046104 ~Ah, I missed that! Probably makes sense to remove that at some point~ Nevermind, we still need it b.c.

[GitHub] dawidwys commented on a change in pull request #6303: [hotfix][JobManageOptions]modify annotation of EXECUTION_FAILOVER_STRATEGY in JobManageOptions

2018-08-07 Thread GitBox
dawidwys commented on a change in pull request #6303: [hotfix][JobManageOptions]modify annotation of EXECUTION_FAILOVER_STRATEGY in JobManageOptions URL: https://github.com/apache/flink/pull/6303#discussion_r208238237 ## File path:

[jira] [Commented] (FLINK-9289) Parallelism of generated operators should have max parallism of input

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571680#comment-16571680 ] ASF GitHub Bot commented on FLINK-9289: --- fhueske commented on issue #6003: [FLINK-9289][Dataset]

[GitHub] fhueske commented on issue #6003: [FLINK-9289][Dataset] Parallelism of generated operators should have max parallelism of input

2018-08-07 Thread GitBox
fhueske commented on issue #6003: [FLINK-9289][Dataset] Parallelism of generated operators should have max parallelism of input URL: https://github.com/apache/flink/pull/6003#issuecomment-411063032 Hi @xccui, I think the problem can be fixed more easily with fewer side effects on tests.

[jira] [Commented] (FLINK-9598) [Checkpoints] The config Minimum Pause Between Checkpoints doesn't work when there's a checkpoint failure

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571678#comment-16571678 ] ASF GitHub Bot commented on FLINK-9598: --- zentol commented on issue #6346: [FLINK-9598] Refine

[GitHub] zentol commented on issue #6346: [FLINK-9598] Refine java-doc about the min pause between checkpoints

2018-08-07 Thread GitBox
zentol commented on issue #6346: [FLINK-9598] Refine java-doc about the min pause between checkpoints URL: https://github.com/apache/flink/pull/6346#issuecomment-411062550 After looking at the discussion threasd I'm not sure if it makes sense to merge this PR. If the behavior is deemed

[GitHub] zentol commented on issue #6303: [hotfix][JobManageOptions]modify annotation of EXECUTION_FAILOVER_STRATEGY in JobManageOptions

2018-08-07 Thread GitBox
zentol commented on issue #6303: [hotfix][JobManageOptions]modify annotation of EXECUTION_FAILOVER_STRATEGY in JobManageOptions URL: https://github.com/apache/flink/pull/6303#issuecomment-411059796 I'm taking over the PR. @dawidwys could you take a look? I've rebased the PR, reworked the

[jira] [Commented] (FLINK-10094) Always backup default config for end-to-end tests

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571665#comment-16571665 ] ASF GitHub Bot commented on FLINK-10094: florianschmidt1994 commented on a change in pull

[jira] [Commented] (FLINK-10094) Always backup default config for end-to-end tests

2018-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571666#comment-16571666 ] ASF GitHub Bot commented on FLINK-10094: florianschmidt1994 commented on a change in pull

[GitHub] florianschmidt1994 commented on a change in pull request #6518: [FLINK-10094][tests] Always backup config before running test

2018-08-07 Thread GitBox
florianschmidt1994 commented on a change in pull request #6518: [FLINK-10094][tests] Always backup config before running test URL: https://github.com/apache/flink/pull/6518#discussion_r208233155 ## File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh ## @@

[GitHub] florianschmidt1994 commented on a change in pull request #6518: [FLINK-10094][tests] Always backup config before running test

2018-08-07 Thread GitBox
florianschmidt1994 commented on a change in pull request #6518: [FLINK-10094][tests] Always backup config before running test URL: https://github.com/apache/flink/pull/6518#discussion_r208233155 ## File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh ## @@

[GitHub] zentol commented on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

2018-08-07 Thread GitBox
zentol commented on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs URL: https://github.com/apache/flink/pull/6508#issuecomment-411058384 scalastyle violations: ``` 10:30:04.747 [INFO] --- scalastyle-maven-plugin:1.0.0:check (default) @

[jira] [Resolved] (FLINK-10071) Document usage of INSERT INTO in SQL Client

2018-08-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-10071. --- Resolution: Fixed Fix Version/s: (was: 1.6.1) (was: 1.7.0)

[jira] [Reopened] (FLINK-10071) Document usage of INSERT INTO in SQL Client

2018-08-07 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reopened FLINK-10071: --- > Document usage of INSERT INTO in SQL Client > --- > >

  1   2   3   4   >