[GitHub] [flink] HuangXingBo commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-20 Thread GitBox
HuangXingBo commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#discussion_r285859989 ## File path: flink-dist/src/main/flink-bin/bin/flink ## @@ -51,5

[GitHub] [flink] HuangXingBo commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-20 Thread GitBox
HuangXingBo commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#discussion_r285860034 ## File path: flink-python/pyflink/java_gateway.py ## @@ -44,6

[GitHub] [flink] HuangXingBo commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend

2019-05-20 Thread GitBox
HuangXingBo commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend URL: https://github.com/apache/flink/pull/8472#discussion_r285859669 ## File path:

[GitHub] [flink] shuai-xu commented on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots

2019-05-20 Thread GitBox
shuai-xu commented on issue #7227: [FLINK-11059] [runtime] do not add releasing failed slot to free slots URL: https://github.com/apache/flink/pull/7227#issuecomment-494247522 @GJL I think this bug still exists now, could you help to review it?

[GitHub] [flink] zzchun edited a comment on issue #8372: [FLINK-12354] [table] Add REVERSE function for table/sql API

2019-05-20 Thread GitBox
zzchun edited a comment on issue #8372: [FLINK-12354] [table] Add REVERSE function for table/sql API URL: https://github.com/apache/flink/pull/8372#issuecomment-492262212 @sunjincheng121 @fhueske @dawidwys @zentol , can you help me to review this MR, thank you.

[GitHub] [flink] beyond1920 commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support translation from StreamExecGroupWindowAggregate to StreamTransformation.

2019-05-20 Thread GitBox
beyond1920 commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support translation from StreamExecGroupWindowAggregate to StreamTransformation. URL: https://github.com/apache/flink/pull/8462#discussion_r285840399 ## File path:

[jira] [Created] (FLINK-12564) Remove getBufferProvider method from ResultPartitionWriter interface

2019-05-20 Thread zhijiang (JIRA)
zhijiang created FLINK-12564: Summary: Remove getBufferProvider method from ResultPartitionWriter interface Key: FLINK-12564 URL: https://issues.apache.org/jira/browse/FLINK-12564 Project: Flink

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-20 Thread GitBox
eaglewatcherwb commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r285842097 ## File path:

[GitHub] [flink] eaglewatcherwb commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-20 Thread GitBox
eaglewatcherwb commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r285841871 ## File path:

[GitHub] [flink] beyond1920 commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support translation from StreamExecGroupWindowAggregate to StreamTransformation.

2019-05-20 Thread GitBox
beyond1920 commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support translation from StreamExecGroupWindowAggregate to StreamTransformation. URL: https://github.com/apache/flink/pull/8462#discussion_r285840399 ## File path:

[GitHub] [flink] flinkbot commented on issue #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-20 Thread GitBox
flinkbot commented on issue #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492#issuecomment-494227524 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] JingsongLi opened a new pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink

2019-05-20 Thread GitBox
JingsongLi opened a new pull request #8492: [FLINK-12563][table-runtime-blink] Introduce vector data format in blink URL: https://github.com/apache/flink/pull/8492 ## What is the purpose of the change Introduce vector data format to high performance parquet/orc source. ##

[jira] [Updated] (FLINK-12563) Introduce vector data format in blink

2019-05-20 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-12563: - Description: Introduce vector data format to high performance parquet/orc source. Introduce 

[jira] [Updated] (FLINK-12563) Introduce vector data format in blink

2019-05-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12563: --- Labels: pull-request-available (was: ) > Introduce vector data format in blink >

[jira] [Created] (FLINK-12563) Introduce vector data format in blink

2019-05-20 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12563: Summary: Introduce vector data format in blink Key: FLINK-12563 URL: https://issues.apache.org/jira/browse/FLINK-12563 Project: Flink Issue Type:

[GitHub] [flink] yanghua commented on a change in pull request #8459: [FLINK-12476] [State TTL] Consider setting a default background cleanup strategy in StateTtlConfig

2019-05-20 Thread GitBox
yanghua commented on a change in pull request #8459: [FLINK-12476] [State TTL] Consider setting a default background cleanup strategy in StateTtlConfig URL: https://github.com/apache/flink/pull/8459#discussion_r285837389 ## File path:

[jira] [Commented] (FLINK-12494) JDBCOutputFormat support reconnect when link failure and flush by timeInterval

2019-05-20 Thread zhaoshijie (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844463#comment-16844463 ] zhaoshijie commented on FLINK-12494: someone haved submited a pr to support JDBCAppendTableSink

[GitHub] [flink] yanghua commented on a change in pull request #8459: [FLINK-12476] [State TTL] Consider setting a default background cleanup strategy in StateTtlConfig

2019-05-20 Thread GitBox
yanghua commented on a change in pull request #8459: [FLINK-12476] [State TTL] Consider setting a default background cleanup strategy in StateTtlConfig URL: https://github.com/apache/flink/pull/8459#discussion_r285837346 ## File path:

[GitHub] [flink] flinkbot commented on issue #8491: [FLINK-12494][JDBC] JDBCAppendTableSink add timeInterval to flush data

2019-05-20 Thread GitBox
flinkbot commented on issue #8491: [FLINK-12494][JDBC] JDBCAppendTableSink add timeInterval to flush data URL: https://github.com/apache/flink/pull/8491#issuecomment-494221527 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] smdfj opened a new pull request #8491: [FLINK-12494][JDBC] JDBCAppendTableSink add timeInterval to flush data

2019-05-20 Thread GitBox
smdfj opened a new pull request #8491: [FLINK-12494][JDBC] JDBCAppendTableSink add timeInterval to flush data URL: https://github.com/apache/flink/pull/8491 ## What is the purpose of the change JDBCAppendTableSink flush to database when data size is reach batchInterval, this pr

[GitHub] [flink] smdfj closed pull request #8490: [FLINK-12494][JDBC] JDBCAppendTableSink add timeInterval to flush data

2019-05-20 Thread GitBox
smdfj closed pull request #8490: [FLINK-12494][JDBC] JDBCAppendTableSink add timeInterval to flush data URL: https://github.com/apache/flink/pull/8490 This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (FLINK-12494) JDBCOutputFormat support reconnect when link failure and flush by timeInterval

2019-05-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12494: --- Labels: pull-request-available (was: ) > JDBCOutputFormat support reconnect when link

[GitHub] [flink] flinkbot commented on issue #8490: [FLINK-12494][JDBC] JDBCAppendTableSink add timeInterval to flush data

2019-05-20 Thread GitBox
flinkbot commented on issue #8490: [FLINK-12494][JDBC] JDBCAppendTableSink add timeInterval to flush data URL: https://github.com/apache/flink/pull/8490#issuecomment-494219842 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] smdfj opened a new pull request #8490: [FLINK-12494][JDBC] JDBCAppendTableSink add timeInterval to flush data

2019-05-20 Thread GitBox
smdfj opened a new pull request #8490: [FLINK-12494][JDBC] JDBCAppendTableSink add timeInterval to flush data URL: https://github.com/apache/flink/pull/8490 ## What is the purpose of the change JDBCAppendTableSink flush to database when data size is reach batchInterval, this pr

[GitHub] [flink] wuchong commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support translation from StreamExecGroupWindowAggregate to StreamTransformation.

2019-05-20 Thread GitBox
wuchong commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support translation from StreamExecGroupWindowAggregate to StreamTransformation. URL: https://github.com/apache/flink/pull/8462#discussion_r285832833 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support translation from StreamExecGroupWindowAggregate to StreamTransformation.

2019-05-20 Thread GitBox
wuchong commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support translation from StreamExecGroupWindowAggregate to StreamTransformation. URL: https://github.com/apache/flink/pull/8462#discussion_r285833527 ## File path:

[jira] [Commented] (FLINK-11560) Translate "Flink Applications" page into Chinese

2019-05-20 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844455#comment-16844455 ] Jark Wu commented on FLINK-11560: - Thanks a lot for push the progress of Flink website translation

[jira] [Comment Edited] (FLINK-11560) Translate "Flink Applications" page into Chinese

2019-05-20 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844455#comment-16844455 ] Jark Wu edited comment on FLINK-11560 at 5/21/19 2:38 AM: -- Thanks a lot for

[GitHub] [flink] asfgit closed pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
asfgit closed pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480 This is an automated message from the Apache Git Service. To respond to

[jira] [Closed] (FLINK-12552) Combine HiveCatalog and GenericHiveMetastoreCatalog

2019-05-20 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12552. Resolution: Fixed merged in 1.9.0: 3fba21a0ce5534b8c95a2bb9e8547b0061e5bb8f > Combine HiveCatalog and

[jira] [Closed] (FLINK-12560) Documentation language build flags

2019-05-20 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-12560. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in 1.9.0: 5c5342e0499e08ebe4fa5b3b57818939ed75b84b >

[GitHub] [flink] asfgit closed pull request #8489: [FLINK-12560][Docs] Documentation language build flags

2019-05-20 Thread GitBox
asfgit closed pull request #8489: [FLINK-12560][Docs] Documentation language build flags URL: https://github.com/apache/flink/pull/8489 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] wuchong commented on issue #8489: [FLINK-12560][Docs] Documentation language build flags

2019-05-20 Thread GitBox
wuchong commented on issue #8489: [FLINK-12560][Docs] Documentation language build flags URL: https://github.com/apache/flink/pull/8489#issuecomment-494214180 Thanks @sjwiesman , looks good to me and I get the same build time in my local machine. Will merge this.

[GitHub] [flink] asfgit closed pull request #8483: [FLINK-12553][Table SQL / Runtime]Fix a bug in SqlDateTimeUtils#parseToTimeMillis

2019-05-20 Thread GitBox
asfgit closed pull request #8483: [FLINK-12553][Table SQL / Runtime]Fix a bug in SqlDateTimeUtils#parseToTimeMillis URL: https://github.com/apache/flink/pull/8483 This is an automated message from the Apache Git Service. To

[GitHub] [flink] Aitozi commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop

2019-05-20 Thread GitBox
Aitozi commented on a change in pull request #8431: [FLINK-12480] Introduce mailbox to StreamTask main-loop URL: https://github.com/apache/flink/pull/8431#discussion_r285828978 ## File path:

[jira] [Closed] (FLINK-12553) Fix a bug in SqlDateTimeUtils#parseToTimeMillis

2019-05-20 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-12553. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in 1.9.0: a86bce5a176144e06d0120b804f3af986c325ebf >

[GitHub] [flink] wuchong commented on issue #8483: [FLINK-12553][Table SQL / Runtime]Fix a bug in SqlDateTimeUtils#parseToTimeMillis

2019-05-20 Thread GitBox
wuchong commented on issue #8483: [FLINK-12553][Table SQL / Runtime]Fix a bug in SqlDateTimeUtils#parseToTimeMillis URL: https://github.com/apache/flink/pull/8483#issuecomment-494212344 LGTM +1 This is an automated message

[jira] [Updated] (FLINK-12558) Yarn application can't stop when flink job finished in normal mode

2019-05-20 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated FLINK-12558: --- Summary: Yarn application can't stop when flink job finished in normal mode (was: Yarn application

[jira] [Comment Edited] (FLINK-12558) Yarn application can't stop when flink job finished

2019-05-20 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844434#comment-16844434 ] lamber-ken edited comment on FLINK-12558 at 5/21/19 1:37 AM: - [~frank wang],

[jira] [Commented] (FLINK-12558) Yarn application can't stop when flink job finished

2019-05-20 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844434#comment-16844434 ] lamber-ken commented on FLINK-12558: [~frank wang], I think the +FlinkJobNotFoundException+ is not

[jira] [Created] (FLINK-12562) Improve code in ExpandColumnFunctionsRule

2019-05-20 Thread Hequn Cheng (JIRA)
Hequn Cheng created FLINK-12562: --- Summary: Improve code in ExpandColumnFunctionsRule Key: FLINK-12562 URL: https://issues.apache.org/jira/browse/FLINK-12562 Project: Flink Issue Type:

[jira] [Commented] (FLINK-7990) Strange behavior when configuring Logback for logging

2019-05-20 Thread Akshay Iyangar (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844422#comment-16844422 ] Akshay Iyangar commented on FLINK-7990: --- [~till.rohrmann] [~fhueske] - We are facing this issue as

[GitHub] [flink] bowenli86 edited a comment on issue #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
bowenli86 edited a comment on issue #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#issuecomment-494188903 > Those abstract classes are part of this PR, and they weren't planned as a separate PR. Thus, I don't see

[GitHub] [flink] bowenli86 commented on issue #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
bowenli86 commented on issue #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#issuecomment-494188903 > Those abstract classes are part of this PR, and they weren't planned as a separate PR. Thus, I don't see a good

[GitHub] [flink] bowenli86 commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
bowenli86 commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#discussion_r285804464 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
bowenli86 commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#discussion_r285804230 ## File path:

[GitHub] [flink] xuefuz commented on issue #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
xuefuz commented on issue #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#issuecomment-494158261 Thanks for the review. Those abstract classes are part of this PR, and they weren't planned as a separate PR. Thus,

[GitHub] [flink] xuefuz commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
xuefuz commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#discussion_r285775675 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
xuefuz commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#discussion_r285774199 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
xuefuz commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#discussion_r285773385 ## File path:

[GitHub] [flink] bowenli86 edited a comment on issue #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog

2019-05-20 Thread GitBox
bowenli86 edited a comment on issue #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#issuecomment-494058032 I'd like to get https://github.com/apache/flink/pull/8480 in first and rebase this PR since 8480 is a

[GitHub] [flink] bowenli86 edited a comment on issue #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog

2019-05-20 Thread GitBox
bowenli86 edited a comment on issue #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#issuecomment-494058032 I'd rather get https://github.com/apache/flink/pull/8480 in first and rebase this PR since 8480 is a

[GitHub] [flink] sjwiesman commented on issue #8489: [FLINK-12560][Docs] Documentation language build flags

2019-05-20 Thread GitBox
sjwiesman commented on issue #8489: [FLINK-12560][Docs] Documentation language build flags URL: https://github.com/apache/flink/pull/8489#issuecomment-494101299 @wuchong good call This is an automated message from the Apache

[GitHub] [flink] blublinsky commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-20 Thread GitBox
blublinsky commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r285698529 ## File path:

[GitHub] [flink] blublinsky commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-20 Thread GitBox
blublinsky commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r28569 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs

2019-05-20 Thread GitBox
xuefuz commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#discussion_r285694599 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#discussion_r285675210 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#discussion_r285670976 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#discussion_r285676953 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#discussion_r285675985 ## File path:

[GitHub] [flink] c4emmmm commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-20 Thread GitBox
c4e commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r285683552 ## File path: flink-ml/flink-ml-api/src/main/java/org/apache/flink/ml/api/core/PipelineStage.java

[GitHub] [flink] bowenli86 commented on issue #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog

2019-05-20 Thread GitBox
bowenli86 commented on issue #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#issuecomment-494058032 @xuefuz I'd rather get https://github.com/apache/flink/pull/8480 in first and rebase this PR since 8480 is a

[jira] [Commented] (FLINK-9172) Support external catalogs in SQL-Client

2019-05-20 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844088#comment-16844088 ] Bowen Li commented on FLINK-9172: - Hi [~eronwright] , are you still interested in this JIRA? If not, we

[GitHub] [flink] bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat…

2019-05-20 Thread GitBox
bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat… URL: https://github.com/apache/flink/pull/8480#discussion_r285403774 ## File path:

[jira] [Commented] (FLINK-12558) Yarn application can't stop when flink job finished

2019-05-20 Thread frank wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844070#comment-16844070 ] frank wang commented on FLINK-12558: from your pic,the job was finised, and log is followd  Caused

[jira] [Assigned] (FLINK-12558) Yarn application can't stop when flink job finished

2019-05-20 Thread frank wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] frank wang reassigned FLINK-12558: -- Assignee: frank wang > Yarn application can't stop when flink job finished >

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285663137 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285662172 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285638898 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285640957 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285644704 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285644373 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285644496 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285660972 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285639189 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285640257 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8463: [FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment URL: https://github.com/apache/flink/pull/8463#discussion_r285658953 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8442: [FLINK-12483] Support (legacy) SourceFunction as special case in the mailbox model for stream tasks

2019-05-20 Thread GitBox
pnowojski commented on a change in pull request #8442: [FLINK-12483] Support (legacy) SourceFunction as special case in the mailbox model for stream tasks URL: https://github.com/apache/flink/pull/8442#discussion_r285654111 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8442: [FLINK-12483] Support (legacy) SourceFunction as special case in the mailbox model for stream tasks

2019-05-20 Thread GitBox
pnowojski commented on a change in pull request #8442: [FLINK-12483] Support (legacy) SourceFunction as special case in the mailbox model for stream tasks URL: https://github.com/apache/flink/pull/8442#discussion_r285650684 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8442: [FLINK-12483] Support (legacy) SourceFunction as special case in the mailbox model for stream tasks

2019-05-20 Thread GitBox
pnowojski commented on a change in pull request #8442: [FLINK-12483] Support (legacy) SourceFunction as special case in the mailbox model for stream tasks URL: https://github.com/apache/flink/pull/8442#discussion_r285654636 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8442: [FLINK-12483] Support (legacy) SourceFunction as special case in the mailbox model for stream tasks

2019-05-20 Thread GitBox
pnowojski commented on a change in pull request #8442: [FLINK-12483] Support (legacy) SourceFunction as special case in the mailbox model for stream tasks URL: https://github.com/apache/flink/pull/8442#discussion_r285651280 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8418: [FLINK-12491][docs][configuration] Fix incorrect javadoc for path sep…

2019-05-20 Thread GitBox
dawidwys commented on a change in pull request #8418: [FLINK-12491][docs][configuration] Fix incorrect javadoc for path sep… URL: https://github.com/apache/flink/pull/8418#discussion_r285643403 ## File path: flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java

[jira] [Comment Edited] (FLINK-12557) Unify create table DDL with clause and connector descriptor keys

2019-05-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844040#comment-16844040 ] Timo Walther edited comment on FLINK-12557 at 5/20/19 3:20 PM: --- Maybe I am

[jira] [Comment Edited] (FLINK-12557) Unify create table DDL with clause and connector descriptor keys

2019-05-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844040#comment-16844040 ] Timo Walther edited comment on FLINK-12557 at 5/20/19 3:19 PM: --- Maybe I am

[jira] [Commented] (FLINK-12557) Unify create table DDL with clause and connector descriptor keys

2019-05-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844040#comment-16844040 ] Timo Walther commented on FLINK-12557: -- Maybe I am biased here, but I still find the old design

[jira] [Assigned] (FLINK-11391) Introduce ShuffleMaster in Job Master

2019-05-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-11391: - Assignee: Andrey Zagrebin (was: zhijiang) > Introduce ShuffleMaster in Job Master >

[GitHub] [flink] wuchong commented on issue #8489: [FLINK-12560][Docs] Documentation language build flags

2019-05-20 Thread GitBox
wuchong commented on issue #8489: [FLINK-12560][Docs] Documentation language build flags URL: https://github.com/apache/flink/pull/8489#issuecomment-494024218 Thanks @sjwiesman , it's a great idea. Could you also add some instruction to `docs/README.md` ?

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285609687 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285602353 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ProducerShuffleDescriptor.java

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285612766 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/DefaultShuffleMaster.java

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285603074 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285606641 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/PartitionInfo.java

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285627259 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285608414 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/PartitionInfo.java

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285604686 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java ##

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285631470 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ProducerShuffleDescriptor.java

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285598677 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285609603 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285628036 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

2019-05-20 Thread GitBox
tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r285609507 ## File path:

  1   2   3   4   >