[GitHub] [flink] JingsongLi commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
JingsongLi commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292285209 ## File path:

[GitHub] [flink] godfreyhe commented on a change in pull request #8677: [FLINK-12795] [table-planner-blink] Extracted creation & configuration of FrameworkConfig & RelBuilder to separate class in blin

2019-06-10 Thread GitBox
godfreyhe commented on a change in pull request #8677: [FLINK-12795] [table-planner-blink] Extracted creation & configuration of FrameworkConfig & RelBuilder to separate class in blink planner URL: https://github.com/apache/flink/pull/8677#discussion_r292284191 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292283695 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292283695 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292283695 ## File path:

[jira] [Updated] (FLINK-12797) Remove duplicate tests in GroupWindowTableAggregateValidationTest

2019-06-10 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-12797: Environment: (was: Some tests in \{{GroupWindowTableAggregateValidationTest}} are duplicate

[jira] [Updated] (FLINK-12797) Remove duplicate tests in GroupWindowTableAggregateValidationTest

2019-06-10 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-12797: Description: Some tests in {{GroupWindowTableAggregateValidationTest}} are duplicate with tests

[jira] [Created] (FLINK-12797) Remove duplicate tests in GroupWindowTableAggregateValidationTest

2019-06-10 Thread Hequn Cheng (JIRA)
Hequn Cheng created FLINK-12797: --- Summary: Remove duplicate tests in GroupWindowTableAggregateValidationTest Key: FLINK-12797 URL: https://issues.apache.org/jira/browse/FLINK-12797 Project: Flink

[jira] [Commented] (FLINK-12662) show jobs failover in history server as well

2019-06-10 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860537#comment-16860537 ] vinoyang commented on FLINK-12662: -- Hi [~till.rohrmann] After getting your idea, I'd like to propose my

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292272829 ## File path:

[jira] [Commented] (FLINK-11947) Support MapState value schema evolution for RocksDB

2019-06-10 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860524#comment-16860524 ] Congxian Qiu(klion26) commented on FLINK-11947: --- [~cre...@gmail.com] thanks for the

[GitHub] [flink] KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292272092 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292272092 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-10 Thread GitBox
zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r292271629 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-10 Thread GitBox
zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r292271205 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy

2019-06-10 Thread GitBox
zhuzhurk commented on a change in pull request #8573: [FLINK-12670][runtime] Implement FailureRateRestartBackoffTimeStrategy URL: https://github.com/apache/flink/pull/8573#discussion_r292271395 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292271428 ## File path:

[GitHub] [flink] wuchong commented on issue #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on issue #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#issuecomment-500679727 @JingsongLi thanks for the reviewing. I have addressed the comments.

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292271043 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292271043 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292270945 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292270760 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8629: [FLINK-12088][table-runtime-blink] Introduce unbounded streaming inner/left/right/full join operator URL: https://github.com/apache/flink/pull/8629#discussion_r292270764 ## File path:

[jira] [Updated] (FLINK-12788) Add support to run a Python job-specific cluster on Kubernetes

2019-06-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-12788: Labels: pull-request-available (was: ) > Add support to run a Python job-specific cluster on Kubernetes

[GitHub] [flink] sunjincheng121 commented on issue #8664: [FLINK-12779][table] Avoid field conflicts when generate field names for non-composite Typeinformation

2019-06-10 Thread GitBox
sunjincheng121 commented on issue #8664: [FLINK-12779][table] Avoid field conflicts when generate field names for non-composite Typeinformation URL: https://github.com/apache/flink/pull/8664#issuecomment-500674980 @flinkbot approve description

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292266500 ## File path:

[GitHub] [flink] sunjincheng121 commented on issue #8653: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers are recycled when FlinkKafk…

2019-06-10 Thread GitBox
sunjincheng121 commented on issue #8653: [FLINK-10455][Connectors/Kafka] Ensure all the KafkaProducers are recycled when FlinkKafk… URL: https://github.com/apache/flink/pull/8653#issuecomment-500673647 @flinkbot attention @pnowojski

[GitHub] [flink] dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script

2019-06-10 Thread GitBox
dianfu commented on issue #8609: [FLINK-12541][container][python] Add support for Python jobs in build script URL: https://github.com/apache/flink/pull/8609#issuecomment-500671784 @tillrohrmann @sunjincheng121 I have updated the PR and the changes are only related to the build script for

[GitHub] [flink] wuchong commented on issue #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on issue #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#issuecomment-500671448 Comments addressed and conflicts solved.

[GitHub] [flink] c4emmmm commented on issue #8632: [FLINK-12744][ml] add shared params in ml package

2019-06-10 Thread GitBox
c4e commented on issue #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#issuecomment-500671277 @bowenli86 @walterddr @Xpray @wuchong @zentol @shaoxuan-wang @ex00 @sunjincheng121 @bluelinsky I appreciate for your advices while

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292264208 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
wuchong commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292263983 ## File path:

[GitHub] [flink] dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API

2019-06-10 Thread GitBox
dianfu commented on issue #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API URL: https://github.com/apache/flink/pull/8532#issuecomment-500670192 @sunjincheng121 Have updated the PR according to your comments. Looking forwarding to your feedback.

[GitHub] [flink] asfgit closed pull request #8671: [FLINK-12787][python] Allow to specify directory in option -pyfs

2019-06-10 Thread GitBox
asfgit closed pull request #8671: [FLINK-12787][python] Allow to specify directory in option -pyfs URL: https://github.com/apache/flink/pull/8671 This is an automated message from the Apache Git Service. To respond to the

[jira] [Closed] (FLINK-12787) Allow to specify directory in option -pyfs

2019-06-10 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12787. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master: 

[GitHub] [flink] flinkbot commented on issue #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-10 Thread GitBox
flinkbot commented on issue #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682#issuecomment-500669024 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292262188 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292262305 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292262315 ## File path:

[jira] [Updated] (FLINK-12796) Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12796: --- Labels: pull-request-available (was: ) > Introduce BaseArray and BaseMap to reduce

[GitHub] [flink] JingsongLi opened a new pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-10 Thread GitBox
JingsongLi opened a new pull request #8682: [FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce conversion overhead to blink URL: https://github.com/apache/flink/pull/8682 ## What is the purpose of the change Currently, in internal data format of flink, the

[jira] [Closed] (FLINK-12640) mvn install flink-shaded-hadoop2-uber: Error creating shaded jar: null

2019-06-10 Thread xiezhiqiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiezhiqiang closed FLINK-12640. --- Resolution: Abandoned Release Note: env issue > mvn install flink-shaded-hadoop2-uber:

[jira] [Commented] (FLINK-12640) mvn install flink-shaded-hadoop2-uber: Error creating shaded jar: null

2019-06-10 Thread xiezhiqiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860495#comment-16860495 ] xiezhiqiang commented on FLINK-12640: - now build is ok ,i'll closed it > mvn install

[GitHub] [flink] sunjincheng121 commented on issue #8671: [FLINK-12787][python] Allow to specify directory in option -pyfs

2019-06-10 Thread GitBox
sunjincheng121 commented on issue #8671: [FLINK-12787][python] Allow to specify directory in option -pyfs URL: https://github.com/apache/flink/pull/8671#issuecomment-500667684 @flinkbot approve all Merging... This is an

[GitHub] [flink] c4emmmm commented on issue #8526: [FLINK-12597][ml] Remove the legacy flink-libraries/flink-ml

2019-06-10 Thread GitBox
c4e commented on issue #8526: [FLINK-12597][ml] Remove the legacy flink-libraries/flink-ml URL: https://github.com/apache/flink/pull/8526#issuecomment-500667561 > We have to update the documentation somehow. Either remove it entirely, blank it if you want to re-use the pages later on,

[jira] [Created] (FLINK-12796) Introduce BaseArray and BaseMap to reduce conversion overhead to blink

2019-06-10 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12796: Summary: Introduce BaseArray and BaseMap to reduce conversion overhead to blink Key: FLINK-12796 URL: https://issues.apache.org/jira/browse/FLINK-12796 Project:

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292256584 ## File path:

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292257458 ## File path:

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292257986 ## File path:

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292255956 ## File path:

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292255627 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292257584 ## File path:

[GitHub] [flink] danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
danny0405 commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292256767 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-10 Thread GitBox
zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#discussion_r292259702 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-10 Thread GitBox
zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#discussion_r292258862 ## File path:

[jira] [Comment Edited] (FLINK-12785) RocksDB savepoint recovery can use a lot of unmanaged memory

2019-06-10 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860481#comment-16860481 ] Congxian Qiu(klion26) edited comment on FLINK-12785 at 6/11/19 2:34 AM:

[jira] [Commented] (FLINK-12785) RocksDB savepoint recovery can use a lot of unmanaged memory

2019-06-10 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860481#comment-16860481 ] Congxian Qiu(klion26) commented on FLINK-12785: --- I think your analysis is correct, we

[GitHub] [flink] zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-10 Thread GitBox
zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#discussion_r292257121 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292252350 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292251830 ## File path:

[GitHub] [flink] flinkbot commented on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-10 Thread GitBox
flinkbot commented on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681#issuecomment-500653848 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Updated] (FLINK-12585) Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12585: --- Labels: pull-request-available (was: ) > Align Stream/BatchTableEnvironment with JAVA

[GitHub] [flink] WeiZhong94 opened a new pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

2019-06-10 Thread GitBox
WeiZhong94 opened a new pull request #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API URL: https://github.com/apache/flink/pull/8681 ## What is the purpose of the change This pull request add `StreamExecutionEnvironment` and `ExecutionEnvironment`

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292245668 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292248207 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292247958 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292248666 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292249000 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292245572 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292249140 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292248144 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect

2019-06-10 Thread GitBox
KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292247887 ## File path:

[GitHub] [flink] KurtYoung closed pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

2019-06-10 Thread GitBox
KurtYoung closed pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink URL: https://github.com/apache/flink/pull/8435 This is an automated message from the Apache Git Service.

[jira] [Closed] (FLINK-12443) Replace InternalType with LogicalType in blink runner

2019-06-10 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12443. -- Resolution: Implemented Fix Version/s: 1.9.0 merged in 1.9.0:

[GitHub] [flink] stevenzwu edited a comment on issue #8665: [FLINK-12781] [Runtime/REST] include the whole stack trace in response payload

2019-06-10 Thread GitBox
stevenzwu edited a comment on issue #8665: [FLINK-12781] [Runtime/REST] include the whole stack trace in response payload URL: https://github.com/apache/flink/pull/8665#issuecomment-500628639 test failed due to this change. increased max content length in test code ```Response

[GitHub] [flink] mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-10 Thread GitBox
mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#discussion_r292227151 ## File path:

[GitHub] [flink] mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-10 Thread GitBox
mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#discussion_r292227151 ## File path:

[GitHub] [flink] stevenzwu commented on issue #8665: [FLINK-12781] [Runtime/REST] include the whole stack trace in response payload

2019-06-10 Thread GitBox
stevenzwu commented on issue #8665: [FLINK-12781] [Runtime/REST] include the whole stack trace in response payload URL: https://github.com/apache/flink/pull/8665#issuecomment-500628639 test failed due to this change ```Response entity too large: DefaultHttpResponse(decodeResult:

[GitHub] [flink] mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-10 Thread GitBox
mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#discussion_r292227151 ## File path:

[GitHub] [flink] mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics …

2019-06-10 Thread GitBox
mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics] Support retention policy for InfluxDB metrics … URL: https://github.com/apache/flink/pull/8668#discussion_r292225473 ## File path: docs/monitoring/metrics.md ## @@ -658,6 +658,7 @@ Parameters:

[jira] [Commented] (FLINK-12122) Spread out tasks evenly across all available registered TaskManagers

2019-06-10 Thread Antonio Verardi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860329#comment-16860329 ] Antonio Verardi commented on FLINK-12122: - [~till.rohrmann]: Thanks for picking this feature up!

[jira] [Updated] (FLINK-12706) Introduce ShuffleService interface and its configuration

2019-06-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12706: --- Labels: pull-request-available (was: ) > Introduce ShuffleService interface and its

[GitHub] [flink] azagrebin commented on issue #8680: [FLINK-12706] Introduce ShuffleService interface and its configuration

2019-06-10 Thread GitBox
azagrebin commented on issue #8680: [FLINK-12706] Introduce ShuffleService interface and its configuration URL: https://github.com/apache/flink/pull/8680#issuecomment-500571729 The PR is based on #8608 at the moment, only last two commits are to review.

[GitHub] [flink] azagrebin opened a new pull request #8680: [FLINK-12706] Introduce ShuffleService interface and its configuration

2019-06-10 Thread GitBox
azagrebin opened a new pull request #8680: [FLINK-12706] Introduce ShuffleService interface and its configuration URL: https://github.com/apache/flink/pull/8680 ## What is the purpose of the change Introduce `ShuffleService` interface with two factory methods for `ShuffleMaster`

[GitHub] [flink] azagrebin commented on issue #8680: [FLINK-12706] Introduce ShuffleService interface and its configuration

2019-06-10 Thread GitBox
azagrebin commented on issue #8680: [FLINK-12706] Introduce ShuffleService interface and its configuration URL: https://github.com/apache/flink/pull/8680#issuecomment-500572793 @flinkbot attention @tillrohrmann @zhijiangW

[GitHub] [flink] flinkbot commented on issue #8680: [FLINK-12706] Introduce ShuffleService interface and its configuration

2019-06-10 Thread GitBox
flinkbot commented on issue #8680: [FLINK-12706] Introduce ShuffleService interface and its configuration URL: https://github.com/apache/flink/pull/8680#issuecomment-500572309 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] azagrebin commented on issue #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

2019-06-10 Thread GitBox
azagrebin commented on issue #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#issuecomment-500535543 Thanks @zhijiangW , I have addressed comments

[GitHub] [flink] knaufk commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-10 Thread GitBox
knaufk commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r292131264 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,166 @@ +--- +title: Glossary

[GitHub] [flink] knaufk commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-06-10 Thread GitBox
knaufk commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r292130218 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,166 @@ +--- +title: Glossary

[jira] [Commented] (FLINK-12423) Add Timer metric type for flink-metrics module

2019-06-10 Thread Piyush Goyal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860215#comment-16860215 ] Piyush Goyal commented on FLINK-12423: -- At Netflix, we use

[jira] [Commented] (FLINK-12680) Add timer type to metric system

2019-06-10 Thread Piyush Goyal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860210#comment-16860210 ] Piyush Goyal commented on FLINK-12680: -- [~till.rohrmann] A good way to look at it is micrometer 

[jira] [Assigned] (FLINK-12398) Support partitioned view in catalog API

2019-06-10 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-12398: Assignee: (was: Bowen Li) > Support partitioned view in catalog API >

[jira] [Closed] (FLINK-12702) support 'properties' in catalog entries in SQL CLI yaml file

2019-06-10 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12702. Resolution: Invalid plan changed. we requires a hive site url right now > support 'properties' in

[GitHub] [flink] asfgit closed pull request #8657: [FLINK-12772][hive] Support mapping ARRAY, MAP, ROW (STRUCT) between Flink and Hive in HiveCatalog

2019-06-10 Thread GitBox
asfgit closed pull request #8657: [FLINK-12772][hive] Support mapping ARRAY, MAP, ROW (STRUCT) between Flink and Hive in HiveCatalog URL: https://github.com/apache/flink/pull/8657 This is an automated message from the

[jira] [Closed] (FLINK-12772) Support mapping ARRAY, MAP, ROW (STRUCT) between Flink and Hive in HiveCatalog

2019-06-10 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12772. Resolution: Fixed merged in 1.9.0: 918dafb4dfa847a42b26115e42fd2bcc005fa47d > Support mapping ARRAY,

[jira] [Closed] (FLINK-12780) use Flink's LogicalTypeRoot for type comparison in HiveTypeUtil

2019-06-10 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12780. Resolution: Fixed merged in 1.9.0: 777b99c59aebbbaeb55fba50e29d24b12634c542 > use Flink's

[GitHub] [flink] bowenli86 commented on issue #8657: [FLINK-12772][hive] Support mapping ARRAY, MAP, ROW (STRUCT) between Flink and Hive in HiveCatalog

2019-06-10 Thread GitBox
bowenli86 commented on issue #8657: [FLINK-12772][hive] Support mapping ARRAY, MAP, ROW (STRUCT) between Flink and Hive in HiveCatalog URL: https://github.com/apache/flink/pull/8657#issuecomment-500508769 Thanks @xuefuz for your review. Merging

[GitHub] [flink] bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-10 Thread GitBox
bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#discussion_r292112089 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-10 Thread GitBox
bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#discussion_r290503595 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

2019-06-10 Thread GitBox
bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table URL: https://github.com/apache/flink/pull/8614#discussion_r29210 ## File path:

  1   2   3   >